From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93159C77B76 for ; Fri, 14 Apr 2023 14:26:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BC276B007B; Fri, 14 Apr 2023 10:26:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16C68900004; Fri, 14 Apr 2023 10:26:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F27CC900003; Fri, 14 Apr 2023 10:26:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E17846B007B for ; Fri, 14 Apr 2023 10:26:05 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C6FE91601F3 for ; Fri, 14 Apr 2023 14:26:05 +0000 (UTC) X-FDA: 80680221090.30.86163D7 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf27.hostedemail.com (Postfix) with ESMTP id EB43040025 for ; Fri, 14 Apr 2023 14:26:03 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WVSBGvQE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681482364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JhJhY1i1X+rQfu4Bn4P5O3hneE5Ahqf44H1V3MlMZSE=; b=Ij1B2UTriYhgjTfn6RxXn/yxEntICSVz6mOeeTwgdJGP24Hgp5HxgXkne7HBsS1c+ZYsHW EVwpiW0Q6YpZ89p4Nv7mFYdo9m0C4rBDbUgH1mT9Q54XLtbWCO8NTX0EeOYp3QfJnSVqr0 OV/GFxHe4MkmecVcwGUuEdtd8ckEd5w= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WVSBGvQE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681482364; a=rsa-sha256; cv=none; b=UgfKpg9cRTiuq+nnqt+btmamR2uoDw3PLm8BqkGTUKN1dDzir0rMTRUh/oaL1HMI7ClERU 7QkqTDUvkGAUnLQ0/loeYAyRkxw8zYtIFKg3M2STpuIJvXLGU8fMtf1Z7QgSMQ9+td808c BXQjmi6QmCtLxq586hMhasMfkw/goLg= Received: by mail-pj1-f41.google.com with SMTP id hg14-20020a17090b300e00b002471efa7a8fso5117875pjb.0 for ; Fri, 14 Apr 2023 07:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681482363; x=1684074363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JhJhY1i1X+rQfu4Bn4P5O3hneE5Ahqf44H1V3MlMZSE=; b=WVSBGvQEWeeZCzJHUSLw6TdU7X7htMEhqLVUOYjuOm5exiNC5ijdRkufnNFt84Bcvp nBa+HXyOE083VwztPKaRnxXoBufXzhDqGmx5EU3nQdOfFARZyba4elQgihG66ZdIP+us AWQNBgqB3ZgRwKcjr/anLW7Yt0XHKvMOhoHHSJ+HOxL3sObVLefIP9AIAVNCeVEtEv1h XIqwvMreBHtnZXG4BLKofcPieosXJ8aJJOZrrwvezai6c/gmMsNouFT0iBOD95fZd4ZF KiC837Ko9b7VgCfyYEEiAshz0fl07KLeKm1Og9HKhxYYplg/Ram9QSDXV5nmw7PrXhcj UxEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681482363; x=1684074363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JhJhY1i1X+rQfu4Bn4P5O3hneE5Ahqf44H1V3MlMZSE=; b=E7b6nSuLXFHB7Z9CjJvzSUqa9N/wc+ySxvj5QSFUMMJw683oAwvVjHHGse5Xeba95u oTpolVt96M00z7qm9Kwm/cChXw1Df6n2b2Bkj8cEj5uR9R1tyt8FuJ8/ugpMKRGbXpsv in4LjeIAdw2YUSSvkU6ivUSGNk+uEB6sqcK5yo3/p/LZ4kDHgseg6adh61ZYzjX/bJQI ddskThYAXApRs5iOUNuyU9dWP+z21ZKtwQXhnzRx07HGzFWwQP+5pg1ElmBI8ALuFmYE IVc2EGBIkdAnljg7JOUPMAKIbkUzLi1O5aAm9pklt1QllqOuLZue+Raqix3r020KZ7Uz Jnbg== X-Gm-Message-State: AAQBX9fLW5qpFVHmT3ozQuEcNLrD+6q0oXUnrKvIOKDl9pMNwEXWYixm KezztW885EXE4TgVSxEv/lw= X-Google-Smtp-Source: AKy350Y3WXBAfHkfEIZhG0ei3Tp0PNc3fK1Ni3ksxBjZThrmtWAJdx1hd2dMChF2jmP20depYO7fIQ== X-Received: by 2002:a17:90a:5b12:b0:244:9385:807f with SMTP id o18-20020a17090a5b1200b002449385807fmr5616908pji.44.1681482362745; Fri, 14 Apr 2023 07:26:02 -0700 (PDT) Received: from strix-laptop.. (2001-b011-20e0-1499-8303-7502-d3d7-e13b.dynamic-ip6.hinet.net. [2001:b011:20e0:1499:8303:7502:d3d7:e13b]) by smtp.googlemail.com with ESMTPSA id h7-20020a17090ac38700b0022335f1dae2sm2952386pjt.22.2023.04.14.07.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 07:26:02 -0700 (PDT) From: Chih-En Lin To: Andrew Morton , Qi Zheng , David Hildenbrand , "Matthew Wilcox (Oracle)" , Christophe Leroy , John Hubbard , Nadav Amit , Barry Song , Pasha Tatashin Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Yu Zhao , Steven Barrett , Juergen Gross , Peter Xu , Kefeng Wang , Tong Tiangen , Christoph Hellwig , "Liam R. Howlett" , Yang Shi , Vlastimil Babka , Alex Sierra , Vincent Whitchurch , Anshuman Khandual , Li kunyu , Liu Shixin , Hugh Dickins , Minchan Kim , Joey Gouly , Chih-En Lin , Michal Hocko , Suren Baghdasaryan , "Zach O'Keefe" , Gautam Menghani , Catalin Marinas , Mark Brown , "Eric W. Biederman" , Andrei Vagin , Shakeel Butt , Daniel Bristot de Oliveira , "Jason A. Donenfeld" , Greg Kroah-Hartman , Alexey Gladkov , x86@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Dinglan Peng , Pedro Fonseca , Jim Huang , Huichun Feng Subject: [PATCH v5 11/17] mm/mprotect: Break COW PTE before changing protection Date: Fri, 14 Apr 2023 22:23:35 +0800 Message-Id: <20230414142341.354556-12-shiyn.lin@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230414142341.354556-1-shiyn.lin@gmail.com> References: <20230414142341.354556-1-shiyn.lin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EB43040025 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: bdrod7rtdzxbx13ceq1egptyzetkbpen X-HE-Tag: 1681482363-802524 X-HE-Meta: U2FsdGVkX1/ayV+MGTNiLPOOJ/e0Qa+tsXNOBxUA4iCw4bEabCjG8xnarfN3rsDkh0T6f/hQSUQjxm+tSLn3/4ocJCwXKSSDj3h9oeyYRnu3s7xs1xP1pT8n+thfN6HojTcvJVEsgTWQypW2lM+1LP581I1ks1n3Q+bs7QvJJh+1QMlNe4B71luUlXiIp1JT0e5VaMocY0IC8uMdSVYc1rUm2gDPubvL3cZ3ovjgK/LqGGe7Eq9w7/VmDkkCAxNTmRPTigm22CvsxW3ypKs8XA8AFRyiA2OIGLtmgfgoTLDbOlfcyD5P9kUARUkdGcjruzgZvLcpZ020EIocQ5k5kqY53JT73rMOabzXhRqpWfo8gJT/NGhEK056MZxL6XtVQOwy81hos9Ar1ZNC8KYg2dA+eLgXnhoED17oLoyEbTJYYuT8e9FZT1SPNbMhKtRIe5FtjvMkZFOVNWV1HLVjh4uU0d0IVsxD7DGVHi++cbrhCMOSloN6Y2y0qIz9CozEGBs6s9JKhwQaNSSd0yvwwYlSjvVWirMSWildf+XD+3D7O7Re3Z0+ezDv4NpbGxeQYXRzwhflIA7+gdVx77jSIWZ7ikQP0XMRVDMpL45DgQ6O3yPyeLh/UlYUuZSmyeWWnjSyxDQypFnrSrzszW9uv6xoV/WcTa+P6GtW/xE9s5DrV2oIZdtdYJ/pwVIphGLKyleRkyrb0gzOtvw659XkzAlSzU/OsDDZa2jCD1gOkBaMGXSaAaqdHNYTenlkGJvWQVBvtose9pIDX6+S3vFI9UAW+3eRc7pG9AD0GEcc7vTkkkTRSE2JMNkftPDBsqFfxAmjwQU7TMQpX1/HRvtf+sGBJwYsl/fpy4JLiZkxsmbrxz7M2uMjQgwLzfMBgCKqPRjZF7JntqaAkdblw9OS0jIEW+XMz/+2jqGbhTZUADK6/Jjnajy04J19fBAFhNaU6sfghZHPAJGx30dShAD 9fxNw/TL trOAbyWeOGgo6YbHqm0+SsqknwhbuxxHZ6jl+s0eKsSr8K4s8pPJL8+5SU+qm1ENlqxbqs8QNJmMftHdumRAd+mvlaSqg+4Um+XkZh3Y1YoTVhI4Dcx03mAwk/fd6L3OQHBOWOxFWwHXJgHLNPolUQeU/FfCEVFZy4A+EfG6kkEtTjImFo7gsFecWJR0Gpe+0vo8x0Nh04LERxTCxfWeBKDjJQ2nzMx0VwShBulSbOwxtUBTKxsNydPcoSyNrZfbaBO/ligSEqaRWq/4soB4fHehgc1OXtYqXuYaD40lwbfsDm6bvsAsal+xDAuGs3IiVYrKmLafc3eAeMlVjE1jgJWgLZSat6QxGYvPC0fVapJVOq+0aUizMS6BcqB/Z2S7Gw4cWQ1djc/wuPl9+U9K4ZT0TiHLU4IaZoVsJYBJfnOdLU5qN4eZh9UyU3liTdiz9wOP+XxIVJ0i/z6+AVR5JtVE/FQh/UPf8mqUoKD3DfwtSGbG0kElNLyV4y1LnemrmS4g0mOgUrzg2gNiq9AofZkp1LKmobDDtk0/isL5KXm8mg50aBZhNYOS3UtKTU7aNUord X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If the PTE table is COW-ed, break it before changing the protection. Signed-off-by: Chih-En Lin --- mm/mprotect.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mm/mprotect.c b/mm/mprotect.c index 13e84d8c0797..a33f23a73fa5 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -103,6 +103,9 @@ static long change_pte_range(struct mmu_gather *tlb, if (pmd_trans_unstable(pmd)) return 0; + if (break_cow_pte(vma, pmd, addr)) + return 0; + /* * The pmd points to a regular pte so the pmd can't change * from under us even if the mmap_lock is only hold for @@ -312,6 +315,12 @@ static inline int pmd_none_or_clear_bad_unless_trans_huge(pmd_t *pmd) return 1; if (pmd_trans_huge(pmdval)) return 0; + /* + * If the entry point to COW-ed PTE, it's write protection bit + * will cause pmd_bad(). + */ + if (!pmd_write(pmdval)) + return 0; if (unlikely(pmd_bad(pmdval))) { pmd_clear_bad(pmd); return 1; -- 2.34.1