From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CC00C77B6E for ; Fri, 14 Apr 2023 14:10:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF786900002; Fri, 14 Apr 2023 10:09:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D80706B0072; Fri, 14 Apr 2023 10:09:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2226900002; Fri, 14 Apr 2023 10:09:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AF2F46B0071 for ; Fri, 14 Apr 2023 10:09:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7917E1A0331 for ; Fri, 14 Apr 2023 14:09:59 +0000 (UTC) X-FDA: 80680180518.13.4230F50 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by imf20.hostedemail.com (Postfix) with ESMTP id F32401C000D for ; Fri, 14 Apr 2023 14:09:56 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="Y UAAluv"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=DSrmlXaT; spf=pass (imf20.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.20 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681481397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XlB3b6fWJFASh9iAOYEpjaIhm6+Wlrx2+6BlnOSLYDQ=; b=5v4SwpFCrkuhLv9C63mMHSzO0ZJ8A29h2tDk579ilUaRPXCUR7wj3AuUfiSL2lycfFhN8z OvK5cAgBjokZWwm5oGB1cFwuzRJYAeB753W7r8jIw7RyDdavzo4Y+xI+LAv9P9AIh4XHka KK+MVTLdwM8X++Vd3LWGLevZmlHAAik= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="Y UAAluv"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=DSrmlXaT; spf=pass (imf20.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.20 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681481397; a=rsa-sha256; cv=none; b=Rd43Rgd8sQuUacKWYqhkNfJpdFv51PAvNkUh1BKbpJjiYoaSY1hr0IytAlASz2EjTZtruq s7vKQGMp9US3PfcP6PVmAHJV99NU7fQu8EKifY45CIhBahEERnErK6p4G+tjkOTVWj0kgv Zeok5aw3vP6kWIyaPlBM6U+JYF8ZVL8= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 026793200A38; Fri, 14 Apr 2023 10:09:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 14 Apr 2023 10:09:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1681481394; x= 1681567794; bh=XlB3b6fWJFASh9iAOYEpjaIhm6+Wlrx2+6BlnOSLYDQ=; b=Y UAAluvoYEsZpIlKpDeHbDkyLGoCYuIySEApQLueJsSYCS/0Kss1VZ+xvFnuan/Tw 3RJVdZMvsVBRJF5NtAkhRgp7EbfCXOFI/NPnDBtjv3oO+JlClkCXmafZtS79Ug+K 9DWN70m9l+q14h5zPrXVOS4t7A6Dc36AK8Y20dCFIAlBIG00ETrs/C9I6cmhMfDd oY9LvSS3P6Eo1ZjBjDp775+iExPp7gfAY4Wkz94AzJfVqwbhacp0pY+zbuGkoVuq W0WjLQU+HgUKddKSn4U9BeVkZXMV2WY9l9cDMZe31mD/gqKiAWzlC3M1ko/kNAXE ftvwI/w0xXYZYDaPu6TpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681481394; x=1681567794; bh=XlB3b6fWJFASh 9iAOYEpjaIhm6+Wlrx2+6BlnOSLYDQ=; b=DSrmlXaTF5d8TO8qllvF2BCWDRSpP 6zi7Fjs0bEMHVISK7wM9MFSp6xT6dtC27Iuhq2FWNk3p9/duFqz5n6rx8S/DEGU0 IfGrP24qoxPP0vetZkiORdMYueLdsfTlpq5Jgj3bDVSFGg6Ctaddt8qq7MjwRNTw ZAAmNM/NI6RyEer0YrAa2JBu5L/bBYDYjtgx4aWK6khlba91SIcVuIaMqEw0ioVs cHGiuPViH0EDLv+pqiuHQQsJs6SQjRjyO2+3aUnnECnqtJYSkfdX8WTaNc5xSGmp ZqB1Ww/ei4j1bCM6jzGjO+ExC+CIMVvrZnC2akX937NA5cA3Q1ri+DMYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeltddgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdttddttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpefhieeghfdtfeehtdeftdehgfehuddtvdeuheet tddtheejueekjeegueeivdektdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Apr 2023 10:09:53 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id EA80210D7B4; Fri, 14 Apr 2023 17:09:48 +0300 (+03) Date: Fri, 14 Apr 2023 17:09:48 +0300 From: "Kirill A. Shutemov" To: Ryan Roberts Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , Yu Zhao , "Yin, Fengwei" , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC v2 PATCH 05/17] mm: Routines to determine max anon folio allocation order Message-ID: <20230414140948.7pcaz6niyr2tpa7s@box.shutemov.name> References: <20230414130303.2345383-1-ryan.roberts@arm.com> <20230414130303.2345383-6-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414130303.2345383-6-ryan.roberts@arm.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 5o5qekts4xzaruzpsgqxb18jf7zkcpwy X-Rspamd-Queue-Id: F32401C000D X-HE-Tag: 1681481396-333416 X-HE-Meta: U2FsdGVkX18mw/lR1lDjUmCRDjHoeiD/UPt5VCxLt5H3KwPkvWUwTQmx2YGExbVZQJUEP5irM1b/JkQkB6WoKwjFCHlJAuddb+1+ROuuZ1J00XKQb3XbB+T9484Ux0MfhDQWMYtBlbMg/7rzYBh4/KLxCWb38qlOa7Ull/yryiKpkWuXZkaonrbecYHXSR4MEXycEH8VNRvaEx+moxX3oRs/ueFWog90o7/mlGNEn0zCZpy46uIsVYHMCJs73pTdmCRavKiN1PIXHOY3tWDC34sxlBpdE/GrjFHGdf8gaayDVjqwlbljMh+e9Ppj0ci4kQ5OrT5nNHsA5jOo2UnE1oOTF8wMZtiT57rTGIOxal5w3lmYOtjNZet6hAKGHgC5UY5tXdHVZXBa73XiDHQieVgQ/dAXz6369M3Q/IUZFWPKacI3v2IGvfRQSPJ7DcEjAmYZaGXIvIQCVf0hzeDk2zrl7h+P4qZ6TA7BMXpdjxfTFcfJ+WkNsWjL7F3w6IWcmI32zo+lTjF9rSIALbJz+/Srj6ZdXYFVp026LSg6poYF1v/S7QIAgq27J4z3W5m3YkBOi8SmrpKQUnmwZX7vvMPU2Gh8coXcBS1wOb/XV7eoWh+naT25yjRcwgzv8rF/kuKjR0WWP84Ndp8/COXlyRhIeMVcItq7y1PZhOq6wqbLCh185tIyFX4oroNcVelAtYuAVmPkndZ7I7lU2s617odCiSJXSghf75pXqH+UKxtqdi1kErMdztveWDBVGlBm6MOeSPctwGVn+I0zvzZRlqmlPQdCQv2GBHsKuwLQlOW7vMrYl5j8e5iXilcC8/YesFF8C7zb25cabWrGHFw5Z7OCHS4PHxpvn4Bw0cqRvHsTbRoDpwuPVE2DOOvzz/sDMJL1G+vfzoeEM4Dig/v3VzxrLwnW5ne7LPZ4u1HxFBP2J9U69w1XHe+H9B/0bY9Kibq3OHlOwoQ/nEFRqJD KFRRc7nh JCf64rNUAIMjGqXMrd41uuFBEqMs29xMQeWc9Ke4lJvbCKBeUQdDq9vq/EQHnEDwO6IFu1cE4KFxPti1x7dkbDvzPEp3W2a91yF//6RVj2TP11FsWQClFk5ECe1Ols0tOIciuFeBHknVeA/RR8WDnCXQ5W7ekzqjl8ucHBc2KG/7gc/W82RQLYd2su9sSYbxmat1ftQTxTfgxrMcAgHCS8a6N4Da14T7sCIj59viOPLLp0V3jmyVPEbjoIz4QdNAZBW4EO+9ct7ZY/RAHHnWEB+cvDjtFsFZMyzFHCxUhWyNAoF365X50SfTetihqIs1Bg52/Bh9X5waZLjRqImAlbonRy8ssYpaTLSQCSj39Pbmm+5SXWoO2Eedbjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 14, 2023 at 02:02:51PM +0100, Ryan Roberts wrote: > For variable-order anonymous folios, we want to tune the order that we > prefer to allocate based on the vma. Add the routines to manage that > heuristic. > > TODO: Currently we always use the global maximum. Add per-vma logic! > > Signed-off-by: Ryan Roberts > --- > include/linux/mm.h | 5 +++++ > mm/memory.c | 8 ++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index cdb8c6031d0f..cc8d0b239116 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3674,4 +3674,9 @@ madvise_set_anon_name(struct mm_struct *mm, unsigned long start, > } > #endif > > +/* > + * TODO: Should this be set per-architecture? > + */ > +#define ANON_FOLIO_ORDER_MAX 4 > + I think it has to be derived from size in bytes, not directly specifies page order. For 4K pages, order 4 is 64k and for 64k pages it is 1M. -- Kiryl Shutsemau / Kirill A. Shutemov