From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA90C77B6E for ; Fri, 14 Apr 2023 01:35:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A0D8900004; Thu, 13 Apr 2023 21:35:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 150C7900002; Thu, 13 Apr 2023 21:35:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03F55900004; Thu, 13 Apr 2023 21:35:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E91A9900002 for ; Thu, 13 Apr 2023 21:35:14 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B3D621602EC for ; Fri, 14 Apr 2023 01:35:14 +0000 (UTC) X-FDA: 80678278548.05.3F25A83 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf12.hostedemail.com (Postfix) with ESMTP id C61284000C for ; Fri, 14 Apr 2023 01:35:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=biVpw3y6; spf=pass (imf12.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.214.196 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681436112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=plCLedIYAsqNnF0GFCSLgqWvPF9OpWHyrxzXNdvY8IQ=; b=ihpTINEUaOUOO/RRFjVavgOR6SyEpcuvnDBZtryduPmkc5wIhISYfhZ+cuRgoaHuLByGCN C8rX6F6Dah+63v60Lg6gQuTVirI/fSi1TmxgiSPM971yEM5ujEypRO7pJ3srWdTGhxQbX9 hcKLQx3ghwLufGwlm5QILmqa2sNynG8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=biVpw3y6; spf=pass (imf12.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.214.196 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681436112; a=rsa-sha256; cv=none; b=0PVdnTb2GXjX1upef3JGpNe523Q7WOqGT24lIy2vf66f9ZZWgDhfzfVQ2Cu+qepalLUgzV EgFQoiO+tusTzYPQAgsfxk26ZLxlO6gscrz48zW0hs/A/TiHVgHTN+mLo9GIASoEm20Xb+ qaD8QDSH/0J41hyG9FVsbp33g4dSWLo= Received: by mail-pl1-f196.google.com with SMTP id i8so7966213plt.10 for ; Thu, 13 Apr 2023 18:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681436112; x=1684028112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=plCLedIYAsqNnF0GFCSLgqWvPF9OpWHyrxzXNdvY8IQ=; b=biVpw3y6TVDKHZQR+2MDdpqk9NQdEoamzjv8Haj+VIuc51lvg5QNl5Ftd1SXcmkLpH rgpR9HbbQPk7w1SAh/047X0BA+wv+SdAyMHMMuo1gaQwVgjnYol/jBFDBDQ6r96INd8R z477L1cYgfNsm6VMCZUzJq6LlBDS0F/C+AC6E+ldHTPyqvZZQZJXbK0JEBmRKWHTyuu3 78S/JNpommNl33fEwf9f0VajqOQxOvFX/PTSG41B20MVIQ3wkHb60If7l4tYcm0EaSIj JqRkMHFOtRHTYGnxY19ZXK/OMI2ZWQrv9N9jL58e039fgOIpTHMj8JNEtAMt+9vFlpMo OCTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681436112; x=1684028112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=plCLedIYAsqNnF0GFCSLgqWvPF9OpWHyrxzXNdvY8IQ=; b=VFG9Hys8zU5A8JztX3gZ4QTLa+kaZ5OJSs94JkOapvQO6IcbVdVxvA0B49BgmXSXgd bWQdqDBroCZAPAnfJAjEbn+9WGdJ3X3IR40Zt4SBSCZqemuzfNiLaBU3ieUJH75MiFC8 CzOTS02Zt70C2h5KH0F00XvCesq5QOwimnH5qh/uPcv0vRwyQ8I7n1VF7K7KgN5P4eRY 6aeTyqcVNXJIIoRRSbY4AqvVmLHVX3m/xl55iocNgA6cBXWPKxfCt4A54LfdDTNP5iP7 CwppLSbp6qWWrOD8FrMe6sXD1Ss1l/0VtYKjq9UQVduBZ1kkYdusGTPQKyYARTifxXbV np6w== X-Gm-Message-State: AAQBX9cAisVPy+5ufKFkqERbIG/JPcKiPG+CWgxYqtGLUAbaxNAtH3BU HLvsjRQDbzEPS6YVHXKLWKI= X-Google-Smtp-Source: AKy350Y8w1QKb4DEb6j4qg8xa1LERVJD9HGnXcsED39DUxLPYMu5P/HZqKO5I9yl0YqYaGJjcxw0Rg== X-Received: by 2002:a17:90b:180e:b0:247:4186:69b4 with SMTP id lw14-20020a17090b180e00b00247418669b4mr110482pjb.21.1681436111651; Thu, 13 Apr 2023 18:35:11 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id c9-20020a17090aa60900b00246f9725ffcsm1902634pjq.33.2023.04.13.18.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 18:35:11 -0700 (PDT) From: xu xin X-Google-Original-From: xu xin To: akpm@linux-foundation.org Cc: david@redhat.com, imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn, yang.yang29@zte.com.cn Subject: Re: [PATCH v6 0/6] ksm: support tracking KSM-placed zero-pages Date: Fri, 14 Apr 2023 09:35:07 +0800 Message-Id: <20230414013507.184195-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230328153852.26c2577e4bd921c371c47a7e@linux-foundation.org> References: <20230328153852.26c2577e4bd921c371c47a7e@linux-foundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C61284000C X-Stat-Signature: 3d84cjqukr3s5jx6kjd6g6pi7hbos548 X-HE-Tag: 1681436112-207713 X-HE-Meta: U2FsdGVkX1+EAvqExkMOOThVM5hsLvS/GoRiSyRFbGjfBeiSATEdwoTLgJZ7GxJZhYStiYtyFrT5MsG9T0DuuNCOitnBcUBj/H4rU18MzRefnqshGQg8GHwPtXuyCYOuY1oTcy6ZS5EP8WwCfIJddqWKXBB7n4hjohnjl7TOmEYwRg+YL94PDvCILPVcAjqHiItXQrP2PFOVFjLz32CRKoTjG9EfRvMwT9axqIl4/cdz4FWrpCbSsxnK7wXko7dziCF0zzAkQieO47ptSRWIKn0Hs40+EJE8Hv3OvsshQktLsE/GfWv02AgFSgjqvDAaNShytrBAyNoO+ihPfULjHQhr8Q5BA/UBnLPLKS/DCTqTnAizFaYKbpdKXVFlIk7ju22bu9whgOunOAInq2QpbZOpYQw4bBx4i+wRjZ2143IxYa7OJ6Su3dZxv8Ycr+Yd3MQ33Ty8pQ8YYTzATFUF+0SIkPySFrmsuO77vjvWsoqmRrK1TXMAgbILjly8Vgh+k7luzen1EcyLb2mbA5HcrlAUVsLNTiPgyLP8zmNBjOSKe3kHBQ4N8ksCpjI1olTLjRzpAE6OuVKh9+fOrqq0MWqSQb7oyd/WT3svwzkleCEepY+Z3kLU++qrQ61PEYpndDIiF9Kq91pyhRm9m8xlDMr5jkix1OjwNkgrRsOgwJdogi52HifRXCBtvv0GN/vN8SMJvlHDHTwx7vNrYsmoloXKDytSxI026GTS6+c0C87AucAVUjyc3DH94WYWOpebi1eIa3DOrciYUMFtQHSKzQdzy8tfjqwKktEHFNSbVXHJJzYC6ubn6cQLhgpYhLSQLx2S59Qar5S2ZGa0LHre3t+EVFnl24EE41t59wRanww80XaGuwClQqwH2fjKsjY90S2XXqpMMNXUjsZwb5GYjwRubwtVKWFuHipqhjHzPBsxkOIUCoYLbuS0nCENLJovlZTvQOulnm7hParroTv taeUyLRm dnCQL+LwZHoY5jUrZcU04jKF6UixniLZpa0ONkHgbhdCEN0QtXjsKKLq/UZ0QcvjZ/PZaxIAWt6i243f0cjhoS49LjqN+KDDJZ1HIpYtYtDQDWpQhExN3CorX/WArRHSixYhpqC/zHSq/QmjNzPvNLEs2Kk/OujFFKnsevThYVYGIi/KiNTtYI8xF9DxQV3Yzbk6XbGwbB2nRYkX2BixJFlw7Q9OoVHE2k3GnGEGArHfIIzmTbRFKbuN1++fFdUJUq9hqruxMT8gt5n0Y3MOxjapQ9Vp9D0rBk6IBvn8FNq/z7TjI5c2Cu1VTmIaFIO+oILMsBNPn+GBqTuOadscl25ihv698Zqajjc1cGN30KSqALY/67KKnwC7utGLFtSRj4KDW0f9Da4H6c1SI2JsOKl2WMwhCRtrvylTmdNbS5Z3kgzg2iNTGpCBuhhctKWFdQ/WgbxvSzH+ItyWFong0FADt14J544V4+mrPmsfHrr6J6WeAkDVOJIDSmePVkRTC2mtgA4ham7QwiLGWtKowMngrWsrIAjDaMh6AM0Vo/48ZSQ+7OctmJ1p9t1Ua8u4PD7+LPjPsjjm4Dvg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> The core idea of this patch set is to enable users to perceive the number of any >> pages merged by KSM, regardless of whether use_zero_page switch has been turned >> on, so that users can know how much free memory increase is really due to their> >> madvise(MERGEABLE) actions. But the problem is, when enabling use_zero_pages, >> all empty pages will be merged with kernel zero pages instead of with each >> other as use_zero_pages is disabled, and then these zero-pages are no longer >> monitored by KSM. > We have sent the v7 series, so some old codes might be changed, and no need to talk more. >We appear to have some outstanding activity on this quite old patchset. >>From my notes: > >- An unresponded-to question from Claudia: > https://lkml.kernel.org/r/20230307192421.30ab869c@p-imbrenda > Claudia is right, but the v7 patches don't rely on rmap_items now, so we can skip this comment. >- Hoping for overall review from David > David's review is great, and we accept his advice on the basic approach in v7 patches to track the ksm zero pages. and now the v7 patches use pte_dirty to mark the KSM-placed zere pages. But since pte_dirty is related to architectures, and some architecture may treat pte_dirty as writable, so we restrict the feature of tracking ksm zero pages only to the tested and well-working architecture. >- Another query from Claudia, and a response indicating that a v7 is > in the works. > https://lore.kernel.org/all/20230307194320.79373a26@p-imbrenda/T/#u The v7 series don't changed it there now, then we can skip it. > >- Another unresponded-to review query: > https://lkml.kernel.org/r/20230307195119.745d0b46@p-imbrenda > The v7 series have referred to Claudia's review but made a few modifications. >- Another response indicating that a v7 is coming > https://lkml.kernel.org/r/20230307195313.2e21245a@p-imbrenda > > So I think I'll drop the v6 series. Please address all these things in > the next version and let's start over. Yes, the next version is here: https://lore.kernel.org/lkml/202304131346489021903@zte.com.cn/