linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, songmuchun@bytedance.com,
	mike.kravetz@oracle.com, willy@infradead.org,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [RFC PATCH 0/4] change ->index to PAGE_SIZE for hugetlb pages
Date: Thu, 13 Apr 2023 16:14:48 -0700	[thread overview]
Message-ID: <20230413231452.84529-1-sidhartha.kumar@oracle.com> (raw)

This RFC patch series attempts to simplify the page cache code by removing
special casing code for hugetlb pages. Normal pages in the page cache are
indexed by PAGE_SIZE while hugetlb pages are indexed by their huge page
size. This was previously tried but the xarray was not performant enough
for the changes.

This series fails many of the hugetlb LTP test cases due to bugs in
accounting and I was hoping to get help/suggestions about why the page
accounting breaks from my changes. The basic mmap tests pass but the
advanced ones which involve overcommiting pages fail.

rebased on mm-unstable 4/13/2023

Sidhartha Kumar (4):
  mm/filemap: remove hugetlb special casing in filemap.c
  mm/hugetlb: remove hugetlb_basepage_index()
  mm/hugetlbfs: remove huge_page_shift in hugetlbfs_file_mmap
  mm/hugetlb: add hpage_shift to alloc_hugetlb_folio

 fs/hugetlbfs/inode.c    |  4 +--
 include/linux/pagemap.h | 13 --------
 mm/filemap.c            | 36 +++++++---------------
 mm/hugetlb.c            | 68 ++++++++++++-----------------------------
 4 files changed, 33 insertions(+), 88 deletions(-)

-- 
2.39.2



             reply	other threads:[~2023-04-13 23:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13 23:14 Sidhartha Kumar [this message]
2023-04-13 23:14 ` [RFC PATCH 1/4] mm/filemap: remove hugetlb special casing in filemap.c Sidhartha Kumar
2023-04-13 23:14 ` [RFC PATCH 2/4] mm/hugetlb: remove hugetlb_basepage_index() Sidhartha Kumar
2023-04-13 23:14 ` [RFC PATCH 3/4] mm/hugetlbfs: remove huge_page_shift in hugetlbfs_file_mmap Sidhartha Kumar
2023-04-13 23:14 ` [RFC PATCH 4/4] mm/hugetlb: add hpage_shift to alloc_hugetlb_folio Sidhartha Kumar
2023-04-25  1:27 ` [RFC PATCH 0/4] change ->index to PAGE_SIZE for hugetlb pages Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230413231452.84529-1-sidhartha.kumar@oracle.com \
    --to=sidhartha.kumar@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=songmuchun@bytedance.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox