From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08349C77B6E for ; Thu, 13 Apr 2023 21:01:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C865900002; Thu, 13 Apr 2023 17:01:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 650D66B0074; Thu, 13 Apr 2023 17:01:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CA11900002; Thu, 13 Apr 2023 17:01:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 33FDD6B0072 for ; Thu, 13 Apr 2023 17:01:00 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 08347AB7B4 for ; Thu, 13 Apr 2023 21:01:00 +0000 (UTC) X-FDA: 80677587480.14.12BD3CF Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf16.hostedemail.com (Postfix) with ESMTP id B25C0180030 for ; Thu, 13 Apr 2023 21:00:56 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=5SO+s+Wz; spf=pass (imf16.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681419656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Po7kMV6PWfvJ0JdTbzWxvRcPOaOmD0dTKySmuNSlDE8=; b=w24zYBy78cUBjk3l5t9+KrSyFC1FCn63iIklpxiT+o4fc8RpLQTS6lw4wWlsXnXnvmFK2T aQH+/RlF+tiWP8HkUIw5e7VGGzaHdVqtg7cpGfFG7sZ2nXuxW5jUzsvVA7tNigNIKrjDfr VbSeVa2RELcEczZ5N2sQRzOqXOshtuo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=5SO+s+Wz; spf=pass (imf16.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681419656; a=rsa-sha256; cv=none; b=e65ApBfo28+zAnV8Pbc3njusYlnVvsYpomrEiJAuEq0z7MO/GouH5BfkrA97bReRQm+JwL hRPK/u0CI826/TdmwB5pzqnyhWbCDkipS4MIEC2OT3WzL0we4JUhwoAWEd8inWfxUTuHAc MT8rB0WD5ZxkV54Fsi243niHqSvFLKk= Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-517c840f181so263841a12.3 for ; Thu, 13 Apr 2023 14:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1681419655; x=1684011655; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Po7kMV6PWfvJ0JdTbzWxvRcPOaOmD0dTKySmuNSlDE8=; b=5SO+s+WzALNpDN1F2r4RktSFMbeXUOZ5ZZ4imLVAQoXA9/lC9hm3pg4FQZHjcgDFRr 1W6P7WWYojNsiIJnPi5nuXNn2irghWpItwRXONlnThqo2JXE5P7eGdXskbXOeHw4pfWs e4/5GvOocPYZ3hDXjojyciRevZvF858Azln1xhdoJbybRGFGIr/n4fs/v2L8hdzg9s+o 8ZlfxWTij0X1M7Oqj0eJgBUQGLAU22t8D3AGl9hVEvZT5GMRqEz+FbjOT15elBmGEZRc Ug46SqyE6nfY3hF8oRes80r0DASMIbliHC9taLr+InAecO1VhkSBXbyNobEJYqH1kvC8 qBig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681419655; x=1684011655; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Po7kMV6PWfvJ0JdTbzWxvRcPOaOmD0dTKySmuNSlDE8=; b=P5G5Dfyox5RwKgQpw5OOemgiKF+wAWEBFjM4vAFKi+0w9WzLzpddTmiNDEv3gNT5Ec 8FlvFJJZXVqiQg3HYMwp6gOCkNqfwJTb8ucCJ6cF7zIgMyZ9v/+b+KPcuV0QAGexNJFO G7Vsk5qfmfdc/bSDvCEQcc45nNfX0DOxXtAekOTfHotVYiE7xKtrN5as9ibpY9QbA0iH 1KwNT86j1fRjpkVV59HxVK65Nbvh8Ar2/3Gvjrpdwg1d4LkRC5rdvVk7Z7SYcu0lkrwq NlsUX6SMX6w+cxdVtalh2bSQSkhxDQZimWfWeTcDPY3dwlFK9nRmMG+jOKbwxt+ZYZYQ cZNg== X-Gm-Message-State: AAQBX9c2Pkt23/oTXFZsrThhy/wtVagZ9KX3YdfVowcVYhf8BwSAMdKM zOrqjWikjXynkMcZfybAjqCHew== X-Google-Smtp-Source: AKy350ZeUgwDYY5eMW7ZOlxK2igrJRw/XaGk5mqSdFs2oVNX3KK71uxfEiOe9qiJLyAHAqLgA8MlqA== X-Received: by 2002:a05:6a00:2e9c:b0:636:d5be:982f with SMTP id fd28-20020a056a002e9c00b00636d5be982fmr6073105pfb.6.1681419655345; Thu, 13 Apr 2023 14:00:55 -0700 (PDT) Received: from dread.disaster.area (pa49-180-41-174.pa.nsw.optusnet.com.au. [49.180.41.174]) by smtp.gmail.com with ESMTPSA id w5-20020aa78585000000b0063824fef27asm1871769pfn.13.2023.04.13.14.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 14:00:54 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pn43n-00322H-2A; Fri, 14 Apr 2023 07:00:51 +1000 Date: Fri, 14 Apr 2023 07:00:51 +1000 From: Dave Chinner To: Yosry Ahmed Cc: David Hildenbrand , Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Tim Chen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state Message-ID: <20230413210051.GO3223426@dread.disaster.area> References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B25C0180030 X-Rspam-User: X-Stat-Signature: yasfxfs4g48c5kgne55ibxymkaeod5on X-HE-Tag: 1681419656-468164 X-HE-Meta: U2FsdGVkX1/iljJm39yvEjgrLiSdxDx9gvjxnQHp83cRpY4aQOkpS4mNOgJKQUl0TorvErY7efbC45ntVSH1y/P2dVpDW2Qm0RSwJVdi66yS7KZRAB2vAA+De1CDyvtR1y8mke+lKfoqdb5BujkVEBzxI3aNfc89YYfRTct4E1mTQ1Mf80No3T7IqEEBfuwqFmNz6mcem/wZAwEcvbHFFdTvZHC7p6B0YV9rXuMLAGrWdM3uWmlEqgznoR4Yh+OVzGa/2A0gjOSvYbfiEL6PPvvETV1hyQdVxD+O6YKTAdtuErLvI1NyRJ4HN9TjH5i801iLQHBQd1Oiav3FVOGwBBm//CjOD+FukYNVemlEvFvBd1RZJcr7MicCQdLOtX5fitLfJyRozQXTFfK5c4UTwaTzSxob62DOgAZOzYo2lMQqXPuWS9SZMIu06vDyGgBtiq15Q8WgrbLvCKDQdj2l4ZWpGdEt3w6JXM+rL5E37yKDS4H2tpbkFXiaHW1qfdq1rXBA0OFX5ns20cEfXHLhwRcD+9hJ2PLlrAsqqxlHE2dWUl0lprlQtOH6ZtwH1rPvjXJXv0sc8tAcvk3NB0BjjAd6tOUh3xuK7fLby5U180z4PEb0tWcnQS0YzECgP9v3ClMcfLYrrVEev7lNLkmMtKvSGOvk4MmXbZpH4eET/6+ke43PeYB8PmfgTYfrnMYDS+ObocGI7whChn/Rw1GpjZL1R0VacFx33SGlDVp38luLmUNI0hLehleQ7jC/D2TYBIXCeXRe1XRqleSDDCnjE8nPNT4D4ek+OaXnR4BZdJ1UJn+amHnHMjCeMuHctHtZ+AKg/oFS5Ef/MYVxC9bhy+7gWgu81RThjCF2jdu3BIDAYkfV4YcsSNdZDaEySmw029PecjKP1FrFhsmEfw4MF+cLZMXCwxDSgvkxhp3ir6z5D9HyfYW6Z2XBYiDmgpq/+LBMH7wl3tbqeyUTj6a j1ap5Nvl zcu9tQW7wKj8NkQo5BUKkMAAejECYEaer9K8KUPDdchgacl9pJd+JYzQQVMk0rCuboGxXr9i+15xCQheBZPTpgSL2NUstE58iLQdIOlloKuG6ZqTzbw9KBAue3CEOJ6KPkSRBOpxTVYYoqSuSne6kwXwkkrZsF254mIM+s4vWfjQDxFn76J3VUY4qVlNe5LKyVRtwK8Vk8Mt0NNqtaaHl3mHAnjjksW/b/tQ5rj2B/AZICLFH+xXanHmOEV1w4rIfhC9EP6bUb7xHMLclCbPDoNE+BTnOJlnVvgBWGrYo3ksAMMe4+SSJMYl1BXyFQVhe7hQ17+RAbLrRlJvXgIJRE1PilDnt9Q3SkZ8LrBau7TYKyN1KuIhV7blqs36N5AqxHmGAt+iQAQIPr40UoKP+U1QHyACLfRaK0AAdyWokF+RItwD4A2+lZk4d8lzp1syxtiXwdc/gHJ6KSTIiS6LHWkp8SWPTD+Q+NuE68Bk03Mr8NXoHWEEpilxcbv8ApmDceQrVQrqtXELsBYkOWqG4nLZenM65EKlfoLYqLG2ULqNRs3Ora2rZni2gbE3Ej9xEOxBXTb92hiEarUgKOe8ZTKBMSIAm2Ec4tf0P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 13, 2023 at 04:29:43AM -0700, Yosry Ahmed wrote: > On Thu, Apr 13, 2023 at 4:21 AM David Hildenbrand wrote: > > > > On 13.04.23 12:40, Yosry Ahmed wrote: > > > During reclaim, we keep track of pages reclaimed from other means than > > > LRU-based reclaim through scan_control->reclaim_state->reclaimed_slab, > > > which we stash a pointer to in current task_struct. > > > > > > However, we keep track of more than just reclaimed slab pages through > > > this. We also use it for clean file pages dropped through pruned inodes, > > > and xfs buffer pages freed. Rename reclaimed_slab to reclaimed, and add > > > > Would "reclaimed_non_lru" be more expressive? Then, > > > > mm_account_reclaimed_pages() -> mm_account_non_lru_reclaimed_pages() > > > > > > Apart from that LGTM. > > Thanks! > > I suck at naming things. If you think "reclaimed_non_lru" is better, > then we can do that. FWIW mm_account_reclaimed_pages() was taken from > a suggestion from Dave Chinner. My initial version had a terrible > name: report_freed_pages(), so I am happy with whatever you see fit. > > Should I re-spin for this or can we change it in place? I don't care for the noise all the bikeshed painting has generated for a simple change like this. If it's a fix for a bug, and the naming is good enough, just merge it already, ok? -Dave. -- Dave Chinner david@fromorbit.com