From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B6BDC77B61 for ; Thu, 13 Apr 2023 22:11:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C4D86B0072; Thu, 13 Apr 2023 18:11:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5756D6B0075; Thu, 13 Apr 2023 18:11:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 463B76B0078; Thu, 13 Apr 2023 18:11:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3417E6B0072 for ; Thu, 13 Apr 2023 18:11:34 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF9D14045D for ; Thu, 13 Apr 2023 22:11:33 +0000 (UTC) X-FDA: 80677765266.12.A20BCEE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 0B3B140022 for ; Thu, 13 Apr 2023 22:11:30 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=WDbW8vTr; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681423891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gehc3ZWaDgASn/82P03yFN1fWXUJ+u/kzaFL5LB8vew=; b=PVDd5PD6UCQzvQSpi6PDp/GHiHJOgl8g6J4fq5QlpHxeHtyUZbT2ZbQaSVeT/mzMVCT2N8 bAUyvILCB25Un9BPDvbrE4UTAJFZF0Yd83PG//MJnw3gtiN/IR07dddoO/EBoA1hi9Zn6g Mfc7mEj+jDuNSGclwVis04kCWgO43bM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=WDbW8vTr; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681423891; a=rsa-sha256; cv=none; b=UAivEtM3GSxqFVINO17aOCgDBwoPjr+0AsvXQpPa2EyYOXZnYpfGtlwXSjgk2Rhze0Wy4P KC8Ex6JvPZugKnyPGV9FOLvf+p7DAt4L8Lc/fn//5xN8SF9l1V/EH6iBcpfHQPd+FXdXUs 9/xo5rZNzFBHB8b69Dg600y48kR/QCI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE9DD641ED; Thu, 13 Apr 2023 22:11:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B38B2C433D2; Thu, 13 Apr 2023 22:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681423888; bh=aOsONFIvhz77p16K57ScSUccywmvY1pixUTbUaWEPx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WDbW8vTruLrE6RmQPKU9MKU5ntrWqVKEXcZK6A0uugt1GdAhuy+oSwItihR0+47z9 RiutRPsvzOLh7JxRjSgxWV6ad9pD9COezJdC+hjr7Eqi5wXoh0L529xMGFbRUBzasN m6bVCctBwGFlFd9EQ2hwj+UzjX0+xMJTlILvefgo= Date: Thu, 13 Apr 2023 15:11:28 -0700 From: Andrew Morton To: Deming Wang Cc: , , , Subject: Re: [PATCH] selftests/mm: Replace obsolete memalign() with posix_memalign() Message-Id: <20230413151128.abd305c1689eeac237e4e4e7@linux-foundation.org> In-Reply-To: <20230413012751.4445-1-wangdeming@inspur.com> References: <20230413012751.4445-1-wangdeming@inspur.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0B3B140022 X-Stat-Signature: nen56r5oidxz1f33e189f6kp3thzcu93 X-HE-Tag: 1681423890-791661 X-HE-Meta: U2FsdGVkX18n3jROANIuIOhmWv1fP8I9/MwSWl9spNaUChd/pPg6EmBOuAbbHsMnXNTGf1Ls3gHh/fGz/fvJgQIN5EosNgRhUnS5IhLEvUhxtKMOWw2T9SXEyQO0p42qHBrGSk6nlhq6iH89vKhwWzkOCCQZyCh+NywtXCx8ZZBOMLK6xsIE7V+5nmSEOWVHLpGhG0UdPOGIWs8fzHhzFjuqqYEHVtNTDK/ZvHvxe4WMn1ULuju2qKJNlV0h4kxR7DEXXUV32tGzSeYrUkXcqY8N7xbPKGWWUnSUvXArbabu0avHHhHfq1IJ0DyEOi3n5USu0k3MDLvSH5aw9CY80QS1z8rVfFcVmout3AsBSIGU/Ag7DhhDPvTosZhiD7xRAdFsztwhxbavep5SYVwLo+4am4YUwO+vM53/KLYKRuiE1hjDs38SImxt5CZ7WgrobWp44xmulu8icAUAcAoTViybgpb0MQOZhQtzEuuLP2qwCdkgiE8MT7xqjl/Zd2iFHPcAsoJfIH0nNc/THEd+DKO3CvvTJNTzA9qh632rCzjFuLBJp7pX4TcUkLKz8PQS6qMclQYIjnLr8hPqg2Hk+so2NFdYWxXVPJkzx+iUfaA8O6Ixda9xhfr0IcGRetV7fBynSU+hw2P9awqShSSPh9N0/60rT+SzpI0ljdKCFJDbBbymhvvocT8wWpZDdfzmHDQEA52vXv5n1Y2nSdx2SYlB/FCT9DwKmDqtQVzMlyGIfTHwIZ34Qwhu+Z/1DIgw1ZlMi0ayxje43VDmh+hC7Tas5fvOQ8pXxMCoc36HkrQ+xne4vCQHvX35ryZjoN3JQxWUHVycNMhAkx7NubM66qU8QdmxI18QcDYlhUQIc70wu7ybtCzvvg2aj280x/FAllJCNhpQtHsmQh+P1hy7gNhjE+CUP2910PQFc0caTpZvmktvG+D3G8rnIsQ779M22qPg6XEAIIsIKJd8Wxi iw4dYgKf vOJxK5gk90oKK3tgvdNUfTIJIVeFXZQNkwBhQphHuuKg966P+rX9raD1eSC470fJf17OXHp61NDm6bIIC/FF7p2LT+PBnu9hlSS5Oe9ybFIQbU5F2d10Khr6XwNYltCGAif4CjEFs6r0qstoC4YN9tmpDusfZC32lOKY+ZBV8raebI9U3VbHK6MPL7HWLzHp9x4eAPmAGbQdfOzXfhBtEraRttIoNl9mm84elcbW3BPrc2akVtp1LBxiD/1AGBzZ0E6AVIrYNkvP/9x6kAZPGATQZC4kEo5AEX16NO246ZhdOaDwGC80BLS6w4itd1V0w+c+BQFHyK2pC8dr05M5BOgueoDdueFik0o8sQOc9jCZpTaerq0U0HYjmxrFoGqG0pAN4CdfzOzqWU8/d6KGcwC3ofdUqLrLGRpYJ5QIj7S4V4bXmKLJB1bruiPGjmkbdjHhS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 12 Apr 2023 21:27:51 -0400 Deming Wang wrote: > memalign() is obsolete according to its manpage. > > Replace memalign() with posix_memalign(). > > As a pointer is passed into posix_memalign(),initialize *map to > NULL,to silence a warning about the function's return value being > used as uninitialized (which is not valid anyway because the > error is properly checked before map is returned). > The patch you sent doesn't do this? > --- a/tools/testing/selftests/mm/soft-dirty.c > +++ b/tools/testing/selftests/mm/soft-dirty.c > @@ -80,9 +80,9 @@ static void test_hugepage(int pagemap_fd, int pagesize) > int i, ret; > size_t hpage_len = read_pmd_pagesize(); > > - map = memalign(hpage_len, hpage_len); > - if (!map) > - ksft_exit_fail_msg("memalign failed\n"); > + ret = posix_memalign((void **)(&map), hpage_len, hpage_len); > + if (ret < 0) > + ksft_exit_fail_msg("posix_memalign failed\n"); > > ret = madvise(map, hpage_len, MADV_HUGEPAGE); > if (ret)