From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA62C77B6E for ; Thu, 13 Apr 2023 01:28:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE8CF900002; Wed, 12 Apr 2023 21:28:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C98AF6B0074; Wed, 12 Apr 2023 21:28:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B87C9900002; Wed, 12 Apr 2023 21:28:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A993B6B0072 for ; Wed, 12 Apr 2023 21:28:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7DEE41602C9 for ; Thu, 13 Apr 2023 01:28:01 +0000 (UTC) X-FDA: 80674631562.10.9ACF7A8 Received: from unicom146.biz-email.net (unicom146.biz-email.net [210.51.26.146]) by imf10.hostedemail.com (Postfix) with ESMTP id 85FF6C000D for ; Thu, 13 Apr 2023 01:27:58 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of wangdeming@inspur.com designates 210.51.26.146 as permitted sender) smtp.mailfrom=wangdeming@inspur.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681349279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=sOp5ejaN9rYtnDJgT7TbPBZWC2H5v3233wtdCinjHpY=; b=ojzfxyAtUPLd15T1JrS/yO+42o3GTDFBxBoLX4+CkGn70o9Sas2UgdIDxptfyLEgitxn/X awOUUnCftOB+FdzPkdkettg5Mq5Jveg+68NaAR5OOM1aY3Rdl2f/n7RjduYHHp1Tz/myw5 gAGYRMAW/e+5/dkd0CLTvuI4McE8oFI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of wangdeming@inspur.com designates 210.51.26.146 as permitted sender) smtp.mailfrom=wangdeming@inspur.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681349279; a=rsa-sha256; cv=none; b=R3JG/2ehf2wlgGFbvt4+erCg+EtRK6aME4CZuL9BAbYwf3Nk/3nls7RPeqU7SLbfVpopxR xO0uFVB+u9oc1NM9jZMlIG/deZhUH7t5nYzDdiBjZ2nHYWH8maBQmPF3Z1p+e27kIj0udn Jr0PUujWPRYComaQpqFWI2pJikOPXGI= Received: from unicom146.biz-email.net by unicom146.biz-email.net ((D)) with ASMTP (SSL) id IVO00050; Thu, 13 Apr 2023 09:27:50 +0800 Received: from localhost.localdomain.com (10.200.104.82) by jtjnmail201603.home.langchao.com (10.100.2.3) with Microsoft SMTP Server id 15.1.2507.21; Thu, 13 Apr 2023 09:27:53 +0800 From: Deming Wang To: , CC: , , , Deming Wang Subject: [PATCH] selftests/mm: Replace obsolete memalign() with posix_memalign() Date: Wed, 12 Apr 2023 21:27:51 -0400 Message-ID: <20230413012751.4445-1-wangdeming@inspur.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.200.104.82] tUid: 2023413092750fa4388fe447b5709db712d77b7ea7373 X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 85FF6C000D X-Stat-Signature: 4wwka93nj19et3pbukpj47igi1imwotf X-Rspam-User: X-HE-Tag: 1681349278-789009 X-HE-Meta: U2FsdGVkX19ix+4B/KgxRUD80Iru3MKouDLZF6K2E2wjLDXdDHCb+Y1fsIgv5vnk1E8hpXTpoiQ2x6TLLvldeeWrnOuWccAvbtavzrLtAD174gvuUQ+yRXkEhUv9Y7eBv6QSWIn35dn0UsGgKBV7MGQv8XEp7mG8Uk0mVMLhirM3ESAxnWXJ75T2EKVs0eV7Ue/Zs7MqI0QdH1jvpAGvM0f+wo2NVVdzRMfrHITNYd/ZDSkTfaFrQ0TdiYX9Hz5ykDqjcR1+MsWlRWpIgZakPMZwhjzUPpvR/jSfZ1hsWmfCaUMKNFIx+f1GiDA7tEHrB05Z+61u74SiTnbr7Atn0mdKMyzm+f8JnePbg1/8nwck8VKWbzHvF0kgumd3sx/lXjs98bpdgRFCtix0NwOJoES5s2ssYvEkOT2/MxgKyhh0dmdbe9exbqi/d/myP0RojwOQWV+r4c2nNMwK9eL//zLd6mkDd1rSZxDRV6hl44YfluLYHCcvIf7eRqTwpYvDd1l5llL0IRy5m8RU15aEQHbM8QwgEeFPEDEIidxJz0d0HmPAE/6LNuWa1j2NHWYt8st1osSIRjaK9tkxUFJGs4Cqg95pL+WcOyl9+5sLQUmNJmfzegWVzeCT5XwHLitWjXQJBU15KEBGi8984D4oM1rzCGPPeUYBZe0AFBmR6PUy4KVT9j/IvQK8QJ0YrWBYCgUW+2j0dyg1I0H/34wky5wSGRkw6NcvrhiNug+l3bN37aUxyOp8DnZIGrej4LzTLfIP+R9VEiVTSwLa0y2NsU9qtWz1jzOBnRHKucddzNoCD5xDU7614qewWLjSZvu8hoTjiIOUV7BhCDnycZC0A8NfUmQTpCJ2Oj9AtdTFpYq58CfkubxwsCpJ3R8Vg1liScEGeuyPj6R8QZCpXz4Lf0HOGjaYpku0mRxwTTndnmRt547LurDyeB18bNZf29MiDwUSK2s2T8P63ocIT+c BZ+B1LEc GjTu9SyWjiEmQMoyxx/fkmiA4AzyuD0EtcSXmtDAN+3NVIpe1HEfy/4ecbXdEwKQq7MEzAL45P7kfXFbg4BhXIDqs0xVu5BFy/pgJaLR6M0NND8RjGHUPeVSR72Mehcv8pi+S7RWwWSvQrTN68U3cHVJ6DD3Ol9tsaabMExPdhDfXb6KcM95VHI9FXbGRBRxKvU1s8OiTRoeW91E0wZVgoOJ82Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: memalign() is obsolete according to its manpage. Replace memalign() with posix_memalign(). As a pointer is passed into posix_memalign(),initialize *map to NULL,to silence a warning about the function's return value being used as uninitialized (which is not valid anyway because the error is properly checked before map is returned). Signed-off-by: Deming Wang --- tools/testing/selftests/mm/soft-dirty.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selftests/mm/soft-dirty.c index 21d8830c5f24..c99350e110ec 100644 --- a/tools/testing/selftests/mm/soft-dirty.c +++ b/tools/testing/selftests/mm/soft-dirty.c @@ -80,9 +80,9 @@ static void test_hugepage(int pagemap_fd, int pagesize) int i, ret; size_t hpage_len = read_pmd_pagesize(); - map = memalign(hpage_len, hpage_len); - if (!map) - ksft_exit_fail_msg("memalign failed\n"); + ret = posix_memalign((void **)(&map), hpage_len, hpage_len); + if (ret < 0) + ksft_exit_fail_msg("posix_memalign failed\n"); ret = madvise(map, hpage_len, MADV_HUGEPAGE); if (ret) -- 2.27.0