From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D431C77B6C for ; Thu, 13 Apr 2023 00:17:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E7E7900003; Wed, 12 Apr 2023 20:17:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89704900002; Wed, 12 Apr 2023 20:17:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7377A900003; Wed, 12 Apr 2023 20:17:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6050A900002 for ; Wed, 12 Apr 2023 20:17:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0846DA02C8 for ; Thu, 13 Apr 2023 00:17:07 +0000 (UTC) X-FDA: 80674452894.28.0B85C92 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by imf04.hostedemail.com (Postfix) with ESMTP id 2661140011 for ; Thu, 13 Apr 2023 00:17:02 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=QuqURqSR; spf=pass (imf04.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681345024; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k+Pg1Bzyv9BcpHloPgqL+/gsU6us6p6A3nKbyzyMGw4=; b=En8lUjxXMZA2/00uXq5RnJNh9tqMSTW3jXiyBNxktTC0Ccvo/KQ0GGOkw+GrRUFb5ehYCd 15v48DkjrBpXXYV10T7igFmaDPMKG2B17f4x/e3g8brYBoio6fAl7EZZPm8BvR0ptHrYHq J8M73wUwuIn5Th5JbC+kQZfdNdr/a0E= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=QuqURqSR; spf=pass (imf04.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681345024; a=rsa-sha256; cv=none; b=M0/GPBWvMFigphaLSaFiLE2NUvPdRr0z5O+LKmRJ4I6RgldGLZcFnNnLf+XgZ+OL97DjTB l6Kc0FGMgENcPKbop0939e5XVUGFI58bPuomlGT5GUbpwWVx+Z/cf1jen4y49pJya9tl6/ CD7SKg+VOcBIh42wXAJd+fNbfl5n4Gw= Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230413001700epoutp01c1796820a3439906e84d8623b55bda8f~VVmM-ZCtF2474424744epoutp01M for ; Thu, 13 Apr 2023 00:17:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230413001700epoutp01c1796820a3439906e84d8623b55bda8f~VVmM-ZCtF2474424744epoutp01M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1681345020; bh=k+Pg1Bzyv9BcpHloPgqL+/gsU6us6p6A3nKbyzyMGw4=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=QuqURqSRXJfqgiPvUpGj8WX1U30ze6IHhRsC2Pp2K46FJzM+MFxigimJISYqgOGkg kP6w4+oDrGq0t+WM+zDR+2fe+FvV2RhnygNe3Kfrl1wmCKjvX45yknUIXsUsRz2pQa eTdmRTe0wfxg8jtnmyRZ09apAjki7cFi4zqAbW7k= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20230413001659epcas1p4b2d23c72038fa25851593c6d0fba38a1~VVmMZjzDJ2783227832epcas1p4M; Thu, 13 Apr 2023 00:16:59 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.36.222]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4PxgB310Jqz4x9Q3; Thu, 13 Apr 2023 00:16:59 +0000 (GMT) X-AuditID: b6c32a39-5f1ff7000000247b-1d-643749fafc30 Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id 15.14.09339.AF947346; Thu, 13 Apr 2023 09:16:59 +0900 (KST) Mime-Version: 1.0 Subject: RE: [PATCH v3] dma-buf/heaps: system_heap: avoid too much allocation Reply-To: jaewon31.kim@samsung.com From: Jaewon Kim To: "T.J. Mercier" CC: Michal Hocko , "jstultz@google.com" , "sumit.semwal@linaro.org" , "daniel.vetter@ffwll.ch" , "akpm@linux-foundation.org" , "hannes@cmpxchg.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jaewon31.kim@gmail.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230413001658epcms1p611d149fcbbbd06fc17387724f4f16359@epcms1p6> Date: Thu, 13 Apr 2023 09:16:58 +0900 X-CMS-MailID: 20230413001658epcms1p611d149fcbbbd06fc17387724f4f16359 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P X-CPGSPASS: Y X-CPGSPASS: Y X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCJsWRmVeSWpSXmKPExsWy7bCmge5vT/MUg83TmC3mrF/DZvHykKbF wod3mS1Wb/K16N48k9Gi9/0rJos/JzayWVzeNYfN4t6a/6wW9/scLE7d/cxu8W79FzYHHo/D b94ze+z9toDFY+esu+weCzaVemz6NInd4861PWweJ2b8ZvHo27KK0WP9lqssHp83yQVwRWXb ZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gAdraRQlphT ChQKSCwuVtK3synKLy1JVcjILy6xVUotSMkpMCvQK07MLS7NS9fLSy2xMjQwMDIFKkzIzrhw fhlLwRTOivZH15kaGNezdzFyckgImEj8XHwbzBYS2MEo8XNJbRcjBwevgKDE3x3CIGFhAX+J fS/mMEKUKEmc/XGFHSKuK9HUvZoFxGYT0JZ4v2ASK4gtIqApce35ZqA4FwezwBFmieZJtxgh dvFKzGh/ygJhS0tsX74VLM4pEChx/lQnE0RcVOLm6rfsMPb7Y/OhekUkWu+dZYawBSUe/NzN CDPnz/HnbBB2scSyzgdQc2okVpxbBRU3l2h4uxLM5hXwleg/sx/sBhYBVYnTR9ZC7XKRmPFk IpjNLCAvsf3tHGZQODADPbN+lz5EiaLEzt9zGSFK+CTefe1hhXmrYeNvdmzsHfOeQJ2jJtHy 7CtUvYzE33/PWCcwKs1ChPQsJItnISxewMi8ilEstaA4Nz212LDAFB63yfm5mxjByVfLcgfj 9Lcf9A4xMnEwHmKU4GBWEuH94WKaIsSbklhZlVqUH19UmpNafIjRFOjlicxSosn5wPSfVxJv aGJpYGJmZGJhbGlspiTO++WpdoqQQHpiSWp2ampBahFMHxMHp1QDk8fysOLZm284Nbgwr9oa dnRT29HtCX/KLnt/K7Hzzbpv8pvR42P8QnGLN3aRf7t/y87OL7u/8LKdnMPu3zKtddufTtnF wHPJPvq024fd5Y+Dwh8yTDbicVnEmR3xIn+/ZIXGhAtymXcPhPjsFV8nlvo8Ic+YycRz9WFV 9a41Ysm/C12uawpf/Rn/QWGL57uMiQf6DnsJ30pw+mOZtyVHutH1pUXfq023bTmF1+gLCVgk LL18lzvkUBvn1/UB19/oxtwocjl55hDzOtNDme9urGW0LDA323pg6eZ6VzaBiUWbdpwMdShb /Lj9wV6r249SmjmXy4o/z33sltxxapVarmz5eRVGvZ5ts5b8+3HAW4mlOCPRUIu5qDgRAN6i mppHBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230410073304epcas1p4cf3079b096994d69472b7801bd530bc7 References: <20230410073228.23043-1-jaewon31.kim@samsung.com> <20230412085726epcms1p7d2bec2526e47bd10a3b6ea6a113c9cc3@epcms1p7> <20230412094440epcms1p445319579ead0d0576bb616ebb07501b4@epcms1p4> <20230412113759epcms1p8cb15b54e3a96c7616419cb030d16f804@epcms1p8> X-Rspamd-Queue-Id: 2661140011 X-Stat-Signature: ee18z5tt3cpta9aj11ri9g9edeorqcb6 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681345022-843266 X-HE-Meta: U2FsdGVkX19cRDOF18q/sqXCYV5XG2tVsLgweJzEPiDAX3uoh6IesWD4xQn4/80rPFOfYGrUYfcM9RUlpwE1kTrYA7zEHEDdtiBYhpYexhNvUCLxkdxIogJm8dMybdUXKI0ASJrxBHsWR8rNJHD3LxJw2Rz0eiG77vkwY3r3ya1IZP/G8KKKm9cbhOgw6pZb8twCcriWWaPD+pu55AEfQfPbZFweBk3u8+89LbuzRjNAnkXt8zVLERedzLIt8P2EqJuXjPE0YHb5UmN4jMRXLKO2KvroknKbPzWC+XLK+E5xz69bPOfkFBAfnZQmX1IlOQcADJCSbA2Ns923j7eVBWWkAfIqxhoG1zd8Sc2B+3F58RSSkk7VTlmQnCYRnKJI8kAInojlxgLvBORxkWoZUp50cMbcuhf+PcTOErYv1AwQFMSl8bSWE3rmvsXlq1jB6wE/iwPu/6sz54u2Lrc7Ea2uwQzMmUCz9TFPANVHmd3N++du192qMOUt9ZY2yBrwpvnGhZ/a2uYFfQILfYEvt3WbqXQmJPHGri9GP7p7dd04IQP5DJWXz9J0zqNTj4MzCjDCf4HvzamXbjbw2xuM396KFcbjEm4G35RlTn0FMevBS7BfG7rdg28kFSOmEKjH5SxMrVagmWae0dEikMleTqu0UYkj1f7yEw83THHE6FlUDi9zBHsiSKlwzJwZhpYHptrx6TKZLpsxcImMxbDQmSrjjNjIq8iZN909BBhD8l5r3VA/acSPP+kVjXM9ZCQ0i4pB+XC3YoFP76Q4sE1NiyQwU7bTGMkY1XdKdbJZO4ETmyoyWB0E5+lVEdoisQjq6tk5mMztSGNS1OOKSxrjs8O1rR22rfE9M3SpvYpOBbm9FTAmgAQ7V6qARCiPFzlTBj0ySYWxz8caFXkYki8gR/jc2ejY0HtJFo/iIF2LHEC6xaTcCWaVHXVnI+1eR5H3b0A/EHkwXHgvKFhg2a9 NplCocUm wMWg0Y3FgEE1cyPWJ/iVRnLPbbyOtkKyk33oK36f46VblrdmKPQcJgY1Ck9DXu38+dIuVMC5Zxx5cVXPccWcZVGEoyO8Vix/UJXnCyOVlQvcLkQ7mLTXJfzCnzSHVFoy6iaVLBmVJVqXuBBGuZHJhxIIvU0HOt4DR1MASE7ukcEx6h0u4HBy+9sCwHV4lG/XpEhSSwwkscrrNtkgKKF7iazQBQhwC131dHijIdmHaIJnDHGSHWfX7hm0gt38rHHED5fv1Pk4N83qAff7kGJ5zT/hJ6me8TSLzKUlsVJtUOPegO23qxGdFmp1g7X47iuWLs4JDYwf8ApXxi586hVOrVVtGJH7XiWSmJoioTIKxIyYwsL8EhvIwvakHzRVlFPCQ2B0rebpFPqi8Su8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >On Wed, Apr 12, 2023 at 4:38?AM Jaewon Kim wrote: > >> Yes I think you're right. As a allocator, dma-buf system heap looks to be loose >> in memory allocation. Limiting dmabuf memory may be required. But I think there >> is no nice and reasonable way so far. And the dma-buf system heap is being >> widely used in Android mobile system. AFAIK the camera consumes huge memory >> through this dma-buf system heap. I actually even looked a huge size request >> over 2GB in one dma-buf request. >> >Hey can you point me to where you saw a request that big? That's a >non-buggy request?! (let me resend as plain text) It was one of camera scenarios. I internally asked and heard that was not a bug but normal. I think 2GB looks too big for one graphics buffer but it could be for other purposes like camera. I think the system heap should support that. Regarding __GFP_RETRY_MAYFAIL, we may need to say dma-buf system heap was designed to gather many pages up to a requested size. If mm returns NULL due to __GFP_RETRY_MAYFAIL, dma-buf system heap will release other already allocated pages, so that it may help to avoid oom.