From: Andrew Morton <akpm@linux-foundation.org>
To: Alexander Potapenko <glider@google.com>
Cc: urezki@gmail.com, hch@infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
elver@google.com, dvyukov@google.com, kasan-dev@googlegroups.com,
Dipanjan Das <mail.dipanjan.das@gmail.com>
Subject: Re: [PATCH 2/2] mm: kmsan: handle alloc failures in kmsan_ioremap_page_range()
Date: Wed, 12 Apr 2023 13:33:31 -0700 [thread overview]
Message-ID: <20230412133331.e26920856ccf94edd057c1e0@linux-foundation.org> (raw)
In-Reply-To: <20230412145300.3651840-2-glider@google.com>
On Wed, 12 Apr 2023 16:53:00 +0200 Alexander Potapenko <glider@google.com> wrote:
> Similarly to kmsan_vmap_pages_range_noflush(),
> kmsan_ioremap_page_range() must also properly handle allocation/mapping
> failures. In the case of such, it must clean up the already created
> metadata mappings and return an error code, so that the failure can be
> propagated to ioremap_page_range().
Unlike [1/2], this changelog doesn't describe the user-visible effects.
A bit of clicking takes me to
: kmsan's allocation of shadow or origin memory in
: kmsan_vmap_pages_range_noflush() fails silently due to fault injection
: (FI). KMSAN sort of "swallows" the allocation failure, and moves on.
: When either of them is later accessed while updating the metadata,
: there are no checks to test the validity of the respective pointers,
: which results in a page fault.
So I'll add that to the changelog and shall add cc:stable to both patches.
next prev parent reply other threads:[~2023-04-12 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 14:52 [PATCH 1/2] mm: kmsan: handle alloc failures in kmsan_vmap_pages_range_noflush() Alexander Potapenko
2023-04-12 14:53 ` [PATCH 2/2] mm: kmsan: handle alloc failures in kmsan_ioremap_page_range() Alexander Potapenko
2023-04-12 20:33 ` Andrew Morton [this message]
2023-04-12 18:27 ` [PATCH 1/2] mm: kmsan: handle alloc failures in kmsan_vmap_pages_range_noflush() kernel test robot
2023-04-12 21:06 ` Andrew Morton
2023-04-13 13:19 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412133331.e26920856ccf94edd057c1e0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=hch@infradead.org \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mail.dipanjan.das@gmail.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox