From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2475C7619A for ; Wed, 12 Apr 2023 12:49:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 752F16B0075; Wed, 12 Apr 2023 08:49:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DD38900002; Wed, 12 Apr 2023 08:49:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5562B6B007B; Wed, 12 Apr 2023 08:49:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 442466B0075 for ; Wed, 12 Apr 2023 08:49:02 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2180BA7919 for ; Wed, 12 Apr 2023 12:49:02 +0000 (UTC) X-FDA: 80672718924.03.556DB32 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 66902A0023 for ; Wed, 12 Apr 2023 12:49:00 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WFnv1NjO; spf=none (imf25.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681303740; a=rsa-sha256; cv=none; b=Bc4f56H7SSNTxGlFQMfzekaa9BiEyj1jkxWBRF8QUeWWxOvPp2WnDfzEyQNWxoQXi49BG0 9hwfHxgsU8o6Od/RbCeAAtIENpUvCDmNUw7FVxB8QaJbSg2Bp68UENInvv3ataQAFUB+0t HTTNsXGuTP4Um+gmlW3MA+M8IV7FkF8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WFnv1NjO; spf=none (imf25.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681303740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nwnw2uTfPO5n4Gp8ZTbsCl6BKgatqoYliynKz2+TMOM=; b=VTmsy0u+ccTMQ67zL+rogPU/RSLSZUYhl6pPeJv6p7RYXYpFCMbDzvURQQJ7EmwxWBF7pq w3/GjJ858cOhhf76cwaobn1LCVqGwtB1zh1C2cIYEE7B/X+/gHQz02XIOp/oq6FI8IqoMx Kg99HedtEmELWplgaJF4Go93Pwhkq2I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Nwnw2uTfPO5n4Gp8ZTbsCl6BKgatqoYliynKz2+TMOM=; b=WFnv1NjOaGkkXkkj+IrnKd7VMG yQnXQFDdQyp/GOGVYk6aypVrAhYvyisIgw2Uo4hCN3Im1JZ7a5ATB9eHTDhr3HnoVI3M/Vayn6QhF Sy8EqNZ313UZZkfaKCKT7K1VWQaqm0Z/t8tZHqV9k9wyonlE8+eKAd+0HBKVc5OyKolPFGAec85JG zU/03alRPxg/VHUqgbbs74x/cgYOANmiUdSHeTIUcY9C3aJ+9ghiyXHRrhC7jXVn2zu+X13X/gV1F 5Hze/xTOeJg444vNqcxku6Bplu3ZPCiU8FxDs5uQH6H4JnC432lX260nwmoKXWZyenGZ+GJ1N9C8v 6D5AB3SA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pmZtu-006s9e-0x; Wed, 12 Apr 2023 12:48:38 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BCC45300274; Wed, 12 Apr 2023 14:48:36 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id ADFD2235CC4A0; Wed, 12 Apr 2023 14:48:36 +0200 (CEST) Date: Wed, 12 Apr 2023 14:48:36 +0200 From: Peter Zijlstra To: Qi Zheng Cc: Vlastimil Babka , "Zhang, Qiang1" , Boqun Feng , "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>, "akpm@linux-foundation.org" , "roman.gushchin@linux.dev" , "iamjoonsoo.kim@lge.com" , "rientjes@google.com" , "penberg@kernel.org" , "cl@linux.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Zhao Gongyi , Sebastian Andrzej Siewior , Thomas Gleixner , RCU , "Paul E . McKenney" Subject: Re: [PATCH] mm: slub: annotate kmem_cache_node->list_lock as raw_spinlock Message-ID: <20230412124836.GF628377@hirez.programming.kicks-ass.net> References: <20230411130854.46795-1-zhengqi.arch@bytedance.com> <932bf921-a076-e166-4f95-1adb24d544cf@bytedance.com> <29efad1c-5ad4-5d26-b1b9-eeee6119e711@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29efad1c-5ad4-5d26-b1b9-eeee6119e711@bytedance.com> X-Rspam-User: X-Rspamd-Queue-Id: 66902A0023 X-Rspamd-Server: rspam01 X-Stat-Signature: whtegwdzixhec73crie51up9djeanb8a X-HE-Tag: 1681303740-475684 X-HE-Meta: U2FsdGVkX18CLZFulm2sMyt53sdsitFDt/88hYIF75v2xDN0GcjqrwAaljLVQP2J4JAgWQFQ5bC45CW/eSFToRxHoFyCyxY3KHCY2I8VPtHjsqVTsjPXNiMvzIsQGb4Rccw2dl3bWaz2fX/84u6K1180+WlJJzUxDVJa+Nd0nm+Gxon0g/6TuThAqsiom1IrmtnfeT1xgTD1AeVY5Hi/hae0LH/D5KiNQaQTnKZi5dIW0khLkBxjjKoRUahWhKgErxAIZNRUn9eHGaMTW8qtu7aslh8+ssDd/KiTrN84QGCc+NRDqtx4zyDR428yr6liXxt9fERuO8JBCaCFITVwwGes55LWWRJpgXSQ9IBTMsiniZj9+k/JrCiJhwCvpF9kat5u5ZsSu6EvwndauVNGRjq8CFvB9j0RJYUIwiZKuSDGh0IQCgfsC3G+KJXCztIkKgwDlpfIQulRrM7akBQEAopp0R/QLAuq+CPGCd058FyBFY2s94btKvSTlKbYek3t3izxOlD3GgAYj5x6wgVOs4wEcw8d+D9fNVBL4dt1VyuSd3XbXaIsD6zqWB9r4d+nf03e/RTmN+iNPknOSL0hoI3bsp3uGbUHUe3RWqVQPWcQmPWSD7UPgPRYE2yPV9M6jlTcEbNQRVjpdTkNqu3KsA7hgtt7tavgyQeezcFllQOvAn0rkIO3p0Ojv48p5PTKyAYFXidv09qZGtBC5nEQfPfUhLIkma3g6xxxsTfKDrPyIb85Xxs0sjnpgNIPShxb3h+wZd9e5GQ0Hh63vQl2nJ+hBIn5/e4Y5yAbP8Dc/xaNRhSmxioalqCmXPrQPADdcnn29F21ylV3ZEf6aQnGYTDXCbwYkD2clgHRhOpWhNfopT4Non48Dv/cVuglCoi8FfHldvSaAWMZMSou1DIwvb6n76PU5Vs4i59V56x/FZBn4zX7SuEE6NQ9/sBzAQUECcZ+gZFCu1bW33ypKIh /qvuHRqx WRi1fEdzQiJIV1vn0acMJ+BQu3EkDcsWtq999OYE8Fz1Bav7jtYqQkPygON4SLSWBx07j3/l/+b7eshZnk9qY/S9yIbG83XgrbEJHda7F81fcUm2B1sKQrGO0dA8DfmIM6lHuLFaXyTmJycTh/5Ud3HppZ82XA4iIIJEK+VzGI5VceyvVRK0N5FlqWjrOdA/Pfz/MHKKbDKDwGsLJjqlQk5Qb4UIGInaX7OizueHS7SG9P6Omz0gCgIT1ipvjJmdVx4V8ucJ8ulwqjgApgVvb2JX5b4HXYxq5d45HKC89ibQkaQ9JcI08ctYa7PpiAgRTX4PG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 12, 2023 at 03:30:20PM +0800, Qi Zheng wrote: > Maybe we should make CONFIG_PROVE_RAW_LOCK_NESTING depend on > CONFIG_PREEMPT_RT: > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index f0d5b82e478d..257b170aacb6 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1262,6 +1262,7 @@ config PROVE_LOCKING > config PROVE_RAW_LOCK_NESTING > bool "Enable raw_spinlock - spinlock nesting checks" > depends on PROVE_LOCKING > + depends on PREEMPT_RT > default n > help > Enable the raw_spinlock vs. spinlock nesting checks which ensure No, very much not. The idea is that we want to work towards having this always enabled (when PROVE_LOCKING) to ensure code gets and stays PREEMPT_RT clean.