From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9471EC7619A for ; Tue, 11 Apr 2023 08:41:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CA666B0110; Tue, 11 Apr 2023 04:41:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0555828005B; Tue, 11 Apr 2023 04:41:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E36126B0112; Tue, 11 Apr 2023 04:41:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CF9DD6B0110 for ; Tue, 11 Apr 2023 04:41:44 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AB23E1A05C9 for ; Tue, 11 Apr 2023 08:41:44 +0000 (UTC) X-FDA: 80668466928.10.CB62A44 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 1D1D820006 for ; Tue, 11 Apr 2023 08:41:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MqKOe68N; spf=pass (imf13.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681202502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zhds1nvyJf57ghkuFtgtAJiNC9mYUGjfuMTxOgoB0oY=; b=THEDL4aoGNM6zqEHukQlmvCIsdqJMHPqPEb6lPCl1l2DeASh1NKq494FkMKQzj9gPJgwci +Tkyv4wMPSlbf7QfzFKDSWGrVeyvuL99hWXvw6YUP+iMwHv778e4lsd/8znbyD6W7ujThs IM40JQ8ITE6t4PLSauSdO7O5LyVlWNM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MqKOe68N; spf=pass (imf13.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681202502; a=rsa-sha256; cv=none; b=c+S/2ajgTHb9cn9X7nH3u9Mae+8+yy77W0go6E7nJSe1POi6uZSV06aNx3aq19cF3lMeFC vq/oGSrtfJGMHxhtSS0WmUk7/ijBsEhbxl+d/46g0fSsp5O8z12qY5NnzR4ttzlB2oehFW BZ+Zw2WT11c+L+LSx/omSF5Z2m846vU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A0F861E4A; Tue, 11 Apr 2023 08:41:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 272D5C433D2; Tue, 11 Apr 2023 08:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681202500; bh=7u7/nI6VJjJ+81GqcnTk2qduufTY1lvAgSL3PrqyYQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MqKOe68NFCmJcYcruvxCJEtd6Oav4j/ZX4tDi97gSAW2vF96nS0SeSY2CATBM4fMr VII0pB1lGhBjtvjhBHjdeO+CAGBESonJ2HnVRJOO9clgEAvUF2njMYMOikTLFSiYkT KiP7X6kJShj70TzzifQCY45GbnBhkUN98J2CKjj66qSOqZKNrjtR3m3osXPMB3WqBL GlXOVcevvlyS46dCHZ9mD8fqUeWxemYEv+O37f0QCLUhN3mDSQtqyKFoZsK9y/EzVz s5i3bt+TwWR1e8oOWYy6dAD+eVfwLiA99wKa1E5phjgptcVrznEFBCjTXK/AnhyfR0 G4UM1rw5ksiOg== Date: Tue, 11 Apr 2023 10:41:35 +0200 From: Carlos Maiolino To: Jan Kara Cc: hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL Message-ID: <20230411084135.vwxuyl2c23hf2kjj@andromeda> References: <20230403084759.884681-1-cem@kernel.org> <20230403084759.884681-3-cem@kernel.org> <20230403102354.jnwrqdbhpysttkxm@quack3> <20230411074708.gb7hkp6knxag3qjs@andromeda> <20230411081445.i57nloespetckatg@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230411081445.i57nloespetckatg@quack3> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: zhqaak11dzciqi4cqtftchncd3c77owm X-Rspamd-Queue-Id: 1D1D820006 X-HE-Tag: 1681202501-985991 X-HE-Meta: U2FsdGVkX18muJ2yoQKLCWCbyFGfFOwMcA+r6Emyo2uxS1h54F/8CVG6clYB1EH8N7ql2PvZ/jXgI4S22gNLm85tMblhoDJ85CEXdPKRJCUVPAYEVodFAgZW/K3p4zI+IiehBbJB727cL2VY8Z3iZE4hTXiqo9O2TZaWn5X8UGJltpCWTH6ZCjsIkyfDWZM3UlLRsTu97LFIjF3tcvaG0teN+Jist3f507s0sVGL/QsMf26ibdy/VFN0iyUJ67LEXg0r1cQjlnkvdZJKskv/RVtMxh/nIC6IegDOojc07JUK/ihj2kWvvk02mwYyJCBDmWX4wh1aplXk0/1e0A44PVrQ17EbCrD3hq/pnPHJp5EOE4hm2v0LbVviuuwEj3jc1Nm43PYMwLBFmzVSfthUkXHTi2OSSXZttZg8PgH0Z1+4V/S/Q0DkXhZltgo5bXNca0JgslDvui6EzJ6ySQX/JeKpjcqnmT6JbQy7dLa3+8Drmf3DO16nBa6tV4MBj6T+rapwgq2lv+PTG6XA97jxr4AgZ1i7YjWg2WaBF5/kg6YOPC2K8O3geqAcgELTc2F0NKUE6qvz9k61M9e79SQkoqYoqiyU1HKTT7QCz4m9yfV5UXPVchICrMbMPgN48kCYYTtqZusY13vJZNLjSOcHj+IPxXysv5q3jIlP2UhdYgimaWPKU0LlYltMaGLZ6c5PFkYWzneyYY7N7RnnWaH5wtCUGiIBTqZVUF1o/kSlQa12R2qnYJ1Q/lbOicEMiqOcGJWITaZ/qJahAsCOgHRjCzz8zFBHvl1XfrCSu/XkS/Yj7T3JIJ58ZVnOt2NorRwFntnFqi2vZVji7JgXBDSIVQ7nxQ8QUAAH+xdI/ma0UopVqFsLtsQJ3HRPYLFuUxzlrNLiLm8nvg++mjTedO4PHYYBB5PjgOY88Gv0U+4g4Alt9tM6LLfHU5zMzpbPKiFlqMrJWvlxn/cZXK0xtnj msk6SLnN sWUT545L1Kco35LYfg2ul4NWZ64VduwGM+qJ9A5H/A+XsC85ROI8QqcmajgoXWNXgnDBjdWPGKTxfzNhEh+58GaBjfwwFJNQBkPcnsPCPNnZ3VgjrbbOAdR/b6J4jmSNoz4/D354IiM/2ofRl7AinPXiZpUh86HZ/d02rVu6r7vjDng7cI+Z5mNEV5anfJzMEmWpQrqv11occqFIYJgAr0yIzHGKCj1zC9m4BjiqQiOx6wcyfPJI+TMGn4V3ZJSA7zICkKkdbZvH010YtF8CB+hXdd5SqbUSSrrBxNPSKQJnXyiholO0SLDixJvPPmPhsiRu8fNGFWSde1ngwkx6sqXcTNfElqO9lmBOC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 11, 2023 at 10:14:45AM +0200, Jan Kara wrote: > > Hi! > > On Tue 11-04-23 09:47:08, Carlos Maiolino wrote: > > My apologies it took a while to get back to you on this one, I was > > accumulating reviews before running through all of them. > > Sure, that is fine. > > > > > inode = shmem_get_inode(idmap, dir->i_sb, dir, mode, 0, VM_NORESERVE); > > > > - if (inode) { > > > > - error = security_inode_init_security(inode, dir, > > > > - NULL, > > > > - shmem_initxattrs, NULL); > > > > - if (error && error != -EOPNOTSUPP) > > > > - goto out_iput; > > > > - error = simple_acl_create(dir, inode); > > > > - if (error) > > > > - goto out_iput; > > > > - d_tmpfile(file, inode); > > > > - } > > > > + > > > > + if (IS_ERR(inode)) > > > > + return PTR_ERR(inode); > > > > > > This doesn't look correct. Previously, we've called > > > finish_open_simple(file, error), now you just return error... Otherwise the > > > patch looks good to me. > > > > I see what you mean. But, finish_open_simple() simply does: > > > > if (error) > > return error; > > > > So, calling it with a non-zero value for error at most will just add another > > function call into the stack. > > I see, I didn't look inside finish_open_simple() :). Well, it is at least > inline function so actually no function call. Great, I didn't notice it's an inline function :D . . . > Yeah, I'd prefer we keep calling finish_open_simple(). Adding a label for > it is fine by me. Ok, I'm updating the series today, hopefully I'll send the new version today or tomorrow. Thanks for the reviews! -- Carlos Maiolino