From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1BF8C76196 for ; Tue, 11 Apr 2023 07:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12DC9280059; Tue, 11 Apr 2023 03:47:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DD366B00F8; Tue, 11 Apr 2023 03:47:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0D73280059; Tue, 11 Apr 2023 03:47:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DEA2A6B00F7 for ; Tue, 11 Apr 2023 03:47:20 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4EB4D40579 for ; Tue, 11 Apr 2023 07:47:18 +0000 (UTC) X-FDA: 80668329756.14.F30D5E8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id A93FF4000F for ; Tue, 11 Apr 2023 07:47:15 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pMAUuUOQ; spf=pass (imf11.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681199235; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sA9gIHBxYyqOmsWsN1PDwwsh/mUy6Q3SLag9p0gczL8=; b=0Yo7QEudwdIO/hi9WoeSwUbg5hVJZHg7RfQTJuG+8OBm5R4RVAYv0xbIuKkWctGVWiCGQm VP+p5f+9xixtRXcPrQTx5IM4SeNfJNq/9800ZCY9GKnLtMcBUq7KXgVDPoemuETymLBEjR v/hV4XQa0YzztNc5L1EOmusY2zbmhGQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pMAUuUOQ; spf=pass (imf11.hostedemail.com: domain of cem@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cem@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681199235; a=rsa-sha256; cv=none; b=oE3Qbxbbx6XatWPwOOsydsbvvQWAGd1iQS6iRw36d9DbnikXhdm2VU9jW53DX45NGRxmn0 XTANKYYBIedMfUyyvBePHm5YiTnFv66qz72NASv/74u0gWTCsuQymwfslXfs37nX0szn6b 37JG1WC9HPde0f3HwXAqalv1VH/vTVI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A543561BEF; Tue, 11 Apr 2023 07:47:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADF0BC433EF; Tue, 11 Apr 2023 07:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681199234; bh=HJ5FYYgDpUem41NoQ8cGQIFYkPRPD9zOKz57ZG3YCA8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pMAUuUOQ2CxJ3N+Jx/jd/0vjk/hUA2uHcRpknqYNlbEJi4OJT1qk67d1xdhg3e5sD ChZRNqu8dgNunix5CRQ/2BtGggLcjnf1IP0Gq9rCNLu1yz7OqEqhpLrkVD86RbAIRG I4bpwUfz6Qsd6OulvgKURo8HyS41O2/hm8WYbNS/AdaVzbGoOUHBmpaupp+O5/ADJn Yldx2OxpOkzO4Z3vR/uGxA2t3LTIQe3jzHLeR4Mfb1hiKgcMD/bHaKED5aQIyIo60u K42BJm2hwTRHnm0o0BHa7Xk1zkLj6U8ICBRKnyKWPmpu3+N66B8+YGg9aDPLf+eQZF T1VK16hxmQfsA== Date: Tue, 11 Apr 2023 09:47:08 +0200 From: Carlos Maiolino To: Jan Kara Cc: hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL Message-ID: <20230411074708.gb7hkp6knxag3qjs@andromeda> References: <20230403084759.884681-1-cem@kernel.org> <20230403084759.884681-3-cem@kernel.org> <20230403102354.jnwrqdbhpysttkxm@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403102354.jnwrqdbhpysttkxm@quack3> X-Stat-Signature: rfz9xb1ar73dqxe5hmh7qzncrgjzzsyt X-Rspam-User: X-Rspamd-Queue-Id: A93FF4000F X-Rspamd-Server: rspam06 X-HE-Tag: 1681199235-329282 X-HE-Meta: U2FsdGVkX1+bBPjfpB/phBHJLk7Qw5FNFUPKJLTqcdlDRfxN9I61/RfjJ2+6+X8aSJ/TClvSfIwWhnB9S2KVbLmDkGibrGv334ux02M79/yMDunswBdV/stGwHzGe5ZXFWGtMicEzjRYatDnyNlw/CS/JqUbLFf+I+jzf1DaZYwflkJAYVSpPN7ml6huBjZIMdT9KlhNAN/k3/35oWjRGcFKECWR5dSTbs/iOLeaWQdclMhBDqPN45sUeOIWdIf9Fkr5hXkeBGU518dGxe9rnZAg/eGuUsqKik1rvdcelOTe8w+nhOYorxEy494IKG59ivAQLmJG50N+DKkMP02IzSQ1y4ClbgssOZQLq+Lv56RReh6kkwKJrI6xyuBHSN7izlxQXWjdqI3ZkLfZ1CzJLp/HaZ1wNyKCGgL2XIYhjQTlClGQl7oi+10uj9My9uU/sFW/Zv55/kljefF2llylxhzWQ2VYfXAbX5ZXHHGD5Boe2PSxOAe7uSZCzP3PS522udFFM7Syh5JYtWXJ+odzPwGn5GHv2Cjk4FTuk8E5Lg1f3iD9mnwAsAuO1uVf1jSs3Koi/fiOVqBC1vMlOvcwt3X5xFTYQfHRZA+LGQ8m2tvG2VbCrEv3mCadOZx+N+Y01L42PzVxd9mmA7Mp+njK+Rf+lGP1S5a9SPXCu/KQ4ABu0hLlpvA2s3vrDg/U/uhKn5qY9zuYh3ZIi/HxGhXkv5Tj9+bIwYbxfSOb/mRd71nCm3hN1dKPQLfrvW1UCAJ8KZ2iytvwl0EoZ3I28K5k3dvI6QHHjLgyxRFJnBJMNu/yuwnUW+JbykFrL7K06nYQHTJSIq8h301MmdxY0fYyCOZzhlQVppVZM/muz5lsIEbpCbk17MzMq3RKugePnIBYuKNFlZ/ubFFZPN5F5Exqm6E9eWrSNboXusTZ61qLFyFP/FKwObhZ2/3L7mBi1VNha6tEFfrQ719rOGutVA3 APLVYCp4 r+x2Wo7sMRe8ev7TeHB2x49kJQdJ/JHecOnj/ZGTl80yR9Vq6TWwUXoQlQNZTNqhTwFUKL0e81v7yYb0501eilbjFg0O5ZgtDp9BM2qYBIAAD5RXzNp90GRgoeownS08qbExnBrI3auhpW6qvxMGrlsa84MwTuuRvRH7UgYwgL9SMGxymlTSxkbAtBFisa+YhSj5iLAHVY0dcct503s57dJl4P/axBUHv/kYuJwrYMAhSkgKzikK1dvxVhXMQ98k8OBLyS5aQMvsd2sB6K8AM4vqQvcCgNlI8H3tOE3JUQeduJrybdvL4pHLwADn1PNZRvuFR3WeHgl2kyH9o2lcpk/mlWO5q66OGAnD9kPa4rb+BMrSG51xP5EN0DOqFNVtIEtHEESsPk2rrJSsGdMnnqSOUrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Honza. My apologies it took a while to get back to you on this one, I was accumulating reviews before running through all of them. > > inode = shmem_get_inode(idmap, dir->i_sb, dir, mode, 0, VM_NORESERVE); > > - if (inode) { > > - error = security_inode_init_security(inode, dir, > > - NULL, > > - shmem_initxattrs, NULL); > > - if (error && error != -EOPNOTSUPP) > > - goto out_iput; > > - error = simple_acl_create(dir, inode); > > - if (error) > > - goto out_iput; > > - d_tmpfile(file, inode); > > - } > > + > > + if (IS_ERR(inode)) > > + return PTR_ERR(inode); > > This doesn't look correct. Previously, we've called > finish_open_simple(file, error), now you just return error... Otherwise the > patch looks good to me. I see what you mean. But, finish_open_simple() simply does: if (error) return error; So, calling it with a non-zero value for error at most will just add another function call into the stack. I'm not opposed to still call finish_open_simple() but I don't think it adds anything. If you prefer it being called. I thought about adding a new label, something like: if (IS_ERR(inode)) goto err_out; . . . d_tmpfile(file, inode) err_out: return finish_open_simple(file, error) . . . Would it work for you? > > Honza > -- > Jan Kara > SUSE Labs, CR -- Carlos Maiolino