From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B21C77B73 for ; Tue, 11 Apr 2023 04:31:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEE186B00B6; Tue, 11 Apr 2023 00:31:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9EA26B00B7; Tue, 11 Apr 2023 00:31:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98D6F280054; Tue, 11 Apr 2023 00:31:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 88CE06B00B6 for ; Tue, 11 Apr 2023 00:31:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 38D874047A for ; Tue, 11 Apr 2023 04:31:34 +0000 (UTC) X-FDA: 80667836508.24.D744BCA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 711A31C0008 for ; Tue, 11 Apr 2023 04:31:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PHuqvFNE; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681187492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x+X5JKgeB9hF+WQJjA7z63RwZbTdXMnOFL97GwJdKw4=; b=XwMxmgTzyIo6QuBZ6tTE3Rs2Yej+ks9SBb0GssxaofotBbllIsb42efLU4tkmp5d+8pOeD 4/x1ajiR120CWWfVUAVbcZijWiN6yb6wlJBPtjxKmGsI+62BrOt35BqqMuRKT84IdJm52d sKf9rknjWywjr4zAb/1EdMd6dRTQYx0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PHuqvFNE; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681187492; a=rsa-sha256; cv=none; b=T3EP9iz0sRuRuZ/ynw8r9ZhIZ2er6SGNBg56ZjrfR0h30p+UBElMMxg2nty6iUcOZFrHpT IuiBj0huT+oR30Jxym3sqCdK5kr+9UrtMhTDcc+Bc7oCklT7dWR/znVr78vcUX0hRH/F02 cq00xPpThWNwmSgtkJA2/+yL5fQEc7s= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F073616EA; Tue, 11 Apr 2023 04:31:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86E83C433EF; Tue, 11 Apr 2023 04:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681187490; bh=UMffUmwIMqiyU5UEzuN4976TTEXDP9TPdjyhgMkWT4M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PHuqvFNEJrcTTZehVURel6pvMxSQSQP3xjWTrs9QuevRX0eQSR5KeWtJ56mF0OcW0 aEqUniHL+M0Z+UE/BhmzAsukPR7zLQ2h7TCbR/Cho5BwOVlM5CSgxD3SGrI0WCheLT cgdWifzhlzscoDKTVx7FVWzN9ACF8QplOnsiDWW8= Date: Mon, 10 Apr 2023 21:31:29 -0700 From: Andrew Morton To: Cc: , , , , , , , , Peter Zijlstra Subject: Re: [PATCH =?ISO-8859-1?Q?linux-next]=A0delayacct:?= track delays from IRQ/SOFTIRQ Message-Id: <20230410213129.1d11261892767a61eacaefba@linux-foundation.org> In-Reply-To: <202304081728353557233@zte.com.cn> References: <202304081728353557233@zte.com.cn> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 711A31C0008 X-Rspam-User: X-Stat-Signature: foziw9xddmjb4m3k1kps6kz4x8w73fir X-HE-Tag: 1681187492-565875 X-HE-Meta: U2FsdGVkX186utLMnOSFNW54QNU2u6Qb7dCR551+ua9NT/7CNbB+2xL+uHBquvLbdLdrxO9wi+7AMVI46UFa80oNCAI1su7soPmAYRqE9ffUCKXEibtRvCguIOcWKijI7OJMXrSfem2KdS4EgYgACzQGJfwQ15m5t3RouIzfskjnT4jhydmIxQEIZ7KK/2qGmpX0pVvSUV3fmHWXJYp4uAvmK8lBwC/2we6/Svjyi15jTiLTsdZM4gySNWOoESOxY1hysKRwe0QCeii+J3xlqatfTLo9btXxmov/mDsB3Dy4z6kCdbgUZ9jvdoXrkcPmGCsSABIasszx4z3EvuJ/ZsKfQKr5uFWTq1yGPHfVimLU4uGZe5jR6kupOwhiERmBC3uidNblTXoJrhybhP0Dq9g9Bu1WPAc8ohlsaufM4lchicRYgZPFiZ9mc0kNNCuBuJ8qd8s8SjPwp6uk/lYMKurKnwwkgqghdi95Y/t5MMGOHGg6UMKgiUCQuCMTZZO1jY8YK/LiTt6+/w0QSGmbP+6ZN2FYYoBTDWOKN78mEpkNaiiU1HQ13e+S5ViuYdRJcQEcqEACb7t1QxOu3Uvf6tKA7cwdgfx2EjkZt4O/P/hJBiJM/IVXNhzHm8z6i3t8rDM8B23hk6olGMWI/hoZgCQ4dWNP3IzT2XURgDE4hRwVE/8qv2mJDIr4tHNe7GAMhk9IGmLvxP9nLtg6ZlQbckY3dFy18r1yp+0VVJQ8tJCfr+ImN+q/imCxJPk/fvq65+ZDAvxRBdCYCUED4T00+NeYiO87dgofODt36OvA+SYySPm+9+dQcLChxkmPrggxbIWiKqfQK98NcGYX9t+otF/L6n+LOXYYAA1V0nELq9VpkjEmLw9VJQl93tcPbZXeSbflOzRqzFgKSplCDMlM/06qHtyo/Yn2Bvqmsl53HfMvmcGIwmhecvKaJMiq10Wwl/IO0HzsctjlAXSBjEu LX0FSw7s IVK7mec1qKpuO9LzGeS3gvA/S/+PfQ196qHbjDwr9mrRapJycrvcnZ1zlawI7zBOOlSX+oxR9Oe3qUN9UDk3UtyooS6Yro4Ikq8KfUMSqGx+rWZykuoBW0HjCrkQlQ6+/GdqwPB5OmzIkA1MHCgaNx1YSt+ymzb0eqBaz4CLXMhNgkjPoUjAZdt4ZfA4MScmbX6siUdbNRnetBPYoNKiaPca1cPEcq7Yc2bveU2DjDy5/bAWfvzYrq1k8+WyXZ9gQu+Yf3wsGRBSkX3R0IXMGdrPUWw2bdWs68tJX12ZB2+KheHDkHAEG77ni8ugTUEXIL77/sOAiaZZtbqQmsZCc2AE+U4yOb6YpQZOjbJ5VDhnIhhOqJoyDnJXOkaJdaKu6MhIe3j0y/YwPZUuu7/cSZVFJh+A+2qUkJ+nN4ucNSBFlgRk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 8 Apr 2023 17:28:35 +0800 (CST) wrote: > From: Yang Yang > > Delay accounting does not track the delay of IRQ/SOFTIRQ. While > IRQ/SOFTIRQ could have obvious impact on some workloads productivity, > such as when workloads are running on system which is busy handling > network IRQ/SOFTIRQ. > > Get the delay of IRQ/SOFTIRQ could help users to reduce such delay. > Such as setting interrupt affinity or task affinity, using kernel thread for > NAPI etc. This is inspired by "sched/psi: Add PSI_IRQ to track IRQ/SOFTIRQ > pressure"[1]. Also fix some code indent problems of older code. > > And update tools/accounting/getdelays.c: > / # ./getdelays -p 156 -di > print delayacct stats ON > printing IO accounting > PID 156 > > CPU count real total virtual total delay total delay average > 15 15836008 16218149 275700790 18.380ms > IO count delay total delay average > 0 0 0.000ms > SWAP count delay total delay average > 0 0 0.000ms > RECLAIM count delay total delay average > 0 0 0.000ms > THRASHING count delay total delay average > 0 0 0.000ms > COMPACT count delay total delay average > 0 0 0.000ms > WPCOPY count delay total delay average > 36 7586118 0.211ms > IRQ count delay total delay average > 42 929161 0.022ms Seems sensible. I'm not sure who's the best person to review/ack this nowadays. We're somewhat double-accounting. Delays due to, for example, IO will already include delays from IRQ activity. But it's presumably a minor thing and I don't see why anyone would care.