From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7D6C7619A for ; Tue, 11 Apr 2023 04:01:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 098D86B008C; Tue, 11 Apr 2023 00:01:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 048DB6B0092; Tue, 11 Apr 2023 00:01:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7B02280054; Tue, 11 Apr 2023 00:01:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D93E56B008C for ; Tue, 11 Apr 2023 00:01:46 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A23E21603EC for ; Tue, 11 Apr 2023 04:01:46 +0000 (UTC) X-FDA: 80667761412.14.05BACAD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id D388F40006 for ; Tue, 11 Apr 2023 04:01:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="k/rSfN0G"; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681185705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=izt+IWsBXCuCfI+QeqbioSxfETpO1Ii83MUdTzKITBg=; b=1XoT7ZGW341ZSwjcDvc4WzoC0m+HovRnXjPrKBIxYCmu7NH7djjbvAMjcoF2Xreuhu1Q1w J9WJ+Xqy8JSqSixvvyFOBuWxQv90V1qcwCjt5NgsWBvs2uJSW0szylLR3wjE3Hrbq4RUbC PUAuIcBLF2cZ/lBK7LiW1TkdS/Qb9oQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="k/rSfN0G"; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681185705; a=rsa-sha256; cv=none; b=EPkEdK7qgsvb1/x8ao6aHGbwxuosngKrVd4qXJ+iq74wji/H5AgbXOG2x0LW9OOCAiKtta M77B5wkpSEgDn9LE9t66cfBSjCEOxZH1JkgzXp4ma1x+HYoMX5DPSLRFclxPjvrYHvxHvX DDxXG7UPuao5GeHK9ZyCW1DBTAvFzSA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5B58561A70; Tue, 11 Apr 2023 04:01:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E362C433D2; Tue, 11 Apr 2023 04:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681185702; bh=HFcCfjMjSwhvTHBboit2JX2IkmCKUJk3G1R9ZYyYF1Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=k/rSfN0GUVuVoGdVi+y0qknccHGcl5/uRhakWeMGLzxHuuJrVKBl4H+12PvnixjoV y70O8tO/qrMg4yY/KL9/LF5GAiqyKLMA50xPaXdd6twR1M8iCFykrL0TdSoQA1jMVC 4TAni3xfw+Ex77aN2ehWjfE63bTnlKgqAkav2IAo= Date: Mon, 10 Apr 2023 21:01:41 -0700 From: Andrew Morton To: Steve Chou Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jiajian Ye Subject: Re: [PATCH] tools/mm/page_owner_sort.c: fix TGID output when cull=tg is used Message-Id: <20230410210141.678bf917bfce759caf9d18df@linux-foundation.org> In-Reply-To: <20230411034929.2071501-1-steve_chou@pesi.com.tw> References: <20230411034929.2071501-1-steve_chou@pesi.com.tw> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D388F40006 X-Stat-Signature: q57fxto5ng6j1uj1szynsfj83eaj4idh X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681185704-193818 X-HE-Meta: U2FsdGVkX18KT38ChH1r0fDH5hF1PBGrRzxLOGHyZz7f/At9wPZlWbmpinaqGd72LjbWjvVkX8orq7KfXrN/J//1DLfnsDStiM4HREksMaypR1ldOizoT8XXP5/13Tjd3hjEy1mgeLpJnqtvcLVpSdspEbkfllKmBOE7dj7ZriNOnKbAFnxLZQiAUBYYshbb8Xm6w5GquMh5vvMD/lvr6Iio+jD8BMrlcZNlB8RLvge8sReN9X2Uf1PfXunXUwsOkdWZJfSbXrrNUF2bnFAmuH0+kFlx6cp83MdndCacKYdEJj+x1Cu8Lzp2cIbgfV+yk9ai6oRKmW8SGk4a3LldZcguZzE/lh6vhi9jTvzhuIcd9IPHsfKfihZl64FZoURcTHpyuKRWDP3tbnJ1ROxfICfV3qNTGeMxCwVfFeimnnX/bTpsjB8gtWNxKFy1g70lGGJFC4E0sM3eaU90Sgv2Qb6hlMZV3dWFenqYgRCDBIZGW371Z5T+cYaxUKNs61Boi87TTW6LSLglzYQn6BwoSakEgJHwhDu2LXSezskR4XyvycWCIe5gzDFcMeaEhPttMzdtBWiG/t8avjoYSg8qrZGCDKhRLSH4TCLoj9rsCoHD0Uld+WnaizMrWPlir5eRk+JtSB8Dwi3i3voF0itNS99YjcAdwmOy94yvnaamwNrCBsihd8DtH0th3wf5G5/u0/RPW/mwhutlVqLYkvtHY9ZnE1xDlYEePUa0OLm3nLLD/X4jKuQtIPJTnrUipgreb/a5XBPx/k5CAoIn941v929cMzhppPP18qk/ciRD4RUOoZDQkLb2n9Tg/IsgAMo6nbF6t5Cp1oQkPCNkKU/zmXxf5seE1oYQiocYhcDYpX7LABQvylP21ocgvULdSkCVq5u1hU3rleFymLJkZ7tP1/mrEOFRAaFXKsUvQo/umr961bPQz9ZM6T3jadRrBCWL14vnKNHQD7xxJuVwCLU 3ElLeAs2 8A/VVSpcCONli8MtPf2aJVLh3C0qoKXRgVa1Keo97825PPfjdFycpTAz4d3M7XHgtpgxfXTEv7lKs8uLxi6NAjPe9DP2mdw3SKqWb4uIs1LMlPFCdZ50fdRQ3DpobtWI6OY/zPwAX2+oyU961mVPi2TmY58KHu0DfvxRdELDdVrXGsglFieVElmuNexs1AXyXD7EOo8wIa4E+qC01SlaEJ354iwJoWMnyTDp9ywnsEZXzhwy0/CWBzHC/NuptIjI+/wsgejthaff8Z8xQnjj8rccnBG+HEQB0WPhOgGX8mtmMx1k496GEj/DJuOyPJ54hvjjP3TbT18ih8D0FHpjViIKO3G0DK6jr3ryq2jigmIxCdN3cd6Wh5cJMWZfuKcds7tCUwpAGCVqLA1xuXtqdlq+qt56jBOrgS1C/UJI9QubiNQIMjAL8XXOjedTznKMz/02t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 Apr 2023 11:49:28 +0800 Steve Chou wrote: > When using cull option with 'tg' flag, the fprintf is using pid instead > of tgid. It should use tgid instead. > > ... > > --- a/tools/mm/page_owner_sort.c > +++ b/tools/mm/page_owner_sort.c > @@ -857,7 +857,7 @@ int main(int argc, char **argv) > if (cull & CULL_PID || filter & FILTER_PID) > fprintf(fout, ", PID %d", list[i].pid); > if (cull & CULL_TGID || filter & FILTER_TGID) > - fprintf(fout, ", TGID %d", list[i].pid); > + fprintf(fout, ", TGID %d", list[i].tgid); > if (cull & CULL_COMM || filter & FILTER_COMM) > fprintf(fout, ", task_comm_name: %s", list[i].comm); > if (cull & CULL_ALLOCATOR) { Thanks, copy-paste error, I expect. I'll add Fixes: 9c8a0a8e599 ("tools/vm/page_owner_sort.c: support for user-defined culling rules") and cc:stable.