From: Andrew Morton <akpm@linux-foundation.org>
To: Steve Chou <steve_chou@pesi.com.tw>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Jiajian Ye <yejiajian2018@email.szu.edu.cn>
Subject: Re: [PATCH] tools/mm/page_owner_sort.c: fix TGID output when cull=tg is used
Date: Mon, 10 Apr 2023 21:01:41 -0700 [thread overview]
Message-ID: <20230410210141.678bf917bfce759caf9d18df@linux-foundation.org> (raw)
In-Reply-To: <20230411034929.2071501-1-steve_chou@pesi.com.tw>
On Tue, 11 Apr 2023 11:49:28 +0800 Steve Chou <steve_chou@pesi.com.tw> wrote:
> When using cull option with 'tg' flag, the fprintf is using pid instead
> of tgid. It should use tgid instead.
>
> ...
>
> --- a/tools/mm/page_owner_sort.c
> +++ b/tools/mm/page_owner_sort.c
> @@ -857,7 +857,7 @@ int main(int argc, char **argv)
> if (cull & CULL_PID || filter & FILTER_PID)
> fprintf(fout, ", PID %d", list[i].pid);
> if (cull & CULL_TGID || filter & FILTER_TGID)
> - fprintf(fout, ", TGID %d", list[i].pid);
> + fprintf(fout, ", TGID %d", list[i].tgid);
> if (cull & CULL_COMM || filter & FILTER_COMM)
> fprintf(fout, ", task_comm_name: %s", list[i].comm);
> if (cull & CULL_ALLOCATOR) {
Thanks, copy-paste error, I expect. I'll add Fixes: 9c8a0a8e599
("tools/vm/page_owner_sort.c: support for user-defined culling rules")
and cc:stable.
prev parent reply other threads:[~2023-04-11 4:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 3:49 Steve Chou
2023-04-11 4:01 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230410210141.678bf917bfce759caf9d18df@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steve_chou@pesi.com.tw \
--cc=yejiajian2018@email.szu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox