From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C77C7619A for ; Tue, 11 Apr 2023 03:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A10336B0088; Mon, 10 Apr 2023 23:59:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BFC36B008A; Mon, 10 Apr 2023 23:59:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AE7F280054; Mon, 10 Apr 2023 23:59:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 789E36B0088 for ; Mon, 10 Apr 2023 23:59:03 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 47745802C0 for ; Tue, 11 Apr 2023 03:59:03 +0000 (UTC) X-FDA: 80667754566.22.0BC6D8F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 84DCB180010 for ; Tue, 11 Apr 2023 03:59:01 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BInDaczb; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681185541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S9pQLq/+PNiiyTzyqcl32LBEeyR30O44UFmzgEM9ki8=; b=7/5YEgBGvEf+J2zUGWWls1BOiY0spJH3GOXdeXjeiZPYM6QWeRZdilnyantmMgf/NalUdE /xf4ApTvuYgPno1xud6qFtEzDnqbmJH25/BPXddvgNwOCcK0EiVpmiT1JVB89OSneNvxsj 0MJk+xkMUtdild85WrzktNQvaYqDP6A= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BInDaczb; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681185541; a=rsa-sha256; cv=none; b=Bm0atkoUSzaA646NCzKE9TaV8boWqff+4JKed85YgI2D3wEIeqBpPskNra0CDhx/WImH8n 9OR5bcL3Z2T4Xe7810EgYNkGner+UmLqMjFJWcG8Morg6nm+hdiW52Dwvc8UublOuy0MU/ IsQYnFDdo8eHEkeerTbDqBW3N9xm9NA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A021E615A1; Tue, 11 Apr 2023 03:59:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C03B7C433EF; Tue, 11 Apr 2023 03:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681185540; bh=ysMBOb2Dvl1FfFehaRIlhqrwfBY5Os8ctxq9hZuc2vQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BInDaczbywhfbiGGix6YCGkT73PVOcZhQHfpOAuaEd4J0IGYaohvGY+JHeNIhas5I EdXKmeXJGS6vHjP6me/MoSRy2uJ5NqkIEjGJxNVBqNo6osnjbWhCAs+khJC5Tdd8/A p77yVj5wmTQiE/eN1GH/1zeKzbXQpCvcsvh0SNh8= Date: Mon, 10 Apr 2023 20:58:59 -0700 From: Andrew Morton To: Peng Zhang Cc: Matthew Wilcox , Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, David Binderman , stable@vger.kernel.org Subject: Re: [PATCH v2] maple_tree: Use correct variable type in sizeof Message-Id: <20230410205859.8dca31a8c0cd54484c60c07c@linux-foundation.org> In-Reply-To: References: <20230411023513.15227-1-zhangpeng.00@bytedance.com> <20230410202935.d1abf62f386eefb1efa36ce4@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: d8xqtzpeb55wy9mbohskkppzekmz9e1b X-Rspam-User: X-Rspamd-Queue-Id: 84DCB180010 X-Rspamd-Server: rspam06 X-HE-Tag: 1681185541-855794 X-HE-Meta: U2FsdGVkX1+r8SznTBSFIG9UujOnAHnMBCk0hcqtPirEppWKdW2yfxF3GH1Jt9/7UaV9NxrrcfPJZ6MSZz6FfxOUvchV8OHQZatgpALpLrLpWZNC4KjYfHD2XCIkM0Mx8qCRbZjJdg9/VgvyrwqLPdilNe0uH/UMX5aWWpHd21puljvaow1VDtvSlo98xvaKlzm8N/8ko6SIUQi9faH9a7JBFrW6nlVzdx8VfsbPcXn6v2S2C7p5J/4dlK2ps3z/t4osGl2eHO4pswkv3RseKxu1LF1nE6ayb4rrP28/hdXFOLwSCw8tAu95ag1MtLtAObKFLQDLwlPi6zMBUv989rkc/2OYJ1iWCULxJMSFJ0lfbtOt4hXmzIab1Pxeaz8bL98sI53kJfJHAqlp5j5pUdKkYwY/m1watCox+Jo1GU8kdolooDEfxv99OXRRyHj9CNY55VAjJld1AJU9d9HhO70c6r7Elq95MTA7CwNjZixJe/uRfaZhhV0XVqZioAcn3uoevYXHVVhCNi4UQcLWd97Nr/QogpI9CA3m24iNTxKJ3QfUHTKl49tJTOzOk6Tt3LFM2+39alOmqJ9JTeJRzq+qPxbIzMau9BnfSJxtqEeikBpS6TXaq3qIdU8SHoYw92bSUzOsEws/yEfOWGUu/vQZBuplhez6qcMuPW8Q5Zu4ba919fgNgJGIsIVioUR8SGBh0PhKiCeL5ScmX3xptDAOMS7rWnAH+VJg0xO9iHVfP0qg4fEbk5g3Sc2EgFe+oLugGLF3TTHC8o3UdNW3kGS5dw+9dQ42CRMhkja9+mAhnF0jANLHsTIdzqfUruChOlywib+ldlsQtkem3xpLJ1ifvIEAE/12nzwm2jgGTZNXcPBy3L/UTrahsF7kq18HUlM1lW4C3DHUiz5qBruUS5S+HC4s37iIw0z3eGnGenP5yrjp8Wu7/1y9SPHWjV8S1/O7hmkwjlwSf5aKovz jOGrz714 40gbXDUNDm2Oa5ENFXRjyIFFGWiCGf8KHWwo6m33DWxl5GjtSX2w9E+G9tssK7mtivleYQyi0Zj6fnBlOjyq/aAzFLyuWFSw1OCC4YStH4SjNzTkjAUkx5BmaIY5zwwlGjbuKQML3gAF8foRIpte2bJtlGKg23o+a4WG2orWK6ZVX/lB6Zbli674iQmto9MayCy1yc5bd5WPahOLdSHIA1wepBDyjZEVjbBDr0O42Bikj1LYt6hGts2dYv8Svju+qqI+d37xgGDI1EPGCQ17p5u1n1jyS8YDpIf+eRdMWQS9yDSKQgUlK3W0+oKJtkTDo+59c5bpnWs9iQ01Ce7wEy1mT8cnpZEP21qtEhhjDh6l4f9qisnlbWE6Vr+RkfIZnnFlCgiVNGGkzFQUuEyFMvln9mriR7tmUXjcLVlrlMCRC2WmlrCWBLz+HTmoHo2sYV4VG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 Apr 2023 11:49:56 +0800 Peng Zhang wrote: > 在 2023/4/11 11:42, Matthew Wilcox 写道: > > On Mon, Apr 10, 2023 at 08:29:35PM -0700, Andrew Morton wrote: > >> On Tue, 11 Apr 2023 10:35:13 +0800 Peng Zhang wrote: > >> > >>> The type of variable pointed to by pivs is unsigned long, but the type > >>> used in sizeof is a pointer type. Change it to unsigned long. > >> Thanks, but there's nothing in this changelog which explains why a > >> -stable backport is being proposed. When fixing a bug, please always > >> describe the user-visible effects of that bug. > > There is no user-visible effect of this bug as the assembly code > > generated will be identical. > > Therefore, if this has always been the case, cc stable > is also unnecessary. I removed the cc:stable, added This change has no runtime effect, as sizeof(ul) == sizeof(ul *). and staged the patch for next merge window, thanks.