From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D368C77B70 for ; Tue, 11 Apr 2023 03:29:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1A3628004E; Mon, 10 Apr 2023 23:29:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CB1828004B; Mon, 10 Apr 2023 23:29:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BAA928004E; Mon, 10 Apr 2023 23:29:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 77DD828004B for ; Mon, 10 Apr 2023 23:29:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3CFC3802BA for ; Tue, 11 Apr 2023 03:29:41 +0000 (UTC) X-FDA: 80667680562.01.C9BFAA0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 883BBC0004 for ; Tue, 11 Apr 2023 03:29:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=euv2XbmW; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681183778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YCS2thbhgNL9GnyC09Z/cIei53FU17GkJ5W0jhwkNfs=; b=46zXI+v/YsI+lwz4yJJXRicENQuAO3gdCeK2LdAXbb7n0HxGoub7H/uxBpI6yCik2i7Tsf 24b8rFMCArluiqZD3OKabQUdAvEIE4SmEtaYZiVi8VkZH+aXEVHhDulDkY6EPHs3m2/k4e snjIGYRweITGkpLodricX+06daSBWZk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=euv2XbmW; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681183778; a=rsa-sha256; cv=none; b=LRIEtytMBIw2gsyejulRIQdCo3Bt7qkZPAPeJ5Wdy9zstW1yIm5rFE/AJtX8WzbCJjA7tZ NBjNDfyWtw9Pfd/HZdNSbsgJ7M1/lLWn5MUA/dj3Nfhzu6O0xu/LqExDbx7GvtPKcGKBFa TTewdwqiP/zbnKrbfhH0adVvxv+mMDg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CFBC613E2; Tue, 11 Apr 2023 03:29:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64803C433D2; Tue, 11 Apr 2023 03:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681183776; bh=8LDh54v+qQDwP7GfVmR9n31ko7S3dKLDiRvUJ8KDTLo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=euv2XbmWvZz54H6/qkrcpFrK+4KsVY+yii8cCib+J6kGceO/xaqWN717ECtugvyhC 05/WCCY8hBFDs9/hsC2YHKbNGF3pni9u5q1g+FsPmjyW+a4Q+iB6jZYdwucChI/l06 tMGN2Ovb3NmNUFh40njg7tOsytb4zYZPj6qswhlU= Date: Mon, 10 Apr 2023 20:29:35 -0700 From: Andrew Morton To: Peng Zhang Cc: Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, David Binderman , stable@vger.kernel.org Subject: Re: [PATCH v2] maple_tree: Use correct variable type in sizeof Message-Id: <20230410202935.d1abf62f386eefb1efa36ce4@linux-foundation.org> In-Reply-To: <20230411023513.15227-1-zhangpeng.00@bytedance.com> References: <20230411023513.15227-1-zhangpeng.00@bytedance.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 883BBC0004 X-Rspam-User: X-Stat-Signature: 5ae3nqbzs7iw9gapd439h8r8mcauhikt X-HE-Tag: 1681183778-460293 X-HE-Meta: U2FsdGVkX19RXlEW+sQoWIDqQrQQp7CriXuF5zYXnI4vChBZBj8GHU8YkRVVMVSTCjdR71nJxawv1xVLryr3i/S1hWP1JLsCi3Lu3lTDynezox8k59AL4SgtzQmB57ywhC0gNTfOYX+iC7CASuKxVflT7EIipZP8BKX3DryytOG6nbeQuet4sOljxmegPZ0eisZMujPdtgsKKHisy0NNjod8vtFxHWYv2rAZyn8ain5YC/xmwM2GGJw1DdFIAiMpBNBxhj6zypX4fWR8rwCvrh4z0dD/1xqHk1v6fhWFIYSDursRuEuX2ML7znNHEP+4XbQGgGPXACRUjv96JF+d7eHCC8qfN3zEyqBJKulhrAaEZwrEa8RUmL1GLAM3Sczka6Xv09b+HE06Vvrs/3E10ePvEeHv2LzuamZTT+4FtCvXNPSNtPw8vlQ828KDjg66kgGq49aC/4QVqWutwA0c/gJKMcbK1J4+f3fP0mVgFHX438Xhm5VjSkVTF8XMMVcC5ce+ibjBEvT3CAV8VlKyutbxImxzAmW5lsK8J9SKs+5bRPHYOPEOY/+sHqNc6inDXd3Z3NJanPllg4G2DOuig0zyRbl8FTQBDkM8+yJv6BUzLyPuwI6gdUuVVytMV0pIAlyIloVLDt5fp0l/mJtXEO4OxwLAzlGKk2C6o2qujyuE3qx2VL9+RO7V77EZv4B/Gc8kuo8sdXqxafRbEMF1wb5Il0jPm5GDyUpP0324tyPezsCVqiA2YV+tQlpIyaLvd0ANnf1Fr8xgu31x10Sf4qo9KrTdIqbcX6kkr+iP1t7l1zrPqmJT5ti7QV0pN/TMgHCW7oIpvFef9V2UKCjKS6GDk6dSJLWdkYcn+VZx77ZuAKM0uo4tub/2aidOunlRnEjdX3QutqTUOGJ72+8e3YhFmaIrXZcyjM5JaXzncAVDzGQ+UMgNYrODSvcyb0N+z7jW/TdrDNdr32A4fgy ZLXnxr1R qeh5GLkBK0dOVXNmTUGua2/rsV95rsI8qP6PfTwzuD3sLep2Zela0ytstBqHIO1QooyhPB1tOWTFpGfFVeKif5+dp/hu9+gkYBfpK6YApO15BA4FfmJy7uqVJVq2oCeuQw+V/wK0TGXi7I03/IllqBDMIbTfl1c4K56qLNcQswfK5YISsCQm6MUbC7795vBAUf6V2xiFDrcEUyioK+oPEL9DFTzsT18Txyoy3GEKUIp+xl0miXt1Gu0zLPAnjSFrNNTnYcInZV4foTaG3A8IJaMX57fnYMBtxuN4ZXnaKDbVotYTGAo/kUdhEktnFb3+2qSfXasD9oQDnGzPfqVlYsFpSjc3sNzCF4zoEOyovnx5nxE9dRlj+EhwRicW6yqq+NxI5N0Cod+KgIfHONMa9SkK4D8ExAMPL1CFlJiSuQ1p070JCUXOsn2Ad5EXgOCn4dVct X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 Apr 2023 10:35:13 +0800 Peng Zhang wrote: > The type of variable pointed to by pivs is unsigned long, but the type > used in sizeof is a pointer type. Change it to unsigned long. Thanks, but there's nothing in this changelog which explains why a -stable backport is being proposed. When fixing a bug, please always describe the user-visible effects of that bug. > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -3255,7 +3255,7 @@ static inline void mas_destroy_rebalance(struct ma_state *mas, unsigned char end > > if (tmp < max_p) > memset(pivs + tmp, 0, > - sizeof(unsigned long *) * (max_p - tmp)); > + sizeof(unsigned long) * (max_p - tmp)); > > if (tmp < mt_slots[mt]) > memset(slots + tmp, 0, sizeof(void *) * (max_s - tmp)); Is there any situation in which sizeof(unsigned long *) != sizeof(unsigned long)?