From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E577C77B6E for ; Sat, 8 Apr 2023 00:33:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB6B8900002; Fri, 7 Apr 2023 20:33:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B408A6B0074; Fri, 7 Apr 2023 20:33:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B950900002; Fri, 7 Apr 2023 20:33:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 849956B0072 for ; Fri, 7 Apr 2023 20:33:28 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 59BD1A0227 for ; Sat, 8 Apr 2023 00:33:28 +0000 (UTC) X-FDA: 80656350096.17.6B2A696 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf23.hostedemail.com (Postfix) with ESMTP id 1F99D140004 for ; Sat, 8 Apr 2023 00:33:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=S1gNZZli; spf=pass (imf23.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680914005; a=rsa-sha256; cv=none; b=7J+Mg3sSIpp/5Qg6mwfarjn5e635uw3WwlSOSnLELqqZq9mZDFmWFupWur4AOPRg5umwJt xr8bQrNhYHeNLV1NM1jLCPqAmXai17Yl/XrfceL6g0BhN4fpwf8EF9L/AeoASSRmQPvr1S AUJXFNCmGyxTZCiAbXIAn+aaD24R5X4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=S1gNZZli; spf=pass (imf23.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680914005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IMcMXhNQ2kYaeyD7Q8JjM/AX7IbH3crjNP3dkhFqoY0=; b=niLkLJER8veWo+up5K/Z3n6055QSW1Gp+A4re2x32vcQ2YRRKEaseHhPkaY6sW4HHwIEXd sgIUu5IJqPp+0nqIecl3asmACdmNh9qcwvhtofCYNvxoPzsZqdlFk2SMBkgWYxI7LfYD+I B6PZLhh0Hg+/j++/zQfLx79gfZW7zoA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680914005; x=1712450005; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+4kq+ByesKZ4cTl2OIrt3sTsul9XMQzu+dHP9ObqPHM=; b=S1gNZZliODVbhXXNrEeTI7R6LuV4MoGsoHzt6VifY7u7m7bCGQb7zD7p CRLdUrGuh7ApHu6JNvd2Pbhvft3BVGwB3+fNRjrBvjtZRVd83ZuuEsvRC /KUW4ahhvo40FKzFnnvhPZdq0VC45fyLh4ZlwVZxuFByBgAwx7osZoZmq V1W3Och49DINR0XWxjLrZ/Q5CbtQSNxvJYOp3vBPvCE4vIrORLg7tG+QP O+oNnZxK/vsMGy5FkMwXce4e+6dqOjUvxLY8fgiGoOZwHL6OANZWbZynQ 8mmEYO6CMNQqdMKP0ux++oLJe17MFR7BxgkDBxmD26zMNVyXSmAfVHUTI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10673"; a="345749421" X-IronPort-AV: E=Sophos;i="5.98,328,1673942400"; d="scan'208";a="345749421" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2023 17:33:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10673"; a="717987704" X-IronPort-AV: E=Sophos;i="5.98,328,1673942400"; d="scan'208";a="717987704" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by orsmga008.jf.intel.com with ESMTP; 07 Apr 2023 17:33:15 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pkwW2-000T4T-3C; Sat, 08 Apr 2023 00:33:14 +0000 Date: Sat, 8 Apr 2023 08:33:14 +0800 From: kernel test robot To: Kees Cook , linux-hardening@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Kees Cook , Andy Shevchenko , Cezary Rojewski , Puyou Lu , Mark Brown , Josh Poimboeuf , Peter Zijlstra , Brendan Higgins , David Gow , Andrew Morton , Linux Memory Management List , Nathan Chancellor , Alexander Potapenko , Zhaoyang Huang , Randy Dunlap , Geert Uytterhoeven , Miguel Ojeda , Alexander Lobakin , Nick Desaulniers , Liam Howlett , Vlastimil Babka , Dan Williams , Rasmus Villemoes , Yury Norov , "Jason A. Donenfeld" , Sander Vanheule , Eric Biggers , "Masami Hiramatsu (Google)" , Andrey Konovalov Subject: Re: [PATCH v2 09/10] fortify: Add KUnit tests for runtime overflows Message-ID: <202304080811.nYP4KpPZ-lkp@intel.com> References: <20230407192717.636137-9-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230407192717.636137-9-keescook@chromium.org> X-Rspam-User: X-Rspamd-Queue-Id: 1F99D140004 X-Rspamd-Server: rspam01 X-Stat-Signature: r4retrxec69egmjiwsqxj54xhxha5wem X-HE-Tag: 1680914004-148020 X-HE-Meta: U2FsdGVkX1+1BZ0JcPzsEWDslIhU2ROZPxtFVmZSOKelc68SMxI2Ls0sznf41Di7mLkimhAvi7JKcqWXg845HrdHOk5sixHVwIKj/RpKuvE5FMubRlAB/E3S5Rdoom4gfySQwCtPQQVuU1F7yWgjPn0dh4NVxoJ7SFNRI/rydnGx49NiUUjM4mlXG9dLnrW5aAGqyHknAmaVsUFoO6US0M+sIWUTOSiku4+R/DDHJ36rTiFoOU7eTyvN454rzSXB1r0ys7KJTZES68cXbVLKb5rqvYyYXlXAWV1oFS7dTkX+zzuZaxLjAG1L1kall39m5UN2ZaByWpCE79UDseeuQiUkRLPInbXZbPKkSFMViNQFcI0DQ30aKVRNg9b4TuQ8mCGE/jYfPX/rvnsL6zh/TTD36YysxXNBRnGBUrwTszucBZrC6ikpIKhMGYnB71qsPM9EvUHfMk/A+OAtJI2gPpDe0zpy/HE//ocigICp6GYbHcgJg31MusF5zss54vZCubginAVYC7nfUdHBMkhkS1BYsQWeS7RNoDbqzlGFw7/wydBAplHjr5sz0P1XUd66bGPVDT1NsaOR1mHvG7WBuqboQnaBpgxwl58yS5umHT/fHTxjSxaGnJnAcEwhUITYBMpwsz5jZSJiZCYzXuHuNgSXzw6Zu6dcyeDyjJY24eUrfLa1NeAWXBFm+eOwiikpfa9zyGqHCimHEjzKQspKQkYsOQxPQYGnx+mBGZwuEGXNFbT+Yj86sc2zfmpZyhjyLJX7GKbvBcyUANr2gpQiuELBXnHImig40bITkYdOVncXqCRqtctzJIraL5W29HHGcjrvwDEvye6jSp6x9+iGefmec4d9VrZDZwamHoW1Qb2HXhb0pet6ly8pfIk8eXuFc4QJbqgx0XsFnccuR12VVh4PY0M54Kq8VbpxQ1bVVYP0dhCCLbMvui7UM34qNXWUBAq/zG4lvNECDtEQSVV 0Q+mG/Cb Rv3czR2ERuRxAWkMqfI84kazPyra2FuLkGrgaok9p5oc+rkFqX8bFjWBcP3XrZ9YA9Dg6Q5ktN40tAiVHFiaP1ElNf4MbVsWgbXyvljO8dYWLgZLsEWNn6EhcbusqZ2+nX9YeBiwacYZ5r8eF2xo2qvuTjG/uPspj+PpD7tqzdW54SdQDr6Q4BSAv4ZJe04tazl0rIi1q1U4uIHtZI2jXJVU5K2PoXEdRgbAfkWvzfPsVRZDp5hricVZIqs0THSMidS9oFkesqZdeHZDXr3WnC9omkvDqYt5Caq6bhWrd+CSatCaQtx6v9nyy1dR7yViaRoafQiND35zCYk5MYr/vZQJaTJvzwiaIoSNWrglXy4OSZtQqsU5axKFeoWiBwPD8RQftc/q8iE2zUJBn3JpaI9beLM2q+AxR5mnyhAtnNRbSOv9uVwDCjzpVLEgID3C1R+q2Z5UV/KpzHX/688tndbR3Rb8Gb4ODAwZZ6xHAFj3h8VRM6xYMSkPvndJ5QbdhsOs2ZVkwC/KuZvscYEbqH3vdmf0C1wm3xy5MUC7xto2lymOzZMlHJwu2cPPCJ4Eg9j5wrZ3ZCPWjDvNKK6EhpHfJRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kees, kernel test robot noticed the following build warnings: [auto build test WARNING on kees/for-next/hardening] [also build test WARNING on kees/for-next/pstore kees/for-next/kspp linus/master tip/x86/core v6.3-rc5 next-20230406] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kees-Cook/kunit-tool-Enable-CONFIG_FORTIFY_SOURCE-under-UML/20230408-032959 base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening patch link: https://lore.kernel.org/r/20230407192717.636137-9-keescook%40chromium.org patch subject: [PATCH v2 09/10] fortify: Add KUnit tests for runtime overflows config: openrisc-randconfig-r034-20230405 (https://download.01.org/0day-ci/archive/20230408/202304080811.nYP4KpPZ-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d212962ef7682ee160bf38fa455475558f031759 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Kees-Cook/kunit-tool-Enable-CONFIG_FORTIFY_SOURCE-under-UML/20230408-032959 git checkout d212962ef7682ee160bf38fa455475558f031759 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash lib/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304080811.nYP4KpPZ-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from lib/fortify_kunit.c:28: lib/fortify_kunit.c: In function 'strnlen_test': >> lib/fortify_kunit.c:412:31: warning: 'strnlen' specified bound 33 exceeds source size 32 [-Wstringop-overread] 412 | KUNIT_EXPECT_EQ(test, strnlen(pad.buf, end + 1), end); include/kunit/test.h:584:38: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION' 584 | const typeof(left) __left = (left); \ | ^~~~ include/kunit/test.h:776:9: note: in expansion of macro 'KUNIT_BINARY_INT_ASSERTION' 776 | KUNIT_BINARY_INT_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:773:9: note: in expansion of macro 'KUNIT_EXPECT_EQ_MSG' 773 | KUNIT_EXPECT_EQ_MSG(test, left, right, NULL) | ^~~~~~~~~~~~~~~~~~~ lib/fortify_kunit.c:412:9: note: in expansion of macro 'KUNIT_EXPECT_EQ' 412 | KUNIT_EXPECT_EQ(test, strnlen(pad.buf, end + 1), end); | ^~~~~~~~~~~~~~~ lib/fortify_kunit.c:359:14: note: source object allocated here 359 | char buf[32]; | ^~~ lib/fortify_kunit.c:414:31: warning: 'strnlen' specified bound 34 exceeds source size 32 [-Wstringop-overread] 414 | KUNIT_EXPECT_EQ(test, strnlen(pad.buf, end + 2), end); include/kunit/test.h:584:38: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION' 584 | const typeof(left) __left = (left); \ | ^~~~ include/kunit/test.h:776:9: note: in expansion of macro 'KUNIT_BINARY_INT_ASSERTION' 776 | KUNIT_BINARY_INT_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:773:9: note: in expansion of macro 'KUNIT_EXPECT_EQ_MSG' 773 | KUNIT_EXPECT_EQ_MSG(test, left, right, NULL) | ^~~~~~~~~~~~~~~~~~~ lib/fortify_kunit.c:414:9: note: in expansion of macro 'KUNIT_EXPECT_EQ' 414 | KUNIT_EXPECT_EQ(test, strnlen(pad.buf, end + 2), end); | ^~~~~~~~~~~~~~~ lib/fortify_kunit.c:359:14: note: source object allocated here 359 | char buf[32]; | ^~~ vim +/strnlen +412 lib/fortify_kunit.c 387 388 static void strnlen_test(struct kunit *test) 389 { 390 struct fortify_padding pad = { }; 391 int i, end = sizeof(pad.buf) - 1; 392 393 /* Fill 31 bytes with valid characters. */ 394 for (i = 0; i < sizeof(pad.buf) - 1; i++) 395 pad.buf[i] = i + '0'; 396 /* Trailing bytes are still %NUL. */ 397 KUNIT_EXPECT_EQ(test, pad.buf[end], '\0'); 398 KUNIT_EXPECT_EQ(test, pad.bytes_after, 0); 399 400 /* String is terminated, so strnlen() is valid. */ 401 KUNIT_EXPECT_EQ(test, strnlen(pad.buf, sizeof(pad.buf)), end); 402 KUNIT_EXPECT_EQ(test, fortify_read_overflows, 0); 403 /* A truncated strnlen() will be safe, too. */ 404 KUNIT_EXPECT_EQ(test, strnlen(pad.buf, sizeof(pad.buf) / 2), 405 sizeof(pad.buf) / 2); 406 KUNIT_EXPECT_EQ(test, fortify_read_overflows, 0); 407 408 /* Make string unterminated, and recount. */ 409 pad.buf[end] = 'A'; 410 end = sizeof(pad.buf); 411 /* Reading beyond with strncpy() will fail. */ > 412 KUNIT_EXPECT_EQ(test, strnlen(pad.buf, end + 1), end); 413 KUNIT_EXPECT_EQ(test, fortify_read_overflows, 1); 414 KUNIT_EXPECT_EQ(test, strnlen(pad.buf, end + 2), end); 415 KUNIT_EXPECT_EQ(test, fortify_read_overflows, 2); 416 417 /* Early-truncated is safe still, though. */ 418 KUNIT_EXPECT_EQ(test, strnlen(pad.buf, end), end); 419 KUNIT_EXPECT_EQ(test, fortify_read_overflows, 2); 420 421 end = sizeof(pad.buf) / 2; 422 KUNIT_EXPECT_EQ(test, strnlen(pad.buf, end), end); 423 KUNIT_EXPECT_EQ(test, fortify_read_overflows, 2); 424 } 425 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests