From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FC1C76196 for ; Thu, 6 Apr 2023 23:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C87F6B0072; Thu, 6 Apr 2023 19:56:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 351BF6B0074; Thu, 6 Apr 2023 19:56:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17F5C6B0075; Thu, 6 Apr 2023 19:56:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0556A6B0072 for ; Thu, 6 Apr 2023 19:56:13 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CD8CB1C7162 for ; Thu, 6 Apr 2023 23:56:12 +0000 (UTC) X-FDA: 80652627384.07.63FDCCD Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf30.hostedemail.com (Postfix) with ESMTP id 7F25C8000B for ; Thu, 6 Apr 2023 23:56:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=OWGzwSNK; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="wEl/a2h2"; spf=pass (imf30.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1680825369; a=rsa-sha256; cv=pass; b=cQ8MAzP5LphKeo5x/6euUxC5+eIO/4SuPBP9BQCfusQ8RwCXu3BCoTb91rMSoebreQsuBM EAIOBqKlkrrzBU2qozyAXGkET9/GGanwk2TdJcG500uleK6JgHMhrkj5JADceDwWtJ7/Z/ g0bQbmkBPeQlzFNlc3St0sE2IFg6YgQ= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=OWGzwSNK; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="wEl/a2h2"; spf=pass (imf30.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680825369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EEJ4/z+BU+cvEK9PuOnNnAvaejxZrID3oQ3JoF6jDIk=; b=ZhQyB+eRySbxOSddDTtXmT2nQvg3DYuxVxs1a0iWwh7XJc5wyEwxBUBy1/zMceHzNQhrMO 9q2fQCZaFAnMgwx7yKCkp8q0KZ7Zj0id797fuwymelW2pnLFSsAlBKFHEtI4+W7ImQ3ehw L7D4dGDPQr/al3n1+lA6qCJsDAF/hdM= Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 336MRx06013858; Thu, 6 Apr 2023 23:55:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=EEJ4/z+BU+cvEK9PuOnNnAvaejxZrID3oQ3JoF6jDIk=; b=OWGzwSNKjS4KMwcxYp4rGXFn1sBZzc0Ib2DaHkNMqdDc5zqSrOyInT/GFQ/N0Tf5Fu0m 4/Wt/WkF0n3HzrsYiWRO/xM3N+qMonPB+g/0tFZpbp63c1w3pgDNhjvv9Q8fTjm4F2Zu OvY3V6sCU3NMa4loDzHD+XF9iCha0FK7UlgJuqFqyY2oXzj5iJI4y2sdFQP+x/d6BIPQ +HEfg1TrqGQ5EjSID3asaahWu/6XNohFFEcoqZnYSHwSMVh4RivkrmkN1K5ewtbWJi3j fKhMClx3ToZlcJk5yL4Zpou80BZPA+6gu5HU9+hn3GcZ8wkkywgaDe4FPXJp/bWJNvgE 7Q== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ppbd4448e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Apr 2023 23:55:45 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 336NpYAj027625; Thu, 6 Apr 2023 23:55:44 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2173.outbound.protection.outlook.com [104.47.73.173]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3pptutsya8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Apr 2023 23:55:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E27G3d3MXYVweSM7llW1wJ6U8B9qZUowNOxf2B5r9LMboXKTicmRSzTqMbAommDm/12uybvQYwHFmqKRe/uMQ8TCFXiOV0YbbLo/+3HLeKDsw6YNfdf0SIBMR/v99I/TNwSTODr1WClow2A85bdHjm2ljiRCNYgVHCQytAxRSTMxwwic5hyPvho2WwCZbpSJZiLVSmj1cFCYCLBnU23MVNo2l01BMIrEjhT8YXj8prsM0zhaW2B0FciAYceH70jmxgN9PvrtD7F8m9f9CEQaRytK0y5KQD5izFB4AUkpQaWqvAHP1iGOdnXaFzy5jhhrjGRIaxDrmzZCrqUI1SDNCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EEJ4/z+BU+cvEK9PuOnNnAvaejxZrID3oQ3JoF6jDIk=; b=J05ZrVGejzZJ49t7yCNHsDwrx3W/iSzbsh9Klad6ckqBmtBT9xaBt9V9K7TGhl3TZML681uTMJgcZwmLsEQGFCkpS2UDgfbf4BtiuBQFsTc3rm8eYyXsh0TuckeVJYqhD+Q3bQm+o8GJ1BW7DW3JIwYLYt9m2QxJL6s4kjK/0fkVvBkE5x8YuCtCLHntD1jpxquU/ahLkPAKdWKTG+xXM85Yc3KGDI9f2gY4tbD/0vrVGOD7nFcVG/eDD6giepTVM5Cdiq+awFThx5wcn49A5HQOGx9u41qIsuEbEqgQhu2J+3+gJ2yzn+K8KoKi5rb6yc7UMVlTt8bDnO7xzsL06g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EEJ4/z+BU+cvEK9PuOnNnAvaejxZrID3oQ3JoF6jDIk=; b=wEl/a2h2J6gxoGx1iQmIqY77vslXChsH0qVrbSnUTv1Ke8OZ55BAZXwflskMUFVUBg8vn9XSiFiCmBj340B6gbkKOqDx8DLuChtKkgs4lFmfwQHb2yoXNZ9fBFNh9C+OFlXnNo9RO0ocPHLciVyfyBxURfy0iy/Mlm1XT4wmEhg= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by PH0PR10MB4760.namprd10.prod.outlook.com (2603:10b6:510:3b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Thu, 6 Apr 2023 23:55:41 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::ffb:de39:b76b:52eb]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::ffb:de39:b76b:52eb%3]) with mapi id 15.20.6277.030; Thu, 6 Apr 2023 23:55:41 +0000 Date: Thu, 6 Apr 2023 16:55:37 -0700 From: Mike Kravetz To: Peng Zhang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, sidhartha.kumar@oracle.com, vishal.moola@gmail.com, muchun.song@linux.dev, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH v5 5/6] mm: convert copy_user_huge_page() to copy_user_folio() Message-ID: <20230406235537.GF14244@monkey> References: <20230331093937.945725-1-zhangpeng362@huawei.com> <20230331093937.945725-6-zhangpeng362@huawei.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230331093937.945725-6-zhangpeng362@huawei.com> X-ClientProxiedBy: MW4PR03CA0189.namprd03.prod.outlook.com (2603:10b6:303:b8::14) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|PH0PR10MB4760:EE_ X-MS-Office365-Filtering-Correlation-Id: fe7cd0bb-1e85-42ec-78bc-08db36fa6dc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M3tsqkTIo4goNCTRVT685+Vrm7yFkygHqzoNApo8639IEppUYxSERTrZG0iV3Y0X+mQn0LdhBcGnuwh6qts2fLdo5WXCIrz0CDvMyoZn7AO9BjcpVoCCx/Uw8aunESzLuLwY4ZOx9Gm5OXrq0n6lbMLKoRqV9YOBFHZs2klsfi960WneghXnt5oid5SN7yw2ov3d26iL7lBNcczeFzqxBDekJ1j9z8evd7LujRzs+FMkYhWH5r0EVX83CswXRViW9ppjjZp6cMsn2yTCMEoERHZLjU0QjJMcTwTo7hCY938E/B7l/f7K2VnTXdIVHOx8v53ykOQNhtHGhlikzMHK8aNvoyepjwKtccuxejBjO3XdNrz0AXcXUkGasmtj5d6fUMaaxsM5YNbEKPK74LLVyY4+tS2sJqdgaj6ILxEjVMiwgw9iwbA/QgF61eDzrg4OTuQ+wn2yqwJ1c9MGBGR+0Uoau7OphYHscRTkXiKjZb5/Taw+gB1YfqbmeWB8m+2Gaa9LRkLGcgOjJX7/GqPRcWkoQv/igQJEji9RaTAwisT6tZABIR7/4wMXQ9UMSESJP1t0owpb1qoHCYPDAU0FCFP6jO2cORLaga44eIwDyeA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(39860400002)(396003)(366004)(136003)(376002)(346002)(451199021)(86362001)(33716001)(33656002)(2906002)(6486002)(186003)(6666004)(53546011)(44832011)(26005)(83380400001)(6512007)(9686003)(478600001)(66476007)(66556008)(8676002)(6506007)(1076003)(4326008)(6916009)(66946007)(41300700001)(38100700002)(5660300002)(8936002)(316002)(14583001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3mZCE2/CP3PgffPMwqBiA+EsR6p4KuzdO2HgJNqvFieZODIqdRu60q6L/fy6?= =?us-ascii?Q?sS/u/pAefstjBWrzv3yd4KlQm7KbrK+eiyPda6hv9WIYGQdIz6V3EsrbHUxX?= =?us-ascii?Q?vZNK27KU/y5Metr9azKESgRCB7XrR7/qoe/F1WRGHMv8gBYoTxMN0mbLpuJl?= =?us-ascii?Q?7xPe5lkfi56ZID5JTLYeaimXmJH84I6C2mMJIkSgGge8a4KhplS/KBjrKXyY?= =?us-ascii?Q?hL5dr4AI8K1COFV9GyqOC1lpOUp2kCONNTXehoY9rIJVmrItXaF8hzjcBtx9?= =?us-ascii?Q?7sIDYvtmExbdV54PH/thzA0SJKCQdJoklYmyWyUKAtb4yfpEa6KbxGG10RwU?= =?us-ascii?Q?EpBv8XcvA26vN/ckJdF2bSXl3TAzPGzIn3+GZCO0agHAOug1DR1eDKfAH008?= =?us-ascii?Q?7ZDL+crMCHYhQhcyNSj/2HbTcchf5vaPtmPqIQtaFUn2qlj/8Wb8XbgC6BC4?= =?us-ascii?Q?3eOrGW+lZcLns/xGbakkBRxQZwGcjrHU5DAroe8fxj9fKQwqezJLINg6ZNuC?= =?us-ascii?Q?yo5DbqD2YiO/yISS2/EcLvU+w9+CrI9wpnS5skEPQ7sUiMRX91wl+vMW8NsI?= =?us-ascii?Q?ojf5uNohzIncz33YqFRuyi064Kus1yjIf6vRpRKeQDq3Y8CnGZzQW19v61H7?= =?us-ascii?Q?Ud9SOuabdUHOwKJTDU99/9IdroD9L6mLIfFbv0FHqHZx8sQ2B1Cy/xSkzUUf?= =?us-ascii?Q?aulEcATihZMfoeWjZokrfQS0BVCs/K02jUgAP4Ju12vXKmPwkVCxAYs7eGnI?= =?us-ascii?Q?6s5s6zQDloXkS2CIJlqifpK0sSu9INXbuo0woL4o/urV8mCtQnI0DWJrSigL?= =?us-ascii?Q?FWyFPHMJD7JIGaU2Ip+199MOsDeabNJok3xUlDdnghzmJ7i6pW+Xxszp+RS0?= =?us-ascii?Q?E5CmA44M5tRwAG8TbJ54fpsXOUW79usel/8pUqjCigHOvvmYBmfD43fq8KuB?= =?us-ascii?Q?GG46J4G7tvlJ5e6Le8pcywQqmYeNcqf4ooSDSbBMIO3fCPwBVm/E0i3blbcl?= =?us-ascii?Q?KFzY4vucnZ1nq0QqF+ibnmtttfx8WWJJ5g20MChnuuxh+qWlqheepeKd9UUx?= =?us-ascii?Q?JCHAMjupDQhF054JOInaaoaH9hSBnM3ZUZ9eaAirWGtodO+ZnCtMBuKGSGIC?= =?us-ascii?Q?/oNj+nwR9hF08hSlu653QgxABgKYOfxvnQ0t3XJaT70bO75oWI+7RuGOS1PC?= =?us-ascii?Q?ENHINCoR+6jLpz1CnW4OsOee6GFh1Z8HyT8NyrxxDJaT02C6pDY43OKB78k0?= =?us-ascii?Q?8siZZGxgGmosYiLBjdvHq9ebC6CfPJ+Pxf5Wn0oK+tmmMlJq9NEhZC6RXw8H?= =?us-ascii?Q?P2ODjWcWR6apUom3tdaud7kMHh6sCaR/yBT48caDe+GreyEO6LExdYvoOp1O?= =?us-ascii?Q?WTqzx8say/4rNHUXCipgad/SHcXvH/jPYp3geiSxG7KO12BxI+ubvVBf6GNe?= =?us-ascii?Q?HmidinUKmM8tEZVq7PJbFszrh4NldUKchqPpq7vlCT9Upv9PBQ5GQz3S+AcG?= =?us-ascii?Q?/pgcQRW2hRMLA6QD9oPsbmiuN2YYWcgtqknbyTuFILHPTgdYHxFTPLG4qflx?= =?us-ascii?Q?ujuDkmIPq0XvxZmAxr19E4HOeE3+rQaqUifflVTX?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?kdf3A+WBhuGDuocD3Lf7W1sI6FmF4X19zMosJQuzPsbc5qjtUWMKQJ4kV53E?= =?us-ascii?Q?oXfL550wctZYlP8teTmomG96BtAQNK9umz2t7OcmcFoNGeBVBZ32EQwpFDbC?= =?us-ascii?Q?4wd8GrMeYST4fF/HkS3B/LN/X43vTYQphKokuV2R17dCPzTcDGPNVjB8yy23?= =?us-ascii?Q?DztacN5naT+BhBuxmhUSJMfol9POE8Yg1P5W/yjP0/9+nj8SNGznjUZeQ0JV?= =?us-ascii?Q?65LHADna264opvSZX4h6JizttLUjAy09lcJDGsSKIzH7bhUetEZFQ466yRfI?= =?us-ascii?Q?AXmJShq9CahIoflRTw2MRUmkZY1wZqhsJHatFB2sxzfokFt5tK0S77V8PgLM?= =?us-ascii?Q?xLQEj7Ak6yFm//60CBQPKjyn1bp7wJniLumLNqeOp8dDoTcmGZ91K0EqfuAn?= =?us-ascii?Q?JQHwLhhQKL0fJkU25vsKqfI3+/hHqvwBQaUR4o7uyAPN4hwO8HTxyKFFAnvM?= =?us-ascii?Q?1UAhtaZ/2xtWFGYcd3nXqH1R8F1h3UZAWkjxgXPQTf3nZ6Dpox7xgnELbuQS?= =?us-ascii?Q?k6p3x5TSoRuQd9nZaZC9N7LIK7qCQseYKPX6QajvFqmpYAvwsBH1xcNrKbcf?= =?us-ascii?Q?L378BWMrgf9YEkZ++T+/LCe4oXgWoVJjjBj5Ol2LSIvrVxsPGOtFTQwdQ7pp?= =?us-ascii?Q?3xiDv1Rtx+akWX155aZatN9MCS77/TM1BkR8IqwZKaVfu5uFyeDjJLNTXG8B?= =?us-ascii?Q?ibORzye+bjQuFE+pIMtzKnncCqGBeXBdlpXWkidKqfvPslaWZq9UPwGSLnWS?= =?us-ascii?Q?FRV1dqRTgoYGi0D2ITfjXoB7LEEUbgarareExMxkz2zlNpgFXWbHj1zOStEm?= =?us-ascii?Q?j1dco6SinllEj+HpkXvR8jYSWg7S2TjJSoj5zlNSeAAUJCCAsETpcQXAbRUk?= =?us-ascii?Q?bAmZlodYZeTRSHZH1Zgr36wzd1y969rn5rlBcKMN+nC792Jlxvo/xcLSXqLT?= =?us-ascii?Q?bZ31WBweyzhqlesrnkoOnQ=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe7cd0bb-1e85-42ec-78bc-08db36fa6dc1 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 23:55:41.6934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8OyD2AghBTDblfGEX2Cq/xQh1CXAbYu9QpOLsZYYLZZyo4h0rkyi71jG4HLlXk8CAN5AzeHE6WjRk8YxJs50SA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4760 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-06_13,2023-04-06_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304060208 X-Proofpoint-ORIG-GUID: Se7WeF3DHE8e-7LnOwMc5VkVMCemjXB- X-Proofpoint-GUID: Se7WeF3DHE8e-7LnOwMc5VkVMCemjXB- X-Rspam-User: X-Rspamd-Queue-Id: 7F25C8000B X-Rspamd-Server: rspam01 X-Stat-Signature: t9kt89eqpasworan9yab9ubyf3gpc4yh X-HE-Tag: 1680825369-316535 X-HE-Meta: U2FsdGVkX18+2VcPMhWDhKkxeYt/JFMIiD3PJAznGiGnQnY5JzbeCrJhOsa1AB6Kg87ILF7bSohU3gccA7VVFRilY8TWc4YAhPuyRTc/1k3oIsecgyWJdoxiHSgonF8nAHnRkyW+Ctcud5BIQfhknfEu9beEZ7uN7flq9XqwMljjHzvfmuWXpi2axDj9ns4xLwHRPO8c4f8+mCZ+2n3jJzmnj3OooFIVmKMpFWfICCftvu2OQYUWqu8E00HAuhkqIopTHua3JUuw5Nh1SzrMmabirpqrhjQlOVWoTnmX8DBOCTsqUsw6G02HuQFI0lvwCMTSbOMXUt0OronI00RGbTMSOe+DIe1YZC2pc3ObQoiTQcVVEcwbUV3VHMwn2gS+8FESIj6Jn6OD54K45qzoMEZaprN3d951rmKJEcfSVIV6HbKswm0Ks706SGG2CrEa+DPWKagN8hNMHJVePcEaYkye//cLw1i6mxHckNLvpjzofj7OH0+KryL1N6NVZ453wcBDqgmiQeaPl0miz9japwpBXS8mn66KJVKE7f665hBOkpSoocxKNc8P8MEK9lOLdxIRTAUcVY9WX/ki/reoeticL6Btcu7LsLMLpIi6HlU3hvYxzMz6iiOAs8BiYvGVDestOONyofnVRv4q1BvEhGGp7Mb3M2jU9JXpzKTMb8Iv6MBC2Mx+8DDRHGf3Qx7PojfWo3zqRTkBATL8rrt8SL+5tbYZJm2IWNOkSyuRhPn4Mqz77Fab2kIt0+xQhy6imSnPiR6N809Ue2UVrFGwZc4pnz7Eb1y0pfb9LoVASNadUA7bZv8cq9aGDH1c5WzLSbRWYSgTA1GKgoK8hWVLzgQyuL8WSCcXMY61ZRT/ET+kq+ucy6cxEZC+NVq6+grAsc7c4mMr8bJ/6/1uwsbpt3BUQR+DVj+65gjuIHx6hO6mR2It+6DzaikXukpGDZMKHn+6wFTwKlCwHOD9wJj BeRL9KHo fi2VWIsE6UAILDB69D2m8dor7vTV1QXRREwu8apOrT5iKKBX7S+UTrlT6diYT5WycVANaPqEcToKHzUnFhD7MzB5zyVB9B+xjuLnL+C0mEttd+7Uvx8eXSBHUziiJB75d2hKRklG0mnvD4/zSbURcEWau3+fogth6SswfDkau9b/GaCrn5xeptT4G+JTBmnb4kT1e+1JWGohC1FwdTviZxLZB5w2jBGdMENxu6fUZ74MQRDEnxy6hFHUKcR100yZOm9Jc4nELo5lNi+cOMhHIzFa8Qa5HDklWEU4wV/soL93cOPnxTU42oKVnGXLEUYi9W+AC44PCmACcHG5ZzArlf/ptzuc4YBjOSnzV579iLmF3FuGoHkOSNGIy80KnC8FiLMA1dOsxR+4NCt+XJxd3qx5nBF8wQNrVY7sOwe4/AnzBk0mKHr3RK0N6tPe4CyY/c0L+hiGrB6J3yZctg8Oh1qzPsBk+g7rIIqYsyP1d/VgJPK9Yhyq0m+azDGA4ygqMtVcS3B1HJwS3As0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/31/23 17:39, Peng Zhang wrote: > From: ZhangPeng > > Replace copy_user_huge_page() with copy_user_folio(). copy_user_folio() > does the same as copy_user_huge_page(), but takes in folios instead of > pages. Convert copy_user_gigantic_page() to take in folios. > Remove pages_per_huge_page from copy_user_folio(), because we can get > that from folio_nr_pages(dst). > > Signed-off-by: ZhangPeng > --- > include/linux/mm.h | 7 +++---- > mm/hugetlb.c | 10 ++++------ > mm/memory.c | 28 ++++++++++++++-------------- > 3 files changed, 21 insertions(+), 24 deletions(-) No technical problems with the patch, but ... > > @@ -5847,15 +5847,15 @@ static void copy_subpage(unsigned long addr, int idx, void *arg) > addr, copy_arg->vma); > } > > -void copy_user_huge_page(struct page *dst, struct page *src, > - unsigned long addr_hint, struct vm_area_struct *vma, > - unsigned int pages_per_huge_page) > +void copy_user_folio(struct folio *dst, struct folio *src, > + unsigned long addr_hint, struct vm_area_struct *vma) > { > + unsigned int pages_per_huge_page = folio_nr_pages(dst); > unsigned long addr = addr_hint & > ~(((unsigned long)pages_per_huge_page << PAGE_SHIFT) - 1); > struct copy_subpage_arg arg = { > - .dst = dst, > - .src = src, > + .dst = &dst->page, > + .src = &src->page, > .vma = vma, > }; > I seem to recall that Matthew suggested changing the function name to copy_user_folio. My only concern is that the name now sounds like a general purpose routine for copying folios. It certainly would work for a single page folio, but there is a bunch of unnecessary overhead in that case. That makes me think there should perhaps be an optimized path for single page folios that just does copy_user_highpage(). But, the argument addr_hint does not make much sense in the single page folio case. So, I am not sure if I agree with leaving large/huge out of the function name. Just wondering if Matthew has any additional thoughts? -- Mike Kravetz