From: Mike Kravetz <mike.kravetz@oracle.com>
To: Peng Zhang <zhangpeng362@huawei.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, willy@infradead.org,
sidhartha.kumar@oracle.com, vishal.moola@gmail.com,
muchun.song@linux.dev, wangkefeng.wang@huawei.com,
sunnanyong@huawei.com
Subject: Re: [PATCH v5 2/6] userfaultfd: use kmap_local_page() in copy_huge_page_from_user()
Date: Thu, 6 Apr 2023 14:32:33 -0700 [thread overview]
Message-ID: <20230406213233.GC14244@monkey> (raw)
In-Reply-To: <20230331093937.945725-3-zhangpeng362@huawei.com>
On 03/31/23 17:39, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@huawei.com>
>
> kmap() and kmap_atomic() are being deprecated in favor of
> kmap_local_page() which is appropriate for any thread local context.[1]
>
> Let's replace the kmap() and kmap_atomic() with kmap_local_page() in
> copy_huge_page_from_user(). When allow_pagefault is false, disable page
> faults to prevent potential deadlock.[2]
>
> [1] https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com/
> [2] https://lkml.kernel.org/r/20221025220136.2366143-1-ira.weiny@intel.com
>
> Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
> ---
> mm/memory.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
Thanks,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
next prev parent reply other threads:[~2023-04-06 21:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 9:39 [PATCH v5 0/6] userfaultfd: convert userfaultfd functions to use folios Peng Zhang
2023-03-31 9:39 ` [PATCH v5 1/6] userfaultfd: convert mfill_atomic_pte_copy() to use a folio Peng Zhang
2023-04-06 21:31 ` Mike Kravetz
2023-04-08 4:42 ` zhangpeng (AS)
2023-03-31 9:39 ` [PATCH v5 2/6] userfaultfd: use kmap_local_page() in copy_huge_page_from_user() Peng Zhang
2023-04-06 21:32 ` Mike Kravetz [this message]
2023-03-31 9:39 ` [PATCH v5 3/6] userfaultfd: convert copy_huge_page_from_user() to copy_folio_from_user() Peng Zhang
2023-04-06 22:22 ` Mike Kravetz
2023-04-07 2:28 ` Vishal Moola
2023-04-08 4:43 ` zhangpeng (AS)
2023-04-10 21:26 ` Mike Kravetz
2023-04-11 1:30 ` Yin, Fengwei
2023-04-11 3:40 ` Matthew Wilcox
2023-04-18 22:21 ` Andrew Morton
2023-03-31 9:39 ` [PATCH v5 4/6] userfaultfd: convert mfill_atomic_hugetlb() to use a folio Peng Zhang
2023-04-06 22:48 ` Mike Kravetz
2023-03-31 9:39 ` [PATCH v5 5/6] mm: convert copy_user_huge_page() to copy_user_folio() Peng Zhang
2023-04-06 23:55 ` Mike Kravetz
2023-04-08 4:42 ` zhangpeng (AS)
2023-03-31 9:39 ` [PATCH v5 6/6] userfaultfd: convert mfill_atomic() to use a folio Peng Zhang
2023-04-07 0:07 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406213233.GC14244@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=sidhartha.kumar@oracle.com \
--cc=sunnanyong@huawei.com \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox