From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431ACC76196 for ; Thu, 6 Apr 2023 20:17:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CBAC6B0071; Thu, 6 Apr 2023 16:17:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8538F6B0072; Thu, 6 Apr 2023 16:17:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F4CD6B0075; Thu, 6 Apr 2023 16:17:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 590A96B0071 for ; Thu, 6 Apr 2023 16:17:19 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2C0688123C for ; Thu, 6 Apr 2023 20:17:19 +0000 (UTC) X-FDA: 80652075798.27.C3DFAB1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 678D380018 for ; Thu, 6 Apr 2023 20:17:17 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=H2Yp1vNc; dmarc=none; spf=none (imf02.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680812237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mFpvxPlspeoy9LDmMBY7APXBNJ5e/XNrdXF3NxrNXXw=; b=pF2xyfF0SnNl9JYKwcPOhKtvHfYy6KlkjBLg6TfPs0OiWrqzoTul4Jm5krJTZ3s+UwlofU gXypUy18AuW760eWW+NZTFsv0CNIhQrgwHrm0ljEbrRwx68gzG8HaZF2cjAyoBOQTpe7UO AOEpvkJFZUzFT8dEsn1p7SrAVrGQhV4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=H2Yp1vNc; dmarc=none; spf=none (imf02.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680812237; a=rsa-sha256; cv=none; b=BC2RcWldBU2+47L+jYveCRz/UTxyPyWH/N7ylt3uQLoogU1nqXnaWLHybEe5KJPJzJ5vd+ lu3ZH3LAGJWy1Na1o7kLgDHcGFr2N556gO3b1jYGEcJ38nAEHzKrWZYHZ/Q4SbqmC42ANI foVojgeunhqrgQJfamxdlEI7CWhfKmg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mFpvxPlspeoy9LDmMBY7APXBNJ5e/XNrdXF3NxrNXXw=; b=H2Yp1vNceuOId//xOj47ZDsS60 cItSvbsseW0Xs+GWraSBzFA6eRyLU98hf574cFaaV6aVEmEu0ESRbFOXjyUbDTBO5MPA9KfTsJCZ2 aE3+f0KTlek19+HRaToSO+/yXAZVtSfHROmNFT11O4up9QsGMne9zuZkmvQlext0W21kTixe0SFKX 88+fGh+uMNaVYVpCOoArqfWaIlO4oCmPB6sjoziSMJjL7JB5+YtvyQVBYbgcgMZ2CWAoTctqOQkb0 gQIUYaETjrk+c39s/BCFc4vVvomZowbeI0w5NhuYXFDbKHp9FciQMQaQoRG7H/alFIbmQAOTYdGWd gvY3jDCA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pkW2P-0008SQ-2U; Thu, 06 Apr 2023 20:17:00 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 990DF300202; Thu, 6 Apr 2023 22:16:52 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7D04F212E36AC; Thu, 6 Apr 2023 22:16:52 +0200 (CEST) Date: Thu, 6 Apr 2023 22:16:52 +0200 From: Peter Zijlstra To: Ankur Arora Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, willy@infradead.org, mgorman@suse.de, rostedt@goodmis.org, tglx@linutronix.de, vincent.guittot@linaro.org, jon.grimm@amd.com, bharata@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com Subject: Re: [PATCH 8/9] irqentry: define irqentry_exit_allow_resched() Message-ID: <20230406201652.GA409443@hirez.programming.kicks-ass.net> References: <20230403052233.1880567-1-ankur.a.arora@oracle.com> <20230403052233.1880567-9-ankur.a.arora@oracle.com> <20230405202240.GE365912@hirez.programming.kicks-ass.net> <87o7o1lzko.fsf@oracle.com> <20230406201359.GC405948@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230406201359.GC405948@hirez.programming.kicks-ass.net> X-Rspamd-Queue-Id: 678D380018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 3m5xacx4f5bf7djmtq78b4ohoh5nk9hc X-HE-Tag: 1680812237-761124 X-HE-Meta: U2FsdGVkX1/M3zwtmpFb5higGnwFoEn+55HNelzDvzALljqAhrizz+xvsOmhUl6JULr/cRrWc8BwAD3BJqu/bcuGpIz73CF2kCUyMUDFjWat30IZaj1Fa6WdDBbpqO98ue5LbNDiOoN2ns3JXRqADQ55uCzX9CuKGnsNi1sgmQXhQ4xVqLbVpxRKk12yPzrCKAQfy/ttMVSrQosKdEhrJ3u3+CBkqCfJDGp1ImxH0vvzmFF5pEM7IGhIYRpBLmXDWgbSzVegee89fr6OId2xUAO1UOIzpWTEtY+qNZH7pqxiaRr32uE7pKw2wNTIaaIp+DuOE4P11l4cmH68PDh9+mTN5RpwwgP/SZue5sFdRjm+TejHRYcD6kUPX5m8uEoFo6ofXDbc7K9yZDZ+uRFcoOlF1LbXmk1D8q/OorFb9eZTUfVezoK25Sym4oFSgvxdy2tIIUrzWMX58yEtH5/USJhv52jyYPjaZNHTd7D5KEs76Me7lfnZ2lJvAuSWjCl4rJ9S3oJm8u9/uq5qhKVMI+TYCcQv70A0qHytE2mWXCuF0IEWY67JKhuZZ0hMtUz9172r65LltoUQHtP4/9Iee8B+swwpiGzVs3EMgLCfZQujkJMvVQJijiGXtwFZrLcejzTWXg/NXqcsrmMJJJux7pMuFdaCsO4MD/NLDImMBESDByGllGjdDMCw2nN5WQYQ2W+bempEx400VGgu/+aJ+/oeIvhH8ivLcGXUOBd7tUkUnhQ89FBntKYNRS6dmz+HNH7Xm9902k97rOcVrr+fLLwDrVz+XixCRoaCz+W4IW2OkdcT7/H4If2XXMvj7cCO7dLTNM8kTfhjfEOA6Xgd2gF2EFPlTpJ088/YgWZv71FX2jHHh5hIwGwnc+lJ1ufQmoFAR4it30qxfH7z+OoE2/e2Wu4ozLC9nUflooSvYAe9MO/FVs20ahaDhroJA2Zm/SkH5YcAqxbxZirR8um o89TQYAZ raYZWfgV/KvfqEsHKR1Fv9mwbvJxwVrJ2FxQKyRDO0pierC4BLzOCgLYxKYONhtvLHCtYdXX1hvq21fRtpXKbpxrEuiK4rJreimaND+DxpVK+CeWY3sq/sHOb7PH01Viwaw84oIysWTokxmm+05l3BqhFHIRasnk9UxrCIMzqNMY8rZj31C7+phvYYX8ZfLm0TNE3WWn+eUdy4qQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 06, 2023 at 10:13:59PM +0200, Peter Zijlstra wrote: > +void irqentry_exit_cond_resched_tif(void) > +{ > +#ifdef TIF_RESCHED_ALLOW > + if (resched_allowed()) { > + /* Sanity check RCU and thread stack */ > + rcu_irq_exit_check_preempt(); > + if (IS_ENABLED(CONFIG_DEBUG_ENTRY)) > + WARN_ON_ONCE(!on_thread_stack()); > + if (need_resched()) > + preempt_schedule_irq(); arguably this can simply call raw_irqentry_exit_cond_resched_tif().. probably better than duplicating all that again. > + } > +#endif > +}