From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02BE8C76196 for ; Thu, 6 Apr 2023 23:30:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89B8F6B0071; Thu, 6 Apr 2023 19:30:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 848676B0074; Thu, 6 Apr 2023 19:30:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EA5D6B0075; Thu, 6 Apr 2023 19:30:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 599A06B0071 for ; Thu, 6 Apr 2023 19:30:02 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3B17A16079C for ; Thu, 6 Apr 2023 23:30:02 +0000 (UTC) X-FDA: 80652561444.17.EFB26D2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 762C9120010 for ; Thu, 6 Apr 2023 23:30:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="UFwip8/h"; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680823800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mlfSGx98bmzTt7RYObQmpA1GB+I6XScGmPgyQkHkUDQ=; b=l//Upj8lZ7Q/IOWvvoEXcQYFQ766WGAlcqI1N4CH08WTcYAPQfyG7WVHa+3XYglBU5sedC c8TsOk0OPoQZP9s2GLAfvBJYD/DRrMreB/zCfwa0G7v++359VO5MZSIkVG/qnf4LsFDuTI atun8Yg1MqHLcd2opMdT2oqjcj/jZpA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="UFwip8/h"; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680823800; a=rsa-sha256; cv=none; b=pVslz39qlrFOEAXzLd58oh33ZduIHD2Csl7JN+PpCqrJkSOlYVT9NnTxC+cGiq8uOjmN1R 0WOL3WsHepIBBsZ8uBVW7j7k7P+OEGNo4a8s9Q/WeayFo6GnHum/6uoP2/RZUDYEITvtKw bcvoBl8P0OhRdt2MdlyBSsTUzkakE0I= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5FFC4647A4; Thu, 6 Apr 2023 23:29:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72C76C433D2; Thu, 6 Apr 2023 23:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1680823798; bh=qDIlNriYIeS492HkC/yOLQLD8cyeiSLOgIcNJoMa84k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UFwip8/hNEYfi28GVP5NGN6Q4UQK1bbuIXgHii34OS4tBhjOISMQG42LkdSssjw4j jv58Vi79dzbgX0Fd5QxH5lXD6O2iX6aMpgOX9tPxsxSnGL/yLT74sl4InM5nXKD8xf fRYWzvlLHAGI1zNjF1tVVBxDAcDqVfRYihUJeANA= Date: Thu, 6 Apr 2023 16:29:57 -0700 From: Andrew Morton To: Stefan Roesch Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, david@redhat.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, hannes@cmpxchg.org, Bagas Sanjaya Subject: Re: [PATCH v5 1/3] mm: add new api to enable ksm per process Message-Id: <20230406162957.57fa69a46691a97d4600f444@linux-foundation.org> In-Reply-To: <20230406165339.1017597-2-shr@devkernel.io> References: <20230406165339.1017597-1-shr@devkernel.io> <20230406165339.1017597-2-shr@devkernel.io> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 762C9120010 X-Stat-Signature: q8xibbwhq5rnehzugmp9s1spcx3u7zgj X-Rspam-User: X-HE-Tag: 1680823800-208017 X-HE-Meta: U2FsdGVkX18bTe+a5qulWgGMcrCUS0ydR8iTfABj/IZ2iiX+G4OuT+K676RmcITIdFx1bSWwLCqO8JpW/S3PCXGDoKTiNOf2yxEq+tSpyXOEU32Vq07lPQJ7lvL81juF62Uc0GgKr4PWQZvlJ0SGpI1JlNOAzY9ijf+Ve+urHQLB/xgUXk4WXEbPAQg2BrO2N7JQ8mTXu0yyi7zVZbxpnTjYQSldOIghO8lpIb+P8hI28D+w+51c8aaL1icuN954tZ+sZapVl0VWp7Gmi0yvnizraKzRLU/b3F6X3sQ8aFgczChk3U4HGw0oo/AempvMuRhhGrkKprkcVIAaBtwAQDMn15H5lRfwkJiELbaLGFeAs15WWU1jUnpSU082OKoEgcgc50QEWtTc7Cg4PSXdmL3vKh+yZk6H6+RNXUfmlgpdl+HflpQZPP43ExreGqhnmODWRjfAcWpgbQsuqiZcjB+EMM2KO4EVaro9/Z35jt0ATci9WGrhAAn0RMntrctetyI2OdEAX7vtFJ3JRrNywginWtB0BrVQmFwYugW4KX9CClT3hOAO4JrEeQkGejCFEFieiEVtc6LD7YCkvt14WEpW9k1taoVAkD70Btl3D+2YPLHU4m40If0bUuLta+2qK0aar1Ugd/AC78zkWeXqXIN2TqxWsueGx5yhqBCX7HWTtE+dX/4GhKDO63VmQpTnm0BBVWF4ldOf4jK2zmrMDwBjzs6/zeqxNTHAEceJ0vhdnEQNQskX7Z219FrtfDEECs4nYXe2RoYX0QTi6nFkIUmTU0abtrEJwEp5zRlmLiiWnBaqmJF5oMt8do1IFLCnB/H9qkC0xYjBUL7bnv0l9lrRIexD3ya6RyZTZx9pIs8OIOhpT2yEHBVLxMGjlkfJSOmKevDe4/MXK0FzuctDK77zerNl0sUTlNiZzDh91zo1VCP8uG6hxth6lkgH7+vkuiz1ge7YW5T7pnvq0xJ E4zsucLq 4C7240fuNTHA37j16WHbEfgY2DiENducXj01Ne0lZqE0Liu+rE6WyGp/BBaKPPPTEvbk6fIiFQlbhihCVe/uqV8cigODus1LdMOtjmb9KGCYolw/WVoFP/ePEioWZEvARsc5dVUm2lrQzGKYQBDPUQNRNoKzuOaooRn4EdvW6+uKehf60TSxVc6iNgjOb48KPi3wTkODamJ0gGwgQU3PJJqscTuj3LrV6EgTkvEuH8hCJUyeTGgcqypZfOAQzs0xCiXo78PpJqGBxo7yyYqBVwKpSh+ronz6RSI0PXAOqs8BO4ECQCqNK5GLxsBowLfv2/bitm1q1/Qd5q7KRK5wkElFXFlu7Wz29JET0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 6 Apr 2023 09:53:37 -0700 Stefan Roesch wrote: > So far KSM can only be enabled by calling madvise for memory regions. To > be able to use KSM for more workloads, KSM needs to have the ability to be > enabled / disabled at the process / cgroup level. > > ... > > @@ -53,6 +62,18 @@ void folio_migrate_ksm(struct folio *newfolio, struct folio *folio); > > #else /* !CONFIG_KSM */ > > +static inline int ksm_add_mm(struct mm_struct *mm) > +{ > +} The compiler doesn't like the lack of a return value. I queued up a patch to simply delete the above function - seems that ksm_add_mm() has no callers if CONFIG_KSM=n. The same might be true of the ksm_add_vma()...ksm_exit() stubs also, Perhaps some kind soul could take a look at whether we can simply clean those out.