From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E52C7618D for ; Thu, 6 Apr 2023 15:59:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DBED6B0071; Thu, 6 Apr 2023 11:59:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18C8B6B0074; Thu, 6 Apr 2023 11:59:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02CA46B0075; Thu, 6 Apr 2023 11:59:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E6D356B0071 for ; Thu, 6 Apr 2023 11:59:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 991EBACA6A for ; Thu, 6 Apr 2023 15:59:58 +0000 (UTC) X-FDA: 80651427276.08.7BE5AB2 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf15.hostedemail.com (Postfix) with ESMTP id 620A4A0016 for ; Thu, 6 Apr 2023 15:59:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="D dqEV9U"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=pVWYKPCw; spf=pass (imf15.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680796795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=trO8jc03FJLvTQr9TJ/mrkQxrmA3NZ7pQ+cjfH4ljHA=; b=FpUoIMA+AGoH3VRPKkG6uRgS0qvSOsvxg5YsW9azsi7JKljEK0SenjTD6g8hNdyuup+5mr A2ysYikC9EjEXJMtS+YKy+dDVRpobVO+a0Sdw0IRjO4E/be+cQJXJjngt+K7WO8k1iWeeV B4SHgZnbWWaSbum7F/a3IgwFANcSO3M= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="D dqEV9U"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=pVWYKPCw; spf=pass (imf15.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680796795; a=rsa-sha256; cv=none; b=USKIJhMzESXC8+N+VtdY31vgo6PYZQ7NBg0X86xPKUj43ZDvcHhq4+Zv3AJqaGzk/ROBon k+64vL4bz9sUA4l/jis1mFF09ww8TOdJ6lFcZ4ndu2kQ+55VvAI1pVdZOaInr5TG97wIP0 GVHQLCRY7Dj237//YTtjbSXnEoOeeqQ= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7283F5C00FB; Thu, 6 Apr 2023 11:59:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 06 Apr 2023 11:59:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1680796791; x= 1680883191; bh=trO8jc03FJLvTQr9TJ/mrkQxrmA3NZ7pQ+cjfH4ljHA=; b=D dqEV9U0jb0GbAcy+Z+YHa9vWqDcOdV11TU5V3txMnnIIP/5vEB/EV2TeqaYRqUp7 O+do7wxJwzR7J/3JEqfHu4EgpTMFhEOC/lPN/RWakbh5xgkNK22zvCQ7TPe64fRP 9IGy/0C+rB6l954EP+bkQg0WIzCWHx6GyPwQHu3jIRohFqwkpIx1Jc+Nz7IswKxu CL/oYYxIb4os9svlgXjpF4iKyF4f0kYxFuCoHqC2ahtMQe923nFOQBb3DojjpyjN oCX64nG1Gyo1gWIcUTr5y6wWe4wBqJoq6JAcaq4j44DqeMYf0f1HNN5ZcrPnoV4d tzTboTMYUMoD+DS56fbIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680796791; x=1680883191; bh=trO8jc03FJLvT Qr9TJ/mrkQxrmA3NZ7pQ+cjfH4ljHA=; b=pVWYKPCweySGyFodQ6stjV6Orskps S7oJXvI2shkOWIEovlHJFRiFkQfHb0YTEWY3C2pvDbKp55W17Zas4Jg40lv2Pe+u QOxUbsSeJMhOSG549C1WvdfU8INOnYKan6gTN/HzhhIKn7mRGHnqxCp5/IfyOk2x w4EsV4p49OqaDs6qeA9P+oj0A/mSJQSBrsE8KfSko3HetmPKDEz3aK9ImQ82WBKA nZxOofj9FwGWum+FeFiNdtHRPeEHSuNxdakoG5liGZUzlD+nY/0KarBj1Afo/PLd XiIm11qskilbFiB+NuPDlU2tDmfSGP808fBwBggLNSB3GIEKDD32aqhIQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejfedgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpeffhedvveeuheeljedtkedtkeeiieekgedtveeu tdejkeevudffudfgveeggfduvdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkhhirhhilhhl sehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Apr 2023 11:59:50 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 311BB109B00; Thu, 6 Apr 2023 18:59:48 +0300 (+03) Date: Thu, 6 Apr 2023 18:59:48 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: "Kirill A. Shutemov" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Bharata B Rao , Jacob Pan , Ashok Raj , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] x86/mm/iommu/sva: Fix error code for LAM enabling failure due to SVA Message-ID: <20230406155948.hlhb53xb3plq6sh5@box> References: <20230403111020.3136-1-kirill.shutemov@linux.intel.com> <20230403111020.3136-2-kirill.shutemov@linux.intel.com> <24661bc4-cc95-5c1b-b88d-94d4ce335d0b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24661bc4-cc95-5c1b-b88d-94d4ce335d0b@intel.com> X-Rspamd-Queue-Id: 620A4A0016 X-Stat-Signature: 8kundi9qnko3f348kf5nubwsgnfk6jpc X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680796795-652224 X-HE-Meta: U2FsdGVkX19ve4L5yl4t9qu9RpBcYMtomMkRMur1r4JAjDzwQAyQHzfjusgpnk1q5yuBX+uC5CRiy/2lkwBlLKNiZlZIf01qqhulidAC7ZQbyNIKOiVA7U+H3GKIAI/lH+bWvT5V7MMlBqweAhUxHxGNZB0PW++EdYyLHs8958yjzWnDg+mjVZL/WC9c2GDPyhEzH07gPYuQlDV7OqqKer7VBgx/gsjsauHieEGL7/+l+EBCbbVZlrjhf6C3Ka+D4KKJuyQdOcUw88W2W2MqBizy64qa4D6qGCuO1DA//DuLx5NwLt4/IijAVhJ/jzklWqno1w9ZhXN120xTorIpQ3tPuu6hV2CPBKE1qPwP5KyCajrq2KdLlvJalk7r/b3YbnIyrOy3kN/+ClliGplG23XPGUNEfxqLcyLqsswimetg71pRtlauJtKTt5GX0wKmuZggPIUjiqQo6K5MUkaPrNGNUe65leAbToVJX7kERr9JAJng6Tnu65YqM5uvZSjBLv9JFGxNsDEfXyRF7fMqZYJ3rQrk/XyqSRYeb+uNaue0KiLapVavVsSTyFbyH5ST3u1w5V3OpF502RTR0VDN6lkfbxIM6HAE3WykqVs1YpKhuq362YMH4l3QN6aC8VDW0Z6G4S1QxbryFxaOkXRTF9Mmq0oVt62J/VWh57rfTys89COJj5NesO6kTg4XBn2lTBHQ1k7HVNj0SVbhwBMm50b0wVRhZ/h4LvMtmjamhBMqsZSN4NjHwCMrnUnQaeMWGsAPCP8vajTbbsoJ51u94CGs5gLVM9eWyOlZ8mRR69u5ZWK6adZ0aTsJIsGvyurkHvatsa6q898iV8kGkei3Z8SIfJ0/POKbrNWvvxdvxxODMufsnfmWMqmLvaTwfvp/A8Z5qB2ELudWNzkV1G8uWHFBZl0TvNNpAT65VnWGgfNrbikShl4DaG915jZrW6iYVTigzEdJ53sVbeJ5KZd M+WLM/e4 CnHYdQZpbte2HvUPgGJSzYMdtXSUryheRkCc9bXTtaJXgjAHQ+bkqj8rT/R3aHBEBHVLMfRXOSdJ14rFBPJacp4LtwOWTfEUCQCwEGn7aQEXaN+lW1JuMwawQLldhI+mApS4XXzX5fNSKRN32WqbxMkfHzOCjVxTCRIazX/cVSezM5BF55UFligv52bzDPWoMjskKrGKJsKWDKFavs1b47xLAsSODSAj8XKu7nV1NXyHpVaPhpnsm2FA+qTbHKHGnlU1xaItVviWA9twoV8HBZMpfPxYBzblIVQd5sCgAjuLVUKtrRgx+MTOp1L/bq2DbtccLCKkK1vPIoMmZPQBw4RDvgpQbQD6B1sC2aNZtRF42AUihk3T9iIRsV6cOmlZbQVK6YFqtR34LJc6kueeX1ptrHQeqG6RK/soZksvOQclCrs18oPmB1XJcAyfqrpfDwH71jgzCYe89IN7qDVP607p/g+SoeQX5ZHFh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 06, 2023 at 08:31:40AM -0700, Dave Hansen wrote: > On 4/3/23 04:10, Kirill A. Shutemov wrote: > > Normally, LAM and SVA are mutually exclusive. LAM enabling will fail if > > SVA is already in use. > > > > Correct error code for the failure. EINTR is nonsensical there. > > > > Signed-off-by: Kirill A. Shutemov > > Fixes: 23e5d9ec2bab ("x86/mm/iommu/sva: Make LAM and SVA mutually exclusive") > > Reported-by: Dmitry Vyukov > > Hi Kirill, > > These look fine. But in the future, Link:'s for Reported-by's would be > very appreciated if the discussion happened in public. Got it. For this one it is: Link: https://lore.kernel.org/all/CACT4Y+YfqSMsZArhh25TESmG-U4jO5Hjphz87wKSnTiaw2Wrfw@mail.gmail.com -- Kiryl Shutsemau / Kirill A. Shutemov