From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1681C77B6C for ; Thu, 6 Apr 2023 21:53:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 563A56B0071; Thu, 6 Apr 2023 17:53:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 513EE6B0074; Thu, 6 Apr 2023 17:53:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E6AB6B0075; Thu, 6 Apr 2023 17:53:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2E3CF6B0071 for ; Thu, 6 Apr 2023 17:53:50 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E98F5C060C for ; Thu, 6 Apr 2023 21:53:49 +0000 (UTC) X-FDA: 80652318978.18.C74D7C8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 40C6A1C0012 for ; Thu, 6 Apr 2023 21:53:48 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PfHJsdlo; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680818028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TbRTu/ZvsFlUHpyj6WCUNoptLsGdLvhoNNPY7Sw5L84=; b=n4oLO3yA+dhx/ERgtQpcG1opQrM6nG2aKUUxvE5GQwzadej4h7xingyv8gK7y9zyZT3+fp 1tiVmABYdww+jfhO85S5//A0wrpHanI1ZOCrON+20s3cG678md8QQVCXbrcBS81ptC1Xzv XdEUeTtNMHFd2ux2Js+NKyIOUAPjYO4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PfHJsdlo; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680818028; a=rsa-sha256; cv=none; b=kzaWp0plRarLa0V65FrTcv1o7NbSn07XLHRL5h/wZI6tixBOJ6p1Dt3CV/8aQVeqQNVzHX SRAeoBdjiBme/XbrIEiuAT5/STZIEgAGAvevneh3dsu3IyHvMWdAZ69O65TnS/bQ2fN84S BqCPdt/CJ/KHEWP5jUISJQFj604a/Z4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4973164C8D; Thu, 6 Apr 2023 21:53:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89577C433EF; Thu, 6 Apr 2023 21:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1680818026; bh=LGynFdLpXdAw06RcdZ1IJ8GRpyk9viwFXtp1CMy3Wds=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PfHJsdloNeSJFGbIpuAf8ez32Le6aBFxLwe2RLMpelS4FLIASRIXkDABBcuRJdqpt avXFdK5fJ+s/6YRl2MvorAusAvoSqw12YQ35vejlnQwr0eCshu50RCEDSFfMPf0+XD V9xXKrUuUxd81wn02Pss6/UcMwdiLXIfXQLAfCXA= Date: Thu, 6 Apr 2023 14:53:45 -0700 From: Andrew Morton To: "Liam R. Howlett" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/mprotect: Fix do_mprotect_pkey() return on error Message-Id: <20230406145345.9c5e4c91461cbf42509a92a9@linux-foundation.org> In-Reply-To: <20230406193050.1363476-1-Liam.Howlett@oracle.com> References: <20230406193050.1363476-1-Liam.Howlett@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 40C6A1C0012 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: n4yzjhdhc7pau1aurhiuhprobr1tqcgs X-HE-Tag: 1680818028-193381 X-HE-Meta: U2FsdGVkX18fD3L9v0m9WZlMLjEz9yclT9vDjdVsfiW2kk664UQzLiG2dmrVfgXO+0x2oQODYDagcYpThyxI3G8Rutb29jgtEzSqugdhYPRostGEDycLaKR/YsHq65WVMud0RKqYLShcoNNWrcvcnV8HAtYPLTPHB2rQhlYD7ctftZOmCZS5Dty03d5I97ej8xESHJ1ovUD2V7vZZ+HnSKZvrb/sY3Z+5UNmc4PQRUdtyjklnKao6xlzDfoLmXtveYgkxfzx8sJ254ttTvLvxEQnF3AaHIbN3ZB4trGbVVnLeRuninW+OkLqFyBoZf/Bi+r9EjXZLgQlGuFKOpT+dN5Vp+i/Wpvmq4mFKxthkdzk+2w6reN0OzJuZD9HQVA94ZSi7Fg0JP52Oy7csLmwolsSUtMHlRaZfb0pQLePKkMm1oeMRoM2bV0pfbgiV7yT+y+OOKG4HNA2Q9v7s3ENwTbDHef5dcsY/h8gw4R0+xZ2VY3hw82FFd0RwaaMjESQoJRVw5gkAphA63KcI50CGGBEpAxDb7R8w99WsKnt7vL6hroNTq72HjwwqXZktOV+ehDKFJgux+KSUwglD83eHYBfFC6IPEJOPBDjeIT10mLpHYa+jdPqHMnPOQ+io48/SGbRav55H7seKdkvlzEkioxkK7oT1uOU153ZE+stq8+w6Fbtpwh8Zr5gSxk6ISRWhw3zjwtQcrxJ6/aDF1EJtF2O4FHwuKqjmk7QFvLSQk15n8KU8L+6B4B10uWwQukbroBRIzagrdMe2cv2juI3GdwD3+6+sS4q6Yp6TVS5+cVQRzKQqoemC/znHM467pdyRNJhltTryc1Kkwlg/8JNojFWmKlsjCjsBt87Vs1teO7ZxUVi4gWQaCIApBaeVi7AWLlBteIhlcmbvTNWaqKyYAQzr12ceRz9sCEPZt6a/YjjlSEWC4iG6NPy9mEK0F0pQmGzRbgKDKeXJrUCNWy VPGjYsBr TQH53CUHw4rytNunJzQC2dK74qJVv40tcxwpRObK6zUpoRgVU42AuWwEezXGyaNDe+3TrdsOeJpzM9UyM4fTzAoMgT08ge7i42Vz7oBNR1ZlNIlZCc4rW9UA9HSL1v3DM0IUSIS6C35K7Z4lBVkXVlPKZo0Mx0+Xr/RbgiZa02k//GXRP3a4XdVyR49Xa9D0O4aNhVaydHUFvjQb/2iSfXUAkJseTR8S9FqwtRR2FxYPKxZSBNXvphXhxRcIAlyOZjPrypCQkdwwaDQtWVkz8UuyTUDZGdoa9d/hq8r88L2NE4UHrA4T1ou94eVz2PIaJZJt9Tkr+hNlSV87Oxm/59KyDY6mycTPhBPrAYhiwbENkQS9ozY3GSRgLaWI3HQf3K71Gb5gcETCetoac6YRTYJOA6Y1xduswbWFZsuwgSRCfSRFgV/5w8OU5wl4VqyUmC0J9zJRn+apnmFOrK4t6peBGbc9IPGyj1chAn66dAUa6iYYVitmOfIPu+vihnLQnK2x/R0+1xeTnc+w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 6 Apr 2023 15:30:50 -0400 "Liam R. Howlett" wrote: > When the loop over the VMA is terminated early due to an error, the > return code could be overwritten with ENOMEM. Fix the return code by > only setting the error on early loop termination when the error is not > set. > > Fixes: 2286a6914c77 ("mm: change mprotect_fixup to vma iterator") > Cc: I do think we should always describe the user-visible effects when proposing a backport. a) so the -stable maintainers understand why we're recommending the backport and b) to help some poor soul who is looking at the patch wondering if it will fix his customer's bug report. How's this? : User-visible effects include: attempts to run mprotect() against a special : mapping or with a poorly-aligned hugetlb address should return -EINVAL, : but they presently return -ENOMEM.