From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E479C7618D for ; Thu, 6 Apr 2023 14:16:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9762A6B0071; Thu, 6 Apr 2023 10:16:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9276A6B0074; Thu, 6 Apr 2023 10:16:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EF126B0075; Thu, 6 Apr 2023 10:16:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7175B6B0071 for ; Thu, 6 Apr 2023 10:16:26 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 481C21C71F3 for ; Thu, 6 Apr 2023 14:16:26 +0000 (UTC) X-FDA: 80651166372.16.147CBBB Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf16.hostedemail.com (Postfix) with ESMTP id ADF08180016 for ; Thu, 6 Apr 2023 14:16:23 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=yMgxS62C; spf=pass (imf16.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680790584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/keXUwxyyyhEmE55ekm1FOCQVlxKlIBEPyFrxNy9+U8=; b=v7bXWwqmqjyd/lFRyT/XrM3TzgvtUsXaR7kZgcRd5ka2xvLYLTsFhMV8qnImiJxj7WFVgE 43o9Mp+xfvO/KCK4SDmElHIntuT72AcRkHqmgWwKiliz8G710/Iryytgy+xetEuWVWG2sD Sn5NOwM00jogiUR+sAYKd0CAPoX1n7E= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=yMgxS62C; spf=pass (imf16.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680790584; a=rsa-sha256; cv=none; b=0BMkeMYt41yUMZwSXnXybwXoi3fTQc/2dCS5wCq9NH4mGVegyCsXcmBDta8YtuxkrEAgHO hyyj9i1sIbhFlY6Ji+s6cvAyJ5ZZBHBMn1YOM0vKv3xSD+1+MdZ84ue4ZmOnqKyj1BdT/Z c8KDVSD2huqK+xgthJ3b3mCus5+yFPk= Received: by mail-qt1-f171.google.com with SMTP id cn12so34801607qtb.8 for ; Thu, 06 Apr 2023 07:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1680790582; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/keXUwxyyyhEmE55ekm1FOCQVlxKlIBEPyFrxNy9+U8=; b=yMgxS62CvuVWs51H3j8VhZZqIn+Cxgamg4MbN38plY1EHsc+48o/I2AU+AL+IrLGyb 2FQPJBrBUfPODEdPgg3Cs8bERKQ8L0drmuknQiejJ1OX5SgINjFOVIRScBqH+2G6tfKz UO9iQ4OkJCRftY92TR3n8hbAi45WxIx43oy9C9NVUE94NNJhL9wVyWMOBI+kGQXkMxWp pFvXpOOfzOVXCB6GmFyiFM9LrIUUQCFvrbgkT4nVWvY6y043YqaOrSy095TBohrzhtDh 4pjKCjdLwRPqUL1UDC7+YaUp7gjIrS2XXSvQH+FO30nS9mfbWYHaorWMJK8x2hMP8vV2 DZOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680790582; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/keXUwxyyyhEmE55ekm1FOCQVlxKlIBEPyFrxNy9+U8=; b=bif/EX5NL/eHvOT1TNZ6ptKT79pAs3nBHKe0Tqr/V3CNlwpHlQjWBsXippx1xRfwoC Jx6yec8nNutVNNs1mkPCRNRtXOXBs84LS5u+JqkhN87E7quxq5yyHYq1PgM8vSYDz7Df YqO44hjna8M3Gp16eCdLxNKx6sMZgGQTLI9nQe6t2uEBWsGeQoi8ksrNsFNniUif+5lx bIgdRDc4oKbn8PCBInEMh1zyez4hnGA/EcexC9fzzkA0iZ3EYZY06IGWzWVhEK+ulntK nDESQdMZWYyuw3STb2GtdVlUvQHzPJxi8igBLNnQ/qvAdKfpWKJr3dnL5Xlx6ECYqYiB CRPQ== X-Gm-Message-State: AAQBX9cV+R4ycua+IuZL3SlvLNrN1V32aqD+vvLEbNyMULG5VRypP5hV BnQcgw6nZIPpLqfFIc6ofpKB3g== X-Google-Smtp-Source: AKy350aHGbMuHwfg10eLISdaNmwzT6KQ08KKQI4+CJ4NG36CU3mo9lXcmtYbtUWWQpn3yduoT2tNeg== X-Received: by 2002:a05:622a:118d:b0:3b9:b2ba:9b3d with SMTP id m13-20020a05622a118d00b003b9b2ba9b3dmr11399480qtk.54.1680790582613; Thu, 06 Apr 2023 07:16:22 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id d7-20020ac85347000000b003e3982a6f2bsm450114qto.18.2023.04.06.07.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 07:16:22 -0700 (PDT) Date: Thu, 6 Apr 2023 10:16:19 -0400 From: Johannes Weiner To: David Hildenbrand Cc: Stefan Roesch , kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, Bagas Sanjaya Subject: Re: [PATCH v4 2/3] mm: add new KSM process and sysfs knobs Message-ID: <20230406141619.GB35884@cmpxchg.org> References: <20230310182851.2579138-1-shr@devkernel.io> <20230310182851.2579138-3-shr@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: ADF08180016 X-Stat-Signature: 73owhmem77u6g9j8ooqw7t74rz9yo74x X-HE-Tag: 1680790583-471010 X-HE-Meta: U2FsdGVkX19mxvDqP/jtZ8O6WxeQO68AGtXr72WHA5M/srbFWVmKQenrTyqgeE/l9iDKsL3d7oHJbLopanCoBDrFHn/YOW+BOoEjp0w+ULFQedaO39De1XDNsVeY15r5fOLHIGcti0RPukCJF6+7JPS670Tz/MAOmYBkNvno9/N8KkMrT4A8+eE2vC7ZKQNfLP2TBr5K9VWVF71myFErk/+hAj8ERKmL675FyIc1OTQtinOrEkolgLDNEK4HN6V9Q1geOcA5qCDCxUHB+hEACguW7l1qJRzA8yknnrG5ZLUJEmYFipAAutMvVio5uKc7gies1dSGZ2qLEJ06Pn61ENk+H5dRWSJwtfTXKTzGve5kw7XGU3apeTy9kEfLPPKaf9CW8i3EzVb4I23pRU9rmM4p+o+ZCl5TBGK8SnCMgMrgJWG5HzwBEFhtUE2mYIVgVAq6vrsJaUHZN4YZ7Rhfx/fTVKz9h7vvQK2Dk7OQHBgr2kylCMKqiYl0IsZyjcoHUDevNJM1D6+E4osIkJZ6OFlvH8y8tJ0is24DkOu93lFz1EHNWHuPQORYrx4yf3i+0NTP1+hVh1JEQJSxd8PU0ZCIYEdQmBAu9y/XeYjhreXf8r1R1LwRMadDCa2l47OU3Mqnp4Z7FFLaEiBO42zvV/kAZYRn2ou3YouiYu2yXWSMSuUwgIaxbkLegj18OWAJMuXC6hsGhwrLeQ8YYTvxts8q5Oscbd8pRhM+plNdqIqPtPOqNd++Q3Bpoj7g0k2FyEQuF2vNkK6Q226cEKKUFcQZgkr9C4QAGpHpyxL1oSvRPbm2nynI3ChsYfL3UygewgyRrJRdrBeHpN7e53ec7MM5eScKzBZJNMvsq3/8DHLr8J1hzfyugteI4AWdKjD2BtHOR3KejzR19bgXYGUWtY+8Q6uQmDGA7PO8EnCFUdzKBCWOnQGcUReeIcWnRz08yAV2MKZmOgCgJv/S0AC wPhELkd+ in+Fn7z2dhV5qDn4EjH6Dahu1TH1X7pBCHFzUVrb3wmLHRBPKKospxyydfOvCvLvn+hVo4jiZmcHACbLXRS3T1Fvt+05XzYFo3994hU16Nm8k94Zw+jHBBmYDB+a0pE+/ZvAhxUV45ViNkdUJ7xpF4sF7yTPuTenLpo60e3xdSEJsWFP1aND2zlvG6WmBbMLvltewsH81ROKZkm8W51/r8vTUezDx4S51kL1xLvGVNBUq6LRcJU0X9M0Am9Wd0LE4HJzVegyWqIXGAIM1U7mGpPP5idrWUViED+NCX173Ii/jF8SLhStmY0lXfdqhuwf78AtpJ73EWtD1nfDQiTUeCmL1K2J4tkdIaRvPbeeycWA6TQNatNEuVf9QjkfhgzykTyhQEMeJY7SowMJ7QfQ9MEAQtCI2DVCK7R7b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 06, 2023 at 03:23:11PM +0200, David Hildenbrand wrote: > > > > > > Often, when you have to start making a list of things that a patch does, it > > > might make sense to split some of the items into separate patches such that you > > > can avoid lists and just explain in list-free text how the pieces in the patch > > > fit together. > > > > > > I'd suggest splitting this patch into logical pieces. For example, separating > > > the general profit calculation/exposure from the per-mm profit and the per-mm > > > ksm type indication. > > > > > > > Originally these were individual patches. If I recall correctly Johannes > > Weiner wanted them as one patch. I can certainly split them again. > > That's why I remember that v1 contained more patches :) > > Again, just my opinion on patches that require a description in form of a > list ... My concern was the initial splitting of patch 1. I found it easier to review with the new prctl() being one logical change, and fully implemented in one go. The changelog is still in the form of a list, but it essentially enumerates diff hunks that make up the interface. No objection to splitting out the multiple sysfs knobs, though! The strategy I usually follow is this: 1. Split out changes based on user-visible behavior (new prctl(), new sysfs knob) 2. Extract changes made along the way that have stand-alone value in existing code (bug fixes, simplifying/documenting tricky sections, cleanups). 3. Split out noisy prep work such as renames and refactors that make the user-visible functional changes more difficult to understand. and then order the series into sections 2, 3, and 1.