From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE3F8C7618D for ; Thu, 6 Apr 2023 13:30:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 279BE6B0071; Thu, 6 Apr 2023 09:30:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 228D36B0074; Thu, 6 Apr 2023 09:30:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F08D6B007B; Thu, 6 Apr 2023 09:30:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 024496B0071 for ; Thu, 6 Apr 2023 09:30:35 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 906B3412E5 for ; Thu, 6 Apr 2023 13:30:34 +0000 (UTC) X-FDA: 80651050788.12.5E34A78 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id D39E416001F for ; Thu, 6 Apr 2023 13:30:31 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vue8C2R2; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680787832; a=rsa-sha256; cv=none; b=puEkOlrcrK1KAPvtGtWN9o/tCd3Vzy/UbuPU+LzG+4aSxvpfQ4izSzYFbNs2bxCTJ4Wg8I ybT8A/Uv6knG2rj52JiR9Qput9EP2wyYs3EqqIyr2DXXU+58h499p7h+pKfKQ+ieMuzTwu HRJSLQ3C0fxTQdEQuXVhIN/5WBAsvCc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vue8C2R2; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680787832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nd3XkTPolwnpqLUE3NgrOTALtPa5jjJD1/nKvlAaz2Y=; b=wBl9GIEePrb1U/HEAU17Z5loYZ77Qcr1vSAIk0TtPni09wizFDdSNa4uqfXyXb5CvrlHvf yVk3pfINSOo71XzLthTzz3Htm9GwN5BwBTQxtE/kXBX53iiKM4LpQdf7TdPAZc6EYcsf3z m3i+gpf2ZfzUEqKslu6EQgigAgIxuj8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Nd3XkTPolwnpqLUE3NgrOTALtPa5jjJD1/nKvlAaz2Y=; b=vue8C2R2wX38xDkBGmlwtFuwej Uh9YLsW/EhfXMh7OJlSlN4QIICEHntt5WzTJnGsnePbisoQVK9CJRIbgzILTTKcC9rMcoH5KSTnLC +BM4FSDOzNuPtj0pJezReU7JgYDtuX7kZBnGSJ5R6oJeKcNvAgEzHJ5cnyJl6vMuW/lwUcLdzsb+U jV4L2Sfce7s6V1mmzQ7Ujvs482g3uQ7SKnRijWGFfVXch9CHyJFxOeVVM6YM2Zd34fz6GBDK0qY8r kylhl+3KwiY5LKfmkEmzd8bEYUSWaULkGLEtIOsfwdZDai4Vh6S9T3AIUaj4NN1o1QFsneAz55xwe RYXZfkyg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pkPgE-00HS2T-GH; Thu, 06 Apr 2023 13:29:34 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A336A300194; Thu, 6 Apr 2023 15:29:28 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7C90E212E36AC; Thu, 6 Apr 2023 15:29:28 +0200 (CEST) Date: Thu, 6 Apr 2023 15:29:28 +0200 From: Peter Zijlstra To: Marcelo Tosatti Cc: Frederic Weisbecker , Yair Podemsky , linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, vschneid@redhat.com, dhildenb@redhat.com, alougovs@redhat.com Subject: Re: [PATCH 3/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to CPUs in kernel mode Message-ID: <20230406132928.GM386572@hirez.programming.kicks-ass.net> References: <20230404134224.137038-1-ypodemsk@redhat.com> <20230404134224.137038-4-ypodemsk@redhat.com> <20230405195226.GB365912@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: D39E416001F X-Rspamd-Server: rspam01 X-Stat-Signature: mdjaiirbbqk968hoazkpxtyujb86ng8k X-HE-Tag: 1680787831-496216 X-HE-Meta: U2FsdGVkX1/fn+nQBRpUv38WuuGBn1JqjR1lyDsLq6CfzHAWd8uvqJAx7qhcyhvNti/pcbdWIKatvblPM9ZayUWAzQaz0vP97IUEOesFMZLMktp69k5qM3M9tKW7lixw91N49YRiI0oWjH52OGTV4fnN0uOwd/dTuHPFJJo7vTgwmkp1PHkrXlpMZefK6QF+DAAynrKi6zjtqaLpo8Wob8ZhHuHfn6XdIxGjf0k66G6PY4vzNRpEAIg/zUBos0KxI9gHnHSFVHB/3WGpwzXUfX5Ni3Gty0CUb1NZejO/Spc/F2iozeAF06BH2welvh3XCFi33AvVVsoDF20pjBqYII2vlSW79cpU23+x262967F0AJ5c4DzheIzeVraPrOfVSg4w4yh6LLy4GcAmUIU21OUr4XXUs4ZutKD94Kfe8PxhiluaEWDY47AaP+Xq2XfPYlXkegXXuz0uDbCLs0et+Ll35Fzu0O6AIIROVVdKuCLoHb1v49CMIeWzrFzOz8SU142jWCKiZkG6rXVeG+RzLM+kGbyTqGmErq6JKLlz6/9Nl8Obitlw0GqSU5Qd7ZU3bi3dA34hVsIOY/Y4/ym17OfUGm603k1Xj7cQ8GMpj7KYP+YQFMiP+2FJcZ1+fkVVrgFqpGIZ7byTBGY3Mh4lLsxVCv8CppIUrGY7YG5i1PWsTocjVfWSAE6n1HbT9xzVNF56Q3B1e2aatw04P3GmYN8AVKKcUb9TCPBUnJDPJ8nGA+jxg2Sd/4/53GchnpvDqucmFxGE+bFL364cj/0ccx4vsnjtab3r/sRDY/rOO4J4XpkUlsp85HCb8hQ6sT71mIN+1cAcC07GTDOjymmyci8nVP/z+9q00hXMrI7ACHl2X5RD0djenqjWxziY26tc3XdtOoek8evrbV7eFDaaRsVdkW93Bf6qJVwJoNGO/tqz9f7z6OwbDf3zAr/STsm4UiafozIDgJ5yf7eVL7r vg5cjg0c RE23be25AsMF5pRHCoKtQreHRO5JUGSTQr6FO7mGfMsrt3r5KaOlzJBp8IXlPeYcION+o3wk/5vdvFi/gLvqd3h2LvDud7yxDjMNvMCy54U3CHLR8+tEZiID0jEwETsd4krIbx6qImpQosTD+WF6unHjV0hjlZkso0lkFVFlmMYRRrDOvBWmasLDYLprG4LK7LmQ1mPRP3Tnl5K7aYv5jN9LMMOWQzl6CVXkvAOxTXw7DZL1vp/OmV5bYJJgl/X8oSkpao7QstcAsCZ8dJmaJsLiqY+VU8vS+3ZTY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 06, 2023 at 09:38:50AM -0300, Marcelo Tosatti wrote: > > To actually hit this path you're doing something really dodgy. > > Apparently khugepaged is using the same infrastructure: > > $ grep tlb_remove_table khugepaged.c > tlb_remove_table_sync_one(); > tlb_remove_table_sync_one(); > > So just enabling khugepaged will hit that path. Urgh, WTF.. Let me go read that stuff :/