From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF6FEC76188 for ; Wed, 5 Apr 2023 14:50:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5BEA6B0072; Wed, 5 Apr 2023 10:50:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0BF06B0074; Wed, 5 Apr 2023 10:50:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFB146B0075; Wed, 5 Apr 2023 10:50:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9F5C06B0072 for ; Wed, 5 Apr 2023 10:50:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 64BD01C67AD for ; Wed, 5 Apr 2023 14:50:17 +0000 (UTC) X-FDA: 80647622874.18.C55422E Received: from outbound-smtp15.blacknight.com (outbound-smtp15.blacknight.com [46.22.139.232]) by imf30.hostedemail.com (Postfix) with ESMTP id AA2D88001A for ; Wed, 5 Apr 2023 14:50:14 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.232 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680706214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0VvPDzNu6GOvKBKekEXxnjMrGzRayJ7HzLwlkQ9u8eY=; b=51nH9VEUMpcf07NKjICbbwdV8Abzu0AwMqrqx8UdrbrjAe9E7KCer8Dv6K9EgHQBJtGV3G hITsvxhfkpb6LtVEWu/EG2LZ+l79WBONlp661qxxpGM+CLZB4fwgsIyxQJffeFU6I7R/eW wuupsvHMV/cQSOtHc8rVXcz9OQpOw+U= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.232 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680706214; a=rsa-sha256; cv=none; b=VuifLCQ270N1l1CAXMzVOO42kOttrHbbtG9xNnrS6zKSfbhbn7dJuNFKIO4FtevdEv8dx5 sQ9n8dqJoPeLYoXgcmTq5YbS3egjqK0zVOEtwkD7yPbMdhZRtYxQPHCBwMyg7/qC6HANcw C/q07d44NnMrOfNDlOgZYjqepToYklg= Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp15.blacknight.com (Postfix) with ESMTPS id F1C961C4266 for ; Wed, 5 Apr 2023 15:50:12 +0100 (IST) Received: (qmail 1459 invoked from network); 5 Apr 2023 14:50:12 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.21.103]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 5 Apr 2023 14:50:12 -0000 Date: Wed, 5 Apr 2023 15:50:10 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Kees Cook , linux-hardening@vger.kernel.org, Alexander Halbuer Subject: Re: [PATCH] mm, page_alloc: use check_pages_enabled static key to check tail pages Message-ID: <20230405145010.lrrc4gnxtaqjlnil@techsingularity.net> References: <20230405142840.11068-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230405142840.11068-1-vbabka@suse.cz> X-Rspamd-Queue-Id: AA2D88001A X-Stat-Signature: o9j4xqhpnu7g91wxb85971sax969imkm X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680706214-883085 X-HE-Meta: U2FsdGVkX1+NSR4LcHrBOHeY8IfahRMb3E4D1+ig6Q2G4yjFKRAJdFIGwtUn6oyIjkp/9IXtvGTpzYIPKj5D3fGBqBfXnIKfX4kv9xYh+pyzqYNkJCfop14duxF3YWjHZpI0NmqiuywlDfmV3q9pPn5hzlheGim59Ve4yMuuRawCJ7qDQKpVOk9KNqulWLB6EC6gkQiOqjdQhbTBXAEHESwhLP0aYXjr9Zn5y2dR0SmFtnxcpsO2/qmfF3Oludzg1LpH7hblnR2x9U3EwNZDjo4ZC+jbItG2DDCo8xv+pLPCrzgKhITC7RJA8VcKqAbbQdK/nsfMiAj6lCjKhSwpTMSRVW/IjQJYui0kVPsrUk9/AvD5Y6JRvFqO7nc0fLBSnPMz7qWIVGbVn7vqC6eV60TzDVfr6e6Treb7MP8ANhurrw/rgemxHsyPwFOaAh7NcYO4fgsQLgWdGhsNCHb/tT6csP9kkSdyXVXk+H45dOFGYc2g1t5IIt+kRTrI1TScu7rxTbAxOPC42/H9l+TS16t0OPffl6y6+Sstz1U9U2zhUIt8hrFPWC/24OaSnpWbZWrkmyIP5RBqrno5yEsdvu6JYfE+Y+O0/z0GiMSGyQhuiiQNKawruoRQY437ze7nFvVWmJx4zg2ZpjZoRPIf/m4MkV3tKEcePD68BtHemj3ybkdiKZ4TTczmOU06ElJGNZBeflR/bsgxFp0b94O/i5YpOwNTnWXZFwVUnEaTXS29AcSD9oVAUOxc2bThECz5SRO7A7gFeRoohFBOEr2pfrSO4R9lvGdQkIf9k6MylVgKWaXc0qMOHaL3wvUhiT/vADEDwxAlXdJn+wgMOUbhCtA8Qx7+vEqYfpKSJwLz6Av2DdziFK1QuVaNN7lzxpW6w8KpwiJv9rVuwqnLtP6KKoxUeuqRrA0QfoC32RYIij+mNZvi28YnVGQ5VEpRMTMU/N4xW6fmDrII/1/k6oG 0tHpcejU Zp1lk+Cq9a8C/kGjdn66t4MqR2XhnNmA37U3LAgQHUTv7gyrfkQdg1Je54rUB2XIUXir/U26shecINRd4jsw8zfvTAMRZccvjZcAgQjv3O7GcZ99AGv08LgebPomW8a7pYeklX48i8Vm2ljw78jFLTynik8/IlmXiC+4R4/G2Bwvo0N5zhYFNo0eKogdRdN6FFvPapc1ueszgjXcyYzi5oQkdt1tpguL66ObtbVK9/rd4xF7ddR+cmNSxwtxrMDEoDDNgEJKEZizrZMyozHHjLcI/wJyf+6w1dT5EnojUi7LBsroINqPgqsaYNSYgZ6MSE2hL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 05, 2023 at 04:28:40PM +0200, Vlastimil Babka wrote: > Commit 700d2e9a36b9 ("mm, page_alloc: reduce page alloc/free sanity > checks") has introduced a new static key check_pages_enabled to control > when struct pages are sanity checked during allocation and freeing. Mel > Gorman suggested that free_tail_pages_check() could use this static key > as well, instead of relying on CONFIG_DEBUG_VM. That makes sense, so do > that. Also rename the function to free_tail_page_prepare() because it > works on a single tail page and has a struct page preparation component > as well as the optional checking component. > Also remove some unnecessary unlikely() within static_branch_unlikely() > statements that Mel pointed out for commit 700d2e9a36b9. > > Suggested-by: Mel Gorman > Signed-off-by: Vlastimil Babka Acked-by: Mel Gorman -- Mel Gorman SUSE Labs