From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E862C76188 for ; Wed, 5 Apr 2023 11:04:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A13DC6B0071; Wed, 5 Apr 2023 07:04:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C35E6B0072; Wed, 5 Apr 2023 07:04:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88B566B0074; Wed, 5 Apr 2023 07:04:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 77E446B0071 for ; Wed, 5 Apr 2023 07:04:13 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 521B21604F3 for ; Wed, 5 Apr 2023 11:04:13 +0000 (UTC) X-FDA: 80647053186.19.AEB9F85 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf28.hostedemail.com (Postfix) with ESMTP id 57A73C0026 for ; Wed, 5 Apr 2023 11:04:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RdFyvhut; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=c4XKQ2pS; spf=pass (imf28.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680692650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QmHkOWmWhOHTZTTCd0u2ToA8BmSfOcNQfCli10b6Z0M=; b=e47HQCmzWPCqfn2XdTAXdL+KF48SFVIVDIc77c5dD9DWI9Oaf5SXnM02AdJffGHwvU5Tkg U/TuRd76PprV7Z5uMq9d+l/2gdbxyAMVZeKJBi7H3Mv4OgR9x6GSRCDkkE17tCZkINff3X hYgW48jaXjyD9wiStq5L85RrjPjiPoI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RdFyvhut; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=c4XKQ2pS; spf=pass (imf28.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680692650; a=rsa-sha256; cv=none; b=2qMEZtSv+l7K3jyYO2MK/POGPhHmuwJjzzUKuZY/YOO5Hpe0UEnIwmHNx49sMTN6Wp/g3z 1GdfPiDVHpZgyB0JngmOGGQMDcrf1kl6UGvCLTunoPg3FhAQLyapkntGylpSG0xW4OAjCy 37C+XhxvNOQK0rCCe8gSySH5iamTIL4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C08362065A; Wed, 5 Apr 2023 11:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1680692648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QmHkOWmWhOHTZTTCd0u2ToA8BmSfOcNQfCli10b6Z0M=; b=RdFyvhutzFzcOMEGCctT+IsMUhB3T1n0nyhFtmkZJDYGyUE6/SAsO/2VBNH9PKMV77E+0j 7ueXmNafykcoRF3zAIIMMK/0RRZCGmoDIpeIXed7li1EFPizwBuNC1BMYW6M0UAwODZv3x XezmHIazOn1H7NwE+GPDtIBth4+7hnM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1680692648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QmHkOWmWhOHTZTTCd0u2ToA8BmSfOcNQfCli10b6Z0M=; b=c4XKQ2pSeCTVW48CnHH26ywWCxnyAQ30+KMSvf3jjOAd7SAjrX/OFC6qXSe1esJvoOAyGY VqmMXqvUFwvRE1DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B335413A10; Wed, 5 Apr 2023 11:04:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /W+gK6hVLWRqFwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 11:04:08 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 48121A0729; Wed, 5 Apr 2023 13:04:08 +0200 (CEST) Date: Wed, 5 Apr 2023 13:04:08 +0200 From: Jan Kara To: Carlos Maiolino Cc: Jan Kara , hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH 4/6] shmem: prepare shmem quota infrastructure Message-ID: <20230405110408.dvbxnvpubowwih7n@quack3> References: <20230403084759.884681-1-cem@kernel.org> <20230403084759.884681-5-cem@kernel.org> <4sn9HjMu80MnoBrnTf2T-G0QFQc9QOwiM7e6ahvv7dZ0N6lpoMY-NTul3DgbNZF08r69V6BuAQI1QcdSzdAFKQ==@protonmail.internalid> <20230404123442.kettrnpmumpzc2da@quack3> <20230404134836.blwy3mfhl3n2bfyj@andromeda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230404134836.blwy3mfhl3n2bfyj@andromeda> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 57A73C0026 X-Stat-Signature: ybzya4bfqecqk8p63rq4q88k67g3ftxu X-Rspam-User: X-HE-Tag: 1680692650-88764 X-HE-Meta: U2FsdGVkX18Yq48oqvq5wy5gkJGj5VEeh2P/3ZBoLt9NmEiY7MGI/9WYX8nrGE0jcyu+yyjURWorM48vT0j6icbGj9iEJfAH/QJqTVuCMFPy6Ay5UZH2vg1w222Z3L0gX0KOFl68pcDlmIpc7a34cp4BsAtb6l1Q3m3nP55O2aV2rdQMDmGKA08Bb5paON0YKFuIG9GxyoWkDYis++7UZ+rk2JRY9DZpquLz0PYyNckvrSd8LOH8+Avl4m4eScPrEe9q2NS/Y5iA2ze0PT/5fdT8i00JggR20HfNhH+dndBvtt8qTt+4qClLW1rXUNQ5mDGul97HQWaGeqY1EhOHsELQbBg5DWs2LQbPaBzh3SdbNwiO22f61zitOwJ2KssHAcwesPAvZMmanJrFjuBi/Gqt4wPYnxCiWr3dAnXqWlL8CkpHNRz3S2gKgZPWeuTVwD0aQHhmilEb6DJ7eVydIQQF5Frq00gKLuhiHkk0m7RMj0KQWueH4uKEm7qIjlSRo14WhBebeaxGC9AGCRPh2a+DW2YneUk6D1HhogerOeR39aV3ZlkUPGxHJdGpdSl72Jz7uQ5xZssQqe+36EnZSl+INZgE36Y4RfjcpdTMospnPhjKT8sgsExOFEQ4qlG7WJgz5V7m5TZ/tL07j8SB456TNOdIqY/pYGdBByb/qiDFr5FVe5FrdsYTnjzAQz8Ho8O1QinqkjR4DHW7JGTCxwx9dhvU8mlm658x+ehyiH/JrIZySDOoLCeXaj98i2kQ/HhLED8pCoQQqUNl/g8UvTDjVEDU+bayPoFLKNLP9R/A9agBrJp6af21j1tqTRwDDGg5vPC68HMAuhMR5kIH3IcM+NaoAgkrINd9Ga7IQ6IV3m7oSimzW/nlqG86DCk6MQXtarSjzwm0w5fmXHkMNQAdkwdTzOF6DXyb69BX10qvTOquSZLH4Lqd4zVvSP3Ghdcxt6qLbsk8Fwqi/vP CS/ceZgh B4jnbM+mvfvo7l6bq3OafWoxghQkGvglfausW9us92n1It+J1P8jNeCOrZ+Pwk9+YlQNYzhQNMfihR28+BIz9kpaB7sg1NDhsaoFYnAG4OPnCqNaI+N4DK4Yl7hc2GoCDbppgmcpzcq4B14usiPAKDhADiid45rezpboCUqO7wYx2GReNfmJzXo+EszPyplSpgj0PITiJu8IX4MulwLFlpgDvS6GFhWhmdmX3h+6SorWx78f78IZGA27kiU3ISmhygSe0OjB17a88+Aw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Carlos! On Tue 04-04-23 15:48:36, Carlos Maiolino wrote: > > > + if (!dquot->dq_dqb.dqb_bhardlimit && > > > + !dquot->dq_dqb.dqb_bsoftlimit && > > > + !dquot->dq_dqb.dqb_ihardlimit && > > > + !dquot->dq_dqb.dqb_isoftlimit) > > > + set_bit(DQ_FAKE_B, &dquot->dq_flags); > > > + spin_unlock(&dquot->dq_dqb_lock); > > > + > > > + /* Make sure flags update is visible after dquot has been filled */ > > > + smp_mb__before_atomic(); > > > + set_bit(DQ_ACTIVE_B, &dquot->dq_flags); > > > > I'm slightly wondering whether we shouldn't have a dquot_mark_active() > > helper for this to hide the barrier details... > > This sounds good to me, would be ok for you if I simply add this to my todo > list, and do it once this series is merged? I'd rather avoid to add more patches > to the series now adding more review overhead. > I can send a new patch later creating a new helper and replacing all > set_bit(DQ_ACTIVE_B, ...) calls with the new helper. Yes, sounds fine to me. Honza -- Jan Kara SUSE Labs, CR