From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F11DC7619A for ; Wed, 5 Apr 2023 08:00:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50BD56B0071; Wed, 5 Apr 2023 04:00:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BB136B0072; Wed, 5 Apr 2023 04:00:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 382666B0074; Wed, 5 Apr 2023 04:00:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 255556B0071 for ; Wed, 5 Apr 2023 04:00:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7A2FC1603FB for ; Wed, 5 Apr 2023 08:00:53 +0000 (UTC) X-FDA: 80646591186.08.AD1CC01 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id 8AAFA1C0027 for ; Wed, 5 Apr 2023 08:00:50 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=nWYAwbTo; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf20.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680681650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NF83qlVzxv5rP31TK87fQBjgypo+iPk8Tgc/ff/LzS0=; b=vRj02IkY4DQui7va+8qr4eO7I65sClP5u9Eof7IcFRwbHWnc9QgzlqYhxZSjs5X29u9qR0 EqreWZ8HoWSP9Fg4gaQb6cz4yPYsjA1aEQDBc4idOfIABWsi/ap9KO5TOYPgIWS5cBKdwX Koq+nUsSvJyA3plpPH6AWp55t76XV0c= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=nWYAwbTo; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf20.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680681650; a=rsa-sha256; cv=none; b=cM9SzZkENPb61ixiGh6RlDVcL+apP54Akh9Kwar3kR7t4GYoXeciqbEaO/AV2AH/WByGV7 OYWP+UY1RJmsdO5Hgq4RBEcFnqYhz9+ONMcBj+ceY8hJ0I5Q0BtDfSEtjsCqxd2zSNUh3N pdmhcpYGndQLFy8foZPxDd9SHLND6rI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D0B2320600; Wed, 5 Apr 2023 08:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680681648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NF83qlVzxv5rP31TK87fQBjgypo+iPk8Tgc/ff/LzS0=; b=nWYAwbTopJSeJ+HfSY6AkXfF6hH7nbJMp50CUAQdErLnNegkaTgEgfo0Xtcp3Y0Zy6IYqu XsFYsercb9dhTAcnh9CiJLDMkcLllZsaGQ8D5uWxucNnpWOTOwS2i2ciWfvyLP63x+kb7Z f8bb2+A7sVt9W5n2EwOktFXUdweSbwk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 85D4013A10; Wed, 5 Apr 2023 08:00:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ai37H7AqLWQjMwAAMHmgww (envelope-from ); Wed, 05 Apr 2023 08:00:48 +0000 Date: Wed, 5 Apr 2023 10:00:47 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, Michal Hocko Subject: Re: [PATCH v3 6/8] workingset: memcg: sleep when flushing stats in workingset_refault() Message-ID: <20230405080047.5omnatjbwz46f3y5@blackpad> References: <20230330191801.1967435-1-yosryahmed@google.com> <20230330191801.1967435-7-yosryahmed@google.com> <20230404165305.ffs7uscqpndnfytn@blackpad> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xkpos56pi67t66c5" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 8AAFA1C0027 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: h9778bxu3dakqesfrz36efbcn3mwrrgf X-HE-Tag: 1680681650-32212 X-HE-Meta: U2FsdGVkX19gkZG5TZHN4C8YXyevTgGT6/Zm+8QTe1qsEeWDe7zVfwbA9XYo7MrSiAjAFgJbJfdzqGpTckj6/LM856MGQmDvZflyZeJ6wMtJXdIUjh/wDG5gSv5X2TkY5r/9lU/P729VjeXbq9qQ0UX6KMvRMMf9ZHrUMe2M0FAPv1B8UYlR+eGLeqQB544+HLT+859LxzbRl90qo17JRXhq/IPc4mckjmPdFmpLkQdVc8H4CSdFkNx/QN+QMcZnBswwDxkYtI8qKgbuEpfAYbYn64WHizgHJASVdN4Jg6ubusKtmhHj/Fqgpx3QVsuvAkVscolUoN2U63k5jIZbr4U2hoy3Uz1K6LZ9rFAC5Wn1KG8y1VoVOU5gw14fNF6qkBzJbPBTYp3TXyk5R7GIE+Gco+aIVKOev4KRa2Oha5EGIXWWTvh+Tu2bqpIJ2Lv5EkHYE8YpzO32bx8i9AVEt5+Cw00T7QD3YEXeb3oVBe8PcVZ4v7X4RzdY9ZUQs+eCaMulH4wkBg7K0wjtfO2tv2K/zleaF0X1zsDPY4U1iPHjbwQFC/9VOINEreS3+eUj3/taz0qiC53ImIalvzyVNOcWq8WRLjKyDJP5rwxsDk+5BafLnzvCIsDfHMHm332Hywuo9D65AA+CjmWLW9A666/88xPe4+cDaPGeTY45WXc1JHTInfvVk8v/8SzYXt7DFltQawWDNs/OLiqIiMt6kvWUpreyMxkiyZ27I4q8huzPbAmmYUAqIgitsST8pUM0/l91pF75ehHPv5CMSk7Bbh7cxv20V+w8Td4J8ydB6haTYlzgHCM570IlobwkMSIbEwIs5752tLBI1JbLlkG90in/ByfnjSgwDMkyO9l/rRWWT7zhHqvIKVPN+uSMolVcI/AaB3lJsYmE2edI9iiWXbaM92F4d6iuzo2iqenpUimi1pPF7bJYtkj3bmTfcmXZO/w7Uh7vQNvl9UVCvgt URlkMgeQ sRCpBQ1YhZbZ3vvFYohGHakcSKacAG+e7AzkuQIVk4UVGBvjg+OpPpcBRLe8akpsK5Envf7zbDrwdLpdYAd/3yGaq7USJPJlpXDaF4Efej1pM2ubcJzabCLT/JEiKsu6S//pe/bXDg/hAdp5vTWfpsNFL3vKkPewGka5ioZ9zkXFdNc8yKce42n+PE4/H4hcE4IaBTBQDW9SDPHVyhS2cVG/XWbooNLagazhkAJRh/8rQrFsm1u798d/ip5ahKCjQbvzOEmtplLRnshyLA6Ac05lRDfZAmLvG20/xwZAPDJGeoQ/bDlgFFrzoOJAvzYfRwh6CYg4tRUQIxoYri2V9BUM8hSShSAeslS/CfFeYxS1C0zQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --xkpos56pi67t66c5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 04, 2023 at 11:09:02AM -0700, Yosry Ahmed wrote: > IIUC there are multiple places where we can sleep in this path, we can > sleep waiting for a page to be read from disk, we can sleep during > allocating the page to read into, and IIUC the allocations on the > fault path can even run into reclaim, going into the vmscan code. So > there are precedents, but I am not sure if that's enough argument. I expect it'd depend on the proportion of the slow/fast paths. OK, let's see how it turns out in wider population. Thanks, Michal --xkpos56pi67t66c5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZC0qqwAKCRAkDQmsBEOq uQd1AP9da0usdZXtaqKldZWC3hNIo/w+tYQarhExM3TWXX+KGQEAvck6zPYNvKdu uhY4KtMQkxSOomI7xDc/A08Ae98OjA8= =ErRC -----END PGP SIGNATURE----- --xkpos56pi67t66c5--