From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9195CC6FD1D for ; Tue, 4 Apr 2023 17:32:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEA0A6B0071; Tue, 4 Apr 2023 13:32:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E72F46B0074; Tue, 4 Apr 2023 13:32:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3AB56B0075; Tue, 4 Apr 2023 13:32:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C09D16B0071 for ; Tue, 4 Apr 2023 13:32:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 86CAB1A0997 for ; Tue, 4 Apr 2023 17:32:14 +0000 (UTC) X-FDA: 80644402188.25.947D9E2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id 8DE74140018 for ; Tue, 4 Apr 2023 17:32:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Rh0Y4PUm; spf=pass (imf23.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680629532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZDEd2ByE3RJ/GX+wDkyEgy/kSR273UEz9enEYcMy1b8=; b=Q1qO6kRBxyDrAu/0P72QUiaDp7+/8v7a5rMIFg3WooobspiPdgaw84DaHhs484WgXPKnsG fF4BWUU0GJ86YInQawMxl6d0l+ZN0O8XB+nLXXKsAKHrBRTCV9DGrGzyhbxnZ6tryM1UNm lOZgEFr5/y+dR7zLA+RfXJOPmFKbvRo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Rh0Y4PUm; spf=pass (imf23.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680629532; a=rsa-sha256; cv=none; b=JqQgmaUVNNP7+MFj9UpXbATmzbF3FXEWBOv52oXSMgTe//U93UYnd/5WZwQG9i8lJ7zF+5 M+64tUO7VJcvSDQeHlwc1izoLfbuLAAKrwnbFTlPOMsGDTYeP4/lMGI2n7pVaHC4YaJf5l XBsxy91/2kj4G5z2CIrTf823WPKfow0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1656F2068F; Tue, 4 Apr 2023 17:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1680629531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZDEd2ByE3RJ/GX+wDkyEgy/kSR273UEz9enEYcMy1b8=; b=Rh0Y4PUmouQ4RsBeXmVM0zyk9aO9dNgz5lgJqiRROymxTIcq8mepaxm62rz47eD78YSCc8 N+f4YDtLQYOmbbnkmJLBZP1k25oDPW/cmNAkStneuDO2Rlp100x2xAs4rxoMS5ADGQHO/1 ESZfTdSKMrdNwWs8pTyYiI7mPWHJeys= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C0FC413920; Tue, 4 Apr 2023 17:32:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cG9ILhpfLGRJQwAAMHmgww (envelope-from ); Tue, 04 Apr 2023 17:32:10 +0000 Date: Tue, 4 Apr 2023 19:32:09 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Shakeel Butt Cc: Yosry Ahmed , Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, Michal Hocko Subject: Re: [PATCH v3 4/8] memcg: replace stats_flush_lock with an atomic Message-ID: <20230404173209.fuw2wdbhbzdgszc6@blackpad> References: <20230330191801.1967435-1-yosryahmed@google.com> <20230330191801.1967435-5-yosryahmed@google.com> <20230404165258.ie6ttxobbmgn62hs@blackpad> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tp4kmk7uybolwv2d" Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: iup6b9rsstde784mpbazofox33br3m6x X-Rspamd-Queue-Id: 8DE74140018 X-HE-Tag: 1680629532-323463 X-HE-Meta: U2FsdGVkX1+bIYi3mftIS+Ai0HE8f8XWNLaLK5p1P6vTsbbNSWWnB5vXfmdMKGH9S0Kg/o9KL6dOGXSeI5H1XJ+U4l0EjeQvY9bMK1VLdOeRFM9tMyiIcXff67BuGnN9NaYx0f74i4/Jedcd87jnNAQS5O6wqDBL+Vya/dTnbyccm/wljev/hvTHFTScStvvH29TmbmS5tRytu+F5F99gtxb57Lb1KEBUsjMmLmFQHI6NbYEKsWMFRf6dcue/Xdpo3h0GsZDgri6ZOPibLM2irNJMjYlzgXc3L1no9lme9HvXYgap6jsvBKCcqEluVpdrCc1G0ffEaz9cuJCgE5NvX3nC4sQiKnVlCN3qa3kTPIIY2pDN1yNIL5acNGw09HxG2Hh0Si0452r9HQMEtwoRZ74wqGq+jjOPhdl4lMzD4h5Jv5FVDkXyoNlXPkq1nhpaYP+9MqKc77Meawe6rrvWcjDs1miIxEZAYtXVjW1woJr5SRPZd2lS6o+9LCJ1Tch5Hy0JwdE73AFv6AMPi8RTiyPqvfls21qHsCqrVPBGCqBMeTAMDEhdYUQX/1c+x3BqsusgbzZjHoR+TT8EZ14web6uJ8vbXBQSLIjtaMLrv6IGUcbuAL1CwiIdgBOU9nbkTLaY/mXdwvzOx4Z5i71xfmVeEoIpXZh8YfvtIBUhBygt6HsEfEVYk7R2fKGQUTKn6aTkZPYDCsb1NueopsHTekuhbz1y2EET6nMFeKZ7DY2LIRRR6NcCX1wD21yp3shUnimkYKkuP7ewu8e6JdjMa7gcjS9GttEBjrA0bsH8uJZqkuAXDlzl4K2XRRG5/f+PQJzD8UdD+KoYkFgm2DhLlChBsCvsKnMFBAptNQdrloaS9C8tmpKCbRWULIBzmqVHk9q0QUG4DHkQ1fTYW2hEQ50WOGGe3ib6lV2rU6SJxMSgcsRFYmDpFGi7TaEF9wZ0duXAcghtfdDViC+erQ Twt9iwOL /ws7f4nUQOMverCFkHLR57YeHpetTtpNIMgWchN8l1Ff9R/IKQ7Bf8WzU/sU0qfAI1ZtP+g/S7H/aPom31BYaUzEbf3iu071PCyokKgMeLc/7KbkDSiGBOwoKQQcmw7Mj3ensI2cAhyOL6XLwINxahwivZ8DcIOTNc0ma/b/Q9hDyH268PIhlxiN5RzIOEqp1t2yZ9gRweflZ1jFI9xJ0WmLb8FG45Td5rlLuvcI3MMKa/05dq/VbmYToEbI0N6la01gbjpMLIS3pUqrt27pd9CyGKK5VMsj2m1qotj19T1DUmyYwwaDBZDnFXweDdSUzXhixxi3ql1MNNokxYhMV6Ghjkny0mgpYq7ETCzen+RNSNNBB3UbwgwKwYG5A1OFCB9tLRxSG32/5QdXbsMGnoB8vuOZHlc7Cn79diGuTqXU2OMOnhGSNTnc1ZQvymeyPbYNzNb7XGaAkzKJ+arMtBQYrEYgT+a4XmmcKja/RFmasmcOeXcqKN4F1OW8WJXW2s0Mg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --tp4kmk7uybolwv2d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 04, 2023 at 10:21:33AM -0700, Shakeel Butt wrote: > > Yes indeed it is. Basically we want to avoid unconditional cache > > dirtying. This pattern is also used at other places in the kernel like > > qspinlock. Thanks for confirmation. (I remembered the commit 873f64b791a2 ("mm/memcontrol.c: remove the redundant updating of stats_flush_threshold"). But was slightly confused why would it be open-coded every time.) > Oh also take a look at > https://lore.kernel.org/all/20230404052228.15788-1-feng.tang@intel.com/ Thanks for the link. Michal --tp4kmk7uybolwv2d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZCxfFAAKCRAkDQmsBEOq ubDdAP9UYeeNxfHY8xeftxD/DsD9BcOlaSaQPTOhztUjOJOmEwD+PjYu9+lFlKNJ In8lwXw/ZwMTHOjEVMnHwxc+TNnpwQk= =LYWU -----END PGP SIGNATURE----- --tp4kmk7uybolwv2d--