From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF5C9C761A6 for ; Tue, 4 Apr 2023 22:28:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D35F6B0071; Tue, 4 Apr 2023 18:28:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35C2F6B0074; Tue, 4 Apr 2023 18:28:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FD4A6B0075; Tue, 4 Apr 2023 18:28:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B4126B0071 for ; Tue, 4 Apr 2023 18:28:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D265380ECA for ; Tue, 4 Apr 2023 22:28:20 +0000 (UTC) X-FDA: 80645148360.18.07716A9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 16B164001C for ; Tue, 4 Apr 2023 22:28:18 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vAxywzSM; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680647299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D6jR5pXT3PZ1a3KPVp82u3UTyUwIA7sLEmJNj+smj5E=; b=M+o4A+Tg80uX9d0dMTyCM6zyp4WT/Xgszqfm3PSo3XRbDplK+5QIy3EoFkkldgyFQhZggG Ta0PiQhogGrQlL55zRBF/o4cx4nqL9jpGAd6TprxqcTMUjFGcR2Jtj2Uj1ol1NMwxBe7Pw pxut8sOzTnWkfNaLyEZDlWZahl9H0nM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vAxywzSM; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680647299; a=rsa-sha256; cv=none; b=ATCf3WZthKN3QqkdCrNuY14eDpk446KbdWfeZ28U1AZBJrnlbV4vqrT1EG4Cb1eI11RnsU VWc6YoPOn2v2W3bRi6lprwPiZUmMtbhLIfJN+2Bc9sIZXkgYMfr2WgJrI+oFuVIZ9GeW/6 D1R77In7OCI6H1znNGqiViYF0d9iq9k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1A20863A83; Tue, 4 Apr 2023 22:28:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C22B1C433D2; Tue, 4 Apr 2023 22:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1680647297; bh=OTTzTEX5FAK65Ptaf3F55ybCVKywhwaSU+WvIwOcWLY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vAxywzSMsDZL7luul1SA1Wj6EjObXuiwGDmtSlEtT+SvrkPVOIA0JNw1CA6wT+m5Z nBGk5WBddO3w+W3RLtJXDA5gbBdRLlrbFGYqyZvbSCZKa1ViqyD5s9rA2sjlIf6S9J psnAr+yTP9bEUu/UFgIpG/YYV4nCtEIOOZjXlQNI= Date: Tue, 4 Apr 2023 15:28:16 -0700 From: Andrew Morton To: Yosry Ahmed Cc: Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Dave Chinner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 0/3] Ignore non-LRU-based reclaim in memcg reclaim Message-Id: <20230404152816.cec6d41bfb9de4680ae8c787@linux-foundation.org> In-Reply-To: References: <20230404001353.468224-1-yosryahmed@google.com> <20230404143824.a8c57452f04929da225a17d0@linux-foundation.org> <20230404145830.b34afedb427921de2f0e2426@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 16B164001C X-Stat-Signature: g1njz41u7rczh444u8ffwkwtg4gsyiqc X-Rspam-User: X-HE-Tag: 1680647298-80433 X-HE-Meta: U2FsdGVkX186eSzMqO7WksKP/eLiKyYykViEikx+46VKBQsB1gtx/7RHZX5oR3NzLe///Iktau7fWz5QXn73Q6TxhjO4B5OywoJwOW5NiuG78tl9CMkbAY1ep7f7JptAN+DV/TH+Z62y5+JPQDYwOeOzW7hGjN4peT3fGTrwNCPkT8nx4dNCHkcNUEYsjGOA0q97dhM/0v8klRgJGxhVVIohkci6++AZquxs2ER/JIgxrst0pdOEJQvg7zdL1xlloNLjR1iriqmoQwTedm1ipjjo4KkPuQOsazlRJDjJaviTOeEkxoUI1UStHJsED5SrIwXVkYtwRJ7TEbeTrX/ZwsDN/CUdelsoLik1+owB+eqZ82T7Aq8iSq+3qdHhZt10DeDrHow2x/CjuQkQ470ya0rduixEqEPRgf0nQE2FaYOKgAon3O39k2FWhQ3qbmTIDCqbrzcIRav5BPDcWW7pnKHiYYTyrfjQfYBoJXhQ6WYa5A01/RUJkF7hGaXPLyO7XdfKLn//sq33StKHiCqblkbM7Ur06vZmH8tADVF1QkOhii64est7D5kNNkW7egrL57wUNLdtB0Ew60+p7AjJoRqPRI5/vKh4besPGr8uZfqM4Qfe0GB2ezxXEEnSHTbvPdpBqju+Wz3nByrIiLU7ciPtk0DOrX8rlOIikHVyztWWF+c9RBJMS/XostYBM4vZmg8xEU84kGpGTy89lBq5S2WoCzHhSQrOqiDbjww05K6jYTiXYsQWwMXR4qHJwUi1Fd6tCSZX4J8W1WY/WBDqPgxXQWEeXXm84hQTtY6tZdzJXwJoVsLMMV5DTGzrr68R3QVGhWo5YrXckNglyzmU3lCwQgiNhEdn8FlVu5GcfcPR/C2ayEtR8nDNVXpQQGskkeratz6Wk/bzqEK+eXE8V8mwlpGxAhB+01gIs3GmY6vYiGNofQuTt8EjkTbc5PO7Z5lQAV+RuR44HAmMPNB d9oyxfzN qykM/XFsCNjIU4ZnJR5dhfrkaOLQyEvDBRTzsGJ00gsdyKzSwp8AomSP43ujehRRQYeMKduFxMhFZooEBk/Vb6KOTrr5wW/0pu5Fv3kPxPwMy+PNRUBAEVAzRC5cP7bSUsA+mmPATNPMyonyHh7ELt1UsmPamOhas8wOaXxJvs0cQ8GHLF6/yC9M4M2TXHtK0Sa8icry/E/PfCwc0GaMQltFyrGBmTTAFchsyXn/GYhpYARYcfL0eN6uvCBR2+nSb2zYEPdVh7OWR0okUx7ELrVxG+NKQUQGPLOyhx964QGB+Dwy9ipkHZj0ARUQR1EyXQlUoAQhSEnTd+FpCv3wAp6fYYXxi3sfLDsaflsAu1dZxeVCFQJKtLgdRVxBQO+Jlcw56ZZF/VaG0WoU6FSLO/J+mTtaRj8/CMJsncX19cWcpOITcX+UeyL8Pwd8LrUDepo8H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 4 Apr 2023 15:00:57 -0700 Yosry Ahmed wrote: > ... > > > > > > > Without refactoring the code that adds reclaim_state->reclaimed to > > > scan_control->nr_reclaimed into a helper (flush_reclaim_state()), the > > > change would need to be done in two places instead of one, and I > > > wouldn't know where to put the huge comment. > > > > Well, all depends on how desirable it it that we backport. If "not > > desirable" then leave things as-is. If at least "possibly desirable" > > then a simple patch with the two changes and no elaborate comment will > > suit. > > > > I would rather leave the current series as-is with an elaborate > comment. I can send a separate single patch as a backport to stable if > this is something that we usually do (though I am not sure how to > format such patch). -stable maintainers prefer to take something which has already been accepted by Linus. The series could be as simple as simple-two-liner.patch revert-simple-two-liner.patch this-series-as-is.patch simple-two-liner.patch goes into 6.3-rcX and -stable. The other patches into 6.4-rc1.