From: Andrew Morton <akpm@linux-foundation.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
"Darrick J. Wong" <djwong@kernel.org>,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Miaohe Lin <linmiaohe@huawei.com>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Peter Xu <peterx@redhat.com>, NeilBrown <neilb@suse.de>,
Shakeel Butt <shakeelb@google.com>,
Michal Hocko <mhocko@kernel.org>, Yu Zhao <yuzhao@google.com>,
Dave Chinner <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v4 0/3] Ignore non-LRU-based reclaim in memcg reclaim
Date: Tue, 4 Apr 2023 15:28:16 -0700 [thread overview]
Message-ID: <20230404152816.cec6d41bfb9de4680ae8c787@linux-foundation.org> (raw)
In-Reply-To: <CAJD7tkZCmkttJo+6XGROo+pmfQ+ppQp6=qukwvAGSeSBEGF+nQ@mail.gmail.com>
On Tue, 4 Apr 2023 15:00:57 -0700 Yosry Ahmed <yosryahmed@google.com> wrote:
> ...
>
> > >
> > > Without refactoring the code that adds reclaim_state->reclaimed to
> > > scan_control->nr_reclaimed into a helper (flush_reclaim_state()), the
> > > change would need to be done in two places instead of one, and I
> > > wouldn't know where to put the huge comment.
> >
> > Well, all depends on how desirable it it that we backport. If "not
> > desirable" then leave things as-is. If at least "possibly desirable"
> > then a simple patch with the two changes and no elaborate comment will
> > suit.
> >
>
> I would rather leave the current series as-is with an elaborate
> comment. I can send a separate single patch as a backport to stable if
> this is something that we usually do (though I am not sure how to
> format such patch).
-stable maintainers prefer to take something which has already been
accepted by Linus.
The series could be as simple as
simple-two-liner.patch
revert-simple-two-liner.patch
this-series-as-is.patch
simple-two-liner.patch goes into 6.3-rcX and -stable. The other
patches into 6.4-rc1.
next prev parent reply other threads:[~2023-04-04 22:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 0:13 Yosry Ahmed
2023-04-04 0:13 ` [PATCH v4 1/3] mm: vmscan: move set_task_reclaim_state() after global_reclaim() Yosry Ahmed
2023-04-04 0:13 ` [PATCH v4 2/3] mm: vmscan: refactor updating reclaimed pages in reclaim_state Yosry Ahmed
2023-04-04 0:13 ` [PATCH v4 3/3] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim Yosry Ahmed
2023-04-04 21:38 ` [PATCH v4 0/3] Ignore " Andrew Morton
2023-04-04 21:49 ` Yosry Ahmed
2023-04-04 21:58 ` Andrew Morton
2023-04-04 22:00 ` Yosry Ahmed
2023-04-04 22:28 ` Andrew Morton [this message]
2023-04-04 22:29 ` Yosry Ahmed
2023-04-04 22:31 ` Andrew Morton
2023-04-04 23:46 ` Yosry Ahmed
2023-04-05 18:48 ` Andrew Morton
2023-04-05 18:55 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404152816.cec6d41bfb9de4680ae8c787@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=42.hyeyoo@gmail.com \
--cc=cl@linux.com \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=djwong@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=neilb@suse.de \
--cc=peterx@redhat.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox