From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 475CDC761A6 for ; Tue, 4 Apr 2023 14:58:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 635F06B0074; Tue, 4 Apr 2023 10:58:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E5566B0075; Tue, 4 Apr 2023 10:58:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ACEF6B007B; Tue, 4 Apr 2023 10:58:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 39B9A6B0074 for ; Tue, 4 Apr 2023 10:58:39 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0765F40F17 for ; Tue, 4 Apr 2023 14:58:39 +0000 (UTC) X-FDA: 80644015158.29.1C2A62D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 696321C000C for ; Tue, 4 Apr 2023 14:58:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FmENSU8D; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680620317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KBh4rzbfHfMkMMlE9cw+MqyUsj44Di5Ker7OlwFYGXg=; b=ywIvliZOnJUd14aMhz6vMgIoxzKpp+Kb7zN35WbE6FFTCRY+MXUc86mYcoUfj+w0Ho6hPz ovkb3nwn30U1rtL/EGxWMu/YF0oexWeQRqBvNnW1eo+tLl15wGXtWCIwIDJAtzvoNv6H1P wOGQTkJKVUirycIS900XEHWnMAGrAVU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FmENSU8D; spf=none (imf18.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680620317; a=rsa-sha256; cv=none; b=hh913CVgGfv78ToH9/AKHigC8219ej4ZG9OBlIsgdZhP5SyEO96OIaFCM4+ROA46PFodEB vD75LJJ1PWPQQAuwlS8CcdqwiaAFbXEk5NSLg+u0jkaiqNzabzLtWlBLc1uA3f1Ts7lJlS EOOwoXPzDTD+hpWa9uilYuNC8tV5i/Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KBh4rzbfHfMkMMlE9cw+MqyUsj44Di5Ker7OlwFYGXg=; b=FmENSU8DdsJwRKLNIy11pT5rwr gZFbISKwxtxGEbpRDZI+PdPBb8ubt+23BYYSER2yHfUnSI2zgXRlA/A9liB6dhfL6rTy6LYIMRvQm gyR6cAIG2mB+TC5hkfYw1+vYNcbuY++BpvLFCCjlbeWJmHkcNxGqSYl+N/wcgrOkou9YFrZd67E9m w2uM4nUqUiAoo0Tu2WJytt+fQkxTpy55fgWCKZrUonHITpNDOnhhCxIBg+tWp3ViIM8YS9U4v2tUE 9jirZfuWp7fZAvU8W0ipyUy++FGIYwgfKD5XO1ksJowLv7OYriDmtjptXbGAC0187adFlCZx+HUPA RAWV4RFA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pji6d-00FSN3-3U; Tue, 04 Apr 2023 14:57:55 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 7720D30003A; Tue, 4 Apr 2023 16:57:51 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5C05626442AC2; Tue, 4 Apr 2023 16:57:51 +0200 (CEST) Date: Tue, 4 Apr 2023 16:57:51 +0200 From: Peter Zijlstra To: Yair Podemsky Cc: linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, frederic@kernel.org, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, mtosatti@redhat.com, vschneid@redhat.com, dhildenb@redhat.com, alougovs@redhat.com Subject: Re: [PATCH 2/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Message-ID: <20230404145751.GA297936@hirez.programming.kicks-ass.net> References: <20230404134224.137038-1-ypodemsk@redhat.com> <20230404134224.137038-3-ypodemsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230404134224.137038-3-ypodemsk@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 696321C000C X-Rspam-User: X-Stat-Signature: dot5jk54juxsnf6ktn534sewkc9roori X-HE-Tag: 1680620315-738707 X-HE-Meta: U2FsdGVkX18kf1F2KPwaabNchkOu+QoA4crfZYbQUjcxH773FOJXzMchgSnMAmXhaXOOPQT+C9WKg8/b4O4byEtSB9FPyYptns2CK/YiwRlKbxglSdGghIQIIHbc1iMkANWKwqkbR4DmQBcka05l3hb9YvD1gXSE48lEKb43rrI0IOSlTSlBtVCXGDSl1aqt5pS3/yHWM/SIvdG6myZqaQ2bz8VS4nM+0fwKZHQUn5oQHWGiR+jj5sREpKpzyJRXQ5IwCXLRdrXSp2oPt6AvmnAGNJh69ne1Yxi6EDzmrj1MNB6TiUYEk1BJThQRlkStPogHzpdeEMguvLB3H0jSskxUOpyE4ySK8guuwN2h6MfVBhIdu3z9AE/9YqWTX1ftSAiU/jyapPxlkKpPLfEWmtxplnKs9+1N64nlINX1C2WhNv3BpoE7Gbt6ZSM+dcffawLrLQiGluEJlM4vnubnWcqbcYKW/EtP+CR+ODcAB2Tug1C0iFNabLVrfC5vX5YWP+Mm3uy2YbSTHRVsfnKmpQeJRgRsPq0/6ltUiIF1nraz7AE1G2sQmOOXltEIhkivYFcBtpDbfkG2RzvRzD1SuQCIOmCr1aWDOY+ZFUPfm5LKRdmof4RUoIGK8z47hBiUQkib+sbMfahAZjwyb3FfpNEx9/pg7O4u8IZ+vFHBegJB/C+Ihhgqj1uuZ/AR28ZHGna40DbgiHjEl9uBvLZHrGzBXIUy0lnDL/VBUtHuSXQoN3f44R93X5ZpYo+fPe4pY82zOJcqEe73GZHw1j0BoNP/d6psXEvoMHWwWxmfbArg5BIgsQ7HjPXk7Qo9xDq3PoOgX7Xivb+NxbDw77VPcQL4Dk9QIIHz62JV8bVyPec6GXkNyMGb3o/4kX604sYsNPtE+QhzlZeFU1rllJirrILs4dLe+3BjLfvuVdkDpfkSWgcJqIc8P2LAE+mq7KUldUWRXMIbnKvnEhmSBkz q5mrIpkZ QEqzwNGqMoxNk6Dzs7E99ICL9hj9+7VO/aueiWhasAmLP9QwBYGWtsY48le6pNbL6rvjwdDbd3LuWRfJm7Cs1Q2sQ1BHT7kNvk6E0gM91rj8IsP42fWv0y2enBRPhVf94J/gA/fawRTH4JHr98l9v8Y/IJxOXMwvQPHoLYdZLVZy0cANm7lQ0uSSgsEFGncjXHrxYFdZOCg3LF1moXFi+DTGUfvJQ723JLJnnXku5Mf8jG7Av68ZNi551YShw4nQhS1Vu3tvIlT33ZRxsiy4ZCObCMVACe2LP3Jdu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 04, 2023 at 04:42:23PM +0300, Yair Podemsky wrote: > diff --git a/mm/mmu_gather.c b/mm/mmu_gather.c > index 2b93cf6ac9ae..5ea9be6fb87c 100644 > --- a/mm/mmu_gather.c > +++ b/mm/mmu_gather.c > @@ -191,7 +191,13 @@ static void tlb_remove_table_smp_sync(void *arg) > /* Simply deliver the interrupt */ > } > > -void tlb_remove_table_sync_one(void) > +#ifdef CONFIG_ARCH_HAS_CPUMASK_BITS > +#define REMOVE_TABLE_IPI_MASK mm_cpumask(mm) > +#else > +#define REMOVE_TABLE_IPI_MASK NULL > +#endif /* CONFIG_ARCH_HAS_CPUMASK_BITS */ > + > +void tlb_remove_table_sync_one(struct mm_struct *mm) > { > /* > * This isn't an RCU grace period and hence the page-tables cannot be > @@ -200,7 +206,8 @@ void tlb_remove_table_sync_one(void) > * It is however sufficient for software page-table walkers that rely on > * IRQ disabling. > */ > - smp_call_function(tlb_remove_table_smp_sync, NULL, 1); > + on_each_cpu_mask(REMOVE_TABLE_IPI_MASK, tlb_remove_table_smp_sync, > + NULL, true); > } Uhh, I don't think NULL is a valid @mask argument. Should that not be something like: #ifdef CONFIG_ARCH_HAS_CPUMASK #define REMOVE_TABLE_IPI_MASK mm_cpumask(mm) #else #define REMOVE_TABLE_IPI_MASK cpu_online_mask #endif preempt_disable(); on_each_cpu_mask(REMOVE_TABLE_IPI_MASK, tlb_remove_table_smp_sync, NULL true); preempt_enable(); ?