From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96BF2C6FD1D for ; Tue, 4 Apr 2023 13:43:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B4F06B0074; Tue, 4 Apr 2023 09:43:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 164A96B0075; Tue, 4 Apr 2023 09:43:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0549B6B0078; Tue, 4 Apr 2023 09:43:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E9B7D6B0074 for ; Tue, 4 Apr 2023 09:43:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 97F531208FE for ; Tue, 4 Apr 2023 13:43:14 +0000 (UTC) X-FDA: 80643825108.08.F4F472A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id D52641C0021 for ; Tue, 4 Apr 2023 13:43:12 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fNVrujFf; spf=pass (imf21.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680615792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=98dFpManPARgksa4GjoMPiRXPOJRbGoDK3gntpYc2e0=; b=htWMowNSMb2vgGbjbr19AFp5s8WyXQIfKprz6me6J8S4v+nmTGR9qKA9jp7Lpxom/Tm1yi vpjH9wqSPzJMTzP4+R7HDjrN29YmM/LBbvL/bT1ZahfYrxSMrAM5U20RGQ2KeDvRZQaR5S gFBvMaRHRqMAtyptqYzUZmYQ3mmlaRo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fNVrujFf; spf=pass (imf21.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680615792; a=rsa-sha256; cv=none; b=UEwodb9saE0znb0LskRyKcyKqqnP2EZK/O0Ggumv5zcaYJgXs0BPfioTKGXlRrZGNs7Opj il3Qvglh2HNBpekm8n1XEm37R00ezNKp/d4EJQeIzXUBdGEdH7J8FZW+EQyHodEavh0Ns9 RDFOIo1WwYvhMHTBGYG37M7eIShBCtk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680615792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=98dFpManPARgksa4GjoMPiRXPOJRbGoDK3gntpYc2e0=; b=fNVrujFf+E0VfeiqniSc4PGhlSQUNjmx6whTZs6uZKjqUkREIzIEIG4n4sJFPS6xRMNOOm ioW8A1A8lfKgas5lb+cfzJycx/ZP0bdlJCZUFd6aXyngFVPHM0kst3T84f4+NE05o8jhc6 234qp0ckfzDhUFCaPstSryeWmqH8KQE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-656-C67ab_qpOfSKsM99qL632Q-1; Tue, 04 Apr 2023 09:43:07 -0400 X-MC-Unique: C67ab_qpOfSKsM99qL632Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3E405101A553; Tue, 4 Apr 2023 13:43:05 +0000 (UTC) Received: from ypodemsk.tlv.csb (unknown [10.39.194.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C2282166B26; Tue, 4 Apr 2023 13:42:57 +0000 (UTC) From: Yair Podemsky To: linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, peterz@infradead.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, frederic@kernel.org, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, mtosatti@redhat.com, vschneid@redhat.com, dhildenb@redhat.com Cc: ypodemsk@redhat.com, alougovs@redhat.com Subject: [PATCH 2/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Date: Tue, 4 Apr 2023 16:42:23 +0300 Message-Id: <20230404134224.137038-3-ypodemsk@redhat.com> In-Reply-To: <20230404134224.137038-1-ypodemsk@redhat.com> References: <20230404134224.137038-1-ypodemsk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D52641C0021 X-Stat-Signature: wsmrq5obgensu518pfty6es191ax9kbp X-HE-Tag: 1680615792-652778 X-HE-Meta: U2FsdGVkX1+lQP79yQIi12aXk89N4vkFct/oq1fH5gTXwFD21z5TsnPO44N032C/1iXgzuCTETc9DjJwi4ku+FFTHnze2W8mJVvaFDi+ZrgKQGmN0Lf34nS94iAGef7aX3xXoGaRhh1uF38vmy09XHSjRWbg5+CJnnZwR/13DM22OTxo/z6wXt/p2tVCMHOK19jPmh1paJRqB2hUcXWYWMcxoNf/DMSc97FM321qGmP9HVl2ZWF+8kQsmhD/4fYVmUWqbcG/597zjDujRp4s90ZXk78J+83icxyZYEEPV8uLi37o9SQECxlKe32Z4JWA2DMuYYS0L3S4EZaKhCvCQ/YSAGcVq+be9QQ7a/s/lCfpKYQ7I6On+okqKXiWjsARu8iJwn1V+/mRrm4RRCcI1F7IjTL82vEZYmq8WULf5z1RLjc5ofOa1gxFo6++TUsQ7m5j27UpHhtLIwrXR0zfsGRxSivLtTSWUoHyss3m7AqcefIonS76l2dyE8Uj+ngyjZ87IBo8rPRjYVPB/cnU4HyTY0EOL51jfVjVytzdHIRcNHj7AxUZed2s3HO0jgK3SffW1BgdllMeRtZKQGKRXW2IDep59m3s1nXkV2pa8qNUz1Y6M7bomrVUh8WQ4IOkapN+yrtRvW6lLScZngWrl+okY6jET6EQK0LHuFScks8A7liHYTF8jdEQuMxLMt1o8A1DyaUaoOdlRbq0ziNYKuNMfSliiNQN5DJ0Kt8AcFSMJBiEOZOUFiuYjrwXtTh0dNUtVb5nNFBWfh7xC4yYpCMY8rVBSarMIhSgCPR2hvZJ/7ofhjTIEJMC+5PZdhTdQ/7uumywDz6/AX3vRSGzP0j2bDW4d72nX6X9U/GP9RVcXATWI2S4M4B4WBgNH+72uHMyYd03qfu3JB18YhWS8iNtO5TBBUaRXe/5BD1BRxPa5shyeLFWkZHdHrVFwbGPKgAVPxD+G+g6+nGu3RV GFaFZwlI JeOi0wsYSsDZZ3NhRPdTzIKzGdzWQbT4P3WVefJOqgee74PKncc7KlJt0FudKGBYZuvGjjJ6D7/IzG0g841q2MvI9RTrfR3RoERWUbQIrd77uB2UF8qZSF5JQOg0oRcu3+Ef7rqwxKAkC4T85jkzMdTkxs/lp01d1Xxw+vBF6hwKDHd5UsgqlNS7TYlc+au09UOXfvgQ1GiAVxIgwqy7IOa6Kewdszl78Nyd8uD4KXOzeHA0OeiNO94ebzF5e5mawnwznhwB+yYiK4wFPjYeGMRT8pIB2eFNnZstWE81cY0FNgqcDApqvx28sQzMCoLi3RwVKxvazqhWU0Dg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently the tlb_remove_table_smp_sync IPI is sent to all CPUs indiscriminately, this causes unnecessary work and delays notable in real-time use-cases and isolated cpus. This patch will limit this IPI on systems with ARCH_HAS_CPUMASK_BITS, Where the IPI will only be sent to cpus referencing the affected mm. Signed-off-by: Yair Podemsky Suggested-by: David Hildenbrand --- include/asm-generic/tlb.h | 4 ++-- mm/khugepaged.c | 4 ++-- mm/mmu_gather.c | 17 ++++++++++++----- 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index b46617207c93..0b6ba17cc8d3 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -222,7 +222,7 @@ extern void tlb_remove_table(struct mmu_gather *tlb, void *table); #define tlb_needs_table_invalidate() (true) #endif -void tlb_remove_table_sync_one(void); +void tlb_remove_table_sync_one(struct mm_struct *mm); #else @@ -230,7 +230,7 @@ void tlb_remove_table_sync_one(void); #error tlb_needs_table_invalidate() requires MMU_GATHER_RCU_TABLE_FREE #endif -static inline void tlb_remove_table_sync_one(void) { } +static inline void tlb_remove_table_sync_one(struct mm_struct *mm) { } #endif /* CONFIG_MMU_GATHER_RCU_TABLE_FREE */ diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 92e6f56a932d..2b4e6ca1f38e 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1070,7 +1070,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, _pmd = pmdp_collapse_flush(vma, address, pmd); spin_unlock(pmd_ptl); mmu_notifier_invalidate_range_end(&range); - tlb_remove_table_sync_one(); + tlb_remove_table_sync_one(mm); spin_lock(pte_ptl); result = __collapse_huge_page_isolate(vma, address, pte, cc, @@ -1427,7 +1427,7 @@ static void collapse_and_free_pmd(struct mm_struct *mm, struct vm_area_struct *v addr + HPAGE_PMD_SIZE); mmu_notifier_invalidate_range_start(&range); pmd = pmdp_collapse_flush(vma, addr, pmdp); - tlb_remove_table_sync_one(); + tlb_remove_table_sync_one(mm); mmu_notifier_invalidate_range_end(&range); mm_dec_nr_ptes(mm); page_table_check_pte_clear_range(mm, addr, pmd); diff --git a/mm/mmu_gather.c b/mm/mmu_gather.c index 2b93cf6ac9ae..5ea9be6fb87c 100644 --- a/mm/mmu_gather.c +++ b/mm/mmu_gather.c @@ -191,7 +191,13 @@ static void tlb_remove_table_smp_sync(void *arg) /* Simply deliver the interrupt */ } -void tlb_remove_table_sync_one(void) +#ifdef CONFIG_ARCH_HAS_CPUMASK_BITS +#define REMOVE_TABLE_IPI_MASK mm_cpumask(mm) +#else +#define REMOVE_TABLE_IPI_MASK NULL +#endif /* CONFIG_ARCH_HAS_CPUMASK_BITS */ + +void tlb_remove_table_sync_one(struct mm_struct *mm) { /* * This isn't an RCU grace period and hence the page-tables cannot be @@ -200,7 +206,8 @@ void tlb_remove_table_sync_one(void) * It is however sufficient for software page-table walkers that rely on * IRQ disabling. */ - smp_call_function(tlb_remove_table_smp_sync, NULL, 1); + on_each_cpu_mask(REMOVE_TABLE_IPI_MASK, tlb_remove_table_smp_sync, + NULL, true); } static void tlb_remove_table_rcu(struct rcu_head *head) @@ -237,9 +244,9 @@ static inline void tlb_table_invalidate(struct mmu_gather *tlb) } } -static void tlb_remove_table_one(void *table) +static void tlb_remove_table_one(struct mm_struct *mm, void *table) { - tlb_remove_table_sync_one(); + tlb_remove_table_sync_one(mm); __tlb_remove_table(table); } @@ -262,7 +269,7 @@ void tlb_remove_table(struct mmu_gather *tlb, void *table) *batch = (struct mmu_table_batch *)__get_free_page(GFP_NOWAIT | __GFP_NOWARN); if (*batch == NULL) { tlb_table_invalidate(tlb); - tlb_remove_table_one(table); + tlb_remove_table_one(tlb->mm, table); return; } (*batch)->nr = 0; -- 2.31.1