From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6336C7618D for ; Tue, 4 Apr 2023 05:30:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C98946B0071; Tue, 4 Apr 2023 01:30:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C482B6B0074; Tue, 4 Apr 2023 01:30:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC47B6B0075; Tue, 4 Apr 2023 01:30:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9177F6B0071 for ; Tue, 4 Apr 2023 01:30:22 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4F9471A07EA for ; Tue, 4 Apr 2023 05:30:22 +0000 (UTC) X-FDA: 80642583084.29.744DD5A Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf01.hostedemail.com (Postfix) with ESMTP id 87E934000B for ; Tue, 4 Apr 2023 05:30:19 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UuaNKybd; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680586220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ppgH37wMRVgKGLen6uqYTBLEZuW5lUwNMye9sViPkQU=; b=tCI6gIemW9fUrcIrI0nbgbjCzFE5jXVjFtFg/Pn7mQ0IzZSPA0hDknKNWwtSUXTp8p8H6K RWuTTYDJ1iZQNvwzT5TgQ4iQY/C+eTLpaO/HHktg97KejMp75N6t7k+9X9spfY+1kejCwc tmiTe+L2FlrXDMN7VrYmdrgaBmGscRs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UuaNKybd; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680586220; a=rsa-sha256; cv=none; b=W67QL0RvYt59+R+NtT7Ez3c97N8a23QK7TjUt2ylAB8Hw2GM9/8HnJAIr5FTQ8N35pPXs/ eIkw05T2RqZ2Syoyy6xF+YVPTGma/3XhE+EA/xd9BOYlJYsc+Y4CtdGqfcBglg0gNxU0u9 XCqeQWff3NvVGlEZ2m8egmFSVPuBltc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680586219; x=1712122219; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ve6U2A790yFZDP2NASGkDII48rORhlhHF+QczkodZ4o=; b=UuaNKybdf6HMld7L3cp+DaehYPxhl0gYMZJ8BKDiuTmhDeyqBLL2eubx piBPiM6SNGtKhk+w09NwjibSUTyLWZgLbHxVwXYPCMFpPDZOogIA70ALs YTZ9GvtsmtGpTNrZtKk8jGGz1nsMkv0BI7WVN/EHx/K367yzz8t/IgyIF Iz7XIRIIoYaRiLRtCQHjkz1xDAVzXL4r57IoY6RLyUQWBbRoHuem94D+f MV4/3v9BzLN19KUk1ubifnXj+07H8kgrFrUh641BFlaRvTnLvu7PJbhae +KWUqnhBezPZL+kLdnmwok9xu539rFhD3dsjHktCrlTc9xAXgiCkj4qN/ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="407154288" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="407154288" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 22:30:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="810096875" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="810096875" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 03 Apr 2023 22:30:06 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pjZF8-000PEc-0r; Tue, 04 Apr 2023 05:30:06 +0000 Date: Tue, 4 Apr 2023 13:29:44 +0800 From: kernel test robot To: Danilo Krummrich , airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, boris.brezillon@collabora.com, alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Danilo Krummrich , Dave Airlie Subject: Re: [PATCH drm-next v3 04/15] drm: manager to keep track of GPUs VA mappings Message-ID: <202304041336.BD0G9U85-lkp@intel.com> References: <20230404012741.116502-5-dakr@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230404012741.116502-5-dakr@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 87E934000B X-Rspam-User: X-Stat-Signature: jpsb55wpmqr6eze3s18sgtjzi8yraq7p X-HE-Tag: 1680586219-324622 X-HE-Meta: U2FsdGVkX1/IXs4Go79I2uHweMfAtC1yp2R9GeWaYDUlZ0VaTjjI5c7pqH1Oyk7vOWZCGs7Zwprq3A2FgfwQTmaVRtZz68h1zQtgGV18wVDFWqJ4jGgju1paC0ezRgU44Tc+XCIKOE6lONQqDjqiNmO/0RbyuH59R8LGfQCXs07BIdAorG9kwIT9dKQpQ8jLkuqedq4mv/MSOPBot9Fx8P24WejPtIF9nrWGcV670/zfZbtZRV8zIC3HDSKXbvH1UQReqz5obXRQxa4lRtcxoDNVzpHsl//1Zl0Hua9XDD63x/AR1FmLlkjTVmWCaj2x6fPJR8NsAwMQ2uTsrX/IqcD7lajSH+5fMK8/7RN3lChfIlg5BGtqIAf7el3p8YvEI2x1nNgR+PvqqUD/zyKxMXhnFi5eLxCfCPXVL5tbST/sKhZ/zNIDhEqveLlujKLZAyYZydTVboU+p1/SCnY604zvHexeyESKfPjxj7du7MV7IVVltPJaL6vHLPZmam2lrZ+iVk93r6NFxplLjtSIBGuaeWlvTXgMXop+MCbJ7OGLH3ADwOwGXb8Rrn//FdI3tNWQbqwYshgUPoM8gtbajayD+N5idEBZpvHzklLhi6arzn2J/Sgq5LB02Q0DSLOuxMyxg42P61++JVXwapwglUXmYi8uivnNPntCJzaar7gVBmx1+F4OuDZLbxftvxsdSgpUsTdNUojLvPkycVyaQrnqK627k8GnHRHsxc8Dh0FzRje87i8ZAULaDebsuWyH0QFPAkmxYKKveqyfVPWUaBNJfhR6/RK6JWF8t7zMEworOw96XL8Tw0xsvoSar+XkDneKWOF2BJD6BAKJlp0TzEhc/Mj7t6unrrZhwmM40iQw+nUviIyQXeCSvSR5mNQhV9IaHdlw64XqrhV8Lu481ArHh2KMgUYlFSAoZzR8jggpX9/6edfsJIbUUZ51dR7MXfcriA/GhPlsYM9Q+pA Bn5+fuLG TN9x5WmSmHr+4IIujEENcxE6KDUErAgiIFq6Mx4SO821baDsDn5dI4Fyr6lB5JTDSeS4IF2/zftU8AvZBT89zaw8AcYBwfskDAFzD2U0KilMCS0y/tHn8DbZTFsN/bujiLMcxzKfqPKlEy6LEFI6SE6UYE3fY1lzdjJIg1wJpJo4j9rIfRlV9CvcNiU/2pGuiidpVJKmIPx6KpEbNGTJzowQmXl4iV1aRSkGoqCb0VMleu/p8c/1RuKol2OyP9Cv5oySrZFeMW8tg0gx9aE2EPCnqi81NxGe5N6xaWkUHTVhCRHZXmTMND02OD0kLRa721rKFMZtLQ7NoEhAyoFmRnXAd6ccA+LSnv1KJ39IINb2JmWZiH0eMX0eTdsPbQsVxDTnJ2IneZ1n0wCzDSsWsIl0un37siMe93u9q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Danilo, kernel test robot noticed the following build warnings: [auto build test WARNING on d36d68fd1925d33066d52468b7c7c6aca6521248] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-execution-context-for-GEM-buffers-v3/20230404-093042 base: d36d68fd1925d33066d52468b7c7c6aca6521248 patch link: https://lore.kernel.org/r/20230404012741.116502-5-dakr%40redhat.com patch subject: [PATCH drm-next v3 04/15] drm: manager to keep track of GPUs VA mappings config: mips-randconfig-r024-20230403 (https://download.01.org/0day-ci/archive/20230404/202304041336.BD0G9U85-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mipsel-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/c25139e5a168ae8a3a3e5ca0b650c201e5f41367 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Danilo-Krummrich/drm-execution-context-for-GEM-buffers-v3/20230404-093042 git checkout c25139e5a168ae8a3a3e5ca0b650c201e5f41367 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/gpu/drm/ drivers/iio/light/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304041336.BD0G9U85-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/drm_gpuva_mgr.c:1031:25: warning: variable 'prev' set but not used [-Wunused-but-set-variable] struct drm_gpuva *va, *prev = NULL; ^ 1 warning generated. vim +/prev +1031 drivers/gpu/drm/drm_gpuva_mgr.c 1023 1024 static int 1025 __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, 1026 struct drm_gpuva_fn_ops *ops, void *priv, 1027 u64 req_addr, u64 req_range, 1028 struct drm_gem_object *req_obj, u64 req_offset) 1029 { 1030 DRM_GPUVA_ITER(it, mgr, req_addr); > 1031 struct drm_gpuva *va, *prev = NULL; 1032 u64 req_end = req_addr + req_range; 1033 int ret; 1034 1035 if (unlikely(!drm_gpuva_in_mm_range(mgr, req_addr, req_range))) 1036 return -EINVAL; 1037 1038 if (unlikely(drm_gpuva_in_kernel_node(mgr, req_addr, req_range))) 1039 return -EINVAL; 1040 1041 drm_gpuva_iter_for_each_range(va, it, req_end) { 1042 struct drm_gem_object *obj = va->gem.obj; 1043 u64 offset = va->gem.offset; 1044 u64 addr = va->va.addr; 1045 u64 range = va->va.range; 1046 u64 end = addr + range; 1047 bool merge = !!va->gem.obj; 1048 1049 if (addr == req_addr) { 1050 merge &= obj == req_obj && 1051 offset == req_offset; 1052 1053 if (end == req_end) { 1054 ret = op_unmap_cb(ops, &it, priv, va, merge); 1055 if (ret) 1056 return ret; 1057 break; 1058 } 1059 1060 if (end < req_end) { 1061 ret = op_unmap_cb(ops, &it, priv, va, merge); 1062 if (ret) 1063 return ret; 1064 goto next; 1065 } 1066 1067 if (end > req_end) { 1068 struct drm_gpuva_op_map n = { 1069 .va.addr = req_end, 1070 .va.range = range - req_range, 1071 .gem.obj = obj, 1072 .gem.offset = offset + req_range, 1073 }; 1074 struct drm_gpuva_op_unmap u = { 1075 .va = va, 1076 .keep = merge, 1077 }; 1078 1079 ret = op_remap_cb(ops, &it, priv, NULL, &n, &u); 1080 if (ret) 1081 return ret; 1082 break; 1083 } 1084 } else if (addr < req_addr) { 1085 u64 ls_range = req_addr - addr; 1086 struct drm_gpuva_op_map p = { 1087 .va.addr = addr, 1088 .va.range = ls_range, 1089 .gem.obj = obj, 1090 .gem.offset = offset, 1091 }; 1092 struct drm_gpuva_op_unmap u = { .va = va }; 1093 1094 merge &= obj == req_obj && 1095 offset + ls_range == req_offset; 1096 u.keep = merge; 1097 1098 if (end == req_end) { 1099 ret = op_remap_cb(ops, &it, priv, &p, NULL, &u); 1100 if (ret) 1101 return ret; 1102 break; 1103 } 1104 1105 if (end < req_end) { 1106 ret = op_remap_cb(ops, &it, priv, &p, NULL, &u); 1107 if (ret) 1108 return ret; 1109 goto next; 1110 } 1111 1112 if (end > req_end) { 1113 struct drm_gpuva_op_map n = { 1114 .va.addr = req_end, 1115 .va.range = end - req_end, 1116 .gem.obj = obj, 1117 .gem.offset = offset + ls_range + 1118 req_range, 1119 }; 1120 1121 ret = op_remap_cb(ops, &it, priv, &p, &n, &u); 1122 if (ret) 1123 return ret; 1124 break; 1125 } 1126 } else if (addr > req_addr) { 1127 merge &= obj == req_obj && 1128 offset == req_offset + 1129 (addr - req_addr); 1130 1131 if (end == req_end) { 1132 ret = op_unmap_cb(ops, &it, priv, va, merge); 1133 if (ret) 1134 return ret; 1135 break; 1136 } 1137 1138 if (end < req_end) { 1139 ret = op_unmap_cb(ops, &it, priv, va, merge); 1140 if (ret) 1141 return ret; 1142 goto next; 1143 } 1144 1145 if (end > req_end) { 1146 struct drm_gpuva_op_map n = { 1147 .va.addr = req_end, 1148 .va.range = end - req_end, 1149 .gem.obj = obj, 1150 .gem.offset = offset + req_end - addr, 1151 }; 1152 struct drm_gpuva_op_unmap u = { 1153 .va = va, 1154 .keep = merge, 1155 }; 1156 1157 ret = op_remap_cb(ops, &it, priv, NULL, &n, &u); 1158 if (ret) 1159 return ret; 1160 break; 1161 } 1162 } 1163 next: 1164 prev = va; 1165 } 1166 1167 return op_map_cb(ops, priv, 1168 req_addr, req_range, 1169 req_obj, req_offset); 1170 } 1171 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests