From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515D4C6FD1D for ; Tue, 4 Apr 2023 12:33:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 910CF6B0074; Tue, 4 Apr 2023 08:33:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C1826B0075; Tue, 4 Apr 2023 08:33:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 761806B0078; Tue, 4 Apr 2023 08:33:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 661356B0074 for ; Tue, 4 Apr 2023 08:33:54 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 093701C6282 for ; Tue, 4 Apr 2023 12:33:54 +0000 (UTC) X-FDA: 80643650388.11.ED1F778 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by imf20.hostedemail.com (Postfix) with ESMTP id 448671C0009 for ; Tue, 4 Apr 2023 12:33:49 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=KLQuf2jw; spf=pass (imf20.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.33 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680611631; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CyluXGQ/M50MWKT/ymzRne/5E932eD39ooQcgkhBmfs=; b=ZM4sFnvN/fUcLWWWhHYhYzc6S0NNMfU4/ILxGgVWnztP6qigdcjgTW4q5xMRpQwnOyKPBr yhUgQNVSMpfs+25Ud0qEMQ6w1g6XXj1Zk73ZzeYH8rJv/nV20f2EcmynRoOzY8eH9d9nA/ vSsPkHFyRlWFhWZtmsW/EXVypwDaB5w= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=KLQuf2jw; spf=pass (imf20.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.33 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680611631; a=rsa-sha256; cv=none; b=1i6Jq97FDr+iybNRrB2iDrPDrdI+rtNDRUr3USg0lL89C5vA+szWv390vOdAcvN4+m0TMf 37sCKmAsgW6iJXLy/Jr2retnopB4HJYfKqfdvJ6HQ5TGqeme8xTN5NppOTOkHm9m4NYx5k mBJOpBFjhL9bqTzFYq3D/FG4U0sIPfA= Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20230404123346epoutp03988ea022858f085771ab6ee510f502b8~Su17D1HGQ1796317963epoutp03W for ; Tue, 4 Apr 2023 12:33:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20230404123346epoutp03988ea022858f085771ab6ee510f502b8~Su17D1HGQ1796317963epoutp03W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1680611626; bh=CyluXGQ/M50MWKT/ymzRne/5E932eD39ooQcgkhBmfs=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=KLQuf2jw34smeS2aJvc+EmHxrxVcGdhEoBK7xGnBkKxhw/efVi6X9UBoN1JWF4krS oZ3wRYw0pzCyLWbWDU2z7wcNJb/OC/bhxAJAvydYLWVgnBV5nmCj8TAKNcXf86sQ1t BNTVwsdEJgajRVbZY9CkLfTUHWFobrwEBefUfbWs= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20230404123346epcas1p42412041191e78ddf51f9dec9562d8951~Su16paRWH2695126951epcas1p4G; Tue, 4 Apr 2023 12:33:46 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.38.247]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4PrRyK5tHRz4x9Pr; Tue, 4 Apr 2023 12:33:45 +0000 (GMT) X-AuditID: b6c32a38-5fbfa70000029402-2f-642c19290181 Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id BA.FC.37890.9291C246; Tue, 4 Apr 2023 21:33:45 +0900 (KST) Mime-Version: 1.0 Subject: RE: [RFC] vsprintf: compile error on %09pK Reply-To: jaewon31.kim@samsung.com From: Jaewon Kim To: Petr Mladek , Jaewon Kim CC: David Laight , 'Jaewon Kim' , "senozhatsky@chromium.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , GyeongHwan Hong X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230404123345epcms1p1518b92632293f3f0bd7d12a29ba7c3e2@epcms1p1> Date: Tue, 04 Apr 2023 21:33:45 +0900 X-CMS-MailID: 20230404123345epcms1p1518b92632293f3f0bd7d12a29ba7c3e2 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE X-CPGSPASS: Y X-CPGSPASS: Y CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJJsWRmVeSWpSXmKPExsWy7bCmvq6mpE6KQeMtPYuXhzQtdizdzGSx 5fcbRovuzTMZLXrfv2KyuLxrDpvFvTX/WS3+P/7KarF74yI2B06P/tlT2DxmN1xk8dg56y67 x6ZPk9g9+rasYvRYv+Uqi8fnTXIB7FHZNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaW FuZKCnmJuam2Si4+AbpumTlAlykplCXmlAKFAhKLi5X07WyK8ktLUhUy8otLbJVSC1JyCswK 9IoTc4tL89L18lJLrAwNDIxMgQoTsjO2nmxkKvjHWzHph0AD4xSuLkZODgkBE4nPh5cwdjFy cQgJ7GCUaPw3lbWLkYODV0BQ4u8OYZAaYQFjiRWHzzOD2EICShJnf1xhh4jrSjR1r2YBsdkE tCXeL5jECmKLCHhKnDrbxgQyk1lgMZPEgasTWCCW8UrMaH8KZUtLbF++lRHE5hRQleg69AUq Lipxc/Vbdhj7/bH5jBC2iETrvbPMELagxIOfuxlh5vw5/pwNwi6WWNb5gAnCrpFYcW4VVNxc ouHtSjCbV8BXov3RXjCbBWjvvG/noPa6SJya1gX2ALOAvMT2t3OYQeHALKApsX6XPkSJosTO 33MZYV5p2PibHZ3NLMAn8e5rDytMfMe8J1DnqEm0PPsKFZeR+PvvGesERqVZiJCehWTxLITF CxiZVzGKpRYU56anFhsWmMDjNjk/dxMjOI1qWexgnPv2g94hRiYOxkOMEhzMSiK8ql1aKUK8 KYmVValF+fFFpTmpxYcYTYFensgsJZqcD0zkeSXxhiaWBiZmRiYWxpbGZkrivF+eaqcICaQn lqRmp6YWpBbB9DFxcEo1MMm/c9ZUck5h15CqlGJQVYyKECtu+b1D/uDD8k8ctw2/fNu25fUm N7EXVds/zCpwDm65rajfJ5+26pro8XfeyxWqXf7YTtH6vEzuco5DP9P2GeF7QvdtbDnacu1n WO1zXUNdC45HQVdlrxxf1mbJX/6Ze8vOvLV++tstTNJtDWqzHjun2QkdyJXbcHjnacGYCctW HV0xUYlB9ctnhuuFyrbHW0LjePVvGTuZHso6wPyJV27f1MtrXNwKMz58D83cMCHizX37u1Ml ap7FX7+gZ95u78vn99Zf5hCDwva3byv2Jj1mj5Pd3L/iXWbLRJtpAr6Pq5Mss8R62jkPb20S WHpnE3thtVcak8ki4T+pSizFGYmGWsxFxYkAWyO9ciwEAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230403104617epcms1p383bacbca705c0d7e4fffca6833050e42 References: <694722c9409b43808cfbc1fc9e495016@AcuMS.aculab.com> <20230403104617epcms1p383bacbca705c0d7e4fffca6833050e42@epcms1p3> <20230404101201epcms1p615a6365e64fc6e0a0fa203d41404940c@epcms1p6> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: uron41zhsfhxaduk7fix36bxnxrdxhbq X-Rspamd-Queue-Id: 448671C0009 X-HE-Tag: 1680611629-561145 X-HE-Meta: U2FsdGVkX1+1DXkLwz8RGCr4kg5oesI7uPt2q/HpLzO741rZm1M0C1gvOH6E2LY9eCyAJ+XjEECoT/eSKgaqRmRRJFWNRDjYm/AVtEInOCJrPUfzTKiqieuMdoyeQQ9N627Uk2/h3vM0raLhj4NGt9v81eXScveNZAAUOthCSVErM2flHBmJPXuixwqLiiU+JclXIIqXS00/3YrKiz5FMih0ttpj2hmOmUzpYuKrCN6X5pVJ5DiF1ulCyGCT2257JxHhKve3HOLpdHPkLpJPU/9jLouraVkvN2TaS+LbsvVjcyHWPQlwEo863CAWKmW42Zi0asa5ZCIaL4xexWsDsG/9HQKegDs/VvjVr+KmfRxUk42ckxIqevCTBxagMvGUO4SvMnlNZpLrVP+JsP9UsvxcGj4ccFuEXqAvUHnp8iBKUwEDixqer1N/cAco1f/PLbuguF4yTxbVCWaQf92r0dtEzgr9uGQh70WLPKqXle3bRomY0GmyvYLo1tP8eOMNjsTVoHqYqKFlHGzu0j5nevnU65UrOO7otdHSnZI+NSk5Yr0psaDXKRau5dpoXYMPa4BER8NUkqiNdjsTBn73+Ea7G+ZuKfMohjYIfC3CDEtyte6+yGHlBd+1cbc4nLf6UjewfDe5JKJSCyQauBysSth+enZPACTvDRcq++1yeBVorgAnN3Avfb+o2jo7botP8FDM0VpNGo/UAVpi6xjBoEPMlfji+rw4eKugfF2uN1oBY6QU/CrGvehSwiroW1ZkCvi5AIMUb9oGPEbSrm5dSh5orb5J45e0EMTsoor53tiwRPViAia3e7ED1jW1MrbYyZTD5IsEHHT29cb8fkh/75mX1Rl5YsLaRAZLXLLPhow2YWJW8gv3uM8j3J8cR/OTkXYUqEB+Pso5sO6SQz0SNoW9cZrzuVBWJCmK6Te7ZasVBx1Loev+WNCG+MO7hxRuhHN3V+TZXvYr//REm0L 9nfbOw0W zrUdcaaH62U7EDpLZ36QYrilNW+j62DPn/Jz2hS/k2qprq14W2fB0ZNR2ty0IxblTla2A9EGlIPB87j/ihmL4KCRvcJjAWMeX5VmZVoeMnvMV3oH/T91ghQx2A/ZxQmUg6f0zegybjEbiMcKyE3dNMu20WGIhYCjdvXSVUR/wG3vJsp8nlQ+NgC+mBrN+lkRdvsJYEAIsTvkyZ/YYaBQQk1i8BplQEgQ5OwGBK43qhfhmw0a8ZI9FRRcp90SXgv9N1VfoBc7kucsElf1Wui1gThQu4irpwE5vTE7L3lNvvoFkZpDOF6kBSQbcafxLn0Lv5D8yFvDOCROKj6dHYYnSqWFgVZrUcfOxdL0U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >On Tue 2023-04-04 19:12:01, Jaewon Kim wrote: >> >From: Jaewon Kim >> >> Sent: 03 April 2023 15:40 >> >... >> >> I wanted to print phys_addr_t type value only when kptr_restrict sysctl is >> >> allowed. So I thought I could use %pK for that purpose. And the physical >> >> address is not that long. I wanted to make that length short like 9 hex. >> > >> >Isn't that is the wrong format for physical addresses anyway? >> >They can be larger than virtual ones (eg x86 with PAE). >> >> Yeah, correct. I just used %pK to hide physical address, I thought it could be >> leak in security perspective. Could you give me advice how I can hide the >> address by default and look the address if kptr_restrict allow it? > >Could you please send a patch that would show what value you want to print? > >The initial mail mentioned converting %09lx to %09pK in some driver. >Then it included a warning when compiling from mm/page_alloc.o > O Oh I just found something I'm interested. I was printing rmem->base and rmem->name and wanted to hide the rmem->base. The commit aeb9267eb6b1 ("of: reserved-mem: print out reserved-mem details during boot - v6.3-rc1") just used %pa. If %pa is not good enough in security perspecitve, I think I can use %pa. Yes it was just my curiosity. I don't actually need the length. I'm OK now. Thank you >Honestly, I think that you could just use %pK or %p. IMHO, it does not >make sense to optimize it for the length. > >Anyway, there is still the question if the address is really worth >printing. Will it really help to locate a potential problem? > >Best Regards, >Petr