From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E34A8C7618D for ; Tue, 4 Apr 2023 03:12:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C3176B0071; Mon, 3 Apr 2023 23:12:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 473966B0074; Mon, 3 Apr 2023 23:12:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 361F16B0075; Mon, 3 Apr 2023 23:12:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 251486B0071 for ; Mon, 3 Apr 2023 23:12:48 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D6A2C806FC for ; Tue, 4 Apr 2023 03:12:47 +0000 (UTC) X-FDA: 80642236374.26.0448043 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf02.hostedemail.com (Postfix) with ESMTP id CECEF8000C for ; Tue, 4 Apr 2023 03:12:44 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of jiangfeng@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=jiangfeng@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680577966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=sn71M4IlYpbZ030rQlc/3baj94jqkzKxCRe+u/NCehA=; b=WBbjOPzmxrVywvR1N0eWxKcKXgNAhGrec1tvpdavoJikzlyP6FaGfTKAWpAGY29+pbqJ39 TShBmgAGCg03JLEVX+gJn5/x8nRz2jk6pn1W/X3gZCEgOI7E9W6U/QwSgUfO88aSl3aZ1p KWhHvR52YZDgIgX0t3GteoVQRLE1nkU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of jiangfeng@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=jiangfeng@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680577966; a=rsa-sha256; cv=none; b=HeMf116C21yOJ32YxIHKnaQgYzLeOWa3w4ixxSuA9WmyYkBTiOIbp5X5TtVy1uhpDSmQsz d5R6SxS0Bw9DBpnkGz+m5LTCJZgFGrXw44RSYQ5rc5gqbZIXH89xJ8kSH8dwszpNvbhixK FQDle5TMhv2Qy+eTU7xICRM+RdGtcyc= X-UUID: c5cabca270304178abb617f394213a67-20230404 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:dc36bc4e-3d52-4bd6-ae7a-aab48546efa6,IP:5,U RL:0,TC:0,Content:0,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:25 X-CID-INFO: VERSION:1.1.22,REQID:dc36bc4e-3d52-4bd6-ae7a-aab48546efa6,IP:5,URL :0,TC:0,Content:0,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:25 X-CID-META: VersionHash:120426c,CLOUDID:bbb131b5-beed-4dfc-bd9c-e1b22fa6ccc4,B ulkID:230404111238YBN49KMO,BulkQuantity:0,Recheck:0,SF:38|24|17|19|44|102, TC:nil,Content:0,EDM:5,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0, OSI:0,OSA:0,AV:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-UUID: c5cabca270304178abb617f394213a67-20230404 X-User: jiangfeng@kylinos.cn Received: from localhost.localdomain [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1792328679; Tue, 04 Apr 2023 11:12:37 +0800 From: Feng Jiang To: akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Feng Jiang , Ming Xie Subject: [PATCH] selftests/mm: fix memory leak in child_memcmp_fn Date: Tue, 4 Apr 2023 11:12:34 +0800 Message-Id: <20230404031234.78272-1-jiangfeng@kylinos.cn> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: qydyzqkwfy5pbhzyr6wn6u1ioypznfpe X-Rspamd-Queue-Id: CECEF8000C X-HE-Tag: 1680577964-167345 X-HE-Meta: U2FsdGVkX1+86wu1anW5/ISpDGyV2buwc9pos3aTeQUHSN7pG1odbJxCM15J6NG5qwx4EUuyeFnEdRueZdYHXkn3IgJ51kdqKmX0Z298WAOo9KSB0579QiwzT9IZHlaw41GIrI3+l1f6UckY4RFgyPXwedy05RUt8GXsismyEdex8OiwJZyoOB6Px6iwbU5S+TYEMEDlosFnXwQoYwSms/MNmDF75WWGRSJDv0wQMXBkf7jQQOuXeheZ8bDYEw/VZPX/kmSEG1w6uVJI3pIYs7ytaED3+kX8p2tmPw3lGj+ubN0iE+HfeK9M5XBLFFcunUbnOD6GElxW3bkYvN421Rh8dRJ5AoAllV+xntRgmvpmmr+LHXkczjreDVAhQgb9R/T7KH+sIZOxB39O+cCJpitXMNpOGz96hG814rF3uN7w/Gdm6OhMIyeaPlysH0/pCFvaFd9+if+MH7QQnIzi2nOFftEcrjXIzkaSVFC//8Bh0wXgbALQje4vDFQRMuL2uhnREeBNgXGRg/bm9gYy5a5k0QMh0cgj6EBrfwbKpQl/opK02ZkDDPl4wg1nYTVwlWV7AJXVcaphxRQncjmzYKxkWdfVT4qvfC1SSmj+CSuaTd/zWRHNogcCyztK+foqY0Jvx6wPUOs7i6IpHtk6Uxsh7IIlpphpL22PwCyXaUyrmvirCVSxa41Fe8phwv1i5KVsb485CUjnxxQFCVCd0UsABEYxevxmjZ8n0xPGcaVeOKqJToXMLSHzyRams31BwrrZ1lB5g1MjL1OQXj2/IyjhGxDJQPqtNzLvVDcZPkjO9/dYWKwVcK5uVjpfYFyWdEkKsApXrP87dayGFCnc23+wSjE87fCmhzVOnKe+eRrm4sfm9d4pTamHerDgx9+xcrNHSeACmyeGczdSk5AX/60z7D6C8WSuuyGXsZyBAYL5DP5POcw8dboLvghRSqSRi2SE7jpp1NPCMd9haxT EJEMxAt6 cFCSk/55hCQjXPWgnyW21wzSs0KYHc8P0iSGx14N+tem0SuPDt+RHpBWVAEwI7TBegJ4XKvPNIPIwJsLO5g8SOpqCPqGck87ovvNm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The allocated memory should be freed on return. Signed-off-by: Feng Jiang Suggested-by: Ming Xie --- tools/testing/selftests/mm/cow.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c index 0eb2e8180aa5..c0dd2dfca51b 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -162,6 +162,10 @@ static int child_memcmp_fn(char *mem, size_t size, { char *old = malloc(size); char buf; + int ret; + + if (!old) + return -ENOMEM; /* Backup the original content. */ memcpy(old, mem, size); @@ -172,7 +176,10 @@ static int child_memcmp_fn(char *mem, size_t size, ; /* See if we still read the old values. */ - return memcmp(old, mem, size); + ret = memcmp(old, mem, size); + free(old); + + return ret; } static int child_vmsplice_memcmp_fn(char *mem, size_t size, -- 2.39.2