From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A2AC761A6 for ; Mon, 3 Apr 2023 15:50:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FF026B0071; Mon, 3 Apr 2023 11:50:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AF6E6B0074; Mon, 3 Apr 2023 11:50:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64F7D6B0075; Mon, 3 Apr 2023 11:50:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 511086B0071 for ; Mon, 3 Apr 2023 11:50:24 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 22111160C7B for ; Mon, 3 Apr 2023 15:50:24 +0000 (UTC) X-FDA: 80640516768.02.FE47CA9 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by imf18.hostedemail.com (Postfix) with ESMTP id C0EB01C0005 for ; Mon, 3 Apr 2023 15:50:21 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="u SVpbwQ"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=t0vcoq5U; dmarc=none; spf=pass (imf18.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.25 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680537022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hvMPk2VFFCoLBECPlHT93AuyqWq9AiPkFUCgyzV1WjM=; b=LWgrfL6xvUqsc099ZGYSkT7k0XNDjZaciCsktaWDlWoNi3Q9hCUhyjjQZ4m0ueeudglzzz S3zonyMmh4YjESfjV8YL2+ox0u433BaKRLZIIRgsbUe6Hp57o+sZw3L3mg7242g8vjMUlI +edyc30tYRVQJv7y7oVDMKlS29PpWug= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="u SVpbwQ"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=t0vcoq5U; dmarc=none; spf=pass (imf18.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.25 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680537022; a=rsa-sha256; cv=none; b=4DDDfnp8POPpzlVo/CZ2E41mjKmOhgNX2fZqbfl5JNKvwGFdC38R+yANlbD+rAJ1Z7G6r0 8uhUJp16LZypfVhqPy7SqunXohaJqnYmFK94UhgNqWijn9E+IJuR/Htomvc61Gy3jDfi4M ZpCJBXcEUhGeR9m5+i/+SBX2gcZLPDQ= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 5503632009D2; Mon, 3 Apr 2023 11:50:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 03 Apr 2023 11:50:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1680537015; x= 1680623415; bh=hvMPk2VFFCoLBECPlHT93AuyqWq9AiPkFUCgyzV1WjM=; b=u SVpbwQ7v4XuHWFLanjNQ9tGfvXICUwjRsTubI1ABBNQWsniN/KY2Rnxy5epytyGn e/f3RAstVfwmlbTOdkpU0nmVgcGkKLOHiCO17obU27wROTgqV8lFN7oAzE0LXuZi OQWDGWFFnzbM0lRJlR1pwILD09/2/YV6zCZq70J5meudotAC7XH4E7YYpznDu797 PgmxWUXwAxw0bEZwrI0iy3icXz9Arb5Fd/UoY9g4bW0LNh1fGx4OnxeimVkCtu2Z 2voJYblHINLFv27+cVHv6gSC57U2xY1ymTCF7QyjC4ZK/AJX/7dPZ6/k9iLSdx9L NFUCb2z4eZPx5wD8uN/LQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680537015; x=1680623415; bh=hvMPk2VFFCoLB ECPlHT93AuyqWq9AiPkFUCgyzV1WjM=; b=t0vcoq5UGAwjtC23bgvg9IlQed7z0 6wrDfzCnaqikCyis26OmexPd1msLzDbzD3zFf1b8M4vYRKkeFcuR9zKQCS1Qa1Bb xwuJ6K94oxCyiRw1ly5ch9/Dn996moASG4fxtT+5gLvtjngp6DmEnqe+vSYEEhGP qLKKDBkGjcIKcEucirDIFH6TPYEyGvzDNC+eUclVdGCnskXe2uWLGFTIHfbkm3EF R7tZwg15nywuFSuayiRLJYrOWOvSLoeAuN/Bwd96BOD23o6eU4kC2vWiAvpqak4v w2xOuXCSMq1byennNQ1Jn1dqFPsFuMCJ2EzVZ5BzZV3nEDHk9jZXgFdEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeijedgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdttddttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpefhieeghfdtfeehtdeftdehgfehuddtvdeuheet tddtheejueekjeegueeivdektdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Apr 2023 11:50:13 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id C1C7E10D7B3; Mon, 3 Apr 2023 18:50:11 +0300 (+03) Date: Mon, 3 Apr 2023 18:50:11 +0300 From: "Kirill A. Shutemov" To: Vlastimil Babka Cc: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Dave Hansen , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv9 03/14] mm/page_alloc: Fake unaccepted memory Message-ID: <20230403155011.aodnd5ratcyeie52@box.shutemov.name> References: <20230330114956.20342-1-kirill.shutemov@linux.intel.com> <20230330114956.20342-4-kirill.shutemov@linux.intel.com> <835dfe65-d9dd-0b16-37d4-920e97f1bca0@suse.cz> <20230403143915.uc4tnpgmssvpdqxu@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403143915.uc4tnpgmssvpdqxu@box.shutemov.name> X-Rspamd-Queue-Id: C0EB01C0005 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: cdu7ys1x6n7guwad9fyezbp6d4g88m1a X-HE-Tag: 1680537021-185020 X-HE-Meta: U2FsdGVkX1+IJz9Zp1c+0g02XSvGotJOeUqlIoUesWkIUsuOL1+R7mEt7tvQ3A/75dHCh8iVcfmz13xUDkM/VdXKX9+FO0EFvvVlfh8IP0x3/ivxGuBU4XMM308O5QwAagSoWo5taO4+KMeFg2TwDcqZevK41L7hDW2oGNn7cRpb8otgpbtr5FOUmIvbCt7uXwtK50YAIiXlAUhA4UpQ+lk5YhRwQxovgQcDUzCZM2HtdXOscrU7+QYEyhzq/KnFR1EYCA7C8Sd3OWBiFAnjXdlcZNzX+vAkmi4trVp01j8uL+cxxoY8kY+76lReYcFiJI/xtjEySc2XvCkdq6QCWqDufUG/b/n2Wa26a08mi/DUbLuN8ZJnDStKD21WcjaoIe+EgLe9ZYrVsT2I9XAA+J5jA8lvXZ5WdMKC1wiqpeYf6s9PNrd9nTKhnpaCjEUlkozwU4NfmqTrtvhFTcfUfwLchzWIT1Q64+Oaxak7an964uQHDpf9L0/cKPYRYMOBzjk7+35x8DfL0YlD6xDPHHqCWmSzYrojm0gRYiom3rfDHB2/m8B02mZirtZQerawsHqCQwZK2ji4tDkkrQhkinDVpJJwtgvuIbAN0+b4LqB3arRIqiyJU6EYgyAb0IA1V6amXQljh7LsPkliD1TWBDyW1pvwufoKJvSAHiVIaFudAzJKXAelBqio7bT5SuXZv1eIqr7ZnTrkehjRKZCNOmF6EDqJLCcwaXvZM5ZsyXm7IkWbmaKcMytlIuNoUWch4U5yTOP2c2oYFqgPT+mh4HDm7PIGSqYsgZyiPjPRhWhKwo0LJmcb3HZSFiuscN5qWAUIlWIJxv8PYU06SPsJo3TSXkDqNcDKCgWwRrO5VbkvS/DNbjdJJzCOzP+p+1Gd7ENUOZlV/2zD5YdocAaoLJbQAC4AzL0T0dRm/axu8xrazI6BbOTi+vNN6kQ4XFei5kLESgdbxT+5I/uikvU 8eJUu+KX uNbm0h67RFMOTKI1xOu4yxYZw7Q7z9pmZPYCiNVbWPElG+O5K4jBWKQGTP8VQfk5+6lGQCd0tLDH0U1zVthGbBquAtT7JuvEKEvfGlBrRjd94u1Wsnzbvr7DbXB2ADziJfvKz3j9k9jgxsTwWLVHaDeh1drQr/wlZz2GIFL/tY/h8CqP2x8kiGyfQa8WYk1F+Kg/pl7ByyvJ+/9n6oLhMe8cXwDO4C+tUBrU5MQjUQubq9fsx6DTJUwTvxMT2T7uTiFdU22MgNEuhJ0LUtl0QXB6TZH+epmHWbSaPGvKd3l0brG9sPmX8RqZzOMBujzekqdZ2/Q1f0OIRAYpaEMUAFcOm+BLznGageZiEqEqnv5E+UrA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 03, 2023 at 05:39:15PM +0300, Kirill A. Shutemov wrote: > On Mon, Apr 03, 2023 at 03:39:53PM +0200, Vlastimil Babka wrote: > > On 3/30/23 13:49, Kirill A. Shutemov wrote: > > > For testing purposes, it is useful to fake unaccepted memory in the > > > system. It helps to understand unaccepted memory overhead to the page > > > allocator. > > > > Ack on being useful for testing, but the question is if we want to also > > merge this patch into mainline as it is? > > I don't insist on getting it upstream, but it can be handy to debug > related bugs in the future. > > > > The patch allows to treat memory above the specified physical memory > > > address as unaccepted. > > > > > > The change only fakes unaccepted memory for page allocator. Memblock is > > > not affected. > > > > > > It also assumes that arch-provided accept_memory() on already accepted > > > memory is a nop. > > > > I guess to be in mainline it would have to at least gracefully handle the > > case of accept_memory actually not being a nop, and running on a system with > > actual unaccepted memory (probably by ignoring the parameter in such case). > > Then also the parameter would have to be documented. > > As it is written now, accept_memory() is nop on system with real > unaccepted memory if the memory is already accepted. Arch-specific code > will check against own records to see if the memory needs accepting. If > not, just return. > > And the option will not interfere with unaccepted memory declared by EFI > memmap. It can extend it, but that's it. > > Looks safe to me. > > > Speaking of documented parameters, I found at least two that seem a more > > generic variant of this (but I didn't look closely if that makes sense): > > > > efi_fake_mem= nn[KMG]@ss[KMG]:aa[,nn[KMG]@ss[KMG]:aa,..] [EFI; X86] > > Add arbitrary attribute to specific memory range by > > updating original EFI memory map. As of now, efi_fake_mem= can adjust attributes of memory. Unaccepted is type of memory, not an attribute. I guess we can allow it override type too. But syntax is going to be fun. > > memmap=%-+ > > [KNL,ACPI] Convert memory within the specified region > > from to . If "-" is left It overrides E820 map, but unaccepted memory is not represented there. Unaccepted memory is just RAM in E820. -- Kiryl Shutsemau / Kirill A. Shutemov