From: Pankaj Raghav <p.raghav@samsung.com>
To: axboe@kernel.dk, minchan@kernel.org, martin@omnibond.com,
hubcap@omnibond.com, brauner@kernel.org, viro@zeniv.linux.org.uk,
senozhatsky@chromium.org, akpm@linux-foundation.org,
willy@infradead.org, hch@lst.de
Cc: devel@lists.orangefs.org, mcgrof@kernel.org,
linux-block@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, gost.dev@samsung.com,
linux-fsdevel@vger.kernel.org,
Pankaj Raghav <p.raghav@samsung.com>
Subject: [PATCH v2 0/5] remove page_endio()
Date: Mon, 3 Apr 2023 15:22:16 +0200 [thread overview]
Message-ID: <20230403132221.94921-1-p.raghav@samsung.com> (raw)
In-Reply-To: <CGME20230403132223eucas1p28adb1d36d39add989d46e9f175c07986@eucas1p2.samsung.com>
It was decided to remove the page_endio() as per the previous RFC
discussion[1] of this series and move that functionality into the caller
itself. One of the side benefit of doing that is the callers have been
modified to directly work on folios as page_endio() already worked on
folios.
mpage changes were tested with a simple boot testing. orangefs was
tested by Mike Marshall (No code changes since he tested).
A basic testing was performed for the zram changes with fio and writeback to
a backing device.
Changes since v1:
- Always chain the IO to the parent as it can never be NULL (Minchan)
- Added reviewed and tested by tags
Changes since RFC 2[2]:
- Call bio_put in zram bio end io handler (Still not Acked by hch[3])
- Call folio_set_error in mpage read endio error path (Willy)
- Directly call folio->mapping in mpage write endio error path (Willy)
[1] https://lore.kernel.org/linux-mm/ZBHcl8Pz2ULb4RGD@infradead.org/
[2] https://lore.kernel.org/linux-mm/20230322135013.197076-1-p.raghav@samsung.com/
[3] https://lore.kernel.org/linux-mm/8adb0770-6124-e11f-2551-6582db27ed32@samsung.com/
Pankaj Raghav (5):
zram: always chain bio to the parent in read_from_bdev_async
orangefs: use folios in orangefs_readahead
mpage: split bi_end_io callback for reads and writes
mpage: use folios in bio end_io handler
filemap: remove page_endio()
drivers/block/zram/zram_drv.c | 16 +++------------
fs/mpage.c | 38 +++++++++++++++++++++++++++--------
fs/orangefs/inode.c | 9 +++++----
include/linux/pagemap.h | 2 --
mm/filemap.c | 30 ---------------------------
5 files changed, 38 insertions(+), 57 deletions(-)
--
2.34.1
next parent reply other threads:[~2023-04-03 13:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230403132223eucas1p28adb1d36d39add989d46e9f175c07986@eucas1p2.samsung.com>
2023-04-03 13:22 ` Pankaj Raghav [this message]
[not found] ` <CGME20230403132223eucas1p2a27e8239b8bda4fc16b675a9473fd61f@eucas1p2.samsung.com>
2023-04-03 13:22 ` [PATCH v2 1/5] zram: always chain bio to the parent in read_from_bdev_async Pankaj Raghav
2023-04-03 21:19 ` Minchan Kim
2023-04-04 15:06 ` Christoph Hellwig
2023-04-04 19:31 ` Andrew Morton
2023-04-05 6:07 ` Christoph Hellwig
2023-04-11 7:34 ` Pankaj Raghav
[not found] ` <CGME20230403132224eucas1p28f82802bc40d4feb5a30bb59c6536ab3@eucas1p2.samsung.com>
2023-04-03 13:22 ` [PATCH v2 2/5] orangefs: use folios in orangefs_readahead Pankaj Raghav
2023-04-04 15:07 ` Christoph Hellwig
[not found] ` <CGME20230403132224eucas1p21fd296fbd4af70220331bb19023f4169@eucas1p2.samsung.com>
2023-04-03 13:22 ` [PATCH v2 3/5] mpage: split bi_end_io callback for reads and writes Pankaj Raghav
2023-04-04 15:09 ` Christoph Hellwig
[not found] ` <CGME20230403132225eucas1p15848db3c850e950b21b339d5861080e1@eucas1p1.samsung.com>
2023-04-03 13:22 ` [PATCH v2 4/5] mpage: use folios in bio end_io handler Pankaj Raghav
2023-04-04 15:10 ` Christoph Hellwig
[not found] ` <CGME20230403132226eucas1p182e09f5da7bc0bd284d6a8494cd40903@eucas1p1.samsung.com>
2023-04-03 13:22 ` [PATCH v2 5/5] filemap: remove page_endio() Pankaj Raghav
2023-04-04 15:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403132221.94921-1-p.raghav@samsung.com \
--to=p.raghav@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=hubcap@omnibond.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@omnibond.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox