From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F46C761A6 for ; Mon, 3 Apr 2023 10:24:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19D6F6B0075; Mon, 3 Apr 2023 06:24:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 125B96B0078; Mon, 3 Apr 2023 06:24:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE05F6B007B; Mon, 3 Apr 2023 06:23:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DBC106B0075 for ; Mon, 3 Apr 2023 06:23:59 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ABBDFAB0C3 for ; Mon, 3 Apr 2023 10:23:59 +0000 (UTC) X-FDA: 80639694198.06.302EFB2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf21.hostedemail.com (Postfix) with ESMTP id 9F9A41C0015 for ; Mon, 3 Apr 2023 10:23:57 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Y6qnWkat; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=II11lOig; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680517438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7L4iCu8UDKsr3R80mYIINoq3rDNNc4DxoBUxCYPGwho=; b=BWTlwllPI7bXig3ISbZghVOmuP9cQCezKQIo2EQD2H0Xp/3oyTEmNOgPDItGKnk9BjzORi 5pDU9XE4qZ8fYLVCOxpi2HKw9NuZtILC9iEHe1x5DnMpK4QQpFLa6NhveemaJgAS5jxPS5 Z3rtQxnMVdigB+I7jYB57W0w0yiXcZE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Y6qnWkat; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=II11lOig; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680517438; a=rsa-sha256; cv=none; b=461kWUkXNsDLrbtO9Ni2pipYELCBYjtWuIXdQZW8CVoVI7l6NW/mnA+6eQMhxrjVemBtf2 DwGXHVFR9fPsEkGeu7bZLB6aY/1JqwWmknz4R5svTrk6ejtbtkENPkFpSNcwsdSFuyhjCG FOzqoMyZ0wiKful/X95rU4/Fn19P78w= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AB28B21AB4; Mon, 3 Apr 2023 10:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1680517435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7L4iCu8UDKsr3R80mYIINoq3rDNNc4DxoBUxCYPGwho=; b=Y6qnWkatcA4T5d84MhS9mbD+PceKfO5nwiBOv3sC9oqO60kilGP2h0Uk97sFXpEWj2q6+S A7ShcbLQUvroC5O7VUyBJ2wgAOq3Ab34y8z4oLnCv8TCzIhUc6z8lL7B0r+VHnZFg9aCy8 S6guGXHa593ZbNSNspKWkve2XSxYmvY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1680517435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7L4iCu8UDKsr3R80mYIINoq3rDNNc4DxoBUxCYPGwho=; b=II11lOigKOGJf+Miarb2cKhTFRmPSInyNAH/JrfBdJvcnRRksQnpE2fHTvXVZvUh2kotiu 4tezM4Rn8xDQdlCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 979151331A; Mon, 3 Apr 2023 10:23:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4X/+JDupKmQcBAAAMHmgww (envelope-from ); Mon, 03 Apr 2023 10:23:55 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E16A4A0723; Mon, 3 Apr 2023 12:23:54 +0200 (CEST) Date: Mon, 3 Apr 2023 12:23:54 +0200 From: Jan Kara To: cem@kernel.org Cc: hughd@google.com, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL Message-ID: <20230403102354.jnwrqdbhpysttkxm@quack3> References: <20230403084759.884681-1-cem@kernel.org> <20230403084759.884681-3-cem@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403084759.884681-3-cem@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: b6dzdgz5zmi1w5cb1jx73r7rozfpu6bn X-Rspamd-Queue-Id: 9F9A41C0015 X-HE-Tag: 1680517437-522069 X-HE-Meta: U2FsdGVkX19kkyTLDSIR/vI3cWF9l4iRpym2IxKMTRByPzQBjbTPkD0lRS7I4SFnC71Vrlv9GCmDj9Gkb+582iACic0GlLrDhbns0KC1J6GgqlraGKnakKyJnmAv6yKX52qWjUzMutpnAcBaJz/gV/1GWWlrkbdeYMzWyKgHqb0nM505CBSHG5CF+ZrnQd2SpsA9ReHHhGLHvNJW4JGSOBSC/R3y1HY+gFhi2HbAsVefOkuAzuzLAUgOD7WGbZwb2hFy4BzfZXpEO3cMAf52FTQTN/dwdrt0bCRScqMsG5M8M7VGrreLVhuN0HloDiTjik1BK9c/2B4TDfDY+1YYd9fV53LvgZX0lIS1OMCqTA2LKD0JxzwAR++mCC3Oi5nqzsy5K5iFgTZmkS5xWDQZJSokQpK+/hq1IVUz0O1GG0uuk9lwGnSjjU+MIg+ypRtQv447im5hVjWoMez0l7YO6TwFJlljxF/ig5xbLzSqBfevqrIV8cGOxfNbIdWkIXw1JozaBSkSfsQ4AG6JgKcUeOu1r3PaubZaxTyYCduIDcGRZ65v6SeSfM1cQVTkWHGnjUcXQvgPlyemWhWyyeRVPn7YZgw+CvOkhXaQ8EyCBQpNOqm7ft/FnO3LQeD9QxjQWTuuF8GGElt4mEsiuDAx1Jb4JaI7yZZBR6aoy6Uwuk/VuZv06JOWRDzCXjHSi0BQxD6wbnTWqYMjc8+NFIs+jEWlTL2OkxU3iu4h04lktXgwQxjn8TDou2NMaYLfkoo0zQSEAx2PvC8DoiKLOm9jq6ugMCOaoymNuI0XBjghH28WkP41rtsSpFFVUdw0bf2uXYt4grYatpF00SJSMTY46v+EP9dcpRfCgtFdzRHRw0bu9/56RFyalWWdxXODkgsVaULvoUxFbX+kG+ZBs2+wJuAjZoNDXpaqavVwVCiU0b+33EpBxRMYZ8v+ghoca93KMRZ3/bhL+aY0p3scN7V QcHsJqRj 51uG+57SodOILgV2JcugFZg2INGiBSWkPibVFME+77S+A5lBQA6ed1+iV299Ula9xIWEGKa0kha68+iHLUx74FIslvJgjAELV8ZGeabuNpuR/Aq/pere99oO4eftUotv94bNFi63cLgxcxA0DGjFhZTteMZFr0B/uLE48KK3BZgD92ib5ExiqdUGQrNz6xj1zZJQXPuApAzElOu+xTuL3Bzz5LEa5vNAjIg9YozYro/lVSALMFRBx36NSX+v23hm6AxwF8OPO6disHsTNwL8yyRoldbdSyJOvIBONYCrfyXCbD+jIcv6TwgPW8yi8YE7et8IgUWc2nHAMcvWvR3+IUKdoFTWoqxplamndrKx5Cd68rUR1L9+54udMz2NaW+blm7MoOeIsRk2vnug= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 03-04-23 10:47:55, cem@kernel.org wrote: > From: Lukas Czerner > > Make shmem_get_inode() return ERR_PTR instead of NULL on error. This will be > useful later when we introduce quota support. > > There should be no functional change. > > Signed-off-by: Lukas Czerner > Signed-off-by: Carlos Maiolino One comment below: > @@ -2958,21 +2967,24 @@ shmem_tmpfile(struct mnt_idmap *idmap, struct inode *dir, > struct file *file, umode_t mode) > { > struct inode *inode; > - int error = -ENOSPC; > + int error; > > inode = shmem_get_inode(idmap, dir->i_sb, dir, mode, 0, VM_NORESERVE); > - if (inode) { > - error = security_inode_init_security(inode, dir, > - NULL, > - shmem_initxattrs, NULL); > - if (error && error != -EOPNOTSUPP) > - goto out_iput; > - error = simple_acl_create(dir, inode); > - if (error) > - goto out_iput; > - d_tmpfile(file, inode); > - } > + > + if (IS_ERR(inode)) > + return PTR_ERR(inode); This doesn't look correct. Previously, we've called finish_open_simple(file, error), now you just return error... Otherwise the patch looks good to me. Honza -- Jan Kara SUSE Labs, CR