From: Hillf Danton <hdanton@sina.com>
To: Mike Galbraith <efault@gmx.de>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, corbet@lwn.net, qyousef@layalina.io,
joshdon@google.com, timj@gnu.org, kprateek.nayak@amd.com,
yu.c.chen@intel.com, youssefesmat@chromium.org,
linux-mm@kvack.org, joel@joelfernandes.org
Subject: Re: [PATCH 14/17] sched/eevdf: Better handle mixed slice length
Date: Sun, 2 Apr 2023 14:28:32 +0800 [thread overview]
Message-ID: <20230402062832.407-1-hdanton@sina.com> (raw)
In-Reply-To: <ba994b0f4b4402612d2e14552882c29dca83ad5f.camel@gmx.de>
On 02 Apr 2023 04:40:20 +0200 Mike Galbraith <efault@gmx.de>
> On Sun, 2023-04-02 at 07:23 +0800, Hillf Danton wrote:
> > On 31 Mar 2023 17:26:51 +0200 Vincent Guittot <vincent.guittot@linaro.org>
> > >
> > > I wanted to stress this situation with a simple use case but it seems
> > > that even without changing the slice, there is a fairness problem:
> > >
> > > Task A always run
> > > Task B loops on : running 1ms then sleeping 1ms
> > > default nice and latency nice prio bot both
> > > each task should get around 50% of the time.
> > >
> > > The fairness is ok with tip/sched/core
> > > but with eevdf, Task B only gets around 30%
> >
> > Convincing evidence for glitch in wakeup preempt.
>
> If you turn on PLACE_BONUS, it'll mimic FAIR_SLEEPERS.. but if you then
> do some testing, you'll probably turn it right back off.
>
> The 50/50 split in current code isn't really any more fair, as soon as
> you leave the tiny bubble of fairness, it's not the least bit fair.
> Nor is that tiny bubble all rainbows and unicorns, it brought with it
> benchmark wins and losses, like everything that changes more than
> comments, its price being service latency variance.
>
> The short term split doesn't really mean all that much, some things
> will like the current fair-bubble better, some eevdf virtual deadline
> math and its less spiky service. We'll see.
>
> I'm kinda hoping eevdf works out, FAIR_SLEEPERS is quite annoying to
> squabble with.
Yeah no matter whatever role FAIR_SLEEPERS could play next week, this paves
a brick for Vlastimil Babka to take it over leaving Peter happy to sit
back with netflix on.
next prev parent reply other threads:[~2023-04-02 6:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230328092622.062917921@infradead.org>
[not found] ` <20230328110354.641979416@infradead.org>
2023-03-30 7:53 ` [PATCH 15/17] [RFC] sched/eevdf: Sleeper bonus Hillf Danton
[not found] ` <20230328110354.141543852@infradead.org>
2023-03-30 11:02 ` [PATCH 08/17] sched/fair: Implement an EEVDF like policy Hillf Danton
[not found] ` <20230328110354.562078801@infradead.org>
[not found] ` <CAKfTPtAkFBw5zt0+WK7dWBUE9OrbOOExG8ueUE6ogdCEQZhpXQ@mail.gmail.com>
2023-04-01 23:23 ` [PATCH 14/17] sched/eevdf: Better handle mixed slice length Hillf Danton
2023-04-02 2:40 ` Mike Galbraith
2023-04-02 6:28 ` Hillf Danton [this message]
[not found] ` <20230410031350.GA49280@maniforge>
2023-04-10 8:23 ` [PATCH 00/17] sched: EEVDF using latency-nice Hillf Danton
2023-04-11 10:15 ` Mike Galbraith
2023-04-11 13:33 ` Hillf Danton
2023-04-11 14:56 ` Mike Galbraith
[not found] ` <20230412025042.1413-1-hdanton@sina.com>
2023-04-12 4:05 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230402062832.407-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=corbet@lwn.net \
--cc=efault@gmx.de \
--cc=joel@joelfernandes.org \
--cc=joshdon@google.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=timj@gnu.org \
--cc=vincent.guittot@linaro.org \
--cc=youssefesmat@chromium.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox