From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFB3C76196 for ; Fri, 31 Mar 2023 20:51:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEA5C6B0072; Fri, 31 Mar 2023 16:51:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C99E56B0074; Fri, 31 Mar 2023 16:51:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3AE06B007B; Fri, 31 Mar 2023 16:51:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A51A66B0072 for ; Fri, 31 Mar 2023 16:51:23 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6CAFDC1219 for ; Fri, 31 Mar 2023 20:51:23 +0000 (UTC) X-FDA: 80630388846.12.C36F538 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf27.hostedemail.com (Postfix) with ESMTP id 8A76B40010 for ; Fri, 31 Mar 2023 20:51:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=sXAFDda3; spf=pass (imf27.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680295881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JRtzt5673pTBKCFQHX4UYCBd1m8JBF6Zbrrqfs4di9A=; b=s4N2zt+1jZ1p56glc97vQURe73kDfAue0fYf3EQJmXhyPHwFlA/JrGyPbKPouxj+/5UZ0A NnnjMB34cMoGNLZ9TKWWp/fZEwaRlFGk26HuYe8uNKftpyKD+7y3e0XRxKf057iLP6rf1q wgVFjTl7uCbsioxHTamMXELw6Ir1NZ0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=sXAFDda3; spf=pass (imf27.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680295881; a=rsa-sha256; cv=none; b=KpPvmwPyNVYAwLR2XTnREloiv6YNhr/DIvCb5zaMVj6uOJrlJo3GWRgEisFFvOIDXjtJpF Ir5kb61Wz414Ii5SFWLFiVGgzmb6oc9Ie7WJvkYeYw3UNPLFHOzNrxdVcw96KGYyV9hjOf l2RUmdoTXjrnjWXa1KtaykWSuGQuzwU= Received: by mail-pl1-f180.google.com with SMTP id z19so22447066plo.2 for ; Fri, 31 Mar 2023 13:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; t=1680295880; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JRtzt5673pTBKCFQHX4UYCBd1m8JBF6Zbrrqfs4di9A=; b=sXAFDda3zkcwpKdTpeSLhqOkOCproJyUjAxYnkIZqqtYJQR0zPt3ML4D1hMXQBwS9g a0nmSOSxm4Bseka1sDryDTasxJXpwTjTq3427t6UMW+Eqr28vGQXGdBd8sddp3cvjpDt MUGDPWdU3UQ2dyd/yPEaofbIJI2VdqxJPnEKIxShKwvUqsEpGLWL2FoYOGyJ3/JVXC6t TMjPJjW9gs7HPq0qrBIqlXCZ9oamDENbToQItl4kQnuEQVrZin0EKEd03vQuXgbLd4bm xsCvzf1fGNGnnrkyiSG+DDovI5RqIqi4/QOj3voi0jP5UvS9ZDRl0JXrNnFYX09llJ6+ wQ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680295880; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JRtzt5673pTBKCFQHX4UYCBd1m8JBF6Zbrrqfs4di9A=; b=iJ3QxuIbrOEYsactJ7eCWHXnS6sEY2yhtCEHCYy1+TxlV0IjaaW115TAX9fJH0Jtlo bJtqzC9zJFvsduD9pDT/VTkMD8iypPeeC8Hb5mvMfxexH3K1/558/RuAJDfCnnAFYt/1 g80LJyAmkLH9/9F6MldaWpa9ttbrJX0GLqn/tA/mgFBWIgEChmn3KY5DldUlqBDrBQVY cib6znlji1b1YiXpqy6Kk8Nj9HJbH/tX9E8DIX0BEgQDpeyifImdXUrxMC8uQ5k5GFjT k0Wyt78UqVYiy4wAxv7WmatzAgcRwHrs/InTxOwJYFwnvNgwptk2SH5v8Bh+z2y/RPYb hFCQ== X-Gm-Message-State: AAQBX9camgML36rEKqRL/l3jx+LSkw3tRZ3EvCMgz1NbaUiCvOaBo9WU EobciuFT5FVn8yxDxQRcm9GdDw== X-Google-Smtp-Source: AKy350Zd1SJBPcPtRskYI01NIeYVd9XIyz1RMBNV6xb7+9mZreUhDv4A1BbFCs/GjenmQlsecveCdQ== X-Received: by 2002:a17:902:db10:b0:1a1:f5dd:2dce with SMTP id m16-20020a170902db1000b001a1f5dd2dcemr31879426plx.6.1680295880383; Fri, 31 Mar 2023 13:51:20 -0700 (PDT) Received: from dread.disaster.area (pa49-181-91-157.pa.nsw.optusnet.com.au. [49.181.91.157]) by smtp.gmail.com with ESMTPSA id t16-20020a170902b21000b0019a997bca5csm1967102plr.121.2023.03.31.13.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 13:51:20 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1piLiP-00FUn3-2r; Sat, 01 Apr 2023 07:51:17 +1100 Date: Sat, 1 Apr 2023 07:51:17 +1100 From: Dave Chinner To: Yosry Ahmed Cc: Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 2/3] mm: vmscan: refactor updating reclaimed pages in reclaim_state Message-ID: <20230331205117.GI3223426@dread.disaster.area> References: <20230331070818.2792558-1-yosryahmed@google.com> <20230331070818.2792558-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230331070818.2792558-3-yosryahmed@google.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8A76B40010 X-Stat-Signature: jziokqjifaz5ddtumw8ctpzddk4wxpin X-Rspam-User: X-HE-Tag: 1680295881-538791 X-HE-Meta: U2FsdGVkX1/Az+kejF9coNsJSKG9Q65YU+tgwHKLM6n5T235nz/jNb+npaKfh+nLFcJUU5IBUYcBl9i7v9d+aeMu0kuYURij/DMbt85FVvMkL2dK21SEDK2rIK1VXVbH67HNZI7p1E86hNCl3EhcKc+w3B9x7KUr+mKtGsSOOth8EO6aW1RnIzZu1JT2ayPXVsoPta5Tzl70fURxCWmDMoHUx39sRa1BKuBEss3JXd88mv6RF9wZHe0xc7vrfqiK2Z4DfFnDyq0/0CPAgHyqMNrB1jxKmPX4ExP+CtS8P7vRIDHnAH4jal5wflZxfbTlrn4wKwhoejp+HyW7quJ4DaEVTwltS1h73havGoxdvOObzD5zROwilyqZvVZJo1SWVHrQb8VMurIm4NogDRb3lZdUox+vtw3xMrIcnL8Jqv1RVuSx6AWqlRQ5EwLGYsPrs/r16r9PiAvm03hcgwQ2cVoUmSPNk9VwNpbKSG2fKsexWAKmoVOe26lHyH5lvhiFW0uXfEjC/3XytcpIcyrYV/iIkGCoC2UJ9E1Pl/Q8PRw9LvgPdEjFZsHX5H+3xmZ8OoINqW3h4g3o8TQrF+yvZIMoJkuovtFUZFendVZLpTTTZNJY93Agec4cnFlJmxuGqkarHZFc4i3A7iHxh+bT6pO6Fm3hBw7AZ5RqkTPyD6wnXCeAbQKV7HchW4SLi6ZCsx9QOiVAb2gtKQCgRW1lk+NDrpxszJYYa7FjDxPprZuSQY4MWSRtmVIIXOqZF1itFvQAM7iFBPwF17mNoCnSG0Pzrr3mYywTQ1RoAZhWCQ1RVf4Mmr47oC4tzA6glRhSXt/igqSWBw4Ro/t8I1b4DIGhSw1Y38lcfOrRWHH0C2VbeqdNwkuCHMIDtQ2Zi8647VBc2oxPnoDkeIDOIOItuhTN3Bcqbd5aRREZ7jLy94+Z5ooJyYUwPFxB4XnU4h3vNmF7FUY4tW8cz6gpQ6q osjivWlm NMRxZD/vy38P0OCLMNNatnL4KHamM4UeEMsTa1cTCBWSxz42XbWOn91FHgG6Lm/WJJ2WuIyujJyDqH3vT44DimlssYpLhimmT/pThMyvRdSvfM8/wKvjUIxL5GGhUBQbttKODAL92iyBLFWx2bUGjJSz1mze9jUTw0EvPUXtD8EXTjWEeVFhvdg+gDH9VzC7ZbpW1DmLj6iBxYmW0AAOxOelQA9DeCM1+/K5yf9FGVMI+rpaWKQI6m9hHlVGF5EFpDDhDH/K4DsPrY1xya3GM0+QfVtvD7qAFXp/aPZ8VOtWvkH8WmGFTltfTUAJggORBcUid9ucImdU3JU/MfRqKkpOEZOWVj07wcynXGV3mlNQTs6j3kefqq9pNt6+Q7FOLB7z6H03svaHkjPa3yyUdaDgAYbGmwmMO8yDP0vwaaS2XiMbLF3iSCmW1BN0ghg7twtNihTY/O86BEHtHqGnU+S1g/Y/zQJ32crh+R5yhO8cUb8me03tsozI7PW1pkIddh7wjt/UyMoK/InrBG2BBMwSoQZG7GB2xbWhllTNBx7lcV9Tr3PK8ommvaVcjON+WOGQ1nBheT+gsbGZXc8a/GB2ixwwxtmlCPWeN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 31, 2023 at 07:08:17AM +0000, Yosry Ahmed wrote: > During reclaim, we keep track of pages reclaimed from other means than > LRU-based reclaim through scan_control->reclaim_state->reclaimed_slab, > which we stash a pointer to in current task_struct. > > However, we keep track of more than just reclaimed slab pages through > this. We also use it for clean file pages dropped through pruned inodes, > and xfs buffer pages freed. Rename reclaimed_slab to reclaimed, and add > a helper function that wraps updating it through current, so that future > changes to this logic are contained within mm/vmscan.c. > > Signed-off-by: Yosry Ahmed ..... > diff --git a/mm/vmscan.c b/mm/vmscan.c > index fef7d1c0f82b2..a3e38851b34ac 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -511,6 +511,34 @@ static void set_task_reclaim_state(struct task_struct *task, > task->reclaim_state = rs; > } > > +/* > + * mm_account_reclaimed_pages(): account reclaimed pages outside of LRU-based > + * reclaim > + * @pages: number of pages reclaimed > + * > + * If the current process is undergoing a reclaim operation, increment the > + * number of reclaimed pages by @pages. > + */ > +void mm_account_reclaimed_pages(unsigned long pages) > +{ > + if (current->reclaim_state) > + current->reclaim_state->reclaimed += pages; > +} > +EXPORT_SYMBOL(mm_account_reclaimed_pages); Shouldn't this be a static inline in a header file? Then you don't need an EXPORT_SYMBOL() - which should really be EXPORT_SYMBOL_GPL() - and callers don't add the overhead of a function call for two lines of code.... -Dave. -- Dave Chinner david@fromorbit.com