From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57ABEC76196 for ; Fri, 31 Mar 2023 12:28:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B4FC6B0071; Fri, 31 Mar 2023 08:28:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 863A36B0072; Fri, 31 Mar 2023 08:28:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B7786B0074; Fri, 31 Mar 2023 08:28:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 58D316B0071 for ; Fri, 31 Mar 2023 08:28:34 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1D3B4140FC4 for ; Fri, 31 Mar 2023 12:28:34 +0000 (UTC) X-FDA: 80629121748.07.392B22D Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf11.hostedemail.com (Postfix) with ESMTP id 25E9240002 for ; Fri, 31 Mar 2023 12:28:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=rAnn6Xpy; spf=pass (imf11.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680265711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sy3H02Yklmpq02OAKYlLX6Sc0hq4r61yxZwpspFLrV4=; b=iXSbA0uEUmTePn4FUb4h+3Z604KsPZUoBIXsojdULMOkaBq2EFiB938SjDiQrOtD2R/KS8 AUrGAqnskNFBRxl5V4PYy8ScgGZAlR1FrH3cLKiGP9HMhcvd/JED8I5LX8sVCpAU2+0sfS fNYk6GIOAZ4KDH282xDKf8dZWmQ6yv0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=rAnn6Xpy; spf=pass (imf11.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680265711; a=rsa-sha256; cv=none; b=Bpask+/2/hjPyRb41Aulif2SvVRopdjrsvW307UU7hXE/VK3+9s7pAohLNNkk/+u+Bm9fp xaEJyRq8eH2YHjc3cIV9xhyiMKixg/lPm9pFF/8js9U7+qZd/P0iWE4guzB+JDbIZDHcZ/ nNPTV0g2a3YDTDoZp2GlACthGQ3vLYQ= Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230331122829euoutp0143cd61870c2f6b3d1593d8f0b0888c1d~RgMKT8JV81109011090euoutp01S for ; Fri, 31 Mar 2023 12:28:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230331122829euoutp0143cd61870c2f6b3d1593d8f0b0888c1d~RgMKT8JV81109011090euoutp01S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1680265709; bh=sy3H02Yklmpq02OAKYlLX6Sc0hq4r61yxZwpspFLrV4=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=rAnn6XpyV73weoWDRzxGpTgYBjyYe+RSOigzQQxyx0iwWEpV6c73java4tfeFH5aK kc1nBpN7O4POvrSTLrwhr51c7/FIj6+6bBKORkEjs/SIVJ3u8iUzKedlNUn/DBNAJk Jvy/OpI1ahxBBeir/gnLTuruCyxoUMLeHCqqzZYM= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230331122828eucas1p2221a593a3ccb1b434b1da25a71533046~RgMKBh0II1636116361eucas1p2T; Fri, 31 Mar 2023 12:28:28 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 69.8A.09966.CE1D6246; Fri, 31 Mar 2023 13:28:28 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230331122828eucas1p18e0bbbda45a6955f59fc82b29f42a8bb~RgMJifuNI3167431674eucas1p1Z; Fri, 31 Mar 2023 12:28:28 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230331122828eusmtrp201ce7800d6dbc2a659cda30347164a5b~RgMJhvdcU3136031360eusmtrp2K; Fri, 31 Mar 2023 12:28:28 +0000 (GMT) X-AuditID: cbfec7f4-d39ff700000026ee-91-6426d1ece90a Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 69.7F.09583.CE1D6246; Fri, 31 Mar 2023 13:28:28 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230331122828eusmtip254994547f7b3b5d847ad1a6ec553e362~RgMJVz-6Q2915729157eusmtip2I; Fri, 31 Mar 2023 12:28:28 +0000 (GMT) Received: from localhost (106.110.32.140) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 31 Mar 2023 13:28:27 +0100 Date: Fri, 31 Mar 2023 14:20:11 +0200 From: Pankaj Raghav To: Johannes Thumshirn CC: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , , , , , Song Liu , , Mike Snitzer , Matthew Wilcox , Dave Kleikamp , , , Bob Peterson , Andreas Gruenbacher , David Sterba , Subject: Re: [PATCH 13/19] zram: use __bio_add_page for adding single page to bio Message-ID: <20230331122011.nq27xmkqmajvx6a5@blixen> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <339841b3b7ce6b2faf56bcaf9d92e298d878ef64.1680108414.git.johannes.thumshirn@wdc.com> X-Originating-IP: [106.110.32.140] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNKsWRmVeSWpSXmKPExsWy7djP87pvLqqlGJz9q2+xbd1udovVd/vZ LE6ufsxm0dr+jcli77vZrBYXfjQyWexZNInJYuXqo0wWFz+2Mln87brHZPH06iygklvaFpce r2C32LP3JIvFvTX/WS3a5+9itDg0uZnJomt2K5vF7Ts/mC1O3JK2OL78L5vF7x9z2BzEPDav 0PK4fLbUY9OqTjaPTZ8msXvsXvCZyWP3zQY2j97md2we7/ddZfNYv+Uqi8fm09UenzfJebQf 6GYK4InisklJzcksSy3St0vgythycCtLwXyWik/vPzM2MO5i7mLk5JAQMJHYuec4YxcjF4eQ wApGiaZrv9kgnC+MEo9unYdyPjNKfDj9hgWm5d6kN0wQieVAVb9OMMFV/fiwih3C2cIocfja e0aQFhYBVYlfS5uAEhwcbAJaEo2d7CBhEQFjiSvfF7KA1DMLHGWVOPL6H1i9sECwRMenL2A2 L9C6JSuuMUHYghInZz4BO4NZQEdiwe5PbCAzmQWkJZb/4wAJcwokSlycchrqOSWJhs1noK6u lTi15RbYoRIC/zglHn1dCVXkItHa9wmqSFji1fEt7BC2jMT/nfOZIOxqiac3fjNDNLcwSvTv XA+2WELAWqLvTA5EjaPEh+ermCDCfBI33gpCnMknMWnbdGaIMK9ER5sQRLWaxI6mrYwTGJVn IXlsFpLHZiE8toCReRWjeGppcW56arFRXmq5XnFibnFpXrpecn7uJkZg+jz97/iXHYzLX33U O8TIxMF4iFGCg1lJhLfQWDVFiDclsbIqtSg/vqg0J7X4EKM0B4uSOK+27clkIYH0xJLU7NTU gtQimCwTB6dUA9Pi3qdGz/s9tdgZs7dEvDzRoeu3cuJflcIf9xLN3mTPX8cj/7FtMWf84VOm W/efD3GNO5Z/98G7F5PerH7WciD4WlaD6/81qq13dyu4XzNYNfG6zdlKkTVslx/IvYvUvvk6 VKPql75r/QPjmcfO5q2t3ffzT7b5pmntInvCrBI2nQnJvHE8eJXfN/60FEON8mWix5VYFJ9+ Cfp+8qnK109Lrx2rmDhF5Fd8+/1zpjFGjJGXtZLyXZ+dn/drKu/rlokhX47Ht6xdmyg8id1r 9c91sRxf5c/cEC/ynjildvOrUmXnrzrxC9Z8mLe+bNpNxQW7m/uO757mwXbvi/L6OcHHtI87 bPlgJeP9tn5GQi+jqhJLcUaioRZzUXEiAMYrDlwOBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsVy+t/xe7pvLqqlGKycLGCxbd1udovVd/vZ LE6ufsxm0dr+jcli77vZrBYXfjQyWexZNInJYuXqo0wWFz+2Mln87brHZPH06iygklvaFpce r2C32LP3JIvFvTX/WS3a5+9itDg0uZnJomt2K5vF7Ts/mC1O3JK2OL78L5vF7x9z2BzEPDav 0PK4fLbUY9OqTjaPTZ8msXvsXvCZyWP3zQY2j97md2we7/ddZfNYv+Uqi8fm09UenzfJebQf 6GYK4InSsynKLy1JVcjILy6xVYo2tDDSM7S00DMysdQzNDaPtTIyVdK3s0lJzcksSy3St0vQ y9hycCtLwXyWik/vPzM2MO5i7mLk5JAQMJG4N+kNUxcjF4eQwFJGiZndO5kgEjISn658ZIew hSX+XOtigyj6yChx4v4mdghnC6PExBefwKpYBFQlfi1tArI5ONgEtCQaO8HCIgLGEle+L2QB qWcWOMoq8evLRVaQhLBAsMStLzsYQWxeoDOWrLgGdcYURolFnyezQiQEJU7OfMICYjML6Egs 2P2JDWQBs4C0xPJ/HCBhToFEiYtTTkO9oyTRsPkMC4RdK/H57zPGCYzCs5BMmoVk0iyESQsY mVcxiqSWFuem5xYb6RUn5haX5qXrJefnbmIEppFtx35u2cG48tVHvUOMTByMhxglOJiVRHgL jVVThHhTEiurUovy44tKc1KLDzGaAoNiIrOUaHI+MJHllcQbmhmYGpqYWRqYWpoZK4nzehZ0 JAoJpCeWpGanphakFsH0MXFwSjUw5R9bcLzD4NIWde1u7fOP/SucVqQIqGQuy140dyW/WHqq LouScp+Uk/cjIYskyYc3meaefvvsxeqzCVukT/42ktXKLKvaGeKvGOnWpb30lf3GQmc5lquX 6xidCvd/Ed26rWu15O9re02m27Hl/Jzt9fak9NRiwTvVnnm88wXCv7H4HL6+K0Q2Vuf/xLeb G66KfwsSzK+e2sApdtD15JSgMG5bwdPnb802a90RsdQo7mWV6NP3pQKzlJZfVltyOsb47fYf /vzvQhosjrW8Sywu81/1Kf5+xkPhzNl7vvfum/nqee4ClnvHJcKi0uqSPvy3FzYpehp2xcZ7 V05ct/838c3ym1sf8H1L49i80iVGiaU4I9FQi7moOBEABax/UawDAAA= X-CMS-MailID: 20230331122828eucas1p18e0bbbda45a6955f59fc82b29f42a8bb X-Msg-Generator: CA X-RootMTR: 20230331122828eucas1p18e0bbbda45a6955f59fc82b29f42a8bb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230331122828eucas1p18e0bbbda45a6955f59fc82b29f42a8bb References: <339841b3b7ce6b2faf56bcaf9d92e298d878ef64.1680108414.git.johannes.thumshirn@wdc.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 25E9240002 X-Stat-Signature: ug31gr8x6fbwqmn3wjuqzh77i4ty1zw8 X-HE-Tag: 1680265710-940876 X-HE-Meta: U2FsdGVkX1+gCi3K6u50m1k4Lmn9CJaUA/DnEIx/9+88Kfgkx1QDYv9gxPgR2nfUpi8o//EGF7Fy74M3DiQ2puP0VlTzRxir3dMLkxkc/y/hPF9G1AfTA0e07uZGi5QpYRFlANES1RPAq+aJC9gqIY+GsWPqWNDMZppcUQN22EFnsP8VLk7v3eKeaBKTa68UOWJ1rwBouiomfl9ThvUj3XRn840ExPwYku2kewiNf0PmliDJdd1GSkbFHXzpQYNOUBNb40nGp3VDq2KgZKxbyFJBRq34vXWvnvEIDTHLf6q9o9yvyVbmn1UY4tLfR762FYy1nX5bc6dfQ07V48va93Fqd/oVsMJ4f6w/xfucFOHCWw6y9gRe82CAAxnoLIyIRsvZgEuTpKurAge1vAChgRHWBm4sn/DgsYc14BVMldrRdmMOLgszeQhN/6mwPr28h63egj9zBtAzu3RYcGP3QRwMj0FTklHijg60s1UVFuKA3LnuIMZRiHmPmD1uJPz+7G9m1EPWEFsVPHXKXpcMapAV3yciWPM7DFqNOCyat/9R31pO5oygUTESvL8aVSvEKYQ06CoeohOPHpNsWLyvw5kt8PYxxbJktyJw89XTrsgppFdtR0hejZp7OBSVnAsCV+u+pG3BtqbTS/crEdVfixNstgGIj5jROoL911GkeQm5RrNaacfR0XMZHwstjPdLnnEpAaodmNvEYyFB6PiysOWgjcuYw8gnIHy4R7CIiBOACtMxL0AzM3mIjXFw/SVWOfrZdZd3yM/WaHfo72yjYAg50M7Tfg49JIUsz14kxAjbBAmcPgHCy/nz+/ZmcLYlvmotljVQx88FVCa6OXktmb5EtPS9oJFF2rURFimyKLvd0n8YDQb3vgG7f6ROXD95q5FP2O8cXT+sXmj6puxMocL2jHrbPnrFtdj6U6Mi6hvVwnc4sX4t86M3kbB1vcSPAXVLiIpyHm6ZqJONpgv D/ao6dDF gspbljAPZoiHBScjr3cnJEOctctFKPHBUHbQsLo5aG3qC70HAwxGeo+2xeb9bZjMXyUErnes3ZC+A7W80m4t8jfYFbZ1VXW0HpA7FwecixCr6fHiY0gfS2MXf1YNsVz9YiiLVKKElASLGhY5c7dUTaO38y6X0UMwkwsgMkrF7gKOwr0LQGAZGVW/K6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 29, 2023 at 10:05:59AM -0700, Johannes Thumshirn wrote: > The zram writeback code uses bio_add_page() to add a page to a newly > created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Looks good, Reviewed-by: Pankaj Raghav