From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38BD3C6FD18 for ; Fri, 31 Mar 2023 12:22:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 731526B0071; Fri, 31 Mar 2023 08:22:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E1C16B0072; Fri, 31 Mar 2023 08:22:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55ACA6B0074; Fri, 31 Mar 2023 08:22:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 46CEB6B0071 for ; Fri, 31 Mar 2023 08:22:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 10D25403C5 for ; Fri, 31 Mar 2023 12:22:41 +0000 (UTC) X-FDA: 80629106922.29.316D878 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf25.hostedemail.com (Postfix) with ESMTP id 74AA2A0018 for ; Fri, 31 Mar 2023 12:22:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=HkHTDHHm; spf=pass (imf25.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680265358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hcuGDJry3da1akfsGf4g2A9Xv80OXlUoG+ekZfXmh3U=; b=VSF4eJkVO8zdnsSCzfQWtGeVarMo2EWHB8g0PayE6aSav42FVgh+lld9asFgYRFP6lkD02 u1FmUNOptLzMmqiDlxRgzy4hw4oa+/FqnV9XlprDKqeYMb9Vr+D9IuBzDBW9iPRdW1XdTK NrBXaRWxZ3DvIhGItcLLYIayofnPxig= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=HkHTDHHm; spf=pass (imf25.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680265358; a=rsa-sha256; cv=none; b=5SoMjpzRLleAFjgsNjfD6Q2dtVnPUdL2QO2xJpcPp/GBFb0gwRZ0o9pSKphenEG4J/MEvl XMG7CT3+kk8dtRYTx76GSGid4BwfH48SqKNQ/D2p2m+QuV2d/Q9AAM3LsbXaL8hnKG0yY4 +KpaOVmJavyEWG1/ffLMbaAXIaK9Cyk= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230331122236euoutp0224c0e9c6824508b21ac7924fe238d5bd~RgHBqekUb3039130391euoutp02G for ; Fri, 31 Mar 2023 12:22:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230331122236euoutp0224c0e9c6824508b21ac7924fe238d5bd~RgHBqekUb3039130391euoutp02G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1680265356; bh=hcuGDJry3da1akfsGf4g2A9Xv80OXlUoG+ekZfXmh3U=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=HkHTDHHmSA41uTSprLQ69X4AG+uE9Z/2Qulc4hPwEJHpUxIRnDwWYbofO4RGvMj3x c/RhO5eA3T0eCeZaw7sJr+T6y75Iw9HiNpQtT8V1UNf24OQlBLamqJYzfzQi1luQxI Ca4P/VK+caJtx0ZXjIPBggIVRC8jMzyr+bwbzcO0= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230331122235eucas1p1a9a510d4bc8face99a131261e67a3fe5~RgHBKw3Qm1948519485eucas1p10; Fri, 31 Mar 2023 12:22:35 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id CD.09.09966.B80D6246; Fri, 31 Mar 2023 13:22:35 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230331122235eucas1p2208286ce210d9b01ea36a26bd3897b72~RgHAr05g82770927709eucas1p2v; Fri, 31 Mar 2023 12:22:35 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230331122235eusmtrp26c22aae866cd012f4e7e50feaedb612a~RgHAqvH4p2795527955eusmtrp2U; Fri, 31 Mar 2023 12:22:35 +0000 (GMT) X-AuditID: cbfec7f4-d39ff700000026ee-cd-6426d08b6c09 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 82.16.08862.B80D6246; Fri, 31 Mar 2023 13:22:35 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230331122235eusmtip2507df0accd5c684b8609aeab0cf06795~RgHAeTKQh2975929759eusmtip2b; Fri, 31 Mar 2023 12:22:35 +0000 (GMT) Received: from localhost (106.110.32.140) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 31 Mar 2023 13:22:34 +0100 Date: Fri, 31 Mar 2023 14:14:18 +0200 From: Pankaj Raghav To: Johannes Thumshirn CC: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , , , , , Song Liu , , Mike Snitzer , Matthew Wilcox , Dave Kleikamp , , , Bob Peterson , Andreas Gruenbacher , David Sterba , , Subject: Re: [PATCH 04/19] fs: buffer: use __bio_add_page to add single page to bio Message-ID: <20230331121418.mch3y43pbt3pahc5@blixen> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <56321f8ef1e70e9e541074593575b74d3e25ade2.1680108414.git.johannes.thumshirn@wdc.com> X-Originating-IP: [106.110.32.140] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOKsWRmVeSWpSXmKPExsWy7djPc7rdF9RSDI4907LYtm43u8Xqu/1s FidXP2azaG3/xmSx991sVosLPxqZLPYsmsRksXL1USaLix9bmSz+dt1jsnh6dRZQyS1ti0uP V7Bb7Nl7ksXi3pr/rBbt83cxWhya3Mxk0TW7lc3i9p0fzBYnbklbHF/+l83i9485bA5iHptX aHlcPlvqsWlVJ5vHpk+T2D12L/jM5LH7ZgObR2/zOzaP9/uusnms33KVxWPz6WqPz5vkPNoP dDMF8ERx2aSk5mSWpRbp2yVwZUy/dYa5YB1Lxd2pN9gaGI8xdzFycEgImEgs2u3RxcjFISSw glFiwcm5rBDOF0aJ843X2SCcz4wSUx8sZIHpeHbdEiK+nFFi66Q9LHBF2680MkI4WxglHm9Y wgjSwSKgKtF92QrEZBPQkmjsZO9i5OQQETCWuPJ9IVgvs8B9VolLR6aBlQsLhEqsWh8EUsML tKtzzltWCFtQ4uTMJywgNrOAjsSC3Z/YQMqZBaQllv/jAAlzCiRKnLkwC6xEQkBJomHzGSi7 VuLUlltMIKskBP5xSkzZ844VIuEi0Ta/hRHCFpZ4dXwLO4QtI/F/53wmCLta4umN38wQzS2M Ev0717NBAsJaou9MDkSNo8T2xbcZIcJ8EjfeCkKcyScxadt0aEDzSnS0CUFUq0nsaNrKOIFR eRaSx2YheWwWwmMLGJlXMYqnlhbnpqcWG+WllusVJ+YWl+al6yXn525iBKbN0/+Of9nBuPzV R71DjEwcjIcYJTiYlUR4C41VU4R4UxIrq1KL8uOLSnNSiw8xSnOwKInzatueTBYSSE8sSc1O TS1ILYLJMnFwSjUwbZLscdAMvKSRfNrp6aT6Q89z9M4xi2vcLU7+sphJ/WPwP76uDyx6HgG5 ey0CZn4TvMynYbrPwPjR7jCds86TVmoJeC6d28Po5rf55fYnyjwnL75Jux12NXhRju7rqLJt JmkJlhv9ti1i/Tr7VNvCGQcvTT4ufMA5QPFMUnCr4/1fsgcuFXF/U1TVFGfalcr9N2NxT6LO a//lp1iZ9j7y/fbCm2X/e62DgidFv05ZrjI1RLLpRZFpT84RRtup/LaVFhequqL3r2n2e3h0 koTKj6zAFd+vtZnvPpD104HPlOtago60hUH1xqjPYbEaUryLerzl1ecr/Z5ledNt6+QJx6ra vcWv+XN86lIvYzVSYinOSDTUYi4qTgQA/sdKXgoEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsVy+t/xe7rdF9RSDHbc5bDYtm43u8Xqu/1s FidXP2azaG3/xmSx991sVosLPxqZLPYsmsRksXL1USaLix9bmSz+dt1jsnh6dRZQyS1ti0uP V7Bb7Nl7ksXi3pr/rBbt83cxWhya3Mxk0TW7lc3i9p0fzBYnbklbHF/+l83i9485bA5iHptX aHlcPlvqsWlVJ5vHpk+T2D12L/jM5LH7ZgObR2/zOzaP9/uusnms33KVxWPz6WqPz5vkPNoP dDMF8ETp2RTll5akKmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk5mSWpRbp2yXo ZUy/dYa5YB1Lxd2pN9gaGI8xdzFycEgImEg8u27ZxcjFISSwlFFi8uoV7F2MnEBxGYlPVz5C 2cISf651sUEUfWSUuHjmGhOEs4VR4uCEJnaQSSwCqhLdl61ATDYBLYnGTrBeEQFjiSvfF7KA lDML3GeVWPVlDhNIjbBAqMSq9UEgNbxAN3TOecsKMXIKo0RL9ycmiISgxMmZT1hAbGYBHYkF uz+xgfQyC0hLLP/HARLmFEiUOHNhFgvEnUoSDZvPQNm1Ep//PmOcwCg8C8mkWUgmzUKYtICR eRWjSGppcW56brGhXnFibnFpXrpecn7uJkZgAtl27OfmHYzzXn3UO8TIxMF4iFGCg1lJhLfQ WDVFiDclsbIqtSg/vqg0J7X4EKMpMCAmMkuJJucDU1heSbyhmYGpoYmZpYGppZmxkjivZ0FH opBAemJJanZqakFqEUwfEwenVAPThPJ5nAGnFlnq/50p4F7+Pvm5oDzze7HQLufooAPH5YSu TNeOdTHPOjFt23a33qaZjzJm/1b75Ts/djdHyp89mxfafj105NXLezzVYhvmd3QbHZ6ouv2u yR63AjsrjoetMzlndmxd8ztcu7bB9s66aVwS4Yl9Z4tmssSGbJP7tjH41/SZt1aInVJv/dY/ /ZlF5YYZMzZsk3R0dT8jbiytWKvSKhswbeNkHf/CTeaeB0Wesbo/WpOo3rbOU+RhA0fB64uX GGc12J0WClvwjPHutcvygmVR10oeO/atlasK5/G+nF/AIZYx21DOcFLpin6/NpYbyw40n7l4 T/1HQWbnj8AZwSJujJWNXp9ifK2UWIozEg21mIuKEwEieVEeqQMAAA== X-CMS-MailID: 20230331122235eucas1p2208286ce210d9b01ea36a26bd3897b72 X-Msg-Generator: CA X-RootMTR: 20230331122235eucas1p2208286ce210d9b01ea36a26bd3897b72 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230331122235eucas1p2208286ce210d9b01ea36a26bd3897b72 References: <56321f8ef1e70e9e541074593575b74d3e25ade2.1680108414.git.johannes.thumshirn@wdc.com> X-Rspamd-Queue-Id: 74AA2A0018 X-Stat-Signature: kmiwbidsuennpyph8u7818fnepfqdhy7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680265358-737190 X-HE-Meta: U2FsdGVkX1/RUAQseVvvZgA2Hr6iA594pqWSrZ+egM6d/NMfdWVZVYHfV8HGFQTG07+s90yHdYp/lmKn25pDOovVKhAYp7zgQEzRQwViqNqBLKYpWRBvQ1qQN2JU3Bm5z4mYLptAt83vP30oY/BWjrFOQqIe+c9yXFIyH5nkmHJFOcxfFmaO3slUFC0mGeVkYzx8M6e63uEONJ/zfXIAPBsdVwzVNvV3wCEcBbltaojXgr1HKKH3m1RANbfFPgDuBq4hpzUD9V3qWTM2QmkZVwGRNp9u1jb6BTq+kTb3I1u3iPsLzgyzHmae1t10jSHI3JSo9FhToy2md+wVq0nUiNUpPhnZb5aCy7y5dkRW8yJ/sPDpdxz6q5NT4lpNXMkXF7AC6oVICEv14l5LzFiyc4fANmEgdlZXcNlwn4D3rCYaVlTE2tYYEcJhweNHU0igCnz/qSOy2Mg1g+6AK9YtNh6GQMco2DCAtn3ZvHRGVYQsUqP7oJ7a7TCDb5SQJMoSh4h9lUR82wE/OprohAUHCE659vC0unkzhU8y0VWLfCITngiWuhIyAoC7IHsnJpa20LpW6XkAx5VtmXxQNeTdnYNwHAhWy1s1sCe/nbnsAOTDrsrHEIpWjIksL2CqLR7XEW3C/At29sAhPjdUk9CgRnIe93NhnAH4Ra3VWYHrfln/GGzxDpqzI26QkqLkqW2tjrjbdX7I6xoVWq4scs3ideKBNKFwjj3QuZfGFEEU/XywZnrci/pEoSqAinF8OfgKb8SC5DqzpgNjKvnMJ34bXhFA9Rv66Egft9lLUTERmoLhR4tZio8/Cmqu0WA4TtuLhrUNwNfiSXOaHKDyjIKPjcGv7N1nFLtd/LwSsAqsPEkzDN3bZH/PFNm/nn8NTasI0k37fOQ43rIoZc41Fft3rxCNSXBSw3pRczUCksdbFCwyvPkrWBYdrogAuONYc714xmKrUXqIM37obi1cFbj 0sEvti09 jRypsGcfpL+BdtcIBQ4InIruMLUSLyvwzBwfQGyWo2gQIdtr9fCXW1vqGBvk5TzyASXc0vhKR5gCiH5UUWfjiScdQO5hbFgSzAd2MWqfC1jUCPeBkfE7HomSs4tMzX/qi1WQtFi6q0cC8S+FPtsuRBvnwv8222257/udeQI9M68mJ9q5zAmcZ/P8sbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 29, 2023 at 10:05:50AM -0700, Johannes Thumshirn wrote: > The buffer_head submission code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn > --- Looks good, Reviewed-by: Pankaj Raghav