From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE392C6FD18 for ; Fri, 31 Mar 2023 12:20:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 166756B0071; Fri, 31 Mar 2023 08:20:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 116876B0072; Fri, 31 Mar 2023 08:20:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED4E06B0074; Fri, 31 Mar 2023 08:20:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DF2166B0071 for ; Fri, 31 Mar 2023 08:20:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B80C0140301 for ; Fri, 31 Mar 2023 12:20:54 +0000 (UTC) X-FDA: 80629102428.12.F60F2FF Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf04.hostedemail.com (Postfix) with ESMTP id 8EC674000C for ; Fri, 31 Mar 2023 12:20:49 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=sEWO2dKy; spf=pass (imf04.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680265250; a=rsa-sha256; cv=none; b=i/3AJPEBVzwCXegzq88Jhbm7vVaPkm8kFajOMXDjPR1wDRlhnYEi6O0eOIPl16vrIRGnON YYEP2JgeCI0AEmm0dgwNwabquQRvnDIw+yBvp4b5Xr4M1cykYoMQWgHr/Qje3oSrSf+atF gpPFA871qSDAjxWdHWDfLx2e8i/XFOM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=sEWO2dKy; spf=pass (imf04.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680265250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RG0AskesBGxejlTr4JHEhK02MF/IWOxvFzpfN3R7npc=; b=QMiWAdzj6mUpxzIUT4JPnk0yz6+JQ7c43aG5j0y8hhMJRrMFbKffjxrWLrfDFxcFQCutNR E1UDAa1/QzEo9sjFtbBQnF6nK2hRJktAOfni8+hH+eIDyQDoo0M9M/pIqhhdTny3PoCXpR Mddjb763mvNaXbwRvIWBvUfTniJ6kLo= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230331122047euoutp02de0b6f09e72db83bf779cb8f31a72057~RgFcDebo22998929989euoutp02k for ; Fri, 31 Mar 2023 12:20:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230331122047euoutp02de0b6f09e72db83bf779cb8f31a72057~RgFcDebo22998929989euoutp02k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1680265247; bh=RG0AskesBGxejlTr4JHEhK02MF/IWOxvFzpfN3R7npc=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=sEWO2dKySJf9bqBkoq2fkNFxwAwamiqJ5bOxce1NxpZX61XpF66PidxaF84lkquev ++ETNPtaWZbvBoFM+W6uSokTPuVsDNzpbcAsQREz9177zRQ6KDcSJVKD666vQWplV9 jUBvS2BYT6A/G1RW/hKzXwYnSiqMy+MammGcX9dw= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230331122046eucas1p2dd047848b60f9ddc31dd7b266bd86d77~RgFbxwOsi1098310983eucas1p24; Fri, 31 Mar 2023 12:20:46 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 14.78.09503.E10D6246; Fri, 31 Mar 2023 13:20:46 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230331122046eucas1p247e0cd2d06229a6b7cae9cb26ea43d5b~RgFbZahPc1098310983eucas1p23; Fri, 31 Mar 2023 12:20:46 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230331122046eusmtrp238c8959c39aa187032906ac97e80131b~RgFbYiwNm2670526705eusmtrp2U; Fri, 31 Mar 2023 12:20:46 +0000 (GMT) X-AuditID: cbfec7f2-ea5ff7000000251f-bf-6426d01eee9e Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F3.4E.09583.E10D6246; Fri, 31 Mar 2023 13:20:46 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230331122046eusmtip2b8baf2b87eb1e2370ba007aa92d0a40b~RgFbLcVLU2523725237eusmtip2g; Fri, 31 Mar 2023 12:20:46 +0000 (GMT) Received: from localhost (106.110.32.140) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 31 Mar 2023 13:20:45 +0100 Date: Fri, 31 Mar 2023 14:12:29 +0200 From: Pankaj Raghav To: Johannes Thumshirn CC: Jens Axboe , Christoph Hellwig , "Hannes Reinecke" , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , , , , , Song Liu , , Mike Snitzer , "Matthew Wilcox" , Dave Kleikamp , , , "Bob Peterson" , Andreas Gruenbacher , David Sterba , Subject: Re: [PATCH 01/19] swap: use __bio_add_page to add page to bio Message-ID: <20230331121156.7c7nbxfhagdufpzo@blixen> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7849b142e073b20f033e5124a39080f59e5f19d2.1680108414.git.johannes.thumshirn@wdc.com> X-Originating-IP: [106.110.32.140] X-ClientProxiedBy: CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBKsWRmVeSWpSXmKPExsWy7djPc7pyF9RSDBZPM7TYtm43u8Xqu/1s FidXP2azaG3/xmSx991sVosLPxqZLPYsmsRksXL1USaLix9bmSz+dt1jsnh6dRZQyS1ti0uP V7Bb7Nl7ksXi3pr/rBbt83cxWhya3Mxk0TW7lc3i9p0fzBYnbklbHF/+l83i9485bA5iHptX aHlcPlvqsWlVJ5vHpk+T2D12L/jM5LH7ZgObR2/zOzaP9/uusnms33KVxWPz6WqPz5vkPNoP dDMF8ERx2aSk5mSWpRbp2yVwZcz/doOtYCNzxfprsQ2Mj5i6GDk5JARMJI5NaGHsYuTiEBJY wSixunsRG4TzhVFi1+QXrBDOZ0aJ7a+uw7WceLyHBSKxnFFiX9M2Rriq46eeQjlbGCUuntsE 1sIioCqx4etl9i5GDg42AS2Jxk52kLCIgLHEle8LwSYxC5xmlVh4/QsrSEJYwE2ibepCsCJe oHVH7ixnhLAFJU7OfMICYjML6Egs2P2JDWQms4C0xPJ/HCBhToFEiZt7FkBdqiTRsPkMC4Rd K7G3+QA7hP2NU+LUCiEI20Vix+rNUPXCEq+Ob4GqkZH4v3M+VLxa4umN38wgd0oItDBK9O9c D7ZXQsBaou9MDoTpKLFrii2EySdx460gxJF8EpO2TWeGCPNKdLRBLVWT2NG0lXECo/IsJG/N QvLWLIS3FjAyr2IUTy0tzk1PLTbMSy3XK07MLS7NS9dLzs/dxAhMnKf/Hf+0g3Huq496hxiZ OBgPMUpwMCuJ8BYaq6YI8aYkVlalFuXHF5XmpBYfYpTmYFES59W2PZksJJCeWJKanZpakFoE k2Xi4JRqYGJ/Mq99ttHmVS9fhk9x2O7O7HvTf+/R+lhRfRXOv75H4oX0PF9zSC0zsTrB2Hsi eKO1iPxXL+MvIfrzNi9OcG46+ol153PN+JnpYbKbTDaqOVs9D1OquC2Qvc6bJZbv0SouaanZ J+X3chn66V2wn3wx+Nano/cD+ev+KYgXdvDKXHV6X3w0czGPM8dGn7d1vwrNFazUsroWMtkd +Ls72vL37s3Kn4871TzKdpGfZlo61e5ruFDCKqVOfjP5pt+WNy4fDn79+XDsAe7Oo6avAv35 39y5bHdLp1fXyF+qKOcGH9MF62viPsXSs85vcJbSfPmjgyG4/s+0ABtmk9XT80s+SRrPL0wQ ULNpnrtUiaU4I9FQi7moOBEAP8WwqwsEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsVy+t/xe7pyF9RSDK5cErfYtm43u8Xqu/1s FidXP2azaG3/xmSx991sVosLPxqZLPYsmsRksXL1USaLix9bmSz+dt1jsnh6dRZQyS1ti0uP V7Bb7Nl7ksXi3pr/rBbt83cxWhya3Mxk0TW7lc3i9p0fzBYnbklbHF/+l83i9485bA5iHptX aHlcPlvqsWlVJ5vHpk+T2D12L/jM5LH7ZgObR2/zOzaP9/uusnms33KVxWPz6WqPz5vkPNoP dDMF8ETp2RTll5akKmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk5mSWpRbp2yXo Zcz/doOtYCNzxfprsQ2Mj5i6GDk5JARMJE483sMCYgsJLGWUeLRWCiIuI/Hpykd2CFtY4s+1 LrYuRi6gmo+MEptubYFytjBKfJz6G6yKRUBVYsPXy0A2BwebgJZEYydYWETAWOLK94UsIPXM AqdZJT7PfskIkhAWcJNom7oQrIgX6Iojd5YzQlwxhVFi8msViLigxMmZT8CuYxbQkViw+xMb yHxmAWmJ5f84QMKcAokSN/csgHpGSaJh8xkWCLtWovPVabYJjMKzkEyahWTSLIRJCxiZVzGK pJYW56bnFhvpFSfmFpfmpesl5+duYgQmkG3Hfm7Zwbjy1Ue9Q4xMHIyHGCU4mJVEeAuNVVOE eFMSK6tSi/Lji0pzUosPMZoCQ2Iis5Rocj4wheWVxBuaGZgamphZGphamhkrifN6FnQkCgmk J5akZqemFqQWwfQxcXBKNTDFVzyrFHN98C7HflXCTe5DketvM5byVt4rXXFnmnXppfPP/gtl BZ5b8vLrudR/D3Iz/Fasl/4UvMc041N88wNOBgf+xBThdu+rZRy24sznqrl8jSra+Ll+/Yzt 3xBydFb+naTaadW32p4G3VITy/E2PH3Ft25+7jOHcJGd0efa9vScOnT3UZHSofkuTbK2e6aF OpbGm31dtmbVN/uOqc+ubDQIvfkv/5/Jt4LA442q4pY3XU00w07n5CmwnVj63Te1aaPR/7fN 6xx/JofOXyfrWGzyV7Sgq/yyyfkbxVGrbKvEPRfzpB0tL9sqLRthkNB5f0FPx8pVbt/eSXo8 /JRkIvyyfrYM914byRPTBJRYijMSDbWYi4oTAXZ/WI2pAwAA X-CMS-MailID: 20230331122046eucas1p247e0cd2d06229a6b7cae9cb26ea43d5b X-Msg-Generator: CA X-RootMTR: 20230331122046eucas1p247e0cd2d06229a6b7cae9cb26ea43d5b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230331122046eucas1p247e0cd2d06229a6b7cae9cb26ea43d5b References: <7849b142e073b20f033e5124a39080f59e5f19d2.1680108414.git.johannes.thumshirn@wdc.com> X-Rspam-User: X-Rspamd-Queue-Id: 8EC674000C X-Rspamd-Server: rspam01 X-Stat-Signature: wqpxjqzb6guyk57ku76i13jb4z8zdez5 X-HE-Tag: 1680265249-267990 X-HE-Meta: U2FsdGVkX18/6PMpcgbXfua0s5eEMjiMJMvUkPrrJ+fliciboJ0A8p2/JAU29D6fqaC73B4+ZKMo3eFOZVaexXI+UEYvC/71iL4h1zGhX/eQlhxd9qjyLmTJmI8U0rnJM19qGjlQJxgucXnScXghXKUoDDbvMGKPw57MI82OBmWBQkIZ3hVf6CLLMXXAHyiYV1Ei7hkOBc1RvcfgznsQfRy8Tom0LqnINrQfXYJSNUecInvR0Q4KA3dOYdK21sHL8t59k5lOuMuk4w7Ko+fkPfLpydLPmePjfNSIIgJ74p7addnnaZpHht7jyzKH9SlT7p2dJSl0+MgxZdq85MK7zU4F6PDAbnFWHIrdrPh83pGionmUhjIqZsigYC+J4zfPaeju0SF3f/NronQ8SKRl+k2EZHnw593idPV4uUZqzRYwI1aIPZSBay3q22OGBp3AgKIXTm3XGs777koA0gSs/vxKQSHEDjYDjmwD7MJ8d3sNYxu8KhrdQDDJfd3VCEGWQylVZ52vj1+iMoRxgbhi5Nfoh0X98nO1ZgRtmwDze/mbUZQnnG4g3wstbYkP8R8oumH/ZGGrXVWb2KiysmIdcDXBEBz2nlmAIehxE7COJShFPxUOu+4ADm9st2Ew/1loIILm6stc4vYAZeCb0bZlFFObmiY4gWyTSBWpUcyhp4wdfMqeIJaOxOHwhbU/fDxH4vmKc3A6U60MInN7CG+FluZYhHvtxRfwetElwFbVw+KIiyfaNgF0Qd+lrwPVB1vVg5tH0Xsq7sdnVJBX7wqh/99MGeQp7Ndrwgp42ZejtETsAp8XWndMXeZVczFc0IkcnzdC0aMUjR9uXK6T+kFIn+mryi1gHf/E9rKA6dQebjXInSSkEK1hHvEsjcInAuiuvIN4WMSLYdD6oNg6jhBQaONbVdVZBCU4CWF9I1Z74fno1+Xseejcbe7y86JC9/hVNzDrSm0w//xnfMChPwN gOsDxGBN UM6OlOTOzXGYW9dzO3eljXRc6ehvtutrdmWuRUL2dzjjstGCaaOzka6g2uRDW4ZbYG1cRumtYbEB6I0riGKCKDfQ2MKJUcxOCJ89OHJclhxeEIRPTYrVoQ6VTQVmUpgbcUB1p7rVEVeHJWd566qCIgwiMSP+xBo5WGueHMmPdGfWe7LrTtcOwGOLuZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 29, 2023 at 10:05:47AM -0700, Johannes Thumshirn wrote: > The swap code only adds a single page to a newly created bio. So use > __bio_add_page() to add the page which is guaranteed to succeed in this > case. > > This brings us closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Looks good, Reviewed-by: Pankaj Raghav