From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDFD2C6FD18 for ; Fri, 31 Mar 2023 09:59:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 666D46B0071; Fri, 31 Mar 2023 05:59:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F02C6B0072; Fri, 31 Mar 2023 05:59:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46A3A6B0074; Fri, 31 Mar 2023 05:59:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 33BFB6B0071 for ; Fri, 31 Mar 2023 05:59:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 08E80160D71 for ; Fri, 31 Mar 2023 09:59:10 +0000 (UTC) X-FDA: 80628745260.15.A5C93DF Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf22.hostedemail.com (Postfix) with ESMTP id C2153C0017 for ; Fri, 31 Mar 2023 09:59:07 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=eNFqrrDv; spf=pass (imf22.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680256748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=V3Imsv5UXjIU6+jF5fHueU/SbtIe7EZ54LbcEh0yngg=; b=cnsefp2DAxmQFQ9o6qb5Wh5pnXnvxO19fDTlkiIQi8loOIUxAJVeqd6chGTeV4aPK1bRr6 cNy46NUwvduEolh2KZNwQDfH3LtMmU04LxunQ1K9nb3kFuiKBiewqE9zsit5BI47JhKn3t lFR/z7BbW6hkMj00AMIDmp+djaO+qsY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=eNFqrrDv; spf=pass (imf22.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680256748; a=rsa-sha256; cv=none; b=TTYVjX6SGV7KGiq9PkBQ3M8YmNjyuvoF3sBEKyf3puTaGy798NBrr/d+gxTnDSofNptQcG yfUytmNXxHhCZsLLtsOFTVbBXrv7XkbfAXlB4g5xewjpN+rgTx5WiC7hFU1CXDUjI9XnAy uUoHYyWlqTp3RXTDigyMUDTBAym+acg= Received: by mail-pl1-f172.google.com with SMTP id f22so16641237plr.0 for ; Fri, 31 Mar 2023 02:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1680256746; x=1682848746; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=V3Imsv5UXjIU6+jF5fHueU/SbtIe7EZ54LbcEh0yngg=; b=eNFqrrDvToe7K30uj4UJdlWR29i2x/3BZZ8yfzzbmfaNxY2ly4sLki8zpCNb1tZL8F 99yx1GqbvY+SYJq73zokyHO5yYeHmQJnsTNl0v83o99fAHuJVEQ3iu2Ib16n74m+GBc6 KsAfwyAiBRByPWGUGz3IRg5l0F2ly8Lt9XpJTZa82a9YVQ2YPetXTMGz0Qeub1rUNOGq 74U77/tjinuH4nZi8bz3ljpHvUvL6IyDLCusE4TSbGa1lAuOTOJGObcYtPfUSr5/0dr9 I6hoGTcoXl3etTMWvHtCYFopuFOlpdoY+jFPcvbTuHhYFNSPp/ax5X/xyzQpFYZJgU8p 5rhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680256746; x=1682848746; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V3Imsv5UXjIU6+jF5fHueU/SbtIe7EZ54LbcEh0yngg=; b=Dl9MyIFxX/5rZFahOU8iJjX9xH4XUZH5hbTC458xlfsK2uocN4HgKpsgzQhlNmU+Lq I40yl4PPmd+BQEKf+wQf78pWlAn8DQGEgHvBeme4hlZAzDh/SovRGOfolxWsCcwtUtMc nPgfX/Ut/q2V5unNpTGPyuSzYWrrzn3udZI0aw/58fuo+bYfiPpgyUlZWcW5TGQ2Bumo ihiHfoicIqH31jUBEx3ly+Fd6lINFT3l9zi/Pl6BW+RkOHymAC1Q60rq3LEWkDiUCguk RvmNQ9GccGxwSWZQ+1H7Vc1Bb8ULuOkmBSlm0Ur/CetE0bsWgEvZ8XcBMHXrscoqaRFt ApRg== X-Gm-Message-State: AAQBX9fTdcGdZxUmyyX1Xrn0zlq2BUivF54tJSTKTg3j3bl0uYb9InSz qLLFJvr5bGUU8LSxToQe8cPFfg== X-Google-Smtp-Source: AKy350ZvNVoMyY9lLBRfiHq5wFZ9JCFpE32CoNb4IXzzebKUTJLtkfr4e6FPbV2oDHIPcOpa6wvfrQ== X-Received: by 2002:a17:902:7593:b0:1a2:8871:b430 with SMTP id j19-20020a170902759300b001a28871b430mr5594577pll.2.1680256746575; Fri, 31 Mar 2023 02:59:06 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([139.177.225.229]) by smtp.gmail.com with ESMTPSA id oo5-20020a17090b1c8500b0023b3179f0fcsm4687782pjb.6.2023.03.31.02.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 02:59:06 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, willy@infradead.org, lstoakes@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: [PATCH 1/2] mm: swap: use folio_batch_reinit() in folio_batch_move_lru() Date: Fri, 31 Mar 2023 17:58:57 +0800 Message-Id: <20230331095858.51810-1-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C2153C0017 X-Stat-Signature: ooqxwoe53c8ip7dfdjfkqys7qf43udec X-Rspam-User: X-HE-Tag: 1680256747-570878 X-HE-Meta: U2FsdGVkX19fOMmx7m+3QLEWMePGUlCJZwrwgkAK+Al2HRAU8WX5kEnoyIEGP+/Z9RnmlAPPqGbCXas/67qJvmC7WI18CwK4piFEEnhFWPl2tzdYe9eIKVeCxn/ChqIat45Sbb0TwANyOQfK+CpR8RYxk+XPse3dDoYPf3di6QfxSYTksWs6LEDz/xJtyrJsWUQC0uYDjT/d4a2i3e4UPactIWPe6vK902TfTEMiveHqN+6bvrJZsaU/85VM/QMUJaF+bVXu1GAD11c32NZi4NRRXn8qs4+FKvKnStRqkRAwJO6U48BuKNTBZv39dsh++yiBD+v8tBtVk7x2Vhl/iKlrdciS2m3+v3RZBB5kXaKrqdZ6L4WgKBBVUG0XosGiaC4eCl6BWfo0quIVn5Y2r530ZB9cvCnYFfVXgqmw2rRyn9VkImUxxmvkTx8jXwf1ALMMNDruhoZoVT8SmIKoLNyJEfaRwe1jzEhr3rZaL3nnEQP6nG0Rw1YVthwXyl2Gz/guM1tYMKA901GT5X228XOz+4CJJuQSMwJmkaLIsTYoGxDYGMNQ5cKTKtgnIJjhYWZUrgVPoD+3sX4RzkQjEEgjQB0vzEuySTLb2cdtZdNoykFqv6j5Hg1xYw6uVKVC0rSxCmMm0EXeMvkIUMg3qdL3Mo7H8twa5Yip2kepPdaFgogJDi+nBSKXIYLJC9Uy2K02/EDNca3BeYEL31jBoFiGdjV7szSIZUZdY/UP5qhQ19CXkOkY687fxKR8HSyQdP+qdHBBjEvypea8tjQJwpCikuC4WM97vM7IiKe+PFVP2spiKcRrJrXwnXhUeF/cjVH6D0AXwq/m8GgVYbOH5h6z0JbYTP3CBSm4+0WaRZFaxR564JMvAudfjqz3zjlmKM38Qxnc4/dtmwUXOPAkjy5YwlCTM+Wr393n7K4FkBbebxwnNQ++LHFCjJma2vP4RtZjdQouh6pVzRA7qOS YM1XJ91q cQ7cdoGb7R+M06yCVPhflrbWMmFAFRrqLklOBOHTOI37toy6ppysTySPZ23PbIaEx7dyR7C3gVJoyEDHNl4N+gBUr+0YRHDL9poFSL6032QG0wMQ+wI8RS382/2ZNlymFFejOkQ97k2afLXRf2M1hfHFrQEeJta3AjoZdc4TXyTkQsEsN54e1BnntpkfUTEM0KrGMWKoUVO7Xx9qTMqyfajAzECkp0I9imhYcRdM7/KI8Ju3O0eFHyi91d5q+3K01rIbYqdX2ZivEph6NwA67pSQaV9Boaaap3/A9q8kYuopU1sqsPsWlTSob1Gu2PFlyWVuYMjmxjhzEguBDKk9FzUY5Z0Gv9IewOCqv3sf0qn8sfwlf9VexRzqPaSV1rTUoM0sho2HgkGpdSbneo3QUBtvBfrMYs3Kc6ChmQyBSfpp2ow7JMZcPYwDLP9/56e7mJ4oaO1OSr6C4S4HSlSfoJ0xTY/6gbLB01I3I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In folio_batch_move_lru(), the folio_batch is not freshly initialised, so it should call folio_batch_reinit() as pagevec_lru_move_fn() did before. Signed-off-by: Qi Zheng --- mm/swap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/swap.c b/mm/swap.c index 57cb01b042f6..423199ee8478 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -222,7 +222,7 @@ static void folio_batch_move_lru(struct folio_batch *fbatch, move_fn_t move_fn) if (lruvec) unlock_page_lruvec_irqrestore(lruvec, flags); folios_put(fbatch->folios, folio_batch_count(fbatch)); - folio_batch_init(fbatch); + folio_batch_reinit(fbatch); } static void folio_batch_add_and_move(struct folio_batch *fbatch, -- 2.20.1