From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D7E8C77B6D for ; Thu, 30 Mar 2023 19:31:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDCF96B0072; Thu, 30 Mar 2023 15:31:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8D426B0074; Thu, 30 Mar 2023 15:31:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C55946B0078; Thu, 30 Mar 2023 15:31:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B51586B0072 for ; Thu, 30 Mar 2023 15:31:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 83E6D140DD2 for ; Thu, 30 Mar 2023 19:31:23 +0000 (UTC) X-FDA: 80626558446.05.B96EEB3 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf18.hostedemail.com (Postfix) with ESMTP id 4B11E1C001B for ; Thu, 30 Mar 2023 19:31:20 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aHv++cdp; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wYPbuyHq; dmarc=none; spf=pass (imf18.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680204680; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Etjp+xE3FIW3A1xPIHa1sQtyQ4/Nn9crT5hD184o2SA=; b=mGsQ8bkuLyOKc7E/+4uwENqO1ukNGA6btRw+hfGVjlNoD9oka5mkgw6qGcxtTVKiqF4nNc irX2dykIDT+YapdGUSnq9iW/fjZlrkupr5cQAtxQCqbocFbLhZyTtXnQrGIcVy0TA9/XoD xft2bdbGoP6YpadREFen2t4QOXAZFGk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=aHv++cdp; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wYPbuyHq; dmarc=none; spf=pass (imf18.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680204680; a=rsa-sha256; cv=none; b=Izqy3L6500pOyUxSGw1pB6IL3UdMQ8xesZaikWfarc+5r6OBvx9hdRuamu46tmBvoEA58P lzPwQVxrxmVfVqiZKvz2RMNrXl8eh4D/G/rzKW/Ru9otZhIspHv1P65VFz5sYktFKXN8Sj t8XT5iwxleEyMhqtX9jDYAZQt1zztfQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 96F501FE07; Thu, 30 Mar 2023 19:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1680204678; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Etjp+xE3FIW3A1xPIHa1sQtyQ4/Nn9crT5hD184o2SA=; b=aHv++cdpXPaXb26/G1LMYwclQgZ4Qx/cyWFa0fjo70P5nNjzjoHIeWQSajl20M1XZZkoz2 ZwgPzABCzOE8C4i0glI8NLuVt6p2eWDvwk3FK3zK7SXAeXYSpz3JpQIfG2AbcvOChVT7+9 1qTNvdPzYgEM+d96UTjl0NgotnSkQr4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1680204678; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Etjp+xE3FIW3A1xPIHa1sQtyQ4/Nn9crT5hD184o2SA=; b=wYPbuyHqUYLobbGSEtgz4W8ycI8q3CtaKnbPUQGE+5MzS+bueBw/fljFzrPU/2rA5fyNzR A2+wNxH4qiVKtHBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 200FE133E0; Thu, 30 Mar 2023 19:31:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 77P7BobjJWQBRQAAMHmgww (envelope-from ); Thu, 30 Mar 2023 19:31:18 +0000 Date: Thu, 30 Mar 2023 21:25:03 +0200 From: David Sterba To: Johannes Thumshirn Cc: "dsterba@suse.cz" , Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , "linux-block@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "dm-devel@redhat.com" , Song Liu , "linux-raid@vger.kernel.org" , Mike Snitzer , Matthew Wilcox , Dave Kleikamp , "jfs-discussion@lists.sourceforge.net" , "cluster-devel@redhat.com" , Bob Peterson , Andreas Gruenbacher , David Sterba , "linux-btrfs@vger.kernel.org" Subject: Re: [PATCH v2 00/19] bio: check return values of bio_add_page Message-ID: <20230330192503.GT10580@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20230330154529.GS10580@twin.jikos.cz> <9835fc72-18b4-517d-0861-b5b413252eb9@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9835fc72-18b4-517d-0861-b5b413252eb9@wdc.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Rspamd-Queue-Id: 4B11E1C001B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 6bcxe5xor78hzfjwgn91t1sh88t17isk X-HE-Tag: 1680204680-515215 X-HE-Meta: U2FsdGVkX18h/wBJlF8jjRnQ8iexkIiF+QiNzNUkjr+u/tAk/uHw9U8hn7VRzn4jcvCfi0Blh986SExXfsK52rlDnNB/7nlUsAozpaYXVhOVUSazDkxqmiusJ4skWg/Tz1DbZb2HazC06Tg1OQnaFuzZYKgAnm8gPrJB9llAbnEhknAGQUWVaeqKKL7VLqU/ByivH11eluCB5Zc0xYtvFuTx8zHF2yaCyyJMGI4vj+alxv7SZ8cznSVEr41Q8X1DnQQ5pOTlk4iAAjDb5mydhI5rxwlJ/R8bMVJbXfcms5So6KG4GigfrYbC8vSdqbGKSXSSnqSPAl59CuHgqakFdxkmk/tS8bucs40ltQNMJzxZc5sqTnU8JVVXZIT0mgcK9XbBeqNel26p/0AjOw0O0LRf6dTmx9be5/pCb7+/7J6PwVzIk2mK8O85RYhStDsZFot9gc5lpK6rnwU4b8oQjZpB3PAVjEGeULWiL7rCW1X76Cfa5q9UhhpS+Y/DJ2U8cq/eSwNhKS2kOlEE0gMdNL4QTirEmKRRjl5TvN87EBv1td/82MDExTBYj6OqxliqOqsh4J4aNl8oxpACEmwAGYQQhVAlIfzjGqe6L1UZ+RkGUzrzGGw1eUbPGBBKJmFgGjR1vZwiJqSlEeE4SZGv/o1o4qOGJhaArCPepW/PsQbdgAxLTQyaN+OdqMRP0on/m/ylr1JIm9Nv8ky3/ANHdqULAoj5Sr8J+2Dg0dj9YE5GaPY25sMYDIOP2gVMUGEwgiiSBhXOrFhqsM8Sly27FIC8pNqvtvkrg9UUe7pElXPvBvSjdGD9HXhCceM4X53Vq5lyPQFRj6eSTCFAFjfa70apn9otdxtRwWcjTtEQ7KEBTqxrlWRtTdw2kXMeCQBvXtXOkBTjX8o+GkStAPy8JxirS4kdno3AqbajSmjkZ6XDWoTz3JQnWHCZrjEkCgfbWW8n7dS9cO2BTuXBdcL CTOD2b22 4aFdG8unYEVcTOp9aWGklMPXaQQ4EC3ifLoQ1sFk61mssIPYPkvxADNMNiGxpLYbon4/BoazXNzaCNatGm0AzC16fkrRs7gpbWKNGfoO1D3P22razB97vQjlZ9rHG9dXcNQ5mV4+ZJHmaCQHBDqW1s/6qNt2IF3J/EOlMcCfA2T3ooq3CCUfoyEr5DtmqKl1cOU2ZuhY2oUD+ObuT7KUYcRE6Yef3s1MHKWdHtmAZqI8AHDCxZOChX9wl3oP6QTDXFGzUHnjvQHes0yX6b12pOwOK2HX/1Y24xv5w4vn22P8VoXn2MGt9/7gr9yHVnFlkWu+vhcUZkMDzzPsHqcTy+BTuVwnzx6vOGK0f/afJjVuc37k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 04:41:58PM +0000, Johannes Thumshirn wrote: > On 30.03.23 17:52, David Sterba wrote: > > On Thu, Mar 30, 2023 at 03:43:42AM -0700, Johannes Thumshirn wrote: > >> We have two functions for adding a page to a bio, __bio_add_page() which is > >> used to add a single page to a freshly created bio and bio_add_page() which is > >> used to add a page to an existing bio. > >> > >> While __bio_add_page() is expected to succeed, bio_add_page() can fail. > >> > >> This series converts the callers of bio_add_page() which can easily use > >> __bio_add_page() to using it and checks the return of bio_add_page() for > >> callers that don't work on a freshly created bio. > >> > >> Lastly it marks bio_add_page() as __must_check so we don't have to go again > >> and audit all callers. > >> > >> Changes to v1: > >> - Removed pointless comment pointed out by Willy > >> - Changed commit messages pointed out by Damien > >> - Colledted Damien's Reviews and Acks > >> > >> Johannes Thumshirn (19): > > > >> btrfs: repair: use __bio_add_page for adding single page > >> btrfs: raid56: use __bio_add_page to add single page > > > > The btrfs patches added to misc-next, thanks. > > > > Thanks but wouldn't it make more sense for Jens to pick up all of them? > The last patch in the series flips bio_add_pages() over to > __must_check and so it'll create an interdependency between the > btrfs and the block tree. I'd rather take it via btrfs tree, this avoids future merge conflicts.