From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60819C6FD1D for ; Thu, 30 Mar 2023 16:52:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAB6C6B007D; Thu, 30 Mar 2023 12:52:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5C2F6B007E; Thu, 30 Mar 2023 12:52:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C23176B0080; Thu, 30 Mar 2023 12:52:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B13C76B007D for ; Thu, 30 Mar 2023 12:52:54 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 768C0C1044 for ; Thu, 30 Mar 2023 16:52:54 +0000 (UTC) X-FDA: 80626159068.28.382D264 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf25.hostedemail.com (Postfix) with ESMTP id 3475AA0012 for ; Thu, 30 Mar 2023 16:52:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Qhwvho/j"; spf=pass (imf25.hostedemail.com: domain of 3Yr4lZAgKCJ0PE7HBBI8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--shakeelb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3Yr4lZAgKCJ0PE7HBBI8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680195171; a=rsa-sha256; cv=none; b=rVIixugy9epO0EI5g4tY0wT8+p1s39A412WcuugrLpR5OuW3dJa2r0sQsTi9RCGty4/r07 4wQcle68wtsVVh2GVQaNPApCLPhy1Xa68TVxiwxr1MrVHJdCoaNzh2M003+XCLm0XYQu+Q No3xO1xqbPL+Rj078eFGgf1my1LZtu0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Qhwvho/j"; spf=pass (imf25.hostedemail.com: domain of 3Yr4lZAgKCJ0PE7HBBI8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--shakeelb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3Yr4lZAgKCJ0PE7HBBI8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680195171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mQYDmK2JgUqCpCRVA2d0KYhO6AxXou2BaS+5pOIMpjU=; b=E5R8CZmRaF7wKAqX8YUM5nMB61W+GhaC1HyKisRpsNVMf6mw77MV+ZX1kj/zKOqoy7FJeB yVTVc+oXBVR4CAzjr68RAPmukddL20Te0jCwcV93zxY9yoedBa6Qu8k4QQNEuc8N1yZHgs 8aNfJl6+F8y4IYBtvHzEH0Incu5q0as= Received: by mail-yb1-f201.google.com with SMTP id i11-20020a256d0b000000b0086349255277so19385223ybc.8 for ; Thu, 30 Mar 2023 09:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680195170; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mQYDmK2JgUqCpCRVA2d0KYhO6AxXou2BaS+5pOIMpjU=; b=Qhwvho/jSCzD962UhSp8uw5ox5R2LCORWuT38KhF1g8kOlUAdKNLzt4oWIseQg7qy5 w7ssDt5UoFmaEOfi2vxsVKdWffZwOyk9SvIH1DtxV7SaetvZLdGPBi9lKWgf7qUPSVtH ASeXYWr/h3EdvlTVN8GZhAr+KU6of6ZeHB90/1jZ1BKAUXAHr1F1ZCDoZ935l51aeNBu N0E1aGMWwpTJOL0st3TggxhzN+bz+EYaXjh7GBoidWRNNGBfmlCvx4E8vijMA/M8+sdk 7fB1TBG+FcXSIh1nNwyzmJq53L1X/KhAKwwh8/ctLfsGGCD1QCGM2Iki1y+qZLDOPx3p E0Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680195170; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mQYDmK2JgUqCpCRVA2d0KYhO6AxXou2BaS+5pOIMpjU=; b=MK0UQsEu+ydOBtlAXQke7N5UIByvb8RIrGoLqC7ienOMynY3J3AjoltR1sqhJGLKAv ZyT0BFuUYtDnq6o5FqTNnTgqJJ2KAA7IaEMG2HnLsVQrIwFfAz+ygDDiPbzs5E6b0OnD Sr1zfnccSAuBZYUxb5NhntCl023v+ejvu8J3H8/sNZ/7XwgZl0CXcusx0EPjRncR17jg wuxe5BhMow0vnr63W0A+B67WBW0HIIGrAc+fkn09rwUZtYYar7XgmKwafCJ6oPVm1qRt QHa15426fJHQBZqlCFVK7G1GkS4aXWDJPJsqvRCsJgN54RE8gCeWGWqRWwGAx6CJXIxl gJWw== X-Gm-Message-State: AAQBX9cGOZCnEPsUV26zI89C2tnF0Ok4DNcLUBB2hOorThGD7Fz/hPJv ksCkipHgT5+h1pkJktdkcQV/U09ExOVHqQ== X-Google-Smtp-Source: AKy350ZKQUPsiA6P7BhOGzirXB+KdSmGZo7ozykgr9T5Dtqy7WkMW7GodFAWWOkH7jqts/4Tipe33E5WWOFTow== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a05:6902:1004:b0:b75:968e:f282 with SMTP id w4-20020a056902100400b00b75968ef282mr15755101ybt.11.1680195170260; Thu, 30 Mar 2023 09:52:50 -0700 (PDT) Date: Thu, 30 Mar 2023 16:52:48 +0000 In-Reply-To: <20230330133822.66271-1-mathieu.desnoyers@efficios.com> Mime-Version: 1.0 References: <20230330133822.66271-1-mathieu.desnoyers@efficios.com> Message-ID: <20230330165248.rv7bssd6ys6m33od@google.com> Subject: Re: [PATCH 1/1] mm: Fix memory leak on mm_init error handling From: Shakeel Butt To: Mathieu Desnoyers Cc: Andrew Morton , linux-kernel@vger.kernel.org, Marek Szyprowski , linux-mm@kvack.org, stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Queue-Id: 3475AA0012 X-Rspamd-Server: rspam01 X-Stat-Signature: e6ixiqashkyncrc4tysfnjyzqbipxbnx X-HE-Tag: 1680195171-570889 X-HE-Meta: U2FsdGVkX18DdilfKa/dYsSuaeW2xBz7cdERUEMhvMiUhCXVAGLqVXimKWsAYBwWYo4/QbBdIu5BQHLJjM1EkqN9jFEMUFc8Az5vnq6g3xgEj/ccbNAfeI8hBYnkdzF6lAnz21KJEkIrqkLuzOnq8TExN64dEYqIPm3PPS9JU5f4yqFAY7PpTTJfIbsk0TxWkVMdym3dPH4RzY4M9BxvdewZtXSVeNjxI23sKXWRca0BLx95ENSvWMBn6I6SxAD/itEEej8jnExpT/DackAZt3+5gRfLjHUl02LkNH/kYs+F15CW5l9hRc/4wyP+E6Aetyz8nLvtHrYFdWfIRGppHZMp2yBGkxnwuZ4lZqMFION/Aadq9Y7yZgjIeQBkufbwNpS5a8D9GT6LZPnswyiQkMUK7RXeRNfUIT6WAkSdu9Upft8fVulEQUnJn8t5sQIonNkn7p2FjcaFFhaeBytCFBFStU3qnD1IJqaI/jQmvVmlFFn/UNtCZg8YNV1ZUo09VPqvJ+xzHjdvkfnGlKvw4m31TAFIJgpsjSVvu8tHoBktqK8PfW4Ss5yhq/c5iictnsIb0Zq4Q8jj/DLPsTWBNChpk/Ix4AMC2rQHPSdydaEDvUXOMsbrc4h+xA3bhVlW2jKNcwwFn6AuD8tP4pdzczZMWWAqHfU280zgnL0SJV8VnUZKitN3C4ddeofF9lNfkrvCZKP1I1IrM1xYfBzEO+Tw6q1Dm+8KRyW7GBgZuRflFDXJ/BGsqu+nZL0rhPL9OkNJBDkR3463Ut3FTysBgLTDhQfCiQBnVeDYA6tTdPZbSeUGjkmStSr1q7e7KHbavYySSFltTVw4SSzSpLXl51ZY1HW2UeCvSSpmZRUNkwMCKbPMNVp9D3ZwyeuuL2ylPw66l+SWVHbEOtL8NsPGO++sZwXstZ/TxLoZRhqNlkFZRGSp0KS5K/HJBpZjm+YK7QahhUGycCLQpDSVOZy Nvr/+5QN 9OYYF/OPv4BX8N/sf9U7UO2whNXrVdTQFw7p5NRugo8Sh8Lcd7F3Me4wxZeDC/2IirWGzMTXW93iuP6d5TVV4eqjK4xfBS91lqeRikFhSD1GpBaElyuYT4l237l/0En7KKFQ9yD3i4+BhQB0QA3U9goWQsfWjqukToB4y3AXAggzXeTrUFFBKSGFyhMKGmSdCgR+mG+K+sS37Kuqg13UxxeTL28ZqAdaUZZuVeAHwh750mQbNSFCAI7+cst+EH6rD7G3gYYugKlP823jqvI6Qchg0SXpiBTIJXtom1oI7czXNoqrgKI/bg/0W5rNeq/UhNaoHCFtU2wSeT0561OcdYmwDglvDt85bCTvQgUZ3h+fMmJBB5dU3/pSXpNs3vqxzmCGbcE+eM+ITHfLBEWJRYKt8DSnJg9WJZoVK5AbbMX6pMlUTsJl+4QnQr9NjuSTdyR1GreQjvNROfFAqG/w2YrDhtO7BUNLkzZK7337OxGCEQYcDJR7WQ9GHMZxjp+tqwRy5Qn8kbYmHHZDNI7npKLczoLxG76T7RtW62QbMX4Oo9OnI7WCQg/ZRy5opj/RtnbT+eMcEpfi9NV8tXBa+3EIyGESfWNPkWdTD2Cdo8Gw+bu0yRoBETVViKD0fGZ8SNYscud+CZiFmA05WQUU/LKO3el9wf4cPtC0rr8ObxxDlZPbQXZr8J0A+ncm3QiScvtHqJogwRmbs1MH76GotBVKRuiuJzXYCiaqOnXRUI6qMyJ96nk75UbbAA7jCyO7En+LOVuV82Yfc2tx+ML1cx0hgKUSHWWM0UA4DvTlm3o2V4WV+aPNtUCENR+oJSU4lZwX8n4X2pc+xMoPcuDKTHdDw0Xir/Iuy0UrAIgWOmy024f7G2NdK6eLlv8ocWTQoL93WLSaf4+LRNOypmhIqm+bgWqe7r/sVIPQp4fxvStK+PSIMtYYQwuDqAR3iKYPE9SJ+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 09:38:22AM -0400, Mathieu Desnoyers wrote: > commit f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter") > introduces a memory leak by missing a call to destroy_context() when a > percpu_counter fails to allocate. > > Before introducing the per-cpu counter allocations, init_new_context() > was the last call that could fail in mm_init(), and thus there was no > need to ever invoke destroy_context() in the error paths. Adding the > following percpu counter allocations adds error paths after > init_new_context(), which means its associated destroy_context() needs > to be called when percpu counters fail to allocate. > Fixes: f1a7941243c1 ("mm: convert mm's rss stats into percpu_counter") > Signed-off-by: Mathieu Desnoyers > Cc: Shakeel Butt > Cc: Andrew Morton > Cc: Marek Szyprowski > Cc: linux-mm@kvack.org > Cc: stable@vger.kernel.org # 6.2 Acked-by: Shakeel Butt