From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD401C6FD1D for ; Thu, 30 Mar 2023 19:33:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B31C6B0072; Thu, 30 Mar 2023 15:33:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4956C6B0074; Thu, 30 Mar 2023 15:33:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 379156B0078; Thu, 30 Mar 2023 15:33:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2C0166B0072 for ; Thu, 30 Mar 2023 15:33:12 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D65DF120AF1 for ; Thu, 30 Mar 2023 19:33:11 +0000 (UTC) X-FDA: 80626562982.16.FD52207 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 10922C0023 for ; Thu, 30 Mar 2023 19:33:09 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pBkUOtyM; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680204790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3PMirBCCkbZnQDd80lf+oG+q4sPNxGbUC5XL7WUTmrs=; b=rSeKD403dSojHt4jhsVyg8gDIgwu6cEJIK1Sidjoutv7zSmttgY+SkQNoZtwMsZmMTkHq0 jsPP2QJKWiVb3k2bKEBOlqE6O+GfaZcfF+2S6trKa9fzZ7BE2CtTBFaNvMjjcmKEx4TqKU IdhHRIDTyJgmEkTDu9ikezR37457r2g= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pBkUOtyM; dmarc=none; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680204790; a=rsa-sha256; cv=none; b=b2/RQ4ynLpBv/0gmOZV6l1ZAbGdCBAklNZ4p5iALxN11beMjgMZu+Y3x1QtR7LQZN5y0IW 8Z2l6FQxgeRLMLNr0Y5mysS9bY7hR2CPhvnHoh/+VwQolxcAB8ZkJL7fNwkr/1Mh8pY0tN HIyEAAsgTcby5u6I/cm/iAhLRYGa+5E= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E23D562183; Thu, 30 Mar 2023 19:33:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CDDBC433D2; Thu, 30 Mar 2023 19:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1680204788; bh=CuUhrO5WS2FE6JMdsT/oGvVlF7xq3fqJIzf4Sdwfy84=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pBkUOtyM93Af4bUH4NAbQgR4xHTh4Nt2/qxQYmzDVZwrTM/83jYmtpbu9R13jFe6O dkiKsy1BXN1nMt190UeEBMERulLGKhUcoiGKFS6jA3egOCysoCbQiA6BUnx3NlDfDK jIWvPGYMijP+7n6Ra6/dgn8J35Xj12zX7zWurcOU= Date: Thu, 30 Mar 2023 12:33:07 -0700 From: Andrew Morton To: Yafang Shao Cc: urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: vmalloc: Avoid warn_alloc noise caused by fatal signal Message-Id: <20230330123307.c3cf460997b4c4e1dfc9bd66@linux-foundation.org> In-Reply-To: <20230330162625.13604-1-laoar.shao@gmail.com> References: <20230330162625.13604-1-laoar.shao@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 10922C0023 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: bi9d6rcybdjrpgrocg3rizwtfm1i6uaw X-HE-Tag: 1680204789-638844 X-HE-Meta: U2FsdGVkX19DaWFItjsc4EjX3K4DpJGYmnKvbgFjFIVAplOId0eBQQ5Nld9J0+ZHLwx3rLrbyk5IJiou0wW/NZ5GWVXg3dCxgqraVoVp4BcCRuimA1dClx3bhCsoZ7BjtiirJKYD5Dyy2f2tntEUPZfnHv+6DbxG9WUy4ZiNdsDiKE/MeUb4Jz+Z3KS7rxrRZr63Ptw5U05GCVTOA8GtZxd0gNea5elJBe14aAFLYGte374g/GA8V8kV1sgF7Key6NUrHNHja3ZtdOw4t95nijMPjzD26fCtx4lstRLsHsBrFsft4gIIiAKSdd6bkHFLNFe5I8XHQ+2PlNzEp3Nt6ZvsIhAXt0mqsV8mJKYvzgQhXqN2/6rQipDyPFYK/j9SG0ekvJVSkhYXMpe4dL3GDCj9nz7OplKDsx1+qLY4FKkkQ7wHsnGZHKc2d7OhzzlK4IOS+HYmcaov4LpPP0RdgEbqvLuPclSz6OuVCefzwUwYRJQEI7vmeoavIhDnnvGkV1kxBiaVZnofk46uDXlWowTCeYJDi5uU/f7Tb78ZqsoUrPNmfm6hEZOLRf1zQQlpgfCQWL82YENUT/6eo53LVbQnukcOLta5DW18em7B4SCqnvSnPUTNscYJxAgxTM3RvnDMoOJiXExuUkzHXrN4pLJg4bz412pMuLTIOoXi9DPSnbzLU+/V7DAaKBN8LLT7R2MRmY6DccNbomos0+zILItNsfwvm06xEZMDf1foYqT8g3ikDoivXTDMnyOR4Nul5nj5GmDNP8gQFo7SvBZGflB17NYs4euDiascxM4Kc95uW3B6jBbAveZpYIahwGGhKNeMB+Um2DCUHe61va/3UcH5y8SfbdWv8N6+yBbNh0U0gNi9nOt+tpE2M64f6Bc0D4O8cNAycv4SGwJm8rKunRkHpUpEp5elvDV0hEkItS2zGIbhb7T5jKImLlbSLg9LRGI/5iFPaSJaqshnmHX oy3dVUKJ RN+Ts6UvbVli/K8GlPJnQUwrYt5rMBapFZHdoYs/6zAeCinkjmh9/nS5qxiJP5LSkP72ThxjkdDkwA45NheYp1372Ds54+icJCGzzzel5NH47+Ng9SqVepUzlnzWmWhqnGZibHPsJHvOnXSsSlZCsaAYqpy6tY7evTRhzgj0U+9RBPW3OBs3lF2JJULbzHzpcVCnzWfPqJzDlXTaqmocQ978dxqX9Ga50HPANkeNAhMHjOSzSrTgmxDMQNLbZoTVv2nhR+eQfnPkfJM8SIy2ZefAD3HMfykuC9gM7IinrrSYZTpDstwTXZ6hEz1SeUJydJRoaBQ3IlZGlwJmgU0J2yxDF4I3h2RSa7dN2gMW1ktDKkFzRMD20A/qs4cR/Ny/o9Dt7v8dHHOkj7aRgVSSYltFqJax8w6ZzuHv1YqJXvf3PWpfcBmiOk20Je2Wv2EankicXe5EigJGAFfHuStwgTsIUy3q7Q0uGqA3KUNnwfcG18OU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 30 Mar 2023 16:26:25 +0000 Yafang Shao wrote: > There're some suspicious warn_alloc on my test serer, for example, > > [13366.518837] warn_alloc: 81 callbacks suppressed > [13366.518841] test_verifier: vmalloc error: size 4096, page order 0, failed to allocate pages, mode:0x500dc2(GFP_HIGHUSER|__GFP_ZERO|__GFP_ACCOUNT), nodemask=(null),cpuset=/,mems_allowed=0-1 > [13366.522240] CPU: 30 PID: 722463 Comm: test_verifier Kdump: loaded Tainted: G W O 6.2.0+ #638 > [13366.524216] Call Trace: > > ... > > This failure really confuse me as there're still lots of available > pages. Finally I figured out it was caused by a fatal signal. When a > process is allocating memory via vm_area_alloc_pages(), it will break > directly even if it hasn't allocated the requested pages when it > receives a fatal signal. In that case, we shouldn't show this warn_alloc, > as it is useless. We only need to show this warning when there're really > no enough pages. > > ... > > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3024,9 +3024,11 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > * allocation request, free them via vfree() if any. > */ > if (area->nr_pages != nr_small_pages) { > - warn_alloc(gfp_mask, NULL, > - "vmalloc error: size %lu, page order %u, failed to allocate pages", > - area->nr_pages * PAGE_SIZE, page_order); > + /* vm_area_alloc_pages() can also fail due to a fatal signal */ > + if (!fatal_signal_pending(current)) > + warn_alloc(gfp_mask, NULL, > + "vmalloc error: size %lu, page order %u, failed to allocate pages", > + area->nr_pages * PAGE_SIZE, page_order); > goto fail; > } Emitting erroneous splats into dmesg is pretty unpleasant, so I'll put a cc:stable on this one. I can't identify a suitable Fixes: target - the code around there has changed several times in fairly cosmetic ways so each of the various -stable kernels will probably need different versions of the patch.