From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC102C761A6 for ; Thu, 30 Mar 2023 11:03:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67D9F6B007E; Thu, 30 Mar 2023 07:03:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62D776B0085; Thu, 30 Mar 2023 07:03:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F6846B0087; Thu, 30 Mar 2023 07:03:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 40E706B007E for ; Thu, 30 Mar 2023 07:03:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 17EA9C0E9A for ; Thu, 30 Mar 2023 11:03:09 +0000 (UTC) X-FDA: 80625277698.07.68CE4DE Received: from mail3-166.sinamail.sina.com.cn (mail3-166.sinamail.sina.com.cn [202.108.3.166]) by imf22.hostedemail.com (Postfix) with ESMTP id 9DCA2C0026 for ; Thu, 30 Mar 2023 11:03:05 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.166 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680174187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aEOY8z+M1G77221y+RSOl4uOqEYDnkgwc2vqTgojvHo=; b=l5xIBa8qeEO+m+6YCPahxxtKreBGFOp+V9HQExKKJgyilPaUNuzSNiYAHNeqwqa54njHdi 76culp05HZ/jN4BNP9wYfEm8NDPbepMqOyGIL1jAgxTK6tZi+eCVdj/ABfpZ3kONilMosV rNX6wR7IKQikazVTtowZUICjvu4Vs+M= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.166 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680174187; a=rsa-sha256; cv=none; b=Fc15jUy+GsXCFtfODu5vJS1iTthhNJGF2yb5UV3EgoW8Bn6dqbdnynEbhV3Hu1+lNRUKIZ /WSPK/sxHYeK1KSYh34yhVz3Nih5otcl8t4JMEDt0HXPxOzXAAKLg2bIdqIDt3DP8ieZtJ D/6g6jrB1wKLeea+UJPtxCBMJLTaK2c= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.59.75]) by sina.com (172.16.97.23) with ESMTP id 64256C3B00030E52; Thu, 30 Mar 2023 19:02:21 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 39922954919544 From: Hillf Danton To: Peter Zijlstra Cc: mingo@kernel.org, vincent.guittot@linaro.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, corbet@lwn.net, qyousef@layalina.io, pavel@ucw.cz, qperret@google.com, tim.c.chen@linux.intel.com, joshdon@google.com, timj@gnu.org, kprateek.nayak@amd.com, yu.c.chen@intel.com, youssefesmat@chromium.org, linux-mm@kvack.org, joel@joelfernandes.org, efault@gmx.de Subject: Re: [PATCH 08/17] sched/fair: Implement an EEVDF like policy Date: Thu, 30 Mar 2023 19:02:51 +0800 Message-Id: <20230330110251.2947-1-hdanton@sina.com> In-Reply-To: <20230328110354.141543852@infradead.org> References: <20230328092622.062917921@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9DCA2C0026 X-Rspam-User: X-Stat-Signature: 81au9zyyg5ehffnantm8re8nip79e6rd X-HE-Tag: 1680174185-339542 X-HE-Meta: U2FsdGVkX1/OUnYGzXTjYLWJ5FVlYN9LSvzFm4vhT5wALcr2ixrj9idqEG58hoVe4dznus3PCMZP3QXrvIfmFkJoa1X68+ZOsTIGjawXGonDSX/cBK0D5xFMq4rDh8QmOYWVvIw3NPeJ27FW4u4rdmhGhmqiMHfdelTvHrwP8H0swcwFe9jAG2TZzcWhKG5f7eml6+t1zgUcLW/3jg2hO1hyTFJslgFALPqn6R3/cqmWUPFDQOlLfcOP3GnsD1PN/kH0pxPjJkdCfEoPUzwSrDDkr9XVjR3YLWgV06SMnkb2hEJzOtpl2z+yB7qTAagFpN70O76qOMWuNu/D2P3z3FLcFMH89LwnYsrXcuXyp6VMCzB7XgWzIoWvSywuFxr4xyXSKwu9VwcmxdfgRgYf8LWJL0Ook3boWM6Uo2gNPlv6ctNy2Wbuk1wzrneNwsx9/JSO5mhPoXSAMGW2twfacVVIb9Lfj+gjZhU4xeKuU4M0bEDlepr/a4Bmk4FBleVqXXJctTmsRcPCyK21YsZSK4Gs2C8+nkmO6KE9rDcfWqn1ARAuyu07fheF4dbb5sLSFQhSAoA0vWqdGxxiX5RXX0qyNQFExMAni4Vcx+4cVYKwx8TDDf2ucCoLncxO3GVvSlSzUxyvjFhypwE2dEKWzpcItjtvaxf3LUB7CiGdWS8MQmC11TIMlSsvD/WrINJmF05mH4Zx38EQ5WOASGf5fKJFwKCcRwCwswpH5JJNU3ji0lnfhGvhJ3rsEbHntZirt/YaaARYyNxHRb+BFssmmkPcr3CC6U+93kqzwVFUM+17lrHfgse2vXIw+BzxuSkEAkM9zYypTYZAHDA6a3CbxS34X1D3kBbD49jUGjIacV6yYsjCVAOChATbtaLhUyjZTH43Q5kq/Y1C4xnHG1g4V7jjTKf9KxIRN3AZX+eyvQM5/4A1FvVpiRNbK6wtxKa7Xw8cJxbhY7Fh2EN0+uo Dl1rWumc a7EhRh3i+0aGTPydywnOMkqnKwa4lHSnaAatoHPh2hLHl/eHTzYtK3028ywTFH0Vy+tBuEaTDvVvfcK7qkH+StK9mcNYjGCYzeApJCDeTBAJ2dgZciLf8MDHFDqNdmMZVVPaITdPES96Szim+QlXk7YLbLkESeU6fmqdp5UR40bb40LK3rTfoaZ9hjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28 Mar 2023 11:26:30 +0200 Peter Zijlstra > > check_preempt_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr) > { > - unsigned long ideal_runtime, delta_exec; > + unsigned long delta_exec; > struct sched_entity *se; > s64 delta; > > - /* > - * When many tasks blow up the sched_period; it is possible that > - * sched_slice() reports unusually large results (when many tasks are > - * very light for example). Therefore impose a maximum. > - */ > - ideal_runtime = min_t(u64, sched_slice(cfs_rq, curr), sysctl_sched_latency); > + if (sched_feat(EEVDF)) { > + if (pick_eevdf(cfs_rq) != curr) > + goto preempt; > + > + return; > + } Given deadline, the tick preempt can be replaced with a timer expiring at the EDL.